<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164124] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164124">164124</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-14 12:59:27 -0800 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve the performance on mobile of FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=128778
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-14
Reviewed by Antti Koivisto.
Source/WebCore:
Little cleanup.
* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::processFilesizeString):
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString):
(WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
Source/WTF:
* wtf/text/WTFString.h:
(WTF::String::endsWith): add a missing overload.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlFTPDirectoryDocumentcpp">trunk/Source/WebCore/html/FTPDirectoryDocument.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (164123 => 164124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-02-14 20:58:28 UTC (rev 164123)
+++ trunk/Source/WTF/ChangeLog 2014-02-14 20:59:27 UTC (rev 164124)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-02-14 Benjamin Poulain <bpoulain@apple.com>
+
+ Improve the performance on mobile of FTPDirectoryDocument
+ https://bugs.webkit.org/show_bug.cgi?id=128778
+
+ Reviewed by Antti Koivisto.
+
+ * wtf/text/WTFString.h:
+ (WTF::String::endsWith): add a missing overload.
+
</ins><span class="cx"> 2014-02-14 Wojciech Bielawski <w.bielawski@samsung.com>
</span><span class="cx">
</span><span class="cx"> (try)append and insert operations don't need new operator for PODs
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (164123 => 164124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2014-02-14 20:58:28 UTC (rev 164123)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2014-02-14 20:59:27 UTC (rev 164124)
</span><span class="lines">@@ -284,6 +284,7 @@
</span><span class="cx"> { return m_impl ? m_impl->endsWith(s.impl(), caseSensitive) : s.isEmpty(); }
</span><span class="cx"> bool endsWith(UChar character) const
</span><span class="cx"> { return m_impl ? m_impl->endsWith(character) : false; }
</span><ins>+ bool endsWith(char character) const { return endsWith(static_cast<UChar>(character)); }
</ins><span class="cx"> template<unsigned matchLength>
</span><span class="cx"> bool endsWith(const char (&prefix)[matchLength], bool caseSensitive = true) const
</span><span class="cx"> { return m_impl ? m_impl->endsWith<matchLength>(prefix, caseSensitive) : !matchLength; }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164123 => 164124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-14 20:58:28 UTC (rev 164123)
+++ trunk/Source/WebCore/ChangeLog 2014-02-14 20:59:27 UTC (rev 164124)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-02-14 Benjamin Poulain <bpoulain@apple.com>
+
+ Improve the performance on mobile of FTPDirectoryDocument
+ https://bugs.webkit.org/show_bug.cgi?id=128778
+
+ Reviewed by Antti Koivisto.
+
+ Little cleanup.
+
+ * html/FTPDirectoryDocument.cpp:
+ (WebCore::FTPDirectoryDocumentParser::appendEntry):
+ (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
+ (WebCore::processFilesizeString):
+ (WebCore::wasLastDayOfMonth):
+ (WebCore::processFileDateString):
+ (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):
+ (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
+ (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
+
</ins><span class="cx"> 2014-02-14 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> Do not attempt to synchronize attributes when no Simple Selector could match an animatable attribute
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFTPDirectoryDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.cpp (164123 => 164124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2014-02-14 20:58:28 UTC (rev 164123)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2014-02-14 20:59:27 UTC (rev 164124)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2007, 2008, 2014 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="cx"> * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -107,41 +107,41 @@
</span><span class="cx"> void FTPDirectoryDocumentParser::appendEntry(const String& filename, const String& size, const String& date, bool isDirectory)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<Element> rowElement = m_tableElement->insertRow(-1, IGNORE_EXCEPTION);
</span><del>- rowElement->setAttribute("class", "ftpDirectoryEntryRow", IGNORE_EXCEPTION);
</del><ins>+ rowElement->setAttribute(HTMLNames::classAttr, "ftpDirectoryEntryRow");
</ins><span class="cx">
</span><span class="cx"> RefPtr<Element> element = document()->createElement(tdTag, false);
</span><span class="cx"> element->appendChild(Text::create(*document(), String(&noBreakSpace, 1)), IGNORE_EXCEPTION);
</span><span class="cx"> if (isDirectory)
</span><del>- element->setAttribute("class", "ftpDirectoryIcon ftpDirectoryTypeDirectory", IGNORE_EXCEPTION);
</del><ins>+ element->setAttribute(HTMLNames::classAttr, "ftpDirectoryIcon ftpDirectoryTypeDirectory");
</ins><span class="cx"> else
</span><del>- element->setAttribute("class", "ftpDirectoryIcon ftpDirectoryTypeFile", IGNORE_EXCEPTION);
</del><ins>+ element->setAttribute(HTMLNames::classAttr, "ftpDirectoryIcon ftpDirectoryTypeFile");
</ins><span class="cx"> rowElement->appendChild(element, IGNORE_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> element = createTDForFilename(filename);
</span><del>- element->setAttribute("class", "ftpDirectoryFileName", IGNORE_EXCEPTION);
</del><ins>+ element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileName");
</ins><span class="cx"> rowElement->appendChild(element, IGNORE_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> element = document()->createElement(tdTag, false);
</span><span class="cx"> element->appendChild(Text::create(*document(), date), IGNORE_EXCEPTION);
</span><del>- element->setAttribute("class", "ftpDirectoryFileDate", IGNORE_EXCEPTION);
</del><ins>+ element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileDate");
</ins><span class="cx"> rowElement->appendChild(element, IGNORE_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> element = document()->createElement(tdTag, false);
</span><span class="cx"> element->appendChild(Text::create(*document(), size), IGNORE_EXCEPTION);
</span><del>- element->setAttribute("class", "ftpDirectoryFileSize", IGNORE_EXCEPTION);
</del><ins>+ element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileSize");
</ins><span class="cx"> rowElement->appendChild(element, IGNORE_EXCEPTION);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Element> FTPDirectoryDocumentParser::createTDForFilename(const String& filename)
</span><span class="cx"> {
</span><span class="cx"> String fullURL = document()->baseURL().string();
</span><del>- if (fullURL[fullURL.length() - 1] == '/')
</del><ins>+ if (fullURL.endsWith('/'))
</ins><span class="cx"> fullURL.append(filename);
</span><span class="cx"> else
</span><del>- fullURL.append("/" + filename);
</del><ins>+ fullURL.append(makeString('/', filename));
</ins><span class="cx">
</span><span class="cx"> RefPtr<Element> anchorElement = document()->createElement(aTag, false);
</span><del>- anchorElement->setAttribute("href", fullURL, IGNORE_EXCEPTION);
</del><ins>+ anchorElement->setAttribute(HTMLNames::hrefAttr, fullURL);
</ins><span class="cx"> anchorElement->appendChild(Text::create(*document(), filename), IGNORE_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> RefPtr<Element> tdElement = document()->createElement(tdTag, false);
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> static String processFilesizeString(const String& size, bool isDirectory)
</span><span class="cx"> {
</span><span class="cx"> if (isDirectory)
</span><del>- return "--";
</del><ins>+ return ASCIILiteral("--");
</ins><span class="cx">
</span><span class="cx"> bool valid;
</span><span class="cx"> int64_t bytes = size.toUInt64(&valid);
</span><span class="lines">@@ -171,7 +171,7 @@
</span><span class="cx">
</span><span class="cx"> static bool wasLastDayOfMonth(int year, int month, int day)
</span><span class="cx"> {
</span><del>- static int lastDays[] = { 31, 0, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
</del><ins>+ static const int lastDays[] = { 31, 0, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
</ins><span class="cx"> if (month < 0 || month > 11)
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -241,9 +241,9 @@
</span><span class="cx"> String dateString;
</span><span class="cx">
</span><span class="cx"> if (fileTime.tm_year > -1)
</span><del>- dateString = String(months[month]) + " " + String::number(fileTime.tm_mday) + ", " + String::number(fileTime.tm_year);
</del><ins>+ dateString = makeString(months[month], ' ', String::number(fileTime.tm_mday), ", ", String::number(fileTime.tm_year));
</ins><span class="cx"> else
</span><del>- dateString = String(months[month]) + " " + String::number(fileTime.tm_mday) + ", " + String::number(now.year());
</del><ins>+ dateString = makeString(months[month], ' ', String::number(fileTime.tm_mday), ", ", String::number(now.year()));
</ins><span class="cx">
</span><span class="cx"> return dateString + timeOfDay;
</span><span class="cx"> }
</span><span class="lines">@@ -261,7 +261,7 @@
</span><span class="cx">
</span><span class="cx"> String filename(result.filename, result.filenameLength);
</span><span class="cx"> if (result.type == FTPDirectoryEntry) {
</span><del>- filename.append("/");
</del><ins>+ filename.append('/');
</ins><span class="cx">
</span><span class="cx"> // We have no interest in linking to "current directory"
</span><span class="cx"> if (filename == "./")
</span><span class="lines">@@ -312,7 +312,7 @@
</span><span class="cx"> // Otherwise create one manually
</span><span class="cx"> tableElement = document()->createElement(tableTag, false);
</span><span class="cx"> m_tableElement = toHTMLTableElement(tableElement.get());
</span><del>- m_tableElement->setAttribute("id", "ftpDirectoryTable", IGNORE_EXCEPTION);
</del><ins>+ m_tableElement->setAttribute(HTMLNames::idAttr, "ftpDirectoryTable");
</ins><span class="cx">
</span><span class="cx"> // If we didn't find the table element, lets try to append our own to the body
</span><span class="cx"> // If that fails for some reason, cram it on the end of the document as a last
</span><span class="lines">@@ -337,7 +337,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<Element> tableElement = document()->createElement(tableTag, false);
</span><span class="cx"> m_tableElement = toHTMLTableElement(tableElement.get());
</span><del>- m_tableElement->setAttribute("id", "ftpDirectoryTable", IGNORE_EXCEPTION);
</del><ins>+ m_tableElement->setAttribute(HTMLNames::idAttr, "ftpDirectoryTable");
</ins><span class="cx">
</span><span class="cx"> bodyElement->appendChild(m_tableElement, IGNORE_EXCEPTION);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>