<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164084] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164084">164084</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2014-02-13 17:59:29 -0800 (Thu, 13 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove position:sticky runtime flag
https://bugs.webkit.org/show_bug.cgi?id=128774
Reviewed by Simon Fraser.
Rollout of <a href="http://trac.webkit.org/projects/webkit/changeset/128663">r128663</a>
No new tests are necessary because there is no behavior change.
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSParserMode.h:
* dom/Document.cpp:
* dom/Document.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserModeh">trunk/Source/WebCore/css/CSSParserMode.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCorepageSettingscpp">trunk/Source/WebCore/page/Settings.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingsh">trunk/Source/WebCore/page/Settings.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/ChangeLog        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-02-13 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Remove position:sticky runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=128774
+
+ Reviewed by Simon Fraser.
+
+ Rollout of r128663
+
+ No new tests are necessary because there is no behavior change.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParserContext::CSSParserContext):
+ (WebCore::operator==):
+ (WebCore::isValidKeywordPropertyAndValue):
+ * css/CSSParserMode.h:
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+
</ins><span class="cx"> 2014-02-04 Gustavo Noronha Silva <gns@gnome.org>
</span><span class="cx">
</span><span class="cx"> [GTK][CMake] Generate GObject DOM bindings .symbols files
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParser.cpp        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -245,7 +245,6 @@
</span><span class="cx"> : baseURL(baseURL)
</span><span class="cx"> , mode(mode)
</span><span class="cx"> , isHTMLDocument(false)
</span><del>- , isCSSStickyPositionEnabled(false)
</del><span class="cx"> , isCSSRegionsEnabled(false)
</span><span class="cx"> , isCSSCompositingEnabled(false)
</span><span class="cx"> , isCSSGridLayoutEnabled(false)
</span><span class="lines">@@ -266,7 +265,6 @@
</span><span class="cx"> , charset(charset)
</span><span class="cx"> , mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
</span><span class="cx"> , isHTMLDocument(document.isHTMLDocument())
</span><del>- , isCSSStickyPositionEnabled(document.cssStickyPositionEnabled())
</del><span class="cx"> , isCSSRegionsEnabled(document.cssRegionsEnabled())
</span><span class="cx"> , isCSSCompositingEnabled(document.cssCompositingEnabled())
</span><span class="cx"> , isCSSGridLayoutEnabled(document.cssGridLayoutEnabled())
</span><span class="lines">@@ -288,7 +286,6 @@
</span><span class="cx"> && a.charset == b.charset
</span><span class="cx"> && a.mode == b.mode
</span><span class="cx"> && a.isHTMLDocument == b.isHTMLDocument
</span><del>- && a.isCSSStickyPositionEnabled == b.isCSSStickyPositionEnabled
</del><span class="cx"> && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
</span><span class="cx"> && a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
</span><span class="cx"> && a.isCSSGridLayoutEnabled == b.isCSSGridLayoutEnabled
</span><span class="lines">@@ -751,7 +748,7 @@
</span><span class="cx"> case CSSPropertyPosition: // static | relative | absolute | fixed | sticky | inherit
</span><span class="cx"> if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed
</span><span class="cx"> #if ENABLE(CSS_STICKY_POSITION)
</span><del>- || (parserContext.isCSSStickyPositionEnabled && valueID == CSSValueWebkitSticky)
</del><ins>+ || valueID == CSSValueWebkitSticky
</ins><span class="cx"> #endif
</span><span class="cx"> )
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserModeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParserMode.h (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParserMode.h        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParserMode.h        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -64,7 +64,6 @@
</span><span class="cx"> String charset;
</span><span class="cx"> CSSParserMode mode;
</span><span class="cx"> bool isHTMLDocument;
</span><del>- bool isCSSStickyPositionEnabled;
</del><span class="cx"> bool isCSSRegionsEnabled;
</span><span class="cx"> bool isCSSCompositingEnabled;
</span><span class="cx"> bool isCSSGridLayoutEnabled;
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.cpp        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -1082,11 +1082,6 @@
</span><span class="cx"> return settings() && settings()->regionBasedColumnsEnabled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Document::cssStickyPositionEnabled() const
-{
- return settings() && settings()->cssStickyPositionEnabled();
-}
-
</del><span class="cx"> bool Document::cssRegionsEnabled() const
</span><span class="cx"> {
</span><span class="cx"> return RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled();
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.h        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -394,7 +394,6 @@
</span><span class="cx"> PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
</span><span class="cx"> PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
</span><span class="cx">
</span><del>- bool cssStickyPositionEnabled() const;
</del><span class="cx"> bool cssRegionsEnabled() const;
</span><span class="cx"> bool cssCompositingEnabled() const;
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.cpp (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.cpp        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/page/Settings.cpp        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -189,9 +189,6 @@
</span><span class="cx"> , m_alwaysUseBaselineOfPrimaryFont(false)
</span><span class="cx"> , m_alwaysUseAcceleratedOverflowScroll(false)
</span><span class="cx"> #endif
</span><del>-#if ENABLE(CSS_STICKY_POSITION)
- , m_cssStickyPositionEnabled(true)
-#endif
</del><span class="cx"> , m_showTiledScrollingIndicator(false)
</span><span class="cx"> , m_tiledBackingStoreEnabled(false)
</span><span class="cx"> , m_backgroundShouldExtendBeyondPage(false)
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.h (164083 => 164084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.h        2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/page/Settings.h        2014-02-14 01:59:29 UTC (rev 164084)
</span><span class="lines">@@ -212,14 +212,6 @@
</span><span class="cx"> void setFontRenderingMode(FontRenderingMode mode);
</span><span class="cx"> FontRenderingMode fontRenderingMode() const;
</span><span class="cx">
</span><del>-#if ENABLE(CSS_STICKY_POSITION)
- void setCSSStickyPositionEnabled(bool enabled) { m_cssStickyPositionEnabled = enabled; }
- bool cssStickyPositionEnabled() const { return m_cssStickyPositionEnabled; }
-#else
- void setCSSStickyPositionEnabled(bool) { }
- bool cssStickyPositionEnabled() const { return false; }
-#endif
-
</del><span class="cx"> void setShowTiledScrollingIndicator(bool);
</span><span class="cx"> bool showTiledScrollingIndicator() const { return m_showTiledScrollingIndicator; }
</span><span class="cx">
</span><span class="lines">@@ -353,9 +345,6 @@
</span><span class="cx"> bool m_allowMultiElementImplicitFormSubmission : 1;
</span><span class="cx"> bool m_alwaysUseAcceleratedOverflowScroll : 1;
</span><span class="cx"> #endif
</span><del>-#if ENABLE(CSS_STICKY_POSITION)
- bool m_cssStickyPositionEnabled : 1;
-#endif
</del><span class="cx"> bool m_showTiledScrollingIndicator : 1;
</span><span class="cx"> bool m_tiledBackingStoreEnabled : 1;
</span><span class="cx"> bool m_backgroundShouldExtendBeyondPage : 1;
</span></span></pre>
</div>
</div>
</body>
</html>