<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[164062] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164062">164062</a></dd>

<dt>Author</dt> <dd>beidson@apple.com</dd>

<dt>Date</dt> <dd>2014-02-13 15:04:30 -0800 (Thu, 13 Feb 2014)</dd>

</dl>

<h3>Log Message</h3>

<pre>IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder

https://bugs.webkit.org/show_bug.cgi?id=128763

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests (Covered by three existing tests)

* platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObjects): If the array is empty we still have to begin() and end() it.

LayoutTests:

* platform/mac-wk2/TestExpectations: One test passes, one passes with expectation changes,

  and the third is now a text failure.

* storage/indexeddb/key-type-array-expected.txt:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>

<li><a href="#trunkLayoutTestsstorageindexeddbkeytypearrayexpectedtxt">trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreplatformKeyedCodingh">trunk/Source/WebCore/platform/KeyedCoding.h</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164061 => 164062)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2014-02-13 23:02:31 UTC (rev 164061)

+++ trunk/LayoutTests/ChangeLog        2014-02-13 23:04:30 UTC (rev 164062)

</span><span class="lines">@@ -1,3 +1,15 @@

</span><ins>+2014-02-13  Brady Eidson  &lt;beidson@apple.com&gt;

+

+        IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder

+        https://bugs.webkit.org/show_bug.cgi?id=128763

+

+        Reviewed by Anders Carlsson.

+

+        * platform/mac-wk2/TestExpectations: One test passes, one passes with expectation changes,

+          and the third is now a text failure.

+

+        * storage/indexeddb/key-type-array-expected.txt:

+

</ins><span class="cx"> 2014-02-13  Yuki Sekiguchi  &lt;yuki.sekiguchi@access-company.com&gt;

</span><span class="cx"> 

</span><span class="cx">         [css3-text] Support -webkit-text-decoration-skip: objects

</span></span></pre></div>

<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (164061 => 164062)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations        2014-02-13 23:02:31 UTC (rev 164061)

+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations        2014-02-13 23:04:30 UTC (rev 164062)

</span><span class="lines">@@ -467,6 +467,7 @@

</span><span class="cx"> storage/indexeddb/cursor-continue-validity.html [ Skip ]

</span><span class="cx"> storage/indexeddb/cursor-continueprimarykey.html [ Skip ]

</span><span class="cx"> storage/indexeddb/cursor-index-delete.html [ Skip ]

</span><ins>+storage/indexeddb/cursor-key-order.html [ Skip ]

</ins><span class="cx"> storage/indexeddb/cursor-leak.html [ Skip ] # Missing needed WKTR feature?

</span><span class="cx"> storage/indexeddb/cursor-overloads.html [ Skip ]

</span><span class="cx"> storage/indexeddb/cursor-primary-key-order.html [ Skip ]

</span><span class="lines">@@ -549,11 +550,6 @@

</span><span class="cx"> storage/indexeddb/prefetch-invalidation.html [ Skip ]

</span><span class="cx"> storage/indexeddb/queued-commands.html [ Skip ]

</span><span class="cx"> 

<del>-# Blink tests that crash the DatabaseProcess under KeyedDecoder::~KeyedDecoder.

-storage/indexeddb/cursor-key-order.html [ Skip ]

-storage/indexeddb/key-type-array.html [ Skip ]

-storage/indexeddb/lazy-index-types.html [ Skip ]

-

</del><span class="cx"> # Blink tests that pass once, but are known to cause trouble downstream.

</span><span class="cx"> storage/indexeddb/clone-exception.html [ Skip ]

</span><span class="cx"> storage/indexeddb/connection-leak.html [ Skip ]

</span></span></pre></div>

<a id="trunkLayoutTestsstorageindexeddbkeytypearrayexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt (164061 => 164062)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt        2014-02-13 23:02:31 UTC (rev 164061)

+++ trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt        2014-02-13 23:04:30 UTC (rev 164062)

</span><span class="lines">@@ -170,112 +170,112 @@