<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163959] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163959">163959</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2014-02-12 09:10:25 -0800 (Wed, 12 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove some unintended copies in ranged for loops
https://bugs.webkit.org/show_bug.cgi?id=128644
Reviewed by Anders Carlsson.
../JavaScriptCore:
* inspector/InjectedScriptHost.cpp:
(Inspector::InjectedScriptHost::clearAllWrappers): Avoid creating/destroying
a std::pair<> and pointer each loop iteration.
* parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser): Avoid copying object containing a string
each loop iteration.
../WebCore:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments): Avoid creating/destroying
RefPtrs in loop.
../WebKit2:
* Shared/WebCrossThreadCopier.cpp:
(WebCore::Vector<Vector<IDBKeyData>>>::copy): Each iteration copies a vector of
vectors,
* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::enumerateRectsBeingDrawn): Avoid copying a FloatRect
on each iteration.
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): Avoid copying
a LayerProperty object each iteration.
* UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests): Avoid
copying a pair<int64_t, pointer> each iteration.
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests): Ditto
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Ditto
* UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle): Avoid creating/destroying a
RefPtr each loop iteration.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents): Avoid copying a WebPlatformTouchPoint
object each cycle.
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree): Avoid copying a pair each iteration.
* UIProcess/mac/WindowServerConnection.mm:
(WebKit::WindowServerConnection::WindowServerConnection): Avoid copying the struct
of occlusionNotificationHandlers each iteration.
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::put): Avoid copying a vector-of-vectors each
iteration.
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::recursiveBuildTransaction): Avoid creating/destroying a
RefPtr each loop iteration.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInjectedScriptHostcpp">trunk/Source/JavaScriptCore/inspector/InjectedScriptHost.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParsercpp">trunk/Source/JavaScriptCore/parser/Parser.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebCrossThreadCopiercpp">trunk/Source/WebKit2/Shared/WebCrossThreadCopier.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedmacRemoteLayerBackingStoremm">trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm</a></li>
<li><a href="#trunkSourceWebKit2SharedmacRemoteLayerTreePropertyAppliermm">trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessGeolocationPermissionRequestManagerProxycpp">trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNotificationsNotificationPermissionRequestManagerProxycpp">trunk/Source/WebKit2/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessScrollingRemoteScrollingCoordinatorProxycpp">trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebContextcpp">trunk/Source/WebKit2/UIProcess/WebContext.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeHostmm">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacWindowServerConnectionmm">trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBServerConnectioncpp">trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-02-11 Brent Fulgham <bfulgham@apple.com>
+
+ Remove some unintended copies in ranged for loops
+ https://bugs.webkit.org/show_bug.cgi?id=128644
+
+ Reviewed by Anders Carlsson.
+
+ * inspector/InjectedScriptHost.cpp:
+ (Inspector::InjectedScriptHost::clearAllWrappers): Avoid creating/destroying
+ a std::pair<> and pointer each loop iteration.
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::Parser): Avoid copying object containing a string
+ each loop iteration.
+
</ins><span class="cx"> 2014-02-11 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Debug build fix after r163946.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInjectedScriptHostcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InjectedScriptHost.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InjectedScriptHost.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/JavaScriptCore/inspector/InjectedScriptHost.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx">
</span><span class="cx"> void InjectedScriptHost::clearAllWrappers()
</span><span class="cx"> {
</span><del>- for (auto wrapper : m_wrappers)
</del><ins>+ for (auto& wrapper : m_wrappers)
</ins><span class="cx"> clearWrapperFromValue(wrapper.value.get());
</span><span class="cx">
</span><span class="cx"> m_wrappers.clear();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/JavaScriptCore/parser/Parser.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx"> continue;
</span><span class="cx"> parameter->collectBoundIdentifiers(boundParameterNames);
</span><span class="cx"> }
</span><del>- for (auto boundParameterName : boundParameterNames)
</del><ins>+ for (auto& boundParameterName : boundParameterNames)
</ins><span class="cx"> scope->declareVariable(&boundParameterName);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebCore/ChangeLog 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-02-11 Brent Fulgham <bfulgham@apple.com>
+
+ Remove some unintended copies in ranged for loops
+ https://bugs.webkit.org/show_bug.cgi?id=128644
+
+ Reviewed by Anders Carlsson.
+
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::loadPendingSVGDocuments): Avoid creating/destroying
+ RefPtrs in loop.
+
</ins><span class="cx"> 2014-02-12 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
</span><span class="cx">
</span><span class="cx"> Update the HTML Media Capture implementation.
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -3324,7 +3324,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> CachedResourceLoader* cachedResourceLoader = state.document().cachedResourceLoader();
</span><del>- for (auto filterOperation : state.filtersWithPendingSVGDocuments())
</del><ins>+ for (auto& filterOperation : state.filtersWithPendingSVGDocuments())
</ins><span class="cx"> filterOperation->getOrCreateCachedSVGDocumentReference()->load(cachedResourceLoader);
</span><span class="cx">
</span><span class="cx"> state.filtersWithPendingSVGDocuments().clear();
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2014-02-11 Brent Fulgham <bfulgham@apple.com>
+
+ Remove some unintended copies in ranged for loops
+ https://bugs.webkit.org/show_bug.cgi?id=128644
+
+ Reviewed by Anders Carlsson.
+
+ * Shared/WebCrossThreadCopier.cpp:
+ (WebCore::Vector<Vector<IDBKeyData>>>::copy): Each iteration copies a vector of
+ vectors,
+ * Shared/mac/RemoteLayerBackingStore.mm:
+ (RemoteLayerBackingStore::enumerateRectsBeingDrawn): Avoid copying a FloatRect
+ on each iteration.
+ * Shared/mac/RemoteLayerTreePropertyApplier.mm:
+ (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): Avoid copying
+ a LayerProperty object each iteration.
+ * UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
+ (WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests): Avoid
+ copying a pair<int64_t, pointer> each iteration.
+ * UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
+ (WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests): Ditto
+ * UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
+ (WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Ditto
+ * UIProcess/WebContext.cpp:
+ (WebKit::WebContext::postMessageToInjectedBundle): Avoid creating/destroying a
+ RefPtr each loop iteration.
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::shouldStartTrackingTouchEvents): Avoid copying a WebPlatformTouchPoint
+ object each cycle.
+ * UIProcess/mac/RemoteLayerTreeHost.mm:
+ (WebKit::RemoteLayerTreeHost::updateLayerTree): Avoid copying a pair each iteration.
+ * UIProcess/mac/WindowServerConnection.mm:
+ (WebKit::WindowServerConnection::WindowServerConnection): Avoid copying the struct
+ of occlusionNotificationHandlers each iteration.
+ * WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
+ (WebKit::WebIDBServerConnection::put): Avoid copying a vector-of-vectors each
+ iteration.
+ * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+ (PlatformCALayerRemote::recursiveBuildTransaction): Avoid creating/destroying a
+ RefPtr each loop iteration.
+
</ins><span class="cx"> 2014-02-12 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
</span><span class="cx">
</span><span class="cx"> Update the HTML Media Capture implementation.
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebCrossThreadCopiercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebCrossThreadCopier.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebCrossThreadCopier.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/Shared/WebCrossThreadCopier.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -70,9 +70,9 @@
</span><span class="cx"> {
</span><span class="cx"> Vector<Vector<IDBKeyData>> result;
</span><span class="cx">
</span><del>- for (auto keys : vector) {
</del><ins>+ for (const auto& keys : vector) {
</ins><span class="cx"> result.append(Vector<IDBKeyData>());
</span><del>- for (auto key : keys)
</del><ins>+ for (const auto& key : keys)
</ins><span class="cx"> result.last().append(WebCore::CrossThreadCopier<IDBKeyData>::copy(key));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacRemoteLayerBackingStoremm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -342,7 +342,7 @@
</span><span class="cx"> inverseTransform = CGAffineTransformScale(inverseTransform, m_scale, -m_scale);
</span><span class="cx"> inverseTransform = CGAffineTransformTranslate(inverseTransform, 0, -m_size.height());
</span><span class="cx">
</span><del>- for (auto rect : m_paintingRects) {
</del><ins>+ for (const auto& rect : m_paintingRects) {
</ins><span class="cx"> CGRect rectToDraw = CGRectApplyAffineTransform(rect, inverseTransform);
</span><span class="cx"> block(rectToDraw);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacRemoteLayerTreePropertyAppliermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -102,7 +102,7 @@
</span><span class="cx">
</span><span class="cx"> if (properties.changedProperties & RemoteLayerTreeTransaction::ChildrenChanged) {
</span><span class="cx"> RetainPtr<NSMutableArray> children = adoptNS([[NSMutableArray alloc] initWithCapacity:properties.children.size()]);
</span><del>- for (auto child : properties.children)
</del><ins>+ for (auto& child : properties.children)
</ins><span class="cx"> [children addObject:relatedLayers.get(child)];
</span><span class="cx"> layer.sublayers = children.get();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessGeolocationPermissionRequestManagerProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">
</span><span class="cx"> void GeolocationPermissionRequestManagerProxy::invalidateRequests()
</span><span class="cx"> {
</span><del>- for (auto request : m_pendingRequests.values())
</del><ins>+ for (auto& request : m_pendingRequests.values())
</ins><span class="cx"> request->invalidate();
</span><span class="cx">
</span><span class="cx"> m_pendingRequests.clear();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNotificationsNotificationPermissionRequestManagerProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx">
</span><span class="cx"> void NotificationPermissionRequestManagerProxy::invalidateRequests()
</span><span class="cx"> {
</span><del>- for (auto request : m_pendingRequests.values())
</del><ins>+ for (auto& request : m_pendingRequests.values())
</ins><span class="cx"> request->invalidate();
</span><span class="cx">
</span><span class="cx"> m_pendingRequests.clear();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessScrollingRemoteScrollingCoordinatorProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx">
</span><span class="cx"> void RemoteScrollingCoordinatorProxy::connectStateNodeLayers(ScrollingStateTree& stateTree, const RemoteLayerTreeHost& layerTreeHost)
</span><span class="cx"> {
</span><del>- for (auto it : stateTree.nodeMap()) {
</del><ins>+ for (auto& it : stateTree.nodeMap()) {
</ins><span class="cx"> ScrollingStateNode* currNode = it.value;
</span><span class="cx"> switch (currNode->nodeType()) {
</span><span class="cx"> case ScrollingNode: {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -814,7 +814,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- for (auto process : m_processes) {
</del><ins>+ for (auto& process : m_processes) {
</ins><span class="cx"> // FIXME: Return early if the message body contains any references to WKPageRefs/WKFrameRefs etc. since they're local to a process.
</span><span class="cx"> IPC::ArgumentEncoder messageData;
</span><span class="cx"> messageData.encode(messageName);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -1404,7 +1404,7 @@
</span><span class="cx"> bool WebPageProxy::shouldStartTrackingTouchEvents(const WebTouchEvent& touchStartEvent) const
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(ASYNC_SCROLLING)
</span><del>- for (auto touchPoint : touchStartEvent.touchPoints()) {
</del><ins>+ for (auto& touchPoint : touchStartEvent.touchPoints()) {
</ins><span class="cx"> if (m_scrollingCoordinatorProxy->isPointInNonFastScrollableRegion(touchPoint.location()))
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeHostmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> {
</span><span class="cx"> LOG(RemoteLayerTree, "%s", transaction.description().data());
</span><span class="cx">
</span><del>- for (auto createdLayer : transaction.createdLayers())
</del><ins>+ for (const auto& createdLayer : transaction.createdLayers())
</ins><span class="cx"> createLayer(createdLayer);
</span><span class="cx">
</span><span class="cx"> bool rootLayerChanged = false;
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> rootLayerChanged = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- for (auto changedLayer : transaction.changedLayers()) {
</del><ins>+ for (auto& changedLayer : transaction.changedLayers()) {
</ins><span class="cx"> auto layerID = changedLayer.key;
</span><span class="cx"> const auto& properties = changedLayer.value;
</span><span class="cx">
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx">
</span><span class="cx"> RemoteLayerTreePropertyApplier::RelatedLayerMap relatedLayers;
</span><span class="cx"> if (properties.changedProperties & RemoteLayerTreeTransaction::ChildrenChanged) {
</span><del>- for (auto child : properties.children)
</del><ins>+ for (auto& child : properties.children)
</ins><span class="cx"> relatedLayers.set(child, getLayer(child));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacWindowServerConnectionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.mm (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.mm 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.mm 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx"> { WKOcclusionNotificationTypeApplicationWindowModificationsStopped, applicationWindowModificationsStopped, "Application Window Modifications Stopped" },
</span><span class="cx"> };
</span><span class="cx">
</span><del>- for (auto occlusionNotificationHandler : occlusionNotificationHandlers) {
</del><ins>+ for (const auto& occlusionNotificationHandler : occlusionNotificationHandlers) {
</ins><span class="cx"> bool result = WKRegisterOcclusionNotificationHandler(occlusionNotificationHandler.notificationType, occlusionNotificationHandler.handler);
</span><span class="cx"> UNUSED_PARAM(result);
</span><span class="cx"> ASSERT_WITH_MESSAGE(result, "Registration of \"%s\" notification handler failed.\n", occlusionNotificationHandler.name);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBServerConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -421,9 +421,9 @@
</span><span class="cx"> IPC::DataReference value(reinterpret_cast<const uint8_t*>(operation.value()->data()), operation.value()->size());
</span><span class="cx">
</span><span class="cx"> Vector<Vector<IDBKeyData>> indexKeys;
</span><del>- for (auto keys : operation.indexKeys()) {
</del><ins>+ for (const auto& keys : operation.indexKeys()) {
</ins><span class="cx"> indexKeys.append(Vector<IDBKeyData>());
</span><del>- for (auto key : keys)
</del><ins>+ for (const auto& key : keys)
</ins><span class="cx"> indexKeys.last().append(IDBKeyData(key.get()));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (163958 => 163959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2014-02-12 14:58:40 UTC (rev 163958)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2014-02-12 17:10:25 UTC (rev 163959)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> if (m_properties.changedProperties != RemoteLayerTreeTransaction::NoChange) {
</span><span class="cx"> if (m_properties.changedProperties & RemoteLayerTreeTransaction::ChildrenChanged) {
</span><span class="cx"> m_properties.children.clear();
</span><del>- for (auto layer : m_children)
</del><ins>+ for (const auto& layer : m_children)
</ins><span class="cx"> m_properties.children.append(layer->layerID());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>