<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163944] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163944">163944</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-02-11 20:50:55 -0800 (Tue, 11 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Switch repaint rect from IntRect to LayoutRect to be able to
repaint on device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=128477
Reviewed by Simon Fraser.
RenderLayer needs to be able to repaint on device pixel boundaries. RenderView still
repaints on integral position.
No change in functionality.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
* rendering/RenderLayerBacking.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
* rendering/RenderObject.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockLineLayoutcpp">trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderElementcpp">trunk/Source/WebCore/rendering/RenderElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingh">trunk/Source/WebCore/rendering/RenderLayerBacking.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/ChangeLog 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2014-02-11 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Switch repaint rect from IntRect to LayoutRect to be able to
+ repaint on device pixel boundaries.
+ https://bugs.webkit.org/show_bug.cgi?id=128477
+
+ Reviewed by Simon Fraser.
+
+ RenderLayer needs to be able to repaint on device pixel boundaries. RenderView still
+ repaints on integral position.
+
+ No change in functionality.
+
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlockFlow::layoutRunsAndFloats):
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::repaintAfterLayoutIfNeeded):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::clearRepaintRects):
+ (WebCore::RenderLayer::scrollTo):
+ (WebCore::RenderLayer::calculateClipRects):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintUsingContainer):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ * rendering/RenderObject.h:
+
</ins><span class="cx"> 2014-02-11 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> iOS build fix fix.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockLineLayoutcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -1054,7 +1054,7 @@
</span><span class="cx"> // that the block really needed a full layout, we missed our chance to repaint the layer
</span><span class="cx"> // before layout started. Luckily the layer has cached the repaint rect for its original
</span><span class="cx"> // position and size, and so we can use that to make a repaint happen now.
</span><del>- repaintUsingContainer(containerForRepaint(), pixelSnappedIntRect(layer()->repaintRect()));
</del><ins>+ repaintUsingContainer(containerForRepaint(), layer()->repaintRect());
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderElement.cpp 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -1187,9 +1187,9 @@
</span><span class="cx"> repaintContainer = &view();
</span><span class="cx">
</span><span class="cx"> if (fullRepaint) {
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds));
</del><ins>+ repaintUsingContainer(repaintContainer, oldBounds);
</ins><span class="cx"> if (newBounds != oldBounds)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds));
</del><ins>+ repaintUsingContainer(repaintContainer, newBounds);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1198,27 +1198,27 @@
</span><span class="cx">
</span><span class="cx"> LayoutUnit deltaLeft = newBounds.x() - oldBounds.x();
</span><span class="cx"> if (deltaLeft > 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.x(), oldBounds.y(), deltaLeft, oldBounds.height()));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(oldBounds.x(), oldBounds.y(), deltaLeft, oldBounds.height()));
</ins><span class="cx"> else if (deltaLeft < 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds.x(), newBounds.y(), -deltaLeft, newBounds.height()));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(newBounds.x(), newBounds.y(), -deltaLeft, newBounds.height()));
</ins><span class="cx">
</span><span class="cx"> LayoutUnit deltaRight = newBounds.maxX() - oldBounds.maxX();
</span><span class="cx"> if (deltaRight > 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.maxX(), newBounds.y(), deltaRight, newBounds.height()));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(oldBounds.maxX(), newBounds.y(), deltaRight, newBounds.height()));
</ins><span class="cx"> else if (deltaRight < 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds.maxX(), oldBounds.y(), -deltaRight, oldBounds.height()));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(newBounds.maxX(), oldBounds.y(), -deltaRight, oldBounds.height()));
</ins><span class="cx">
</span><span class="cx"> LayoutUnit deltaTop = newBounds.y() - oldBounds.y();
</span><span class="cx"> if (deltaTop > 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.x(), oldBounds.y(), oldBounds.width(), deltaTop));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(oldBounds.x(), oldBounds.y(), oldBounds.width(), deltaTop));
</ins><span class="cx"> else if (deltaTop < 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds.x(), newBounds.y(), newBounds.width(), -deltaTop));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(newBounds.x(), newBounds.y(), newBounds.width(), -deltaTop));
</ins><span class="cx">
</span><span class="cx"> LayoutUnit deltaBottom = newBounds.maxY() - oldBounds.maxY();
</span><span class="cx"> if (deltaBottom > 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds.x(), oldBounds.maxY(), newBounds.width(), deltaBottom));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(newBounds.x(), oldBounds.maxY(), newBounds.width(), deltaBottom));
</ins><span class="cx"> else if (deltaBottom < 0)
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.x(), newBounds.maxY(), oldBounds.width(), -deltaBottom));
</del><ins>+ repaintUsingContainer(repaintContainer, LayoutRect(oldBounds.x(), newBounds.maxY(), oldBounds.width(), -deltaBottom));
</ins><span class="cx">
</span><span class="cx"> if (newOutlineBox == oldOutlineBox)
</span><span class="cx"> return false;
</span><span class="lines">@@ -1245,7 +1245,7 @@
</span><span class="cx"> LayoutUnit right = std::min<LayoutUnit>(newBounds.maxX(), oldBounds.maxX());
</span><span class="cx"> if (rightRect.x() < right) {
</span><span class="cx"> rightRect.setWidth(std::min(rightRect.width(), right - rightRect.x()));
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(rightRect));
</del><ins>+ repaintUsingContainer(repaintContainer, rightRect);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> LayoutUnit height = absoluteValue(newOutlineBox.height() - oldOutlineBox.height());
</span><span class="lines">@@ -1265,7 +1265,7 @@
</span><span class="cx"> LayoutUnit bottom = std::min(newBounds.maxY(), oldBounds.maxY());
</span><span class="cx"> if (bottomRect.y() < bottom) {
</span><span class="cx"> bottomRect.setHeight(std::min(bottomRect.height(), bottom - bottomRect.y()));
</span><del>- repaintUsingContainer(repaintContainer, pixelSnappedIntRect(bottomRect));
</del><ins>+ repaintUsingContainer(repaintContainer, bottomRect);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -421,9 +421,9 @@
</span><span class="cx"> if (!renderer().view().printing()) {
</span><span class="cx"> bool didRepaint = false;
</span><span class="cx"> if (m_repaintStatus & NeedsFullRepaint) {
</span><del>- renderer().repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldRepaintRect));
</del><ins>+ renderer().repaintUsingContainer(repaintContainer, oldRepaintRect);
</ins><span class="cx"> if (m_repaintRect != oldRepaintRect) {
</span><del>- renderer().repaintUsingContainer(repaintContainer, pixelSnappedIntRect(m_repaintRect));
</del><ins>+ renderer().repaintUsingContainer(repaintContainer, m_repaintRect);
</ins><span class="cx"> didRepaint = true;
</span><span class="cx"> }
</span><span class="cx"> } else if (shouldRepaintAfterLayout()) {
</span><span class="lines">@@ -707,8 +707,8 @@
</span><span class="cx"> ASSERT(!m_hasVisibleContent);
</span><span class="cx"> ASSERT(!m_visibleContentStatusDirty);
</span><span class="cx">
</span><del>- m_repaintRect = IntRect();
- m_outlineBox = IntRect();
</del><ins>+ m_repaintRect = LayoutRect();
+ m_outlineBox = LayoutRect();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderLayer::updateLayerPositionsAfterDocumentScroll()
</span><span class="lines">@@ -2289,7 +2289,7 @@
</span><span class="cx"> #else
</span><span class="cx"> if (requiresRepaint)
</span><span class="cx"> #endif
</span><del>- renderer().repaintUsingContainer(repaintContainer, pixelSnappedIntRect(m_repaintRect));
</del><ins>+ renderer().repaintUsingContainer(repaintContainer, m_repaintRect);
</ins><span class="cx">
</span><span class="cx"> // Schedule the scroll DOM event.
</span><span class="cx"> if (Element* element = renderer().element())
</span><span class="lines">@@ -6203,13 +6203,13 @@
</span><span class="cx">
</span><span class="cx"> renderer().view().repaintViewRectangle(absRect);
</span><span class="cx"> } else
</span><del>- backing()->setContentsNeedDisplayInRect(pixelSnappedIntRect(r), shouldClip);
</del><ins>+ backing()->setContentsNeedDisplayInRect(r, shouldClip);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Since we're only painting non-composited layers, we know that they all share the same repaintContainer.
</span><span class="cx"> void RenderLayer::repaintIncludingNonCompositingDescendants(RenderLayerModelObject* repaintContainer)
</span><span class="cx"> {
</span><del>- renderer().repaintUsingContainer(repaintContainer, pixelSnappedIntRect(renderer().clippedOverflowRectForRepaint(repaintContainer)));
</del><ins>+ renderer().repaintUsingContainer(repaintContainer, renderer().clippedOverflowRectForRepaint(repaintContainer));
</ins><span class="cx">
</span><span class="cx"> for (RenderLayer* curr = firstChild(); curr; curr = curr->nextSibling()) {
</span><span class="cx"> if (!curr->isComposited())
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -2082,41 +2082,42 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // r is in the coordinate space of the layer's render object
</span><del>-void RenderLayerBacking::setContentsNeedDisplayInRect(const IntRect& r, GraphicsLayer::ShouldClipToLayer shouldClip)
</del><ins>+void RenderLayerBacking::setContentsNeedDisplayInRect(const LayoutRect& r, GraphicsLayer::ShouldClipToLayer shouldClip)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!paintsIntoCompositedAncestor());
</span><span class="cx">
</span><ins>+ FloatRect pixelSnappedRectForPainting = pixelSnappedForPainting(r, deviceScaleFactor());
</ins><span class="cx"> FrameView& frameView = owningLayer().renderer().view().frameView();
</span><span class="cx"> if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
</span><span class="cx"> frameView.addTrackedRepaintRect(pixelSnappedIntRect(r));
</span><span class="cx">
</span><span class="cx"> if (m_graphicsLayer && m_graphicsLayer->drawsContent()) {
</span><del>- IntRect layerDirtyRect = r;
</del><ins>+ FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</ins><span class="cx"> layerDirtyRect.move(-m_graphicsLayer->offsetFromRenderer());
</span><span class="cx"> m_graphicsLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_foregroundLayer && m_foregroundLayer->drawsContent()) {
</span><del>- IntRect layerDirtyRect = r;
</del><ins>+ FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</ins><span class="cx"> layerDirtyRect.move(-m_foregroundLayer->offsetFromRenderer());
</span><span class="cx"> m_foregroundLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: need to split out repaints for the background.
</span><span class="cx"> if (m_backgroundLayer && m_backgroundLayer->drawsContent()) {
</span><del>- IntRect layerDirtyRect = r;
</del><ins>+ FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</ins><span class="cx"> layerDirtyRect.move(-m_backgroundLayer->offsetFromRenderer());
</span><span class="cx"> m_backgroundLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_maskLayer && m_maskLayer->drawsContent()) {
</span><del>- IntRect layerDirtyRect = r;
</del><ins>+ FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</ins><span class="cx"> layerDirtyRect.move(-m_maskLayer->offsetFromRenderer());
</span><span class="cx"> m_maskLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_scrollingContentsLayer && m_scrollingContentsLayer->drawsContent()) {
</span><del>- IntRect layerDirtyRect = r;
</del><ins>+ FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</ins><span class="cx"> layerDirtyRect.move(-m_scrollingContentsLayer->offsetFromRenderer());
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> // Account for the fact that RenderLayerBacking::updateGraphicsLayerGeometry() bakes scrollOffset into offsetFromRenderer on iOS.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx">
</span><span class="cx"> void setContentsNeedDisplay(GraphicsLayer::ShouldClipToLayer = GraphicsLayer::ClipToLayer);
</span><span class="cx"> // r is in the coordinate space of the layer's render object
</span><del>- void setContentsNeedDisplayInRect(const IntRect&, GraphicsLayer::ShouldClipToLayer = GraphicsLayer::ClipToLayer);
</del><ins>+ void setContentsNeedDisplayInRect(const LayoutRect&, GraphicsLayer::ShouldClipToLayer = GraphicsLayer::ClipToLayer);
</ins><span class="cx">
</span><span class="cx"> // Notification from the renderer that its content changed.
</span><span class="cx"> void contentChanged(ContentChangeType);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -1225,7 +1225,7 @@
</span><span class="cx"> return repaintContainer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderObject::repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const IntRect& r, bool immediate, bool shouldClipToLayer) const
</del><ins>+void RenderObject::repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect& r, bool immediate, bool shouldClipToLayer) const
</ins><span class="cx"> {
</span><span class="cx"> if (!repaintContainer) {
</span><span class="cx"> view().repaintViewRectangle(r, immediate);
</span><span class="lines">@@ -1271,7 +1271,7 @@
</span><span class="cx"> return; // Don't repaint if we're printing.
</span><span class="cx">
</span><span class="cx"> RenderLayerModelObject* repaintContainer = containerForRepaint();
</span><del>- repaintUsingContainer(repaintContainer ? repaintContainer : view, pixelSnappedIntRect(clippedOverflowRectForRepaint(repaintContainer)), immediate);
</del><ins>+ repaintUsingContainer(repaintContainer ? repaintContainer : view, clippedOverflowRectForRepaint(repaintContainer), immediate);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderObject::repaintRectangle(const LayoutRect& r, bool immediate, bool shouldClipToLayer) const
</span><span class="lines">@@ -1292,7 +1292,7 @@
</span><span class="cx">
</span><span class="cx"> RenderLayerModelObject* repaintContainer = containerForRepaint();
</span><span class="cx"> computeRectForRepaint(repaintContainer, dirtyRect);
</span><del>- repaintUsingContainer(repaintContainer ? repaintContainer : view, pixelSnappedIntRect(dirtyRect), immediate, shouldClipToLayer);
</del><ins>+ repaintUsingContainer(repaintContainer ? repaintContainer : view, dirtyRect, immediate, shouldClipToLayer);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderObject::repaintSlowRepaintObject() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (163943 => 163944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2014-02-12 04:50:55 UTC (rev 163944)
</span><span class="lines">@@ -723,7 +723,7 @@
</span><span class="cx"> RenderLayerModelObject* containerForRepaint() const;
</span><span class="cx"> // Actually do the repaint of rect r for this object which has been computed in the coordinate space
</span><span class="cx"> // of repaintContainer. If repaintContainer is 0, repaint via the view.
</span><del>- void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const IntRect&, bool immediate = false, bool shouldClipToLayer = true) const;
</del><ins>+ void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect&, bool immediate = false, bool shouldClipToLayer = true) const;
</ins><span class="cx">
</span><span class="cx"> // Repaint the entire object. Called when, e.g., the color of a border changes, or when a border
</span><span class="cx"> // style changes.
</span></span></pre>
</div>
</div>
</body>
</html>