<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163724] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163724">163724</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-02-08 14:20:07 -0800 (Sat, 08 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused ChromeClient::formStateDidChange().
<https://webkit.org/b/128469>
Nobody listens for this callback anymore so remove it and stop
spamming no-op virtual dispatches in forms code.
Reviewed by Anders Carlsson.
* html/FileInputType.cpp:
(WebCore::FileInputType::setFiles):
* html/HTMLFormControlElementWithState.cpp:
* html/HTMLFormControlElementWithState.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValueCommon):
* loader/EmptyClients.h:
* page/ChromeClient.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypecpp">trunk/Source/WebCore/html/FileInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlElementWithStatecpp">trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlElementWithStateh">trunk/Source/WebCore/html/HTMLFormControlElementWithState.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientsh">trunk/Source/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkSourceWebCorepageChromeClienth">trunk/Source/WebCore/page/ChromeClient.h</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportChromeClientEflcpp">trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportChromeClientEflh">trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportChromeClientGtkh">trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h</a></li>
<li><a href="#trunkSourceWebKitiosWebCoreSupportWebChromeClientIOSh">trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebChromeClienth">trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEcpp">trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEh">trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/ChangeLog 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2014-02-08 Andreas Kling <akling@apple.com>
+
+ Remove unused ChromeClient::formStateDidChange().
+ <https://webkit.org/b/128469>
+
+ Nobody listens for this callback anymore so remove it and stop
+ spamming no-op virtual dispatches in forms code.
+
+ Reviewed by Anders Carlsson.
+
+ * html/FileInputType.cpp:
+ (WebCore::FileInputType::setFiles):
+ * html/HTMLFormControlElementWithState.cpp:
+ * html/HTMLFormControlElementWithState.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::updateType):
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ (WebCore::HTMLSelectElement::selectOption):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::updateValue):
+ (WebCore::HTMLTextAreaElement::setValueCommon):
+ * loader/EmptyClients.h:
+ * page/ChromeClient.h:
+
</ins><span class="cx"> 2014-02-08 Chris J. Shull <chrisjshull@gmail.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Find evaluates attributes in a case sensitive manner
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -349,7 +349,6 @@
</span><span class="cx"> m_fileList = files;
</span><span class="cx">
</span><span class="cx"> input->setFormControlValueMatchesRenderer(true);
</span><del>- input->notifyFormStateChanged();
</del><span class="cx"> input->setNeedsValidityCheck();
</span><span class="cx">
</span><span class="cx"> Vector<String> paths;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlElementWithStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -64,16 +64,6 @@
</span><span class="cx"> return form()->shouldAutocomplete();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLFormControlElementWithState::notifyFormStateChanged()
-{
- Frame* frame = document().frame();
- if (!frame)
- return;
-
- if (Page* page = frame->page())
- page->chrome().client().formStateDidChange(this);
-}
-
</del><span class="cx"> bool HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState() const
</span><span class="cx"> {
</span><span class="cx"> // We don't save/restore control state in a form with autocomplete=off.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlElementWithStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlElementWithState.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlElementWithState.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/HTMLFormControlElementWithState.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -40,7 +40,6 @@
</span><span class="cx"> virtual FormControlState saveFormControlState() const;
</span><span class="cx"> // The specified FormControlState must have at least one string value.
</span><span class="cx"> virtual void restoreFormControlState(const FormControlState&) { }
</span><del>- void notifyFormStateChanged();
</del><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> HTMLFormControlElementWithState(const QualifiedName& tagName, Document&, HTMLFormElement*);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -533,7 +533,6 @@
</span><span class="cx"> addToRadioButtonGroup();
</span><span class="cx">
</span><span class="cx"> setNeedsValidityCheck();
</span><del>- notifyFormStateChanged();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::subtreeHasChanged()
</span><span class="lines">@@ -1024,8 +1023,6 @@
</span><span class="cx">
</span><span class="cx"> if (!valueChanged)
</span><span class="cx"> return;
</span><del>-
- notifyFormStateChanged();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::setValueInternal(const String& sanitizedValue, TextFieldEventBehavior eventBehavior)
</span><span class="lines">@@ -1080,7 +1077,6 @@
</span><span class="cx"> // Input event is fired by the Node::defaultEventHandler for editable controls.
</span><span class="cx"> if (!isTextField())
</span><span class="cx"> dispatchInputEvent();
</span><del>- notifyFormStateChanged();
</del><span class="cx">
</span><span class="cx"> setNeedsValidityCheck();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -661,7 +661,6 @@
</span><span class="cx">
</span><span class="cx"> scrollToSelection();
</span><span class="cx"> setNeedsValidityCheck();
</span><del>- notifyFormStateChanged();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLSelectElement::listBoxOnChange()
</span><span class="lines">@@ -909,7 +908,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> setNeedsValidityCheck();
</span><del>- notifyFormStateChanged();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int HTMLSelectElement::optionToListIndex(int optionIndex) const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -341,7 +341,6 @@
</span><span class="cx"> ASSERT(renderer());
</span><span class="cx"> m_value = innerTextValue();
</span><span class="cx"> const_cast<HTMLTextAreaElement*>(this)->setFormControlValueMatchesRenderer(true);
</span><del>- const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged();
</del><span class="cx"> m_isDirty = true;
</span><span class="cx"> m_wasModifiedByUser = true;
</span><span class="cx"> const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility(false);
</span><span class="lines">@@ -394,7 +393,6 @@
</span><span class="cx"> setSelectionRange(endOfString, endOfString);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- notifyFormStateChanged();
</del><span class="cx"> setTextAsOfLastFormControlChangeEvent(normalizedValue);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -167,8 +167,6 @@
</span><span class="cx"> virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) override;
</span><span class="cx"> virtual void loadIconForFiles(const Vector<String>&, FileIconLoader*) override { }
</span><span class="cx">
</span><del>- virtual void formStateDidChange(const Node*) override { }
-
</del><span class="cx"> virtual void elementDidFocus(const Node*) override { }
</span><span class="cx"> virtual void elementDidBlur(const Node*) override { }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ChromeClient.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ChromeClient.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -268,10 +268,6 @@
</span><span class="cx"> virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) = 0;
</span><span class="cx"> // Asynchronous request to load an icon for specified filenames.
</span><span class="cx"> virtual void loadIconForFiles(const Vector<String>&, FileIconLoader*) = 0;
</span><del>-
- // Notification that the given form element has changed. This function
- // will be called frequently, so handling should be very fast.
- virtual void formStateDidChange(const Node*) = 0;
</del><span class="cx">
</span><span class="cx"> virtual void elementDidFocus(const Node*) { };
</span><span class="cx"> virtual void elementDidBlur(const Node*) { };
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportChromeClientEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -497,11 +497,6 @@
</span><span class="cx"> chooser->chooseFile(filenames[0]);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientEfl::formStateDidChange(const Node*)
-{
- notImplemented();
-}
-
</del><span class="cx"> void ChromeClientEfl::setCursor(const Cursor& cursor)
</span><span class="cx"> {
</span><span class="cx"> ewk_view_cursor_set(m_view, cursor);
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportChromeClientEflh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -147,7 +147,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
</span><span class="cx"> virtual void loadIconForFiles(const Vector<String>&, FileIconLoader*);
</span><del>- virtual void formStateDidChange(const Node*);
</del><span class="cx">
</span><span class="cx"> virtual void setCursor(const Cursor&);
</span><span class="cx"> virtual void setCursorHiddenUntilMouseMoves(bool);
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportChromeClientGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -122,8 +122,6 @@
</span><span class="cx"> virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
</span><span class="cx"> virtual void loadIconForFiles(const Vector<WTF::String>&, FileIconLoader*);
</span><span class="cx">
</span><del>- virtual void formStateDidChange(const Node*) { }
-
</del><span class="cx"> virtual void setCursor(const Cursor&);
</span><span class="cx"> virtual void setCursorHiddenUntilMouseMoves(bool);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitiosWebCoreSupportWebChromeClientIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -62,8 +62,6 @@
</span><span class="cx"> virtual void suppressFormNotifications() override;
</span><span class="cx"> virtual void restoreFormNotifications() override;
</span><span class="cx">
</span><del>- virtual void formStateDidChange(const WebCore::Node*) override { }
-
</del><span class="cx"> virtual void elementDidFocus(const WebCore::Node*) override;
</span><span class="cx"> virtual void elementDidBlur(const WebCore::Node*) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -153,8 +153,6 @@
</span><span class="cx"> virtual bool shouldReplaceWithGeneratedFileForUpload(const WTF::String& path, WTF::String &generatedFilename) override;
</span><span class="cx"> virtual WTF::String generateReplacementFile(const WTF::String& path) override;
</span><span class="cx">
</span><del>- virtual void formStateDidChange(const WebCore::Node*) override { }
-
</del><span class="cx"> virtual void elementDidFocus(const WebCore::Node*) override;
</span><span class="cx"> virtual void elementDidBlur(const WebCore::Node*) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -128,8 +128,6 @@
</span><span class="cx"> virtual void setCursorHiddenUntilMouseMoves(bool);
</span><span class="cx"> virtual void setLastSetCursorToCurrentCursor();
</span><span class="cx">
</span><del>- virtual void formStateDidChange(const WebCore::Node*) { }
-
</del><span class="cx"> // Pass 0 as the GraphicsLayer to detatch the root layer.
</span><span class="cx"> virtual void attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*);
</span><span class="cx"> // Sets a flag to specify that the next time content is drawn to the window,
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -367,11 +367,6 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientWinCE::formStateDidChange(const Node*)
-{
- notImplemented();
-}
-
</del><span class="cx"> bool ChromeClientWinCE::selectItemWritingDirectionIsNatural()
</span><span class="cx"> {
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -133,10 +133,6 @@
</span><span class="cx"> // Asynchronous request to load an icon for specified filenames.
</span><span class="cx"> virtual void loadIconForFiles(const Vector<WTF::String>&, WebCore::FileIconLoader*) override;
</span><span class="cx">
</span><del>- // Notification that the given form element has changed. This function
- // will be called frequently, so handling should be very fast.
- virtual void formStateDidChange(const WebCore::Node*) override;
-
</del><span class="cx"> // Pass 0 as the GraphicsLayer to detatch the root layer.
</span><span class="cx"> virtual void attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) override;
</span><span class="cx"> // Sets a flag to specify that the next time content is drawn to the window,
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -723,11 +723,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void WebChromeClient::formStateDidChange(const Node*)
-{
- notImplemented();
-}
-
</del><span class="cx"> void WebChromeClient::didAssociateFormControls(const Vector<RefPtr<WebCore::Element>>& elements)
</span><span class="cx"> {
</span><span class="cx"> return m_page->injectedBundleFormClient().didAssociateFormControls(m_page, elements);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (163723 => 163724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-02-08 22:11:20 UTC (rev 163723)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-02-08 22:20:07 UTC (rev 163724)
</span><span class="lines">@@ -188,10 +188,6 @@
</span><span class="cx"> virtual void scheduleAnimation() override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- // Notification that the given form element has changed. This function
- // will be called frequently, so handling should be very fast.
- virtual void formStateDidChange(const WebCore::Node*) override;
-
</del><span class="cx"> virtual void didAssociateFormControls(const Vector<RefPtr<WebCore::Element>>&) override;
</span><span class="cx"> virtual bool shouldNotifyOnFormChanges() override;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>