<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163703] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163703">163703</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-02-08 00:45:47 -0800 (Sat, 08 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use renderer iterators in two more places.
<https://webkit.org/b/128371>
Reviewed by Antti Koivisto.
* dom/Position.cpp:
(WebCore::Position::primaryDirection):
Use lineageOfType instead of walking the parent chain.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::insertOnlyThisLayer):
Use childrenOfType instead of walking the children.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomPositioncpp">trunk/Source/WebCore/dom/Position.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163702 => 163703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-08 08:42:07 UTC (rev 163702)
+++ trunk/Source/WebCore/ChangeLog 2014-02-08 08:45:47 UTC (rev 163703)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-02-08 Andreas Kling <akling@apple.com>
+
+ Use renderer iterators in two more places.
+ <https://webkit.org/b/128371>
+
+ Reviewed by Antti Koivisto.
+
+ * dom/Position.cpp:
+ (WebCore::Position::primaryDirection):
+
+ Use lineageOfType instead of walking the parent chain.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::insertOnlyThisLayer):
+
+ Use childrenOfType instead of walking the children.
+
</ins><span class="cx"> 2014-02-07 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> [ASan] Use new/delete in PODFreeListArena
</span></span></pre></div>
<a id="trunkSourceWebCoredomPositioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Position.cpp (163702 => 163703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Position.cpp 2014-02-08 08:42:07 UTC (rev 163702)
+++ trunk/Source/WebCore/dom/Position.cpp 2014-02-08 08:45:47 UTC (rev 163703)
</span><span class="lines">@@ -36,6 +36,7 @@
</span><span class="cx"> #include "PositionIterator.h"
</span><span class="cx"> #include "RenderBlock.h"
</span><span class="cx"> #include "RenderInline.h"
</span><ins>+#include "RenderIterator.h"
</ins><span class="cx"> #include "RenderLineBreak.h"
</span><span class="cx"> #include "RenderText.h"
</span><span class="cx"> #include "RuntimeEnabledFeatures.h"
</span><span class="lines">@@ -1334,15 +1335,11 @@
</span><span class="cx">
</span><span class="cx"> TextDirection Position::primaryDirection() const
</span><span class="cx"> {
</span><del>- TextDirection primaryDirection = LTR;
- for (const RenderObject* r = m_anchorNode->renderer(); r; r = r->parent()) {
- if (r->isRenderBlockFlow()) {
- primaryDirection = toRenderBlockFlow(r)->style().direction();
- break;
- }
- }
-
- return primaryDirection;
</del><ins>+ if (!m_anchorNode->renderer())
+ return LTR;
+ if (auto* blockFlow = lineageOfType<RenderBlockFlow>(*m_anchorNode->renderer()).first())
+ return blockFlow->style().direction();
+ return LTR;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (163702 => 163703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-08 08:42:07 UTC (rev 163702)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-08 08:45:47 UTC (rev 163703)
</span><span class="lines">@@ -81,6 +81,7 @@
</span><span class="cx"> #include "RenderFlowThread.h"
</span><span class="cx"> #include "RenderGeometryMap.h"
</span><span class="cx"> #include "RenderInline.h"
</span><ins>+#include "RenderIterator.h"
</ins><span class="cx"> #include "RenderLayerBacking.h"
</span><span class="cx"> #include "RenderLayerCompositor.h"
</span><span class="cx"> #include "RenderMarquee.h"
</span><span class="lines">@@ -1833,10 +1834,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Remove all descendant layers from the hierarchy and add them to the new position.
</span><del>- for (RenderObject* curr = renderer().firstChild(); curr; curr = curr->nextSibling()) {
- if (curr->isRenderElement())
- toRenderElement(curr)->moveLayers(m_parent, this);
- }
</del><ins>+ for (auto& child : childrenOfType<RenderElement>(renderer()))
+ child.moveLayers(m_parent, this);
</ins><span class="cx">
</span><span class="cx"> // Clear out all the clip rects.
</span><span class="cx"> clearClipRectsIncludingDescendants();
</span></span></pre>
</div>
</div>
</body>
</html>