<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163705] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163705">163705</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-02-08 00:50:00 -0800 (Sat, 08 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>CTTE: SVGTRefTargetEventListener is always owned by SVGTRefElement.
<https://webkit.org/b/128432>
Tighten up the relationship between SVGTRefElement and its internal
event listener helper by storing the listener in a Ref, and making
the listeners backpointer to the element be a reference.
Reviewed by Anders Carlsson.
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefTargetEventListener::create):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::operator==):
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::SVGTRefElement):
* svg/SVGTRefElement.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTRefElementcpp">trunk/Source/WebCore/svg/SVGTRefElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTRefElementh">trunk/Source/WebCore/svg/SVGTRefElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163704 => 163705)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-08 08:48:51 UTC (rev 163704)
+++ trunk/Source/WebCore/ChangeLog 2014-02-08 08:50:00 UTC (rev 163705)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-02-08 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ CTTE: SVGTRefTargetEventListener is always owned by SVGTRefElement.
+ <https://webkit.org/b/128432>
+
+ Tighten up the relationship between SVGTRefElement and its internal
+ event listener helper by storing the listener in a Ref, and making
+ the listeners backpointer to the element be a reference.
+
+ Reviewed by Anders Carlsson.
+
+ * svg/SVGTRefElement.cpp:
+ (WebCore::SVGTRefTargetEventListener::create):
+ (WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
+ (WebCore::SVGTRefTargetEventListener::operator==):
+ (WebCore::SVGTRefTargetEventListener::handleEvent):
+ (WebCore::SVGTRefElement::SVGTRefElement):
+ * svg/SVGTRefElement.h:
+
+2014-02-07 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> Devirtualize RenderBlockFlowRareData.
</span><span class="cx"> <https://webkit.org/b/128427>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTRefElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (163704 => 163705)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTRefElement.cpp 2014-02-08 08:48:51 UTC (rev 163704)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp 2014-02-08 08:50:00 UTC (rev 163705)
</span><span class="lines">@@ -56,9 +56,9 @@
</span><span class="cx">
</span><span class="cx"> class SVGTRefTargetEventListener : public EventListener {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<SVGTRefTargetEventListener> create(SVGTRefElement* trefElement)
</del><ins>+ static PassRef<SVGTRefTargetEventListener> create(SVGTRefElement& trefElement)
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGTRefTargetEventListener(trefElement));
</del><ins>+ return adoptRef(*new SVGTRefTargetEventListener(trefElement));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static const SVGTRefTargetEventListener* cast(const EventListener* listener)
</span><span class="lines">@@ -72,21 +72,20 @@
</span><span class="cx"> bool isAttached() const { return m_target.get(); }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- SVGTRefTargetEventListener(SVGTRefElement* trefElement);
</del><ins>+ explicit SVGTRefTargetEventListener(SVGTRefElement& trefElement);
</ins><span class="cx">
</span><span class="cx"> virtual void handleEvent(ScriptExecutionContext*, Event*) override;
</span><span class="cx"> virtual bool operator==(const EventListener&) override;
</span><span class="cx">
</span><del>- SVGTRefElement* m_trefElement;
</del><ins>+ SVGTRefElement& m_trefElement;
</ins><span class="cx"> RefPtr<Element> m_target;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-SVGTRefTargetEventListener::SVGTRefTargetEventListener(SVGTRefElement* trefElement)
</del><ins>+SVGTRefTargetEventListener::SVGTRefTargetEventListener(SVGTRefElement& trefElement)
</ins><span class="cx"> : EventListener(SVGTRefTargetEventListenerType)
</span><span class="cx"> , m_trefElement(trefElement)
</span><span class="cx"> , m_target(0)
</span><span class="cx"> {
</span><del>- ASSERT(m_trefElement);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SVGTRefTargetEventListener::attach(PassRefPtr<Element> target)
</span><span class="lines">@@ -113,7 +112,7 @@
</span><span class="cx"> bool SVGTRefTargetEventListener::operator==(const EventListener& listener)
</span><span class="cx"> {
</span><span class="cx"> if (const SVGTRefTargetEventListener* targetListener = SVGTRefTargetEventListener::cast(&listener))
</span><del>- return m_trefElement == targetListener->m_trefElement;
</del><ins>+ return &m_trefElement == &targetListener->m_trefElement;
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -121,15 +120,15 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isAttached());
</span><span class="cx">
</span><del>- if (event->type() == eventNames().DOMSubtreeModifiedEvent && m_trefElement != event->target())
- m_trefElement->updateReferencedText(m_target.get());
</del><ins>+ if (event->type() == eventNames().DOMSubtreeModifiedEvent && &m_trefElement != event->target())
+ m_trefElement.updateReferencedText(m_target.get());
</ins><span class="cx"> else if (event->type() == eventNames().DOMNodeRemovedFromDocumentEvent)
</span><del>- m_trefElement->detachTarget();
</del><ins>+ m_trefElement.detachTarget();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> inline SVGTRefElement::SVGTRefElement(const QualifiedName& tagName, Document& document)
</span><span class="cx"> : SVGTextPositioningElement(tagName, document)
</span><del>- , m_targetListener(SVGTRefTargetEventListener::create(this))
</del><ins>+ , m_targetListener(SVGTRefTargetEventListener::create(*this))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(hasTagName(SVGNames::trefTag));
</span><span class="cx"> registerAnimatedPropertiesForSVGTRefElement();
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTRefElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTRefElement.h (163704 => 163705)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTRefElement.h 2014-02-08 08:48:51 UTC (rev 163704)
+++ trunk/Source/WebCore/svg/SVGTRefElement.h 2014-02-08 08:50:00 UTC (rev 163705)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx"> DECLARE_ANIMATED_STRING(Href, href)
</span><span class="cx"> END_DECLARE_ANIMATED_PROPERTIES
</span><span class="cx">
</span><del>- RefPtr<SVGTRefTargetEventListener> m_targetListener;
</del><ins>+ Ref<SVGTRefTargetEventListener> m_targetListener;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre>
</div>
</div>
</body>
</html>