<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163667] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163667">163667</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-02-07 17:09:56 -0800 (Fri, 07 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove some unused functions from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128407
Reviewed by Anders Carlsson.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):
* bindings/js/SerializedScriptValue.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValueh">trunk/Source/WebCore/bindings/js/SerializedScriptValue.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163666 => 163667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-08 00:58:08 UTC (rev 163666)
+++ trunk/Source/WebCore/ChangeLog 2014-02-08 01:09:56 UTC (rev 163667)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-07 Alexey Proskuryakov <ap@apple.com>
+
+ Remove some unused functions from SerializedScriptValue
+ https://bugs.webkit.org/show_bug.cgi?id=128407
+
+ Reviewed by Anders Carlsson.
+
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::SerializedScriptValue::undefinedValue):
+ (WebCore::SerializedScriptValue::nullValue):
+ * bindings/js/SerializedScriptValue.h:
+
</ins><span class="cx"> 2014-02-07 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IDB: Some Mozilla cursor mutation tests fail
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (163666 => 163667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2014-02-08 00:58:08 UTC (rev 163666)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2014-02-08 01:09:56 UTC (rev 163667)
</span><span class="lines">@@ -2540,12 +2540,6 @@
</span><span class="cx"> return adoptRef(new SerializedScriptValue(buffer, blobURLs, arrayBufferContentsArray.release()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::create()
-{
- Vector<uint8_t> buffer;
- return adoptRef(new SerializedScriptValue(buffer));
-}
-
</del><span class="cx"> PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(const String& string)
</span><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="lines">@@ -2555,11 +2549,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value)
-{
- return SerializedScriptValue::create(exec, value, 0, 0);
-}
-
</del><span class="cx"> PassRefPtr<SerializedScriptValue> SerializedScriptValue::numberValue(double value)
</span><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="lines">@@ -2567,9 +2556,11 @@
</span><span class="cx"> return adoptRef(new SerializedScriptValue(buffer));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-JSValue SerializedScriptValue::deserialize(JSC::ExecState* exec, JSC::JSGlobalObject* globalObject)
</del><ins>+PassRefPtr<SerializedScriptValue> SerializedScriptValue::undefinedValue()
</ins><span class="cx"> {
</span><del>- return deserialize(exec, globalObject, 0);
</del><ins>+ Vector<uint8_t> buffer;
+ CloneSerializer::serializeUndefined(buffer);
+ return adoptRef(new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -2612,14 +2603,6 @@
</span><span class="cx"> return result.first;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#if ENABLE(INSPECTOR)
-Deprecated::ScriptValue SerializedScriptValue::deserializeForInspector(JSC::ExecState* scriptState)
-{
- JSValue value = deserialize(scriptState, scriptState->lexicalGlobalObject(), 0);
- return Deprecated::ScriptValue(scriptState->vm(), value);
-}
-#endif
-
</del><span class="cx"> JSValueRef SerializedScriptValue::deserialize(JSContextRef destinationContext, JSValueRef* exception, MessagePortArray* messagePorts)
</span><span class="cx"> {
</span><span class="cx"> ExecState* exec = toJS(destinationContext);
</span><span class="lines">@@ -2643,13 +2626,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue()
</span><span class="cx"> {
</span><del>- return SerializedScriptValue::create();
-}
-
-PassRefPtr<SerializedScriptValue> SerializedScriptValue::undefinedValue()
-{
</del><span class="cx"> Vector<uint8_t> buffer;
</span><del>- CloneSerializer::serializeUndefined(buffer);
</del><span class="cx"> return adoptRef(new SerializedScriptValue(buffer));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.h (163666 => 163667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.h 2014-02-08 00:58:08 UTC (rev 163666)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.h 2014-02-08 01:09:56 UTC (rev 163667)
</span><span class="lines">@@ -77,9 +77,7 @@
</span><span class="cx"> return adoptRef(new SerializedScriptValue(buffer));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SerializedScriptValue> create();
</del><span class="cx"> static PassRefPtr<SerializedScriptValue> nullValue();
</span><del>- static PassRefPtr<SerializedScriptValue> undefinedValue();
</del><span class="cx"> static PassRefPtr<SerializedScriptValue> booleanValue(bool value);
</span><span class="cx">
</span><span class="cx"> static PassRefPtr<SerializedScriptValue> serialize(const Deprecated::ScriptValue&, JSC::ExecState*, SerializationErrorMode = Throwing);
</span><span class="lines">@@ -94,17 +92,13 @@
</span><span class="cx"> JSValueRef deserialize(JSContextRef, JSValueRef* exception, MessagePortArray*);
</span><span class="cx"> JSValueRef deserialize(JSContextRef, JSValueRef* exception);
</span><span class="cx">
</span><del>-#if ENABLE(INSPECTOR)
- Deprecated::ScriptValue deserializeForInspector(JSC::ExecState*);
-#endif
-
</del><span class="cx"> const Vector<uint8_t>& data() const { return m_data; }
</span><span class="cx"> const Vector<String>& blobURLs() const { return m_blobURLs; }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>- static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue);
</del><ins>+ // FIXME: Get rid of these. The only caller immediately deserializes the result, so it's a very roundabout way to create a JSValue.
</ins><span class="cx"> static PassRefPtr<SerializedScriptValue> numberValue(double value);
</span><del>- JSC::JSValue deserialize(JSC::ExecState*, JSC::JSGlobalObject*);
</del><ins>+ static PassRefPtr<SerializedScriptValue> undefinedValue();
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> static PassRefPtr<SerializedScriptValue> createFromWireBytes(const Vector<uint8_t>& data)
</span></span></pre>
</div>
</div>
</body>
</html>