<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163655] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163655">163655</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-07 15:07:29 -0800 (Fri, 07 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revert <a href="http://trac.webkit.org/projects/webkit/changeset/154384">r154384</a> and <a href="http://trac.webkit.org/projects/webkit/changeset/154674">r154674</a> as they broke selection rect computations for text with ligatures.
Source/WebCore:
* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
* platform/graphics/GlyphBuffer.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):
* platform/graphics/WidthIterator.h:
LayoutTests:
* fast/text/partial-textruns-expected.html: Removed.
* fast/text/partial-textruns.html: Removed.
* fast/text/resources/PTS55F-webfont.ttf: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontcpp">trunk/Source/WebCore/platform/graphics/Font.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontFastPathcpp">trunk/Source/WebCore/platform/graphics/FontFastPath.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGlyphBufferh">trunk/Source/WebCore/platform/graphics/GlyphBuffer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsWidthIteratorcpp">trunk/Source/WebCore/platform/graphics/WidthIterator.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsWidthIteratorh">trunk/Source/WebCore/platform/graphics/WidthIterator.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttextpartialtextrunsexpectedhtml">trunk/LayoutTests/fast/text/partial-textruns-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasttextpartialtextrunshtml">trunk/LayoutTests/fast/text/partial-textruns.html</a></li>
<li><a href="#trunkLayoutTestsfasttextresourcesPTS55Fwebfontttf">trunk/LayoutTests/fast/text/resources/PTS55F-webfont.ttf</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (163654 => 163655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-02-07 23:03:03 UTC (rev 163654)
+++ trunk/LayoutTests/ChangeLog        2014-02-07 23:07:29 UTC (rev 163655)
</span><span class="lines">@@ -1,3 +1,11 @@
</span><ins>+2014-02-07 Ryosuke Niwa <rniwa@webkit.org>
+
+ Revert r154384 and r154674 as they broke selection rect computations for text with ligatures.
+
+ * fast/text/partial-textruns-expected.html: Removed.
+ * fast/text/partial-textruns.html: Removed.
+ * fast/text/resources/PTS55F-webfont.ttf: Removed.
+
</ins><span class="cx"> 2014-02-07 Brendan Long <b.long@cablelabs.com>
</span><span class="cx">
</span><span class="cx"> Update TextTrack API to current spec
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextpartialtextrunsexpectedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/text/partial-textruns-expected.html (163654 => 163655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/partial-textruns-expected.html        2014-02-07 23:03:03 UTC (rev 163654)
+++ trunk/LayoutTests/fast/text/partial-textruns-expected.html        2014-02-07 23:07:29 UTC (rev 163655)
</span><span class="lines">@@ -1,37 +0,0 @@
</span><del>-<html>
-<head>
-<style>
- @font-face {
- font-family: PTSans;
- src: url('resources/PTS55F-webfont.ttf') format("truetype");
- font-weight: normal;
- font-style: normal;
- }
- #sandbox { position: absolute; width: 400px; }
- article {
- width: 400px;
- font-family: PTSans;
- font-size: 24px;
- -webkit-font-kerning: normal;
- }
-</style>
-</head>
-<body>
-<div id=sandbox>
-<article>
-This test is meant <span id=selection>to test if font metrics change when partially rendered. To test select multiple lines with the begin</span> or end line being only partially selected. The test succedes if none of the letters in the partially selected lines shift compared to when they are not selected or the line fully selected.
-</article>
-</div>
-
-<script>
- var selection = window.getSelection();
- if (selection.rangeCount > 0)
- selection.removeAllRanges();
- var selectionNode = document.getElementById("selection");
- var range = document.createRange();
- range.selectNode(selectionNode);
- selection.addRange(range);
-</script>
-
-</body>
-</html>
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextpartialtextrunshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/text/partial-textruns.html (163654 => 163655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/partial-textruns.html        2014-02-07 23:03:03 UTC (rev 163654)
+++ trunk/LayoutTests/fast/text/partial-textruns.html        2014-02-07 23:07:29 UTC (rev 163655)
</span><span class="lines">@@ -1,35 +0,0 @@
</span><del>-<html>
-<head>
-<style>
- @font-face {
- font-family: PTSans;
- src: url('resources/PTS55F-webfont.ttf') format("truetype");
- font-weight: normal;
- font-style: normal;
- }
- #sandbox { position: absolute; width: 400px; }
- article {
- width: 400px;
- font-family: PTSans;
- font-size: 24px;
- -webkit-font-kerning: normal;
- }
-</style>
-</head>
-<body>
-<div id=sandbox>
-<article id=article>This test is meant to test if font metrics change when partially rendered. To test select multiple lines with the begin or end line being only partially selected. The test succedes if none of the letters in the partially selected lines shift compared to when they are not selected or the line fully selected.</article>
-</div>
-<script>
- var selection = window.getSelection();
- if (selection.rangeCount > 0)
- selection.removeAllRanges();
- var article = document.getElementById("article");
- var range = document.createRange();
- range.setStart(article.firstChild, 19);
- range.setEnd(article.firstChild, 119);
- selection.addRange(range);
-</script>
-
-</body>
-</html>
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextresourcesPTS55Fwebfontttf"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/text/resources/PTS55F-webfont.ttf (163654 => 163655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/resources/PTS55F-webfont.ttf        2014-02-07 23:03:03 UTC (rev 163654)
+++ trunk/LayoutTests/fast/text/resources/PTS55F-webfont.ttf        2014-02-07 23:07:29 UTC (rev 163655)
</span><span class="lines">@@ -1,403 +0,0 @@
</span><del>- FFTMZp\xB8\xDB , GDEF\xF2& H 8GPOS;\xB9[8 \x80 \xEEGSUB5\xCEN\xB0 p @OS/2\x9Cg\x84Y \xB0 `cmap\xDB:\xF6 \xDAcvt
-I \xEC (fpgm\xB4/\xA7 egasp | glyf\xF1\xB5X \x88 Y0head\xF7\xF2R
- `\xB8 6hheavV `\xF0 $hmtx\xF41x a ,loca\xEB\xC7" c@ maxp\xC5\xD8 dX name#\x82@J dx \xB8post\xBF\x9A\xE9 f0 prep]ʻy h8 @ \xC7\xFE\xB0\xDF \xC99\xFC \xC99\xFF 0