<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163529] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163529">163529</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2014-02-06 02:50:58 -0800 (Thu, 06 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Verify copy/paste of misspellings asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128246
Reviewed by Ryosuke Niwa.
Refactoring two spelling tests that use copy/paste to be able to
verify spelling markers asynchronously.
Additionally, use evalAndLog() to make test expectation more readable.
Fix the description according to the tests.
Start off verifying whether spelling marker is available when continuous spell
checking (spellcheck attribute, respectively) is on.
Without this test case, the tests passed even spellchecking
or copy/paste were not implemented (EFL).
* editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
* editing/spelling/spellcheck-paste-continuous-disabled.html:
Remove unnecessary spellcheck=true attribute. It's default value and we
do not manipulate it at all.
Add destination element where paste operation is performed.
* editing/spelling/spellcheck-paste-disabled-expected.txt:
* editing/spelling/spellcheck-paste-disabled.html:
* platform/efl/TestExpectations:
Mark spellcheck-paste-continuous-disabled.html as failing since EFL does not
implement copy/paste feature.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestseditingspellingspellcheckpastecontinuousdisabledexpectedtxt">trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingspellingspellcheckpastecontinuousdisabledhtml">trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html</a></li>
<li><a href="#trunkLayoutTestseditingspellingspellcheckpastedisabledexpectedtxt">trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingspellingspellcheckpastedisabledhtml">trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled.html</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/ChangeLog 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2014-02-06 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ Verify copy/paste of misspellings asynchronously
+ https://bugs.webkit.org/show_bug.cgi?id=128246
+
+ Reviewed by Ryosuke Niwa.
+
+ Refactoring two spelling tests that use copy/paste to be able to
+ verify spelling markers asynchronously.
+ Additionally, use evalAndLog() to make test expectation more readable.
+ Fix the description according to the tests.
+
+ Start off verifying whether spelling marker is available when continuous spell
+ checking (spellcheck attribute, respectively) is on.
+ Without this test case, the tests passed even spellchecking
+ or copy/paste were not implemented (EFL).
+
+ * editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
+ * editing/spelling/spellcheck-paste-continuous-disabled.html:
+ Remove unnecessary spellcheck=true attribute. It's default value and we
+ do not manipulate it at all.
+ Add destination element where paste operation is performed.
+
+ * editing/spelling/spellcheck-paste-disabled-expected.txt:
+ * editing/spelling/spellcheck-paste-disabled.html:
+
+ * platform/efl/TestExpectations:
+ Mark spellcheck-paste-continuous-disabled.html as failing since EFL does not
+ implement copy/paste feature.
+
</ins><span class="cx"> 2014-02-06 László Langó <llango.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Create a HTMLUnknownElement when using createElement('image')
</span></span></pre></div>
<a id="trunkLayoutTestseditingspellingspellcheckpastecontinuousdisabledexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -1,12 +1,23 @@
</span><del>-Test if WebKit does not spellcheck text when pasting text and continuous spellcheck is turned off. To test manually, disable continuous spellcheck, copy the text "zz apple" and paste it to the textarea. When "zz" is not marked as misspelled, this test succeeds.
</del><ins>+Test if WebKit does not spellcheck text when pasting text and continuous spellcheck is turned off. To test manually, copy the text "zz apple", disable continuous spellcheck and paste it to editable element below. When "zz" is not marked as misspelled, this test succeeds.
</ins><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS internals.hasSpellingMarker(0, 2) is true
-PASS internals.hasSpellingMarker(0, 2) is false
</del><ins>+document.execCommand("InsertText", false, "z")
+document.execCommand("InsertText", false, "z")
+document.execCommand("InsertText", false, " ")
+document.execCommand("InsertText", false, "a")
+document.execCommand("InsertText", false, "p")
+document.execCommand("InsertText", false, "p")
+document.execCommand("InsertText", false, "l")
+document.execCommand("InsertText", false, "e")
+PASS internals.hasSpellingMarker(0, 2) became true
+document.execCommand('Copy')
+internals.setContinuousSpellCheckingEnabled(false)
+document.execCommand('Paste')
+PASS internals.hasSpellingMarker(0, 2) became different from true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx"> zz apple
</span><del>-
</del><ins>+zz apple
</ins></span></pre></div>
<a id="trunkLayoutTestseditingspellingspellcheckpastecontinuousdisabledhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -6,33 +6,46 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <div>
</span><del>-<div id="src" contenteditable="true" spellcheck="true"></div>
</del><ins>+<div id="src" contenteditable="true"></div>
+<div id="dst" contenteditable="true"></div>
</ins><span class="cx"> </div>
</span><span class="cx"> <script language="javascript">
</span><span class="cx"> description('Test if WebKit does not spellcheck text when pasting text and continuous spellcheck is turned off. ' +
</span><del>- 'To test manually, disable continuous spellcheck, copy the text "zz apple" and paste it to the textarea. ' +
</del><ins>+ 'To test manually, copy the text "zz apple", disable continuous spellcheck and paste it to editable element below. ' +
</ins><span class="cx"> 'When "zz" is not marked as misspelled, this test succeeds.');
</span><span class="cx">
</span><del>-// Insert a misspelled word to initialize a spellchecker.
</del><ins>+jsTestIsAsync = true;
+
+if (window.internals) {
+ internals.settings.setUnifiedTextCheckerEnabled(true);
+ internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
</ins><span class="cx"> var srcNode = document.getElementById('src');
</span><span class="cx"> srcNode.focus();
</span><del>-document.execCommand("InsertText", false, 'z');
-document.execCommand("InsertText", false, 'z');
-document.execCommand("InsertText", false, ' ');
-document.execCommand("InsertText", false, 'a');
-document.execCommand("InsertText", false, 'p');
-document.execCommand("InsertText", false, 'p');
-document.execCommand("InsertText", false, 'l');
-document.execCommand("InsertText", false, 'e');
-shouldBeTrue('internals.hasSpellingMarker(0, 2)');
-window.getSelection().selectAllChildren(srcNode);
-document.execCommand('Copy');
</del><ins>+evalAndLog('document.execCommand("InsertText", false, "z")');
+evalAndLog('document.execCommand("InsertText", false, "z")');
+evalAndLog('document.execCommand("InsertText", false, " ")');
+evalAndLog('document.execCommand("InsertText", false, "a")');
+evalAndLog('document.execCommand("InsertText", false, "p")');
+evalAndLog('document.execCommand("InsertText", false, "p")');
+evalAndLog('document.execCommand("InsertText", false, "l")');
+evalAndLog('document.execCommand("InsertText", false, "e")');
</ins><span class="cx">
</span><del>-internals.setContinuousSpellCheckingEnabled(false);
</del><ins>+if (window.internals) {
+ shouldBecomeEqual('internals.hasSpellingMarker(0, 2)', 'true', function() {
+ window.getSelection().selectAllChildren(srcNode);
+ evalAndLog("document.execCommand('Copy')");
</ins><span class="cx">
</span><del>-document.execCommand('Paste');
-shouldBeFalse('internals.hasSpellingMarker(0, 2)');
</del><ins>+ evalAndLog("internals.setContinuousSpellCheckingEnabled(false)");
</ins><span class="cx">
</span><ins>+ var dstNode = document.getElementById('dst');
+ dstNode.focus();
+ evalAndLog("document.execCommand('Paste')");
+ shouldBecomeDifferent('internals.hasSpellingMarker(0, 2)', 'true', finishJSTest);
+ });
+}
+
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestseditingspellingspellcheckpastedisabledexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -3,11 +3,20 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS internals.hasSpellingMarker(0, 2) is true
-PASS internals.hasSpellingMarker(0, 2) is false
</del><ins>+document.execCommand("InsertText", false, "z")
+document.execCommand("InsertText", false, "z")
+document.execCommand("InsertText", false, " ")
+document.execCommand("InsertText", false, "a")
+document.execCommand("InsertText", false, "p")
+document.execCommand("InsertText", false, "p")
+document.execCommand("InsertText", false, "l")
+document.execCommand("InsertText", false, "e")
+PASS internals.hasSpellingMarker(0, 2) became true
+document.execCommand("Copy")
+document.execCommand("Paste")
+PASS internals.hasSpellingMarker(0, 2) became different from true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx"> zz apple
</span><del>-
</del><span class="cx"> zz apple
</span></span></pre></div>
<a id="trunkLayoutTestseditingspellingspellcheckpastedisabledhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled.html (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled.html 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/editing/spelling/spellcheck-paste-disabled.html 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <div>
</span><del>-<div id="src" contenteditable="true" spellcheck="true"></div><br/>
</del><ins>+<div id="src" contenteditable="true" spellcheck="true"></div>
</ins><span class="cx"> <div id="dst" contenteditable="true" spellcheck="false"></div>
</span><span class="cx"> </div>
</span><span class="cx"> <script language="javascript">
</span><span class="lines">@@ -14,26 +14,36 @@
</span><span class="cx"> 'To test manually, copy the text "zz apple" and paste it to the textarea. ' +
</span><span class="cx"> 'When "zz" is not marked as misspelled, this test succeeds.');
</span><span class="cx">
</span><del>-// Insert a misspelled word to initialize a spellchecker.
</del><ins>+jsTestIsAsync = true;
+
+if (window.internals) {
+ internals.settings.setUnifiedTextCheckerEnabled(true);
+ internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
</ins><span class="cx"> var srcNode = document.getElementById('src');
</span><span class="cx"> srcNode.focus();
</span><del>-document.execCommand("InsertText", false, 'z');
-document.execCommand("InsertText", false, 'z');
-document.execCommand("InsertText", false, ' ');
-document.execCommand("InsertText", false, 'a');
-document.execCommand("InsertText", false, 'p');
-document.execCommand("InsertText", false, 'p');
-document.execCommand("InsertText", false, 'l');
-document.execCommand("InsertText", false, 'e');
-shouldBeTrue('internals.hasSpellingMarker(0, 2)');
-window.getSelection().selectAllChildren(srcNode);
-document.execCommand('Copy');
</del><ins>+evalAndLog('document.execCommand("InsertText", false, "z")');
+evalAndLog('document.execCommand("InsertText", false, "z")');
+evalAndLog('document.execCommand("InsertText", false, " ")');
+evalAndLog('document.execCommand("InsertText", false, "a")');
+evalAndLog('document.execCommand("InsertText", false, "p")');
+evalAndLog('document.execCommand("InsertText", false, "p")');
+evalAndLog('document.execCommand("InsertText", false, "l")');
+evalAndLog('document.execCommand("InsertText", false, "e")');
</ins><span class="cx">
</span><del>-var dstNode = document.getElementById('dst');
-dstNode.focus();
-document.execCommand('Paste');
-shouldBeFalse('internals.hasSpellingMarker(0, 2)');
</del><ins>+if (window.internals) {
+ shouldBecomeEqual('internals.hasSpellingMarker(0, 2)', 'true', function() {
+ window.getSelection().selectAllChildren(srcNode);
+ evalAndLog('document.execCommand("Copy")');
</ins><span class="cx">
</span><ins>+ var dstNode = document.getElementById('dst');
+ dstNode.focus();
+ evalAndLog('document.execCommand("Paste")');
+ shouldBecomeDifferent('internals.hasSpellingMarker(0, 2)', 'true', finishJSTest);
+ });
+}
+
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (163528 => 163529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2014-02-06 10:05:00 UTC (rev 163528)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2014-02-06 10:50:58 UTC (rev 163529)
</span><span class="lines">@@ -890,6 +890,7 @@
</span><span class="cx"> webkit.org/b/84338 editing/pasteboard/testcase-9507.html [ Failure ]
</span><span class="cx"> webkit.org/b/84338 editing/spelling/spellcheck-async-mutation.html [ Failure ]
</span><span class="cx"> webkit.org/b/84338 editing/spelling/spellcheck-queue.html [ Failure ]
</span><ins>+webkit.org/b/84338 editing/spelling/spellcheck-paste-continuous-disabled.html [ Failure ]
</ins><span class="cx"> webkit.org/b/84338 editing/spelling/spellcheck-paste-disabled.html [ Failure ]
</span><span class="cx"> webkit.org/b/84338 editing/spelling/spellcheck-paste.html [ Failure ]
</span><span class="cx"> webkit.org/b/84338 editing/style/apply-through-end-of-document.html [ Failure ]
</span></span></pre>
</div>
</div>
</body>
</html>