<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163302] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163302">163302</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-03 05:54:32 -0800 (Mon, 03 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] Fix selection and hover effect of content in region with overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=127101
Patch by Mihai Maerean <mmaerean@adobe.com> on 2014-02-03
Reviewed by Mihnea Ovidenie.
Source/WebCore:
RenderNamedFlowFragments are not hit candidates. The hit test algorithm will pick the
parent layer, the one of the region.
Test: fast/regions/hover-overflow-hidden.html
* rendering/RenderLayer.cpp:
(WebCore::isHitCandidate):
LayoutTests:
* fast/regions/hover-overflow-hidden.html: Added.
* fast/regions/hover-overflow-hidden-expected.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionshoveroverflowhiddenexpectedhtml">trunk/LayoutTests/fast/regions/hover-overflow-hidden-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionshoveroverflowhiddenhtml">trunk/LayoutTests/fast/regions/hover-overflow-hidden.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (163301 => 163302)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-03 13:43:36 UTC (rev 163301)
+++ trunk/LayoutTests/ChangeLog 2014-02-03 13:54:32 UTC (rev 163302)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-02-03 Mihai Maerean <mmaerean@adobe.com>
+
+ [CSS Regions] Fix selection and hover effect of content in region with overflow:hidden
+ https://bugs.webkit.org/show_bug.cgi?id=127101
+
+ Reviewed by Mihnea Ovidenie.
+
+ * fast/regions/hover-overflow-hidden.html: Added.
+ * fast/regions/hover-overflow-hidden-expected.html: Added.
+
</ins><span class="cx"> 2014-02-02 Maciej Stachowiak <mjs@apple.com>
</span><span class="cx">
</span><span class="cx"> Adopt URLUtils interface and template in HTMLAnchorElement and HTMLAreaElement
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoveroverflowhiddenexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-overflow-hidden-expected.html (0 => 163302)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-overflow-hidden-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-overflow-hidden-expected.html 2014-02-03 13:54:32 UTC (rev 163302)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+ <title>Expected result - Bug 127101: [CSS Regions] Fix selection and hover effect of content in region with overflow:hidden</title>
+ <style>
+ .content {
+ margin: 10px;
+ box-shadow: 0px 0px 0px 10px Green;
+ }
+ body {
+ margin: 0;
+ padding: 0;
+ }
+ </style>
+</head>
+<body>
+ <div class="content">hover me</div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoveroverflowhiddenhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-overflow-hidden.html (0 => 163302)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-overflow-hidden.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-overflow-hidden.html 2014-02-03 13:54:32 UTC (rev 163302)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+ <title>Test - Bug 127101: [CSS Regions] Fix selection and hover effect of content in region with overflow:hidden</title>
+ <style>
+ .content {
+ -webkit-flow-into: flow;
+ box-shadow: 0px 0px 0px 10px Red;
+ margin: 10px;
+ }
+ .content:hover {
+ box-shadow: 0px 0px 0px 10px Green;
+ }
+ .region {
+ -webkit-flow-from: flow;
+ overflow: hidden;
+ }
+ body {
+ margin: 0;
+ padding: 0;
+ }
+ </style>
+</head>
+<body>
+ <div class="content">hover me</div>
+ <div class="region">region</div>
+
+ <script type="text/javascript">
+ if (window.eventSender) {
+ var box = document.querySelector(".content").getBoundingClientRect();
+ window.eventSender.mouseMoveTo((box.right + box.left) / 2, (box.top + box.bottom) / 2);
+ }
+ </script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163301 => 163302)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-03 13:43:36 UTC (rev 163301)
+++ trunk/Source/WebCore/ChangeLog 2014-02-03 13:54:32 UTC (rev 163302)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-02-03 Mihai Maerean <mmaerean@adobe.com>
+
+ [CSS Regions] Fix selection and hover effect of content in region with overflow:hidden
+ https://bugs.webkit.org/show_bug.cgi?id=127101
+
+ Reviewed by Mihnea Ovidenie.
+
+ RenderNamedFlowFragments are not hit candidates. The hit test algorithm will pick the
+ parent layer, the one of the region.
+
+ Test: fast/regions/hover-overflow-hidden.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::isHitCandidate):
+
</ins><span class="cx"> 2014-02-02 Maciej Stachowiak <mjs@apple.com>
</span><span class="cx">
</span><span class="cx"> Adopt URLUtils interface and template in HTMLAnchorElement and HTMLAreaElement
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (163301 => 163302)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-03 13:43:36 UTC (rev 163301)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-03 13:54:32 UTC (rev 163302)
</span><span class="lines">@@ -4661,6 +4661,11 @@
</span><span class="cx"> {
</span><span class="cx"> if (!hitLayer)
</span><span class="cx"> return false;
</span><ins>+
+ // RenderNamedFlowFragments are not hit candidates. The hit test algorithm will pick the parent
+ // layer, the one of the region.
+ if (hitLayer->renderer().isRenderNamedFlowFragment())
+ return false;
</ins><span class="cx">
</span><span class="cx"> // The hit layer is depth-sorting with other layers, so just say that it was hit.
</span><span class="cx"> if (canDepthSort)
</span></span></pre>
</div>
</div>
</body>
</html>