<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163361] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163361">163361</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-02-03 20:13:54 -0800 (Mon, 03 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Need regression test to ensure that the debugger does not attempt to execute a bad script from its console.
<https://webkit.org/b/128121>
Reviewed by Geoffrey Garen.
Regression test for https://bugs.webkit.org/show_bug.cgi?id=127600.
* inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt: Added.
* inspector-protocol/debugger/breakpoint-condition-with-bad-script.html: Added.
- Sets up a breakpoint with a condition script. The condition script
will fail to parse with a syntax error.
I've tested that without the fix in http://trac.webkit.org/<a href="http://trac.webkit.org/projects/webkit/changeset/162752">r162752</a>,
this will crash the VM. With the fix, it works fine.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectorprotocoldebuggerbreakpointconditionwithbadscriptexpectedtxt">trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldebuggerbreakpointconditionwithbadscripthtml">trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (163360 => 163361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-04 04:08:25 UTC (rev 163360)
+++ trunk/LayoutTests/ChangeLog 2014-02-04 04:13:54 UTC (rev 163361)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-02-03 Mark Lam <mark.lam@apple.com>
+
+ Need regression test to ensure that the debugger does not attempt to execute a bad script from its console.
+ <https://webkit.org/b/128121>
+
+ Reviewed by Geoffrey Garen.
+
+ Regression test for https://bugs.webkit.org/show_bug.cgi?id=127600.
+
+ * inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt: Added.
+ * inspector-protocol/debugger/breakpoint-condition-with-bad-script.html: Added.
+ - Sets up a breakpoint with a condition script. The condition script
+ will fail to parse with a syntax error.
+ I've tested that without the fix in http://trac.webkit.org/r162752,
+ this will crash the VM. With the fix, it works fine.
+
</ins><span class="cx"> 2014-02-03 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r163018): Can’t scroll in <select> lists
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldebuggerbreakpointconditionwithbadscriptexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt (0 => 163361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt 2014-02-04 04:13:54 UTC (rev 163361)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+CONSOLE MESSAGE: line 9: SyntaxError: Unexpected keyword 'else'
+The debugger should not crash when executing a bad script for testing a breakpoint condition.
+
+Found breakpoint.js
+inside breakpointWithCondition a:(1) b:(2) a+b:(3)
+PASS: The VM should not crash.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldebuggerbreakpointconditionwithbadscripthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script.html (0 => 163361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script.html (rev 0)
+++ trunk/LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script.html 2014-02-04 04:13:54 UTC (rev 163361)
</span><span class="lines">@@ -0,0 +1,53 @@
</span><ins>+<html>
+<head>
+<script src="../../http/tests/inspector-protocol/resources/protocol-test.js"></script>
+<script src="resources/breakpoint.js"></script>
+<script>
+function test()
+{
+ InspectorTest.eventHandler["Debugger.scriptParsed"] = function(messageObject)
+ {
+ if (/resources\/breakpoint\.js$/.test(messageObject.params.url)) {
+ InspectorTest.log("Found breakpoint.js");
+ var breakpoint = {
+ location: {
+ scriptId: messageObject.params.scriptId,
+ lineNumber: 8,
+ columnNumber: 0
+ },
+ options: {
+ autoContinue: true,
+ condition: "else", // a bad script that should fail to parse.
+ action: [
+ {type: "log", data: "FAIL: The breakpoint action should not be executed if the condition had an exception."}
+ ]
+ }
+ };
+ InspectorTest.sendCommand("Debugger.setBreakpoint", breakpoint, InspectorTest.checkForError);
+ InspectorTest.sendCommand("Runtime.evaluate", {expression: "breakpointWithCondition(1,2)"}, function() {
+ InspectorTest.log("PASS: The VM should not crash.");
+ completeTest();
+ });
+ }
+ }
+
+ InspectorTest.eventHandler["Debugger.paused"] = function(messageObject)
+ {
+ InspectorTest.log("FAIL: Paused in debugger: reason = \"" + messageObject.params.reason + "\"");
+ completeTest();
+ }
+
+ function completeTest()
+ {
+ // Reset the pauseOnException state before ending the test.
+ InspectorTest.completeTest();
+ }
+
+ InspectorTest.sendCommand("Debugger.enable", {});
+}
+</script>
+</head>
+<body onload="runTest()">
+<p>The debugger should not crash when executing a bad script for testing a breakpoint condition.</p>
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>