<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163271] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163271">163271</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2014-02-02 13:56:15 -0800 (Sun, 02 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add some missing override keywords
https://bugs.webkit.org/show_bug.cgi?id=128082
Reviewed by Antti Koivisto.
* loader/DocumentThreadableLoader.h:
* loader/LinkLoader.h:
* loader/TextTrackLoader.h:
* xml/parser/XMLDocumentParser.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderDocumentThreadableLoaderh">trunk/Source/WebCore/loader/DocumentThreadableLoader.h</a></li>
<li><a href="#trunkSourceWebCoreloaderLinkLoaderh">trunk/Source/WebCore/loader/LinkLoader.h</a></li>
<li><a href="#trunkSourceWebCoreloaderTextTrackLoaderh">trunk/Source/WebCore/loader/TextTrackLoader.h</a></li>
<li><a href="#trunkSourceWebCorexmlparserXMLDocumentParserh">trunk/Source/WebCore/xml/parser/XMLDocumentParser.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163270 => 163271)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/ChangeLog 2014-02-02 21:56:15 UTC (rev 163271)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-02 Sam Weinig <sam@webkit.org>
+
+ Add some missing override keywords
+ https://bugs.webkit.org/show_bug.cgi?id=128082
+
+ Reviewed by Antti Koivisto.
+
+ * loader/DocumentThreadableLoader.h:
+ * loader/LinkLoader.h:
+ * loader/TextTrackLoader.h:
+ * xml/parser/XMLDocumentParser.h:
+
</ins><span class="cx"> 2014-02-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IDB: Support IDBFactory.deleteDatabase()
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderDocumentThreadableLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.h (163270 => 163271)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2014-02-02 21:56:15 UTC (rev 163271)
</span><span class="lines">@@ -78,11 +78,11 @@
</span><span class="cx"> void clearResource();
</span><span class="cx">
</span><span class="cx"> // CachedRawResourceClient
</span><del>- virtual void dataSent(CachedResource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
- virtual void responseReceived(CachedResource*, const ResourceResponse&);
- virtual void dataReceived(CachedResource*, const char* data, int dataLength);
- virtual void redirectReceived(CachedResource*, ResourceRequest&, const ResourceResponse&);
- virtual void notifyFinished(CachedResource*);
</del><ins>+ virtual void dataSent(CachedResource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
+ virtual void responseReceived(CachedResource*, const ResourceResponse&) override;
+ virtual void dataReceived(CachedResource*, const char* data, int dataLength) override;
+ virtual void redirectReceived(CachedResource*, ResourceRequest&, const ResourceResponse&) override;
+ virtual void notifyFinished(CachedResource*) override;
</ins><span class="cx">
</span><span class="cx"> void didReceiveResponse(unsigned long identifier, const ResourceResponse&);
</span><span class="cx"> void didReceiveData(unsigned long identifier, const char* data, int dataLength);
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderLinkLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/LinkLoader.h (163270 => 163271)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/LinkLoader.h 2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/LinkLoader.h 2014-02-02 21:56:15 UTC (rev 163271)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> virtual ~LinkLoader();
</span><span class="cx">
</span><span class="cx"> // from CachedResourceClient
</span><del>- virtual void notifyFinished(CachedResource*);
</del><ins>+ virtual void notifyFinished(CachedResource*) override;
</ins><span class="cx">
</span><span class="cx"> void released();
</span><span class="cx"> bool loadLink(const LinkRelAttribute&, const String& type, const String& sizes, const URL&, Document*);
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderTextTrackLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/TextTrackLoader.h (163270 => 163271)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/TextTrackLoader.h 2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/loader/TextTrackLoader.h 2014-02-02 21:56:15 UTC (rev 163271)
</span><span class="lines">@@ -71,15 +71,15 @@
</span><span class="cx"> private:
</span><span class="cx">
</span><span class="cx"> // CachedResourceClient
</span><del>- virtual void notifyFinished(CachedResource*);
- virtual void deprecatedDidReceiveCachedResource(CachedResource*);
</del><ins>+ virtual void notifyFinished(CachedResource*) override;
+ virtual void deprecatedDidReceiveCachedResource(CachedResource*) override;
</ins><span class="cx">
</span><span class="cx"> // WebVTTParserClient
</span><del>- virtual void newCuesParsed();
</del><ins>+ virtual void newCuesParsed() override;
</ins><span class="cx"> #if ENABLE(WEBVTT_REGIONS)
</span><del>- virtual void newRegionsParsed();
</del><ins>+ virtual void newRegionsParsed() override;
</ins><span class="cx"> #endif
</span><del>- virtual void fileFailedToParse();
</del><ins>+ virtual void fileFailedToParse() override;
</ins><span class="cx">
</span><span class="cx"> TextTrackLoader(TextTrackLoaderClient&, ScriptExecutionContext*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorexmlparserXMLDocumentParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.h (163270 => 163271)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2014-02-02 21:07:40 UTC (rev 163270)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2014-02-02 21:56:15 UTC (rev 163271)
</span><span class="lines">@@ -99,15 +99,15 @@
</span><span class="cx"> XMLDocumentParser(DocumentFragment&, Element*, ParserContentPolicy);
</span><span class="cx">
</span><span class="cx"> // From DocumentParser
</span><del>- virtual void insert(const SegmentedString&);
- virtual void append(PassRefPtr<StringImpl>);
- virtual void finish();
- virtual bool isWaitingForScripts() const;
- virtual void stopParsing();
- virtual void detach();
</del><ins>+ virtual void insert(const SegmentedString&) override;
+ virtual void append(PassRefPtr<StringImpl>) override;
+ virtual void finish() override;
+ virtual bool isWaitingForScripts() const override;
+ virtual void stopParsing() override;
+ virtual void detach() override;
</ins><span class="cx">
</span><span class="cx"> // from CachedResourceClient
</span><del>- virtual void notifyFinished(CachedResource*);
</del><ins>+ virtual void notifyFinished(CachedResource*) override;
</ins><span class="cx">
</span><span class="cx"> void end();
</span><span class="cx">
</span><span class="lines">@@ -116,7 +116,7 @@
</span><span class="cx">
</span><span class="cx"> bool appendFragmentSource(const String&);
</span><span class="cx">
</span><del>-public:
</del><ins>+ public:
</ins><span class="cx"> // callbacks from parser SAX
</span><span class="cx"> void error(XMLErrors::ErrorType, const char* message, va_list args) WTF_ATTRIBUTE_PRINTF(3, 0);
</span><span class="cx"> void startElementNs(const xmlChar* xmlLocalName, const xmlChar* xmlPrefix, const xmlChar* xmlURI, int nb_namespaces,
</span></span></pre>
</div>
</div>
</body>
</html>