<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163289] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163289">163289</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2014-02-02 23:52:38 -0800 (Sun, 02 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Obey "delete this" comments, including deleting String::characters and friends
https://bugs.webkit.org/show_bug.cgi?id=126865
Reviewed by Andreas Kling.
Source/WebCore:
* CMakeLists.txt: Deleted HTMLParserErrorCodes.cpp.
* GNUmakefile.list.am: Deleted HTMLParserErrorCodes.cpp/h, and HTMLParserQuirks.h.
* WebCore.vcxproj/WebCore.vcxproj: Deleted HTMLParserErrorCodes.cpp/h.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/HTMLParserErrorCodes.cpp: Removed.
* html/HTMLParserErrorCodes.h: Removed.
* html/HTMLParserQuirks.h: Removed.
* rendering/RenderText.h: Deleted the characters function, leaving behind the
deprecatedCharacters function.
Source/WTF:
* wtf/text/AtomicString.h: Deleted the characters function.
* wtf/text/StringBuilder.h: Deleted the characters function, leaving behind the
deprecatedCharacters function.
* wtf/text/StringImpl.h: Ditto.
* wtf/text/WTFString.h: Ditto. Also added a constructor that takes a StringImpl&,
helpful for later string refactoring.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextAtomicStringh">trunk/Source/WTF/wtf/text/AtomicString.h</a></li>
<li><a href="#trunkSourceWTFwtftextStringBuilderh">trunk/Source/WTF/wtf/text/StringBuilder.h</a></li>
<li><a href="#trunkSourceWTFwtftextStringImplh">trunk/Source/WTF/wtf/text/StringImpl.h</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreGNUmakefilelistam">trunk/Source/WebCore/GNUmakefile.list.am</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxproj">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTexth">trunk/Source/WebCore/rendering/RenderText.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorehtmlHTMLParserErrorCodescpp">trunk/Source/WebCore/html/HTMLParserErrorCodes.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLParserErrorCodesh">trunk/Source/WebCore/html/HTMLParserErrorCodes.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLParserQuirksh">trunk/Source/WebCore/html/HTMLParserQuirks.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WTF/ChangeLog 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-02-02 Darin Adler <darin@apple.com>
+
+ Obey "delete this" comments, including deleting String::characters and friends
+ https://bugs.webkit.org/show_bug.cgi?id=126865
+
+ Reviewed by Andreas Kling.
+
+ * wtf/text/AtomicString.h: Deleted the characters function.
+ * wtf/text/StringBuilder.h: Deleted the characters function, leaving behind the
+ deprecatedCharacters function.
+ * wtf/text/StringImpl.h: Ditto.
+ * wtf/text/WTFString.h: Ditto. Also added a constructor that takes a StringImpl&,
+ helpful for later string refactoring.
+
</ins><span class="cx"> 2014-02-02 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS”
</span></span></pre></div>
<a id="trunkSourceWTFwtftextAtomicStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/AtomicString.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/AtomicString.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -93,7 +93,6 @@
</span><span class="cx"> AtomicStringImpl* impl() const { return static_cast<AtomicStringImpl *>(m_string.impl()); }
</span><span class="cx">
</span><span class="cx"> bool is8Bit() const { return m_string.is8Bit(); }
</span><del>- const UChar* characters() const { return m_string.deprecatedCharacters(); } // FIXME: Delete this.
</del><span class="cx"> const LChar* characters8() const { return m_string.characters8(); }
</span><span class="cx"> const UChar* characters16() const { return m_string.characters16(); }
</span><span class="cx"> unsigned length() const { return m_string.length(); }
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringBuilder.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringBuilder.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WTF/wtf/text/StringBuilder.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -248,7 +248,6 @@
</span><span class="cx"> return m_buffer->characters16();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const UChar* characters() const { return deprecatedCharacters(); } // FIXME: Delete this.
</del><span class="cx"> const UChar* deprecatedCharacters() const
</span><span class="cx"> {
</span><span class="cx"> if (!m_length)
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringImpl.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringImpl.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -452,7 +452,6 @@
</span><span class="cx">
</span><span class="cx"> ALWAYS_INLINE const LChar* characters8() const { ASSERT(is8Bit()); return m_data8; }
</span><span class="cx"> ALWAYS_INLINE const UChar* characters16() const { ASSERT(!is8Bit()); return m_data16; }
</span><del>- const UChar* characters() const { return deprecatedCharacters(); } // FIXME: Delete this.
</del><span class="cx"> ALWAYS_INLINE const UChar* deprecatedCharacters() const
</span><span class="cx"> {
</span><span class="cx"> if (!is8Bit())
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -112,6 +112,7 @@
</span><span class="cx"> WTF_EXPORT_STRING_API String(const char* characters);
</span><span class="cx">
</span><span class="cx"> // Construct a string referencing an existing StringImpl.
</span><ins>+ String(StringImpl& impl) : m_impl(&impl) { }
</ins><span class="cx"> String(StringImpl* impl) : m_impl(impl) { }
</span><span class="cx"> String(PassRefPtr<StringImpl> impl) : m_impl(impl) { }
</span><span class="cx"> String(PassRef<StringImpl> impl) : m_impl(std::move(impl)) { }
</span><span class="lines">@@ -156,7 +157,6 @@
</span><span class="cx"> return m_impl->length();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const UChar* characters() const { return deprecatedCharacters(); } // FIXME: Delete this.
</del><span class="cx"> const UChar* deprecatedCharacters() const
</span><span class="cx"> {
</span><span class="cx"> if (!m_impl)
</span></span></pre></div>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1423,7 +1423,6 @@
</span><span class="cx"> html/HTMLOutputElement.cpp
</span><span class="cx"> html/HTMLParagraphElement.cpp
</span><span class="cx"> html/HTMLParamElement.cpp
</span><del>- html/HTMLParserErrorCodes.cpp
</del><span class="cx"> html/HTMLPlugInElement.cpp
</span><span class="cx"> html/HTMLPlugInImageElement.cpp
</span><span class="cx"> html/HTMLPreElement.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/ChangeLog 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-02-02 Darin Adler <darin@apple.com>
+
+ Obey "delete this" comments, including deleting String::characters and friends
+ https://bugs.webkit.org/show_bug.cgi?id=126865
+
+ Reviewed by Andreas Kling.
+
+ * CMakeLists.txt: Deleted HTMLParserErrorCodes.cpp.
+ * GNUmakefile.list.am: Deleted HTMLParserErrorCodes.cpp/h, and HTMLParserQuirks.h.
+ * WebCore.vcxproj/WebCore.vcxproj: Deleted HTMLParserErrorCodes.cpp/h.
+ * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+
+ * html/HTMLParserErrorCodes.cpp: Removed.
+ * html/HTMLParserErrorCodes.h: Removed.
+ * html/HTMLParserQuirks.h: Removed.
+
+ * rendering/RenderText.h: Deleted the characters function, leaving behind the
+ deprecatedCharacters function.
+
</ins><span class="cx"> 2014-02-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IDB: Cannot open new databases with the default version
</span></span></pre></div>
<a id="trunkSourceWebCoreGNUmakefilelistam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/GNUmakefile.list.am (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/GNUmakefile.list.am 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -3468,9 +3468,6 @@
</span><span class="cx"> Source/WebCore/html/HTMLParagraphElement.h \
</span><span class="cx"> Source/WebCore/html/HTMLParamElement.cpp \
</span><span class="cx"> Source/WebCore/html/HTMLParamElement.h \
</span><del>- Source/WebCore/html/HTMLParserErrorCodes.cpp \
- Source/WebCore/html/HTMLParserErrorCodes.h \
- Source/WebCore/html/HTMLParserQuirks.h \
</del><span class="cx"> Source/WebCore/html/HTMLPlugInElement.cpp \
</span><span class="cx"> Source/WebCore/html/HTMLPlugInElement.h \
</span><span class="cx"> Source/WebCore/html/HTMLPlugInImageElement.cpp \
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -15267,7 +15267,6 @@
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\html\HTMLParserErrorCodes.cpp" />
</del><span class="cx"> <ClCompile Include="..\html\HTMLPlugInElement.cpp">
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
</span><span class="lines">@@ -20384,7 +20383,6 @@
</span><span class="cx"> <ClInclude Include="..\html\HTMLOutputElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLParagraphElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLParamElement.h" />
</span><del>- <ClInclude Include="..\html\HTMLParserErrorCodes.h" />
</del><span class="cx"> <ClInclude Include="..\html\HTMLPlugInElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLPlugInImageElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLPreElement.h" />
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -3882,9 +3882,6 @@
</span><span class="cx"> <ClCompile Include="..\html\HTMLParamElement.cpp">
</span><span class="cx"> <Filter>html</Filter>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\html\HTMLParserErrorCodes.cpp">
- <Filter>html</Filter>
- </ClCompile>
</del><span class="cx"> <ClCompile Include="..\html\HTMLPlugInElement.cpp">
</span><span class="cx"> <Filter>html</Filter>
</span><span class="cx"> </ClCompile>
</span><span class="lines">@@ -10901,9 +10898,6 @@
</span><span class="cx"> <ClInclude Include="..\html\HTMLParamElement.h">
</span><span class="cx"> <Filter>html</Filter>
</span><span class="cx"> </ClInclude>
</span><del>- <ClInclude Include="..\html\HTMLParserErrorCodes.h">
- <Filter>html</Filter>
- </ClInclude>
</del><span class="cx"> <ClInclude Include="..\html\HTMLPlugInElement.h">
</span><span class="cx"> <Filter>html</Filter>
</span><span class="cx"> </ClInclude>
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1495,7 +1495,6 @@
</span><span class="cx"> 4496E39E1398136C003EE32A /* JSSVGAnimateMotionElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 4496E39C1398136C003EE32A /* JSSVGAnimateMotionElement.h */; };
</span><span class="cx"> 4496E3A0139813A5003EE32A /* JSSVGMPathElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 4496E39F139813A5003EE32A /* JSSVGMPathElement.h */; };
</span><span class="cx"> 4496E3A2139813CB003EE32A /* JSSVGMPathElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4496E3A1139813CB003EE32A /* JSSVGMPathElement.cpp */; };
</span><del>- 449B19F50FA72ECE0015CA4A /* HTMLParserQuirks.h in Headers */ = {isa = PBXBuildFile; fileRef = 449B19F30FA72ECE0015CA4A /* HTMLParserQuirks.h */; settings = {ATTRIBUTES = (Private, ); }; };
</del><span class="cx"> 44A20DB90F84166C00B3E1FE /* WebCoreURLResponseIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 44A20DB80F84166C00B3E1FE /* WebCoreURLResponseIOS.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 44A28AAC12DFB8AC00AE923B /* MathMLElementFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 44A28AAB12DFB8AC00AE923B /* MathMLElementFactory.h */; };
</span><span class="cx"> 44A28AAF12DFB8BF00AE923B /* MathMLNames.h in Headers */ = {isa = PBXBuildFile; fileRef = 44A28AAE12DFB8BF00AE923B /* MathMLNames.h */; };
</span><span class="lines">@@ -4979,8 +4978,6 @@
</span><span class="cx"> BC53DA62114314BD000D817E /* DOMObjectHashTableMap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC53DA61114314BD000D817E /* DOMObjectHashTableMap.cpp */; };
</span><span class="cx"> BC5823F50C0A98DF0053F1B5 /* JSHTMLElementCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC5823F40C0A98DF0053F1B5 /* JSHTMLElementCustom.cpp */; };
</span><span class="cx"> BC5825F30C0B89380053F1B5 /* JSCSSStyleDeclarationCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC5825F20C0B89380053F1B5 /* JSCSSStyleDeclarationCustom.cpp */; };
</span><del>- BC588AF00BFA6CF900EE679E /* HTMLParserErrorCodes.h in Headers */ = {isa = PBXBuildFile; fileRef = BC588AEF0BFA6CF900EE679E /* HTMLParserErrorCodes.h */; };
- BC588B4B0BFA723C00EE679E /* HTMLParserErrorCodes.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC588B4A0BFA723C00EE679E /* HTMLParserErrorCodes.cpp */; };
</del><span class="cx"> BC5A12DF0DC0414800C9AFAD /* CSSReflectValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC5A12DD0DC0414800C9AFAD /* CSSReflectValue.cpp */; };
</span><span class="cx"> BC5A12E00DC0414800C9AFAD /* CSSReflectValue.h in Headers */ = {isa = PBXBuildFile; fileRef = BC5A12DE0DC0414800C9AFAD /* CSSReflectValue.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> BC5A86840C33676000EEA649 /* DOMSelection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC5A86810C33676000EEA649 /* DOMSelection.cpp */; };
</span><span class="lines">@@ -8361,7 +8358,6 @@
</span><span class="cx"> 4496E39C1398136C003EE32A /* JSSVGAnimateMotionElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSSVGAnimateMotionElement.h; sourceTree = "<group>"; };
</span><span class="cx"> 4496E39F139813A5003EE32A /* JSSVGMPathElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSSVGMPathElement.h; sourceTree = "<group>"; };
</span><span class="cx"> 4496E3A1139813CB003EE32A /* JSSVGMPathElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSSVGMPathElement.cpp; sourceTree = "<group>"; };
</span><del>- 449B19F30FA72ECE0015CA4A /* HTMLParserQuirks.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLParserQuirks.h; sourceTree = "<group>"; };
</del><span class="cx"> 44A20DB80F84166C00B3E1FE /* WebCoreURLResponseIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreURLResponseIOS.h; sourceTree = "<group>"; };
</span><span class="cx"> 44A28AAB12DFB8AC00AE923B /* MathMLElementFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MathMLElementFactory.h; sourceTree = "<group>"; };
</span><span class="cx"> 44A28AAE12DFB8BF00AE923B /* MathMLNames.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MathMLNames.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -12159,8 +12155,6 @@
</span><span class="cx"> BC53DA61114314BD000D817E /* DOMObjectHashTableMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMObjectHashTableMap.cpp; sourceTree = "<group>"; };
</span><span class="cx"> BC5823F40C0A98DF0053F1B5 /* JSHTMLElementCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLElementCustom.cpp; sourceTree = "<group>"; };
</span><span class="cx"> BC5825F20C0B89380053F1B5 /* JSCSSStyleDeclarationCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSCSSStyleDeclarationCustom.cpp; sourceTree = "<group>"; };
</span><del>- BC588AEF0BFA6CF900EE679E /* HTMLParserErrorCodes.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = HTMLParserErrorCodes.h; sourceTree = "<group>"; };
- BC588B4A0BFA723C00EE679E /* HTMLParserErrorCodes.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLParserErrorCodes.cpp; sourceTree = "<group>"; };
</del><span class="cx"> BC59DEF8169DEDC30016AC34 /* Settings.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = Settings.in; sourceTree = "<group>"; };
</span><span class="cx"> BC59DEFA169DEDD80016AC34 /* make_settings.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_settings.pl; sourceTree = "<group>"; };
</span><span class="cx"> BC5A12DD0DC0414800C9AFAD /* CSSReflectValue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSReflectValue.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -17300,9 +17294,6 @@
</span><span class="cx"> A871D44F0A127CBC00B12A68 /* HTMLParamElement.cpp */,
</span><span class="cx"> A871D44E0A127CBC00B12A68 /* HTMLParamElement.h */,
</span><span class="cx"> 1AE2AB720A1CE81500B42B25 /* HTMLParamElement.idl */,
</span><del>- BC588B4A0BFA723C00EE679E /* HTMLParserErrorCodes.cpp */,
- BC588AEF0BFA6CF900EE679E /* HTMLParserErrorCodes.h */,
- 449B19F30FA72ECE0015CA4A /* HTMLParserQuirks.h */,
</del><span class="cx"> A871D44D0A127CBC00B12A68 /* HTMLPlugInElement.cpp */,
</span><span class="cx"> A871D44C0A127CBC00B12A68 /* HTMLPlugInElement.h */,
</span><span class="cx"> 4415292D0E1AE8A000C4A2D0 /* HTMLPlugInImageElement.cpp */,
</span><span class="lines">@@ -23820,11 +23811,9 @@
</span><span class="cx"> 51D719F8181106E00016DC51 /* IndexedDB.h in Headers */,
</span><span class="cx"> A8EA7CB50A192B9C00A8EF5F /* HTMLParagraphElement.h in Headers */,
</span><span class="cx"> A871D4580A127CBC00B12A68 /* HTMLParamElement.h in Headers */,
</span><del>- BC588AF00BFA6CF900EE679E /* HTMLParserErrorCodes.h in Headers */,
</del><span class="cx"> B59ED23B18272679006D564C /* RenderAncestorIterator.h in Headers */,
</span><span class="cx"> 93E2A307123E9DC0009FE12A /* HTMLParserIdioms.h in Headers */,
</span><span class="cx"> 973F418A169B95FF0006BF60 /* HTMLParserOptions.h in Headers */,
</span><del>- 449B19F50FA72ECE0015CA4A /* HTMLParserQuirks.h in Headers */,
</del><span class="cx"> 073BE34B17D17E7A002BD431 /* JSNavigatorUserMediaErrorCallback.h in Headers */,
</span><span class="cx"> 977B3871122883E900B81FF8 /* HTMLParserScheduler.h in Headers */,
</span><span class="cx"> A871D4560A127CBC00B12A68 /* HTMLPlugInElement.h in Headers */,
</span><span class="lines">@@ -27164,7 +27153,6 @@
</span><span class="cx"> 4AD01008127E642A0015035F /* HTMLOutputElement.cpp in Sources */,
</span><span class="cx"> A8EA7CB20A192B9C00A8EF5F /* HTMLParagraphElement.cpp in Sources */,
</span><span class="cx"> A871D4590A127CBC00B12A68 /* HTMLParamElement.cpp in Sources */,
</span><del>- BC588B4B0BFA723C00EE679E /* HTMLParserErrorCodes.cpp in Sources */,
</del><span class="cx"> 93E2A306123E9DC0009FE12A /* HTMLParserIdioms.cpp in Sources */,
</span><span class="cx"> 973F418B169B96030006BF60 /* HTMLParserOptions.cpp in Sources */,
</span><span class="cx"> 977B3870122883E900B81FF8 /* HTMLParserScheduler.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLParserErrorCodescpp"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/html/HTMLParserErrorCodes.cpp (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLParserErrorCodes.cpp 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/html/HTMLParserErrorCodes.cpp 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1,28 +0,0 @@
</span><del>-/*
- * Copyright (C) 2007 Apple Computer, Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-// FIXME: Delete this file.
</del></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLParserErrorCodesh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/html/HTMLParserErrorCodes.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLParserErrorCodes.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/html/HTMLParserErrorCodes.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1,26 +0,0 @@
</span><del>-/*
- * Copyright (C) 2007 Apple Computer, Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-// FIXME: Delete this file.
</del></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLParserQuirksh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/html/HTMLParserQuirks.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLParserQuirks.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/html/HTMLParserQuirks.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -1,26 +0,0 @@
</span><del>-/*
- * Copyright (C) 2009 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-// FIXME: Delete this file.
</del></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderText.h (163288 => 163289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderText.h 2014-02-03 07:31:40 UTC (rev 163288)
+++ trunk/Source/WebCore/rendering/RenderText.h 2014-02-03 07:52:38 UTC (rev 163289)
</span><span class="lines">@@ -74,11 +74,10 @@
</span><span class="cx">
</span><span class="cx"> virtual VisiblePosition positionForPoint(const LayoutPoint&) override;
</span><span class="cx">
</span><del>- bool is8Bit() const { return m_text.is8Bit(); }
</del><ins>+ bool is8Bit() const { return m_text.impl()->is8Bit(); }
</ins><span class="cx"> const LChar* characters8() const { return m_text.impl()->characters8(); }
</span><span class="cx"> const UChar* characters16() const { return m_text.impl()->characters16(); }
</span><del>- const UChar* characters() const { return deprecatedCharacters(); } // FIXME: Delete this.
- const UChar* deprecatedCharacters() const { return m_text.deprecatedCharacters(); }
</del><ins>+ const UChar* deprecatedCharacters() const { return m_text.impl()->deprecatedCharacters(); }
</ins><span class="cx"> UChar characterAt(unsigned i) const { return is8Bit() ? characters8()[i] : characters16()[i]; }
</span><span class="cx"> UChar operator[](unsigned i) const { return characterAt(i); }
</span><span class="cx"> unsigned textLength() const { return m_text.impl()->length(); } // non virtual implementation of length()
</span></span></pre>
</div>
</div>
</body>
</html>