<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163238] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163238">163238</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-01 00:05:21 -0800 (Sat, 01 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=128028
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-31
Reviewed by Anders Carlsson.
.:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/WebCore:
The code is incorrect and was only supported by Nix.
* dom/Document.cpp:
(WebCore::Document::childrenChanged):
* dom/ViewportArguments.h:
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):
Source/WTF:
* wtf/FeatureDefines.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfFeatureDefinesh">trunk/Source/WTF/wtf/FeatureDefines.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomViewportArgumentsh">trunk/Source/WebCore/dom/ViewportArguments.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMetaElementcpp">trunk/Source/WebCore/html/HTMLMetaElement.cpp</a></li>
<li><a href="#trunkSourcecmakeWebKitFeaturescmake">trunk/Source/cmake/WebKitFeatures.cmake</a></li>
<li><a href="#trunkSourcecmakeconfighcmake">trunk/Source/cmakeconfig.h.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-31 Benjamin Poulain <bpoulain@apple.com>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ * Source/cmake/WebKitFeatures.cmake:
+ * Source/cmakeconfig.h.cmake:
+
</ins><span class="cx"> 2014-01-31 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> Rollout r163195 and related patches
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WTF/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-01-31 Benjamin Poulain <bpoulain@apple.com>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ * wtf/FeatureDefines.h:
+
</ins><span class="cx"> 2014-01-31 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
</span></span></pre></div>
<a id="trunkSourceWTFwtfFeatureDefinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/FeatureDefines.h (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -590,10 +590,6 @@
</span><span class="cx"> #define ENABLE_LEGACY_VENDOR_PREFIXES 0
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if !defined(ENABLE_LEGACY_VIEWPORT_ADAPTION)
-#define ENABLE_LEGACY_VIEWPORT_ADAPTION 0
-#endif
-
</del><span class="cx"> #if !defined(ENABLE_LETTERPRESS)
</span><span class="cx"> #define ENABLE_LETTERPRESS 0
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/ChangeLog 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-31 Benjamin Poulain <bpoulain@apple.com>
+
+ Remove LEGACY_VIEWPORT_ADAPTION
+ https://bugs.webkit.org/show_bug.cgi?id=128028
+
+ Reviewed by Anders Carlsson.
+
+ The code is incorrect and was only supported by Nix.
+
+ * dom/Document.cpp:
+ (WebCore::Document::childrenChanged):
+ * dom/ViewportArguments.h:
+ * html/HTMLMetaElement.cpp:
+ (WebCore::HTMLMetaElement::process):
+
</ins><span class="cx"> 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Release build fix after r163234. Don't always export the symbol that doesn't exist under NDEBUG.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -794,21 +794,7 @@
</span><span class="cx"> {
</span><span class="cx"> ContainerNode::childrenChanged(change);
</span><span class="cx">
</span><del>- // NOTE: Per DOM, dynamically inserting/removing doctype nodes doesn't affect compatibility mode.
-
-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- // FIXME: It's a little strange to add these rules when a DocumentType with this prefix is added,
- // but not remove these rules when a DocumentType with this prefix is removed. It seems this should
- // be handled more the way the compatibility mode is, by fetching the doctype at the appropriate time,
- // rather than by responding when a document type node is inserted.
- if (DocumentType* documentType = doctype()) {
- if (documentType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.", /* caseSensitive */ false))
- processViewport("width=device-width, height=device-height", ViewportArguments::XHTMLMobileProfile);
- }
-#endif
-
</del><span class="cx"> Element* newDocumentElement = childrenOfType<Element>(*this).first();
</span><del>-
</del><span class="cx"> if (newDocumentElement == m_documentElement)
</span><span class="cx"> return;
</span><span class="cx"> m_documentElement = newDocumentElement;
</span></span></pre></div>
<a id="trunkSourceWebCoredomViewportArgumentsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ViewportArguments.h (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ViewportArguments.h 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -58,11 +58,6 @@
</span><span class="cx"> enum Type {
</span><span class="cx"> // These are ordered in increasing importance.
</span><span class="cx"> Implicit,
</span><del>-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- XHTMLMobileProfile,
- HandheldFriendlyMeta,
- MobileOptimizedMeta,
-#endif
</del><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> PluginDocument,
</span><span class="cx"> ImageDocument,
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMetaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMetaElement.cpp (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMetaElement.cpp 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/WebCore/html/HTMLMetaElement.cpp 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -81,12 +81,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> else if (equalIgnoringCase(name(), "referrer"))
</span><span class="cx"> document().processReferrerPolicy(contentValue);
</span><del>-#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
- else if (equalIgnoringCase(name(), "handheldfriendly") && equalIgnoringCase(contentValue, "true"))
- document().processViewport("width=device-width", ViewportArguments::HandheldFriendlyMeta);
- else if (equalIgnoringCase(name(), "mobileoptimized"))
- document().processViewport("width=device-width, initial-scale=1", ViewportArguments::MobileOptimizedMeta);
-#endif
</del><span class="cx">
</span><span class="cx"> // Get the document to process the tag, but only if we're actually part of DOM tree (changing a meta tag while
</span><span class="cx"> // it's not in the tree shouldn't have any effect on the document)
</span></span></pre></div>
<a id="trunkSourcecmakeWebKitFeaturescmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/WebKitFeatures.cmake (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/WebKitFeatures.cmake 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -71,7 +71,6 @@
</span><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_INSPECTOR "Toggle Web Inspector support" ON)
</span><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_JIT "Enable JustInTime javascript support" ON)
</span><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_NOTIFICATIONS "Toggle Legacy Desktop Notifications Support" OFF)
</span><del>- WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toggle legacy viewport adaption" OFF)
</del><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VENDOR_PREFIXES "Toggle Legacy Vendor Prefix Support" ON)
</span><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEB_AUDIO "Toggle Legacy Web Audio support" ON)
</span><span class="cx"> WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH "Toggle pre fetching support" OFF)
</span></span></pre></div>
<a id="trunkSourcecmakeconfighcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmakeconfig.h.cmake (163237 => 163238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmakeconfig.h.cmake 2014-02-01 07:04:18 UTC (rev 163237)
+++ trunk/Source/cmakeconfig.h.cmake 2014-02-01 08:05:21 UTC (rev 163238)
</span><span class="lines">@@ -62,7 +62,6 @@
</span><span class="cx"> #cmakedefine01 ENABLE_INSPECTOR
</span><span class="cx"> #cmakedefine01 ENABLE_JIT
</span><span class="cx"> #cmakedefine01 ENABLE_LEGACY_NOTIFICATIONS
</span><del>-#cmakedefine01 ENABLE_LEGACY_VIEWPORT_ADAPTION
</del><span class="cx"> #cmakedefine01 ENABLE_LEGACY_VENDOR_PREFIXES
</span><span class="cx"> #cmakedefine01 ENABLE_LEGACY_WEB_AUDIO
</span><span class="cx"> #cmakedefine01 ENABLE_LINK_PREFETCH
</span></span></pre>
</div>
</div>
</body>
</html>