<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[163157] trunk/Source/WebCore</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163157">163157</a></dd>

<dt>Author</dt> <dd>simon.fraser@apple.com</dd>

<dt>Date</dt> <dd>2014-01-30 21:42:25 -0800 (Thu, 30 Jan 2014)</dd>

</dl>

<h3>Log Message</h3>

<pre>Some fixed position elements disappear in WK2 on iOS

https://bugs.webkit.org/show_bug.cgi?id=127977

Reviewed by Tim Horton.

Use the appropriate rectangle to ensure that on iOS we don't

consider a fixed element outside the viewport when zoomed in,

and therefore never make a compositing layer for it.

Also remove the iOS-specific code in RenderLayerCompositor::requiresCompositingForPosition(),

since it's OK to use the common code. Doing so requires that we

set the &quot;acceleratedCompositingForFixedPositionEnabled&quot; setting to true

for iOS, so do so.

* page/Settings.cpp:

* page/Settings.in:

* rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCorepageSettingscpp">trunk/Source/WebCore/page/Settings.cpp</a></li>

<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>

<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163156 => 163157)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-01-31 05:41:46 UTC (rev 163156)

+++ trunk/Source/WebCore/ChangeLog        2014-01-31 05:42:25 UTC (rev 163157)

</span><span class="lines">@@ -1,3 +1,24 @@

</span><ins>+2014-01-30  Simon Fraser  &lt;simon.fraser@apple.com&gt;

+

+        Some fixed position elements disappear in WK2 on iOS

+        https://bugs.webkit.org/show_bug.cgi?id=127977

+

+        Reviewed by Tim Horton.

+

+        Use the appropriate rectangle to ensure that on iOS we don't 

+        consider a fixed element outside the viewport when zoomed in,

+        and therefore never make a compositing layer for it.

+

+        Also remove the iOS-specific code in RenderLayerCompositor::requiresCompositingForPosition(),

+        since it's OK to use the common code. Doing so requires that we

+        set the &quot;acceleratedCompositingForFixedPositionEnabled&quot; setting to true

+        for iOS, so do so.

+

+        * page/Settings.cpp:

+        * page/Settings.in:

+        * rendering/RenderLayerCompositor.cpp:

+        (WebCore::RenderLayerCompositor::requiresCompositingForPosition):

+

</ins><span class="cx"> 2014-01-30  Zalan Bujtas  &lt;zalan@apple.com&gt;

</span><span class="cx"> 

<span class="cx">         Subpixel rendering: Make RoundedRect layout unit aware.

</span></span></pre></div>

<a id="trunkSourceWebCorepageSettingscpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.cpp (163156 => 163157)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/page/Settings.cpp        2014-01-31 05:41:46 UTC (rev 163156)

+++ trunk/Source/WebCore/page/Settings.cpp        2014-01-31 05:42:25 UTC (rev 163157)

</span><span class="lines">@@ -124,11 +124,13 @@

</span><span class="cx"> 

</span><span class="cx"> #if PLATFORM(IOS)

</span><span class="cx"> static const bool defaultFixedPositionCreatesStackingContext = true;

</span><ins>+static const bool defaultAcceleratedCompositingForFixedPositionEnabled = true;

</ins><span class="cx"> static const bool defaultMediaPlaybackAllowsInline = false;

</span><span class="cx"> static const bool defaultMediaPlaybackRequiresUserGesture = true;

</span><span class="cx"> static const bool defaultShouldRespectImageOrientation = true;

</span><span class="cx"> #else

</span><span class="cx"> static const bool defaultFixedPositionCreatesStackingContext = false;

</span><ins>+static const bool defaultAcceleratedCompositingForFixedPositionEnabled = false;

</ins><span class="cx"> static const bool defaultMediaPlaybackAllowsInline = true;

</span><span class="cx"> static const bool defaultMediaPlaybackRequiresUserGesture = false;

</span><span class="cx"> static const bool defaultShouldRespectImageOrientation = false;

</span></span></pre></div>

<a id="trunkSourceWebCorepageSettingsin"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (163156 => 163157)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/page/Settings.in        2014-01-31 05:41:46 UTC (rev 163156)

+++ trunk/Source/WebCore/page/Settings.in        2014-01-31 05:42:25 UTC (rev 163157)

</span><span class="lines">@@ -95,7 +95,7 @@

</span><span class="cx"> 

</span><span class="cx"> xssAuditorEnabled initial=false

</span><span class="cx"> unsafePluginPastingEnabled initial=true

</span><del>-acceleratedCompositingForFixedPositionEnabled initial=false

</del><ins>+acceleratedCompositingForFixedPositionEnabled initial=defaultAcceleratedCompositingForFixedPositionEnabled

</ins><span class="cx"> acceleratedCompositingForOverflowScrollEnabled initial=false

</span><span class="cx"> 

<span class="cx"> # Works only in conjunction with forceCompositingMode.

</span></span></pre></div>

<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (163156 => 163157)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp        2014-01-31 05:41:46 UTC (rev 163156)

+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp        2014-01-31 05:42:25 UTC (rev 163157)

</span><span class="lines">@@ -2495,24 +2495,9 @@

</span><span class="cx"> 

</span><span class="cx"> bool RenderLayerCompositor::requiresCompositingForPosition(RenderLayerModelObject&amp; renderer, const RenderLayer&amp; layer, RenderLayer::ViewportConstrainedNotCompositedReason* viewportConstrainedNotCompositedReason) const

</span><span class="cx"> {

</span><del>-#if PLATFORM(IOS)

-    if (renderer.isStickyPositioned())

-        return true;

-

</del><span class="cx">     // position:fixed elements that create their own stacking context (e.g. have an explicit z-index,

</span><span class="cx">     // opacity, transform) can get their own composited layer. A stacking context is required otherwise

<span class="cx">     // z-index and clipping will be broken.

</span><del>-    if (!(renderer.isOutOfFlowPositioned() &amp;&amp; renderer.style().position() == FixedPosition))

-        return false;

-

-    if (!m_renderView.hasCustomFixedPosition(renderer, RenderView::CheckContainingBlock)) {

-        m_reevaluateCompositingAfterLayout = true;

-        return false;

-    }

-#else

-    // position:fixed elements that create their own stacking context (e.g. have an explicit z-index,

-    // opacity, transform) can get their own composited layer. A stacking context is required otherwise

-    // z-index and clipping will be broken.

</del><span class="cx">     if (!renderer.isPositioned())

</span><span class="cx">         return false;

</span><span class="cx">     

</span><span class="lines">@@ -2532,7 +2517,6 @@

</span><span class="cx"> 

</span><span class="cx">     if (isSticky)

</span><span class="cx">         return hasCoordinatedScrolling() &amp;&amp; isViewportConstrainedFixedOrStickyLayer(layer);

</span><del>-#endif

</del><span class="cx"> 

</span><span class="cx">     auto container = renderer.container();

<span class="cx">     // If the renderer is not hooked up yet then we have to wait until it is.

</span><span class="lines">@@ -2563,7 +2547,7 @@

</span><span class="cx">     }

</span><span class="cx"> 

<span class="cx">     // Fixed position elements that are invisible in the current view don't get their own layer.

</span><del>-    LayoutRect viewBounds = m_renderView.frameView().viewportConstrainedVisibleContentRect();

</del><ins>+    LayoutRect viewBounds = m_renderView.frameView().viewportConstrainedExtentRect();

</ins><span class="cx">     LayoutRect layerBounds = layer.calculateLayerBounds(&amp;layer, 0, RenderLayer::UseLocalClipRectIfPossible | RenderLayer::IncludeLayerFilterOutsets | RenderLayer::UseFragmentBoxes

</span><span class="cx">         | RenderLayer::ExcludeHiddenDescendants | RenderLayer::DontConstrainForMask | RenderLayer::IncludeCompositedDescendants);

<span class="cx">     // Map to m_renderView to ignore page scale.

</span></span></pre>

</div>

</div>

</body>

</html>