<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163102] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163102">163102</a></dd>
<dt>Author</dt> <dd>jer.noble@apple.com</dd>
<dt>Date</dt> <dd>2014-01-30 12:44:42 -0800 (Thu, 30 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[MediaControls][iOS] Fix a couple of UI bugs in the iOS Media Controls
https://bugs.webkit.org/show_bug.cgi?id=127929
Reviewed by Eric Carlson.
Two UI bugs in the iOS Media Controls: the text in the controls should use the apple
system font rather than the webkit small control font, and the buttons in the controls
are clipped due to an "off by one" error when calculating the SVG image dimensions.
* Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls):
(audio::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-time-remaining-display):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163101 => 163102)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-30 20:43:04 UTC (rev 163101)
+++ trunk/Source/WebCore/ChangeLog 2014-01-30 20:44:42 UTC (rev 163102)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-01-30 Jer Noble <jer.noble@apple.com>
+
+ [MediaControls][iOS] Fix a couple of UI bugs in the iOS Media Controls
+ https://bugs.webkit.org/show_bug.cgi?id=127929
+
+ Reviewed by Eric Carlson.
+
+ Two UI bugs in the iOS Media Controls: the text in the controls should use the apple
+ system font rather than the webkit small control font, and the buttons in the controls
+ are clipped due to an "off by one" error when calculating the SVG image dimensions.
+
+ * Modules/mediacontrols/mediaControlsiOS.css:
+ (::-webkit-media-controls):
+ (audio::-webkit-media-controls-play-button):
+ (audio::-webkit-media-controls-fullscreen-button):
+ (audio::-webkit-media-controls-time-remaining-display):
+
</ins><span class="cx"> 2014-01-30 Jeremy Jones <jeremyj@apple.com>
</span><span class="cx">
</span><span class="cx"> Refactor WebVideoFullscreenController separating AVKit from MediaElement.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (163101 => 163102)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-01-30 20:43:04 UTC (rev 163101)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-01-30 20:44:42 UTC (rev 163102)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> -webkit-align-items: stretch;
</span><span class="cx"> -webkit-justify-content: flex-end;
</span><span class="cx"> -webkit-flex-direction: column;
</span><ins>+ font-family: -apple-system-font;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> video::-webkit-media-text-track-container,
</span><span class="lines">@@ -153,8 +154,8 @@
</span><span class="cx"> audio::-webkit-media-controls-play-button {
</span><span class="cx"> margin-left: 34px;
</span><span class="cx"> margin-right: 13px;
</span><del>- width: 18px;
- height: 16px;
</del><ins>+ width: 19px;
+ height: 17px;
</ins><span class="cx"> -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 18 16"><rect x="1" y="0" width="5" height="16" fill="white"/><rect x="12" y="0" width="5" height="16" fill="white"/></svg>');
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -167,8 +168,8 @@
</span><span class="cx"> audio::-webkit-media-controls-fullscreen-button {
</span><span class="cx"> margin-right: 34px;
</span><span class="cx"> margin-left: 13px;
</span><del>- width: 16px;
- height: 16px;
</del><ins>+ width: 17px;
+ height: 17px;
</ins><span class="cx"> -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16px" height="16px"><g stroke="white" fill="transparent"><path d="M .5,5 v -4.5 h 4.5M .5,.5 l 5.5,5.5" /> <path d="M 15.5,11 v 4.5 h -4.5 M 15.5,15.5 l -5.5,-5.5" /></g></svg>')
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -218,7 +219,6 @@
</span><span class="cx"> -webkit-justify-content: center;
</span><span class="cx"> -webkit-align-items: center;
</span><span class="cx"> cursor: default;
</span><del>- font: -webkit-small-control;
</del><span class="cx"> font-size: 10px;
</span><span class="cx"> overflow-y: hidden;
</span><span class="cx"> overflow-x: hidden;
</span></span></pre>
</div>
</div>
</body>
</html>