<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163116] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163116">163116</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2014-01-30 14:49:32 -0800 (Thu, 30 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Lots of API test assertion failures after <a href="http://trac.webkit.org/projects/webkit/changeset/163093">r163093</a>
https://bugs.webkit.org/show_bug.cgi?id=127948
Reviewed by Alexey Proskuryakov.
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::processDidExit):
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _processDidExit]):
* UIProcess/API/ios/WKContentViewInternal.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::processDidExit):
* UIProcess/API/mac/WKView.mm:
(-[WKView _processDidExit]):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
* UIProcess/API/mac/WKViewInternal.h:
Rename _processDidCrash to _processDidExit, since it containes cleanup we
should do in both cases. Also, call it whenever a process terminates instead
of just upon a crash. Also clear the ViewGestureController, because its
state doesn't make sense between WebProcesses.
(-[WKView _setCustomSwipeViews:]):
Don't make a ViewGestureController if we don't have one and would be
only creating one to set an empty list of custom swipe views.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplh">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIiosPageClientImplIOSh">trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIiosPageClientImplIOSmm">trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIiosWKContentViewmm">trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIiosWKContentViewInternalh">trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacPageClientImplh">trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacPageClientImplmm">trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewInternalh">trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageClienth">trunk/Source/WebKit2/UIProcess/PageClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2014-01-30 Tim Horton <timothy_horton@apple.com>
+
+ Lots of API test assertion failures after r163093
+ https://bugs.webkit.org/show_bug.cgi?id=127948
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/API/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::processDidExit):
+ * UIProcess/API/ios/WKContentView.mm:
+ (-[WKContentView _processDidExit]):
+ * UIProcess/API/ios/WKContentViewInternal.h:
+ * UIProcess/API/mac/PageClientImpl.h:
+ * UIProcess/API/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::processDidExit):
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView _processDidExit]):
+ * UIProcess/PageClient.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::processDidCrash):
+ (WebKit::WebPageProxy::resetStateAfterProcessExited):
+ * UIProcess/API/mac/WKViewInternal.h:
+ Rename _processDidCrash to _processDidExit, since it containes cleanup we
+ should do in both cases. Also, call it whenever a process terminates instead
+ of just upon a crash. Also clear the ViewGestureController, because its
+ state doesn't make sense between WebProcesses.
+
+ (-[WKView _setCustomSwipeViews:]):
+ Don't make a ViewGestureController if we don't have one and would be
+ only creating one to set an empty list of custom swipe views.
+
</ins><span class="cx"> 2014-01-30 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IDB: ObjectStore cursor advance() support
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -116,7 +116,7 @@
</span><span class="cx"> return webkitWebViewBaseIsInWindow(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::PageClientImpl::processDidCrash()
</del><ins>+void PageClientImpl::PageClientImpl::processDidExit()
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> virtual bool isViewFocused() override;
</span><span class="cx"> virtual bool isViewVisible() override;
</span><span class="cx"> virtual bool isViewInWindow() override;
</span><del>- virtual void processDidCrash() override;
</del><ins>+ virtual void processDidExit() override;
</ins><span class="cx"> virtual void didRelaunchProcess() override;
</span><span class="cx"> virtual void pageClosed() override;
</span><span class="cx"> virtual void preferencesDidChange() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIiosPageClientImplIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> virtual bool isViewFocused() override;
</span><span class="cx"> virtual bool isViewVisible() override;
</span><span class="cx"> virtual bool isViewInWindow() override;
</span><del>- virtual void processDidCrash() override;
</del><ins>+ virtual void processDidExit() override;
</ins><span class="cx"> virtual void didRelaunchProcess() override;
</span><span class="cx"> virtual void pageClosed() override;
</span><span class="cx"> virtual void preferencesDidChange() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIiosPageClientImplIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -109,9 +109,9 @@
</span><span class="cx"> return [m_view window];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::processDidCrash()
</del><ins>+void PageClientImpl::processDidExit()
</ins><span class="cx"> {
</span><del>- [m_view _processDidCrash];
</del><ins>+ [m_view _processDidExit];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PageClientImpl::didRelaunchProcess()
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIiosWKContentViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -281,7 +281,7 @@
</span><span class="cx"> return std::make_unique<RemoteLayerTreeDrawingAreaProxy>(_page.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_processDidCrash
</del><ins>+- (void)_processDidExit
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Implement.
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIiosWKContentViewInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (std::unique_ptr<WebKit::DrawingAreaProxy>)_createDrawingAreaProxy;
</span><del>-- (void)_processDidCrash;
</del><ins>+- (void)_processDidExit;
</ins><span class="cx"> - (void)_didRelaunchProcess;
</span><span class="cx"> - (void)_setAcceleratedCompositingRootLayer:(CALayer *)rootLayer;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> virtual void setAcceleratedCompositingRootLayer(CALayer *) override;
</span><span class="cx"> virtual CALayer *acceleratedCompositingRootLayer() const override;
</span><span class="cx">
</span><del>- virtual void processDidCrash();
</del><ins>+ virtual void processDidExit();
</ins><span class="cx"> virtual void pageClosed();
</span><span class="cx"> virtual void didRelaunchProcess();
</span><span class="cx"> virtual void preferencesDidChange() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacPageClientImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -241,9 +241,9 @@
</span><span class="cx"> return [m_wkView _colorSpace];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::processDidCrash()
</del><ins>+void PageClientImpl::processDidExit()
</ins><span class="cx"> {
</span><del>- [m_wkView _processDidCrash];
</del><ins>+ [m_wkView _processDidExit];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PageClientImpl::pageClosed()
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -2219,12 +2219,14 @@
</span><span class="cx"> return colorSpaceData;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_processDidCrash
</del><ins>+- (void)_processDidExit
</ins><span class="cx"> {
</span><span class="cx"> if (_data->_layerHostingView)
</span><span class="cx"> [self _setAcceleratedCompositingModeRootLayer:nil];
</span><span class="cx">
</span><span class="cx"> [self _updateRemoteAccessibilityRegistration:NO];
</span><ins>+
+ _data->_gestureController = nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)_pageClosed
</span><span class="lines">@@ -3338,6 +3340,9 @@
</span><span class="cx">
</span><span class="cx"> - (void)_setCustomSwipeViews:(NSArray *)customSwipeViews
</span><span class="cx"> {
</span><ins>+ if (!customSwipeViews.count && !_data->_gestureController)
+ return;
+
</ins><span class="cx"> [self _ensureGestureController];
</span><span class="cx">
</span><span class="cx"> Vector<RetainPtr<NSView>> views;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx">
</span><span class="cx"> - (std::unique_ptr<WebKit::DrawingAreaProxy>)_createDrawingAreaProxy;
</span><span class="cx"> - (BOOL)_isFocused;
</span><del>-- (void)_processDidCrash;
</del><ins>+- (void)_processDidExit;
</ins><span class="cx"> - (void)_pageClosed;
</span><span class="cx"> - (void)_didRelaunchProcess;
</span><span class="cx"> - (void)_preferencesDidChange;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageClient.h 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> // Return the layer hosting mode for the view.
</span><span class="cx"> virtual LayerHostingMode viewLayerHostingMode() { return LayerHostingModeDefault; }
</span><span class="cx">
</span><del>- virtual void processDidCrash() = 0;
</del><ins>+ virtual void processDidExit() = 0;
</ins><span class="cx"> virtual void didRelaunchProcess() = 0;
</span><span class="cx"> virtual void pageClosed() = 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (163115 => 163116)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-30 22:37:13 UTC (rev 163115)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-30 22:49:32 UTC (rev 163116)
</span><span class="lines">@@ -3749,12 +3749,10 @@
</span><span class="cx">
</span><span class="cx"> resetStateAfterProcessExited();
</span><span class="cx">
</span><ins>+ // FIXME: Should we do this when the process exits cleanly, instead of just upon crashing?
</ins><span class="cx"> auto transaction = m_pageLoadState.transaction();
</span><del>-
</del><span class="cx"> m_pageLoadState.reset(transaction);
</span><span class="cx">
</span><del>- m_pageClient.processDidCrash();
-
</del><span class="cx"> m_loaderClient->processDidCrash(this);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3856,6 +3854,8 @@
</span><span class="cx">
</span><span class="cx"> resetState();
</span><span class="cx">
</span><ins>+ m_pageClient.processDidExit();
+
</ins><span class="cx"> m_pageClient.clearAllEditCommands();
</span><span class="cx"> m_pendingLearnOrIgnoreWordMessageCount = 0;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>