<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[163012] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/163012">163012</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-29 01:32:29 -0800 (Wed, 29 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename notifyRendererOfSelectionChange
https://bugs.webkit.org/show_bug.cgi?id=127831
Reviewed by Antti Koivisto.
Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl.
* WebCore.order: Removed the exported symbol name as it's not used in WebKit or WebKit2 code.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::updateSelectionCachesIfSelectionIsInsideTextFormControl): Don't update the style since the existence
of text form control's shadow DOM no longer depends on renderer.
* editing/FrameSelection.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::selectionChanged): Don't check renderer() for the same reason.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreorder">trunk/Source/WebCore/WebCore.order</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectionh">trunk/Source/WebCore/editing/FrameSelection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextFormControlElementcpp">trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/ChangeLog 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
+
+ Rename notifyRendererOfSelectionChange
+ https://bugs.webkit.org/show_bug.cgi?id=127831
+
+ Reviewed by Antti Koivisto.
+
+ Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl.
+
+ * WebCore.order: Removed the exported symbol name as it's not used in WebKit or WebKit2 code.
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::setSelection):
+ (WebCore::FrameSelection::selectAll):
+ (WebCore::FrameSelection::updateSelectionCachesIfSelectionIsInsideTextFormControl): Don't update the style since the existence
+ of text form control's shadow DOM no longer depends on renderer.
+ * editing/FrameSelection.h:
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::HTMLTextFormControlElement::selectionChanged): Don't check renderer() for the same reason.
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+
</ins><span class="cx"> 2014-01-28 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreorder"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.order (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.order 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/WebCore.order 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -3230,7 +3230,6 @@
</span><span class="cx"> __ZN7WebCore14FrameSelection12setSelectionERKNS_16VisibleSelectionEjNS0_19CursorAlignOnScrollENS_15TextGranularityE
</span><span class="cx"> __ZN7WebCore13TypingCommand11closeTypingEPNS_5FrameE
</span><span class="cx"> __ZN7WebCoreeqERKNS_16VisibleSelectionES2_
</span><del>-__ZN7WebCore14FrameSelection31notifyRendererOfSelectionChangeENS_14EUserTriggeredE
</del><span class="cx"> __ZN7WebCore24enclosingTextFormControlERKNS_8PositionE
</span><span class="cx"> __ZNK7WebCore8Position13containerNodeEv
</span><span class="cx"> __ZN7WebCore9FrameView5clearEv
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx">
</span><span class="cx"> if (m_selection == s) {
</span><span class="cx"> // Even if selection was not changed, selection offsets may have been changed.
</span><del>- notifyRendererOfSelectionChange(userTriggered);
</del><ins>+ updateSelectionCachesIfSelectionIsInsideTextFormControl(userTriggered);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -320,7 +320,7 @@
</span><span class="cx"> // It will be restored by the vertical arrow navigation code if necessary.
</span><span class="cx"> m_xPosForVerticalArrowNavigation = NoXPosForVerticalArrowNavigation();
</span><span class="cx"> selectFrameElementInParentIfFullySelected();
</span><del>- notifyRendererOfSelectionChange(userTriggered);
</del><ins>+ updateSelectionCachesIfSelectionIsInsideTextFormControl(userTriggered);
</ins><span class="cx"> m_frame->editor().respondToChangedSelection(oldSelection, options);
</span><span class="cx"> if (userTriggered == UserTriggered) {
</span><span class="cx"> ScrollAlignment alignment;
</span><span class="lines">@@ -1702,7 +1702,7 @@
</span><span class="cx"> setSelection(newSelection);
</span><span class="cx">
</span><span class="cx"> selectFrameElementInParentIfFullySelected();
</span><del>- notifyRendererOfSelectionChange(UserTriggered);
</del><ins>+ updateSelectionCachesIfSelectionIsInsideTextFormControl(UserTriggered);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool FrameSelection::setSelectedRange(Range* range, EAffinity affinity, bool closeTyping)
</span><span class="lines">@@ -1910,10 +1910,8 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FrameSelection::notifyRendererOfSelectionChange(EUserTriggered userTriggered)
</del><ins>+void FrameSelection::updateSelectionCachesIfSelectionIsInsideTextFormControl(EUserTriggered userTriggered)
</ins><span class="cx"> {
</span><del>- m_frame->document()->updateStyleIfNeeded();
-
</del><span class="cx"> if (HTMLTextFormControlElement* textControl = enclosingTextFormControl(start()))
</span><span class="cx"> textControl->selectionChanged(userTriggered == UserTriggered);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.h (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.h 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/editing/FrameSelection.h 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -273,7 +273,7 @@
</span><span class="cx"> bool shouldDeleteSelection(const VisibleSelection&) const;
</span><span class="cx"> enum EndPointsAdjustmentMode { AdjustEndpointsAtBidiBoundary, DoNotAdjsutEndpoints };
</span><span class="cx"> void setNonDirectionalSelectionIfNeeded(const VisibleSelection&, TextGranularity, EndPointsAdjustmentMode = DoNotAdjsutEndpoints);
</span><del>- void notifyRendererOfSelectionChange(EUserTriggered);
</del><ins>+ void updateSelectionCachesIfSelectionIsInsideTextFormControl(EUserTriggered);
</ins><span class="cx">
</span><span class="cx"> void paintDragCaret(GraphicsContext*, const LayoutPoint&, const LayoutRect& clipRect) const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -477,9 +477,10 @@
</span><span class="cx">
</span><span class="cx"> void HTMLTextFormControlElement::selectionChanged(bool userTriggered)
</span><span class="cx"> {
</span><del>- if (!renderer() || !isTextFormControl())
</del><ins>+ if (!isTextFormControl())
</ins><span class="cx"> return;
</span><span class="cx">
</span><ins>+ // FIXME: Don't re-compute selection start and end if this function was called inside setSelectionRange.
</ins><span class="cx"> // selectionStart() or selectionEnd() will return cached selection when this node doesn't have focus
</span><span class="cx"> cacheSelection(computeSelectionStart(), computeSelectionEnd(), computeSelectionDirection());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (163011 => 163012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2014-01-29 08:31:46 UTC (rev 163011)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2014-01-29 09:32:29 UTC (rev 163012)
</span><span class="lines">@@ -984,7 +984,7 @@
</span><span class="cx"> handled = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- m_frame.selection().notifyRendererOfSelectionChange(UserTriggered);
</del><ins>+ m_frame.selection().updateSelectionCachesIfSelectionIsInsideTextFormControl(UserTriggered);
</ins><span class="cx">
</span><span class="cx"> m_frame.selection().selectFrameElementInParentIfFullySelected();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>