<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162962] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162962">162962</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2014-01-28 14:32:05 -0800 (Tue, 28 Jan 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Document::topDocument() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=127786

Reviewed by Darin Adler.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::implicitClose):
(WebCore::Document::topDocument):
(WebCore::Document::topOrigin):
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/Document.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::incrementScrollEventListenersCount):
(WebCore::DOMWindow::decrementScrollEventListenersCount):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isReplacementObscured):
* rendering/RenderView.cpp:
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderEmbeddedObjectcpp">trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/ChangeLog        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2014-01-28  Antti Koivisto  &lt;antti@apple.com&gt;
+
+        Document::topDocument() should return a reference
+        https://bugs.webkit.org/show_bug.cgi?id=127786
+
+        Reviewed by Darin Adler.
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::mainFrame):
+        (WebCore::AccessibilityObject::topDocument):
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityContainer]):
+        * dom/Document.cpp:
+        (WebCore::Document::~Document):
+        (WebCore::Document::createRenderTree):
+        (WebCore::Document::destroyRenderTree):
+        (WebCore::Document::clearAXObjectCache):
+        (WebCore::Document::existingAXObjectCache):
+        (WebCore::Document::axObjectCache):
+        (WebCore::Document::implicitClose):
+        (WebCore::Document::topDocument):
+        (WebCore::Document::topOrigin):
+        (WebCore::Document::webkitCancelFullScreen):
+        (WebCore::Document::webkitDidExitFullScreenForElement):
+        * dom/Document.h:
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::incrementScrollEventListenersCount):
+        (WebCore::DOMWindow::decrementScrollEventListenersCount):
+        * rendering/RenderEmbeddedObject.cpp:
+        (WebCore::RenderEmbeddedObject::isReplacementObscured):
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
+        
</ins><span class="cx"> 2014-01-28  Viatcheslav Ostapenko  &lt;sl.ostapenko@samsung.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Sticky positioning is broken for table rows
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -609,11 +609,11 @@
</span><span class="cx"> {
</span><span class="cx">     Document* document = topDocument();
</span><span class="cx">     if (!document)
</span><del>-        return 0;
</del><ins>+        return nullptr;
</ins><span class="cx">     
</span><span class="cx">     Frame* frame = document-&gt;frame();
</span><span class="cx">     if (!frame)
</span><del>-        return 0;
</del><ins>+        return nullptr;
</ins><span class="cx">     
</span><span class="cx">     return &amp;frame-&gt;mainFrame();
</span><span class="cx"> }
</span><span class="lines">@@ -621,8 +621,8 @@
</span><span class="cx"> Document* AccessibilityObject::topDocument() const
</span><span class="cx"> {
</span><span class="cx">     if (!document())
</span><del>-        return 0;
-    return document()-&gt;topDocument();
</del><ins>+        return nullptr;
+    return &amp;document()-&gt;topDocument();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> String AccessibilityObject::language() const
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -1109,7 +1109,7 @@
</span><span class="cx">     // Verify this is the top document. If not, we might need to go through the platform widget.
</span><span class="cx">     FrameView* frameView = m_object-&gt;documentFrameView();
</span><span class="cx">     Document* document = m_object-&gt;document();
</span><del>-    if (document &amp;&amp; frameView &amp;&amp; document != document-&gt;topDocument())
</del><ins>+    if (document &amp;&amp; frameView &amp;&amp; document != &amp;document-&gt;topDocument())
</ins><span class="cx">         return frameView-&gt;platformWidget();
</span><span class="cx">     
</span><span class="cx">     // The top scroll view's parent is the web document view.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/dom/Document.cpp        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -593,7 +593,7 @@
</span><span class="cx">     ASSERT(!m_parser || m_parser-&gt;refCount() == 1);
</span><span class="cx">     detachParser();
</span><span class="cx"> 
</span><del>-    if (this == topDocument())
</del><ins>+    if (this == &amp;topDocument())
</ins><span class="cx">         clearAXObjectCache();
</span><span class="cx"> 
</span><span class="cx">     m_decoder = nullptr;
</span><span class="lines">@@ -1947,7 +1947,7 @@
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!renderView());
</span><span class="cx">     ASSERT(!m_inPageCache);
</span><del>-    ASSERT(!m_axObjectCache || this != topDocument());
</del><ins>+    ASSERT(!m_axObjectCache || this != &amp;topDocument());
</ins><span class="cx"> 
</span><span class="cx">     if (m_isNonRenderedPlaceholder)
</span><span class="cx">         return;
</span><span class="lines">@@ -2032,7 +2032,7 @@
</span><span class="cx"> 
</span><span class="cx">     TemporaryChange&lt;bool&gt; change(m_renderTreeBeingDestroyed, true);
</span><span class="cx"> 
</span><del>-    if (this == topDocument())
</del><ins>+    if (this == &amp;topDocument())
</ins><span class="cx">         clearAXObjectCache();
</span><span class="cx"> 
</span><span class="cx">     documentWillBecomeInactive();
</span><span class="lines">@@ -2167,7 +2167,7 @@
</span><span class="cx"> 
</span><span class="cx"> void Document::clearAXObjectCache()
</span><span class="cx"> {
</span><del>-    ASSERT(topDocument() == this);
</del><ins>+    ASSERT(&amp;topDocument() == this);
</ins><span class="cx">     // Clear the cache member variable before calling delete because attempts
</span><span class="cx">     // are made to access it during destruction.
</span><span class="cx">     m_axObjectCache.clear();
</span><span class="lines">@@ -2175,10 +2175,10 @@
</span><span class="cx"> 
</span><span class="cx"> AXObjectCache* Document::existingAXObjectCache() const
</span><span class="cx"> {
</span><del>-    if (!topDocument()-&gt;hasLivingRenderTree())
</del><ins>+    Document&amp; topDocument = this-&gt;topDocument();
+    if (!topDocument.hasLivingRenderTree())
</ins><span class="cx">         return nullptr;
</span><del>-
-    return topDocument()-&gt;m_axObjectCache.get();
</del><ins>+    return topDocument.m_axObjectCache.get();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> AXObjectCache* Document::axObjectCache() const
</span><span class="lines">@@ -2190,16 +2190,16 @@
</span><span class="cx">     // document.  This is because we need to be able to get from any WebCoreAXObject
</span><span class="cx">     // to any other WebCoreAXObject on the same page.  Using a single cache allows
</span><span class="cx">     // lookups across nested webareas (i.e. multiple documents).
</span><del>-    Document* topDocument = this-&gt;topDocument();
</del><ins>+    Document&amp; topDocument = this-&gt;topDocument();
</ins><span class="cx"> 
</span><span class="cx">     // If the document has already been detached, do not make a new axObjectCache.
</span><del>-    if (!topDocument-&gt;hasLivingRenderTree())
</del><ins>+    if (!topDocument.hasLivingRenderTree())
</ins><span class="cx">         return nullptr;
</span><span class="cx"> 
</span><del>-    ASSERT(topDocument == this || !m_axObjectCache);
-    if (!topDocument-&gt;m_axObjectCache)
-        topDocument-&gt;m_axObjectCache = adoptPtr(new AXObjectCache(*topDocument));
-    return topDocument-&gt;m_axObjectCache.get();
</del><ins>+    ASSERT(&amp;topDocument == this || !m_axObjectCache);
+    if (!topDocument.m_axObjectCache)
+        topDocument.m_axObjectCache = adoptPtr(new AXObjectCache(topDocument));
+    return topDocument.m_axObjectCache.get();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Document::setVisuallyOrdered()
</span><span class="lines">@@ -2468,7 +2468,7 @@
</span><span class="cx">         // exists in the cache (we ignore the return value because we don't need it here). This is 
</span><span class="cx">         // only safe to call when a layout is not in progress, so it can not be used in postNotification.    
</span><span class="cx">         axObjectCache()-&gt;getOrCreate(renderView());
</span><del>-        if (this == topDocument())
</del><ins>+        if (this == &amp;topDocument())
</ins><span class="cx">             axObjectCache()-&gt;postNotification(renderView(), AXObjectCache::AXLoadComplete);
</span><span class="cx">         else {
</span><span class="cx">             // AXLoadComplete can only be posted on the top document, so if it's a document
</span><span class="lines">@@ -4311,9 +4311,13 @@
</span><span class="cx">     return parent-&gt;document();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-Document* Document::topDocument() const
</del><ins>+Document&amp; Document::topDocument() const
</ins><span class="cx"> {
</span><del>-    return m_frame ? m_frame-&gt;mainFrame().document() : const_cast&lt;Document*&gt;(this);
</del><ins>+    if (!m_frame)
+        return const_cast&lt;Document&amp;&gt;(*this);
+    // This should always be non-null.
+    Document* mainFrameDocument = m_frame-&gt;mainFrame().document();
+    return mainFrameDocument ? *mainFrameDocument : const_cast&lt;Document&amp;&gt;(*this);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> PassRefPtr&lt;Attr&gt; Document::createAttribute(const String&amp; name, ExceptionCode&amp; ec)
</span><span class="lines">@@ -4875,7 +4879,7 @@
</span><span class="cx"> 
</span><span class="cx"> SecurityOrigin* Document::topOrigin() const
</span><span class="cx"> {
</span><del>-    return topDocument()-&gt;securityOrigin();
</del><ins>+    return topDocument().securityOrigin();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> struct PerformTaskContext {
</span><span class="lines">@@ -5222,16 +5226,17 @@
</span><span class="cx">     // is defined as: 
</span><span class="cx">     // &quot;To fully exit fullscreen act as if the exitFullscreen() method was invoked on the top-level browsing
</span><span class="cx">     // context's document and subsequently empty that document's fullscreen element stack.&quot;
</span><del>-    if (!topDocument()-&gt;webkitFullscreenElement())
</del><ins>+    Document&amp; topDocument = this-&gt;topDocument();
+    if (!topDocument.webkitFullscreenElement())
</ins><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     // To achieve that aim, remove all the elements from the top document's stack except for the first before
</span><span class="cx">     // calling webkitExitFullscreen():
</span><span class="cx">     Vector&lt;RefPtr&lt;Element&gt;&gt; replacementFullscreenElementStack;
</span><del>-    replacementFullscreenElementStack.append(topDocument()-&gt;webkitFullscreenElement());
-    topDocument()-&gt;m_fullScreenElementStack.swap(replacementFullscreenElementStack);
</del><ins>+    replacementFullscreenElementStack.append(topDocument.webkitFullscreenElement());
+    topDocument.m_fullScreenElementStack.swap(replacementFullscreenElementStack);
</ins><span class="cx"> 
</span><del>-    topDocument()-&gt;webkitExitFullscreen();
</del><ins>+    topDocument.webkitExitFullscreen();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Document::webkitExitFullscreen()
</span><span class="lines">@@ -5404,10 +5409,9 @@
</span><span class="cx">     // When webkitCancelFullScreen is called, we call webkitExitFullScreen on the topDocument(). That
</span><span class="cx">     // means that the events will be queued there. So if we have no events here, start the timer on
</span><span class="cx">     // the exiting document.
</span><del>-    Document* exitingDocument = this;
-    if (m_fullScreenChangeEventTargetQueue.isEmpty() &amp;&amp; m_fullScreenErrorEventTargetQueue.isEmpty())
-        exitingDocument = topDocument();
-    exitingDocument-&gt;m_fullScreenChangeDelayTimer.startOneShot(0);
</del><ins>+    bool eventTargetQueuesEmpty = m_fullScreenChangeEventTargetQueue.isEmpty() &amp;&amp; m_fullScreenErrorEventTargetQueue.isEmpty();
+    Document&amp; exitingDocument = eventTargetQueuesEmpty ? topDocument() : *this;
+    exitingDocument.m_fullScreenChangeDelayTimer.startOneShot(0);
</ins><span class="cx"> }
</span><span class="cx">     
</span><span class="cx"> void Document::setFullScreenRenderer(RenderFullScreen* renderer)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/dom/Document.h        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -905,7 +905,7 @@
</span><span class="cx">     bool inDesignMode() const;
</span><span class="cx"> 
</span><span class="cx">     Document* parentDocument() const;
</span><del>-    Document* topDocument() const;
</del><ins>+    Document&amp; topDocument() const;
</ins><span class="cx">     
</span><span class="cx">     ScriptRunner* scriptRunner() { return m_scriptRunner.get(); }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/page/DOMWindow.cpp        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -1695,7 +1695,7 @@
</span><span class="cx"> void DOMWindow::incrementScrollEventListenersCount()
</span><span class="cx"> {
</span><span class="cx">     Document* document = this-&gt;document();
</span><del>-    if (++m_scrollEventListenerCount == 1 &amp;&amp; document == document-&gt;topDocument()) {
</del><ins>+    if (++m_scrollEventListenerCount == 1 &amp;&amp; document == &amp;document-&gt;topDocument()) {
</ins><span class="cx">         Frame* frame = this-&gt;frame();
</span><span class="cx">         if (frame &amp;&amp; frame-&gt;page())
</span><span class="cx">             frame-&gt;page()-&gt;chrome().client().setNeedsScrollNotifications(frame, true);
</span><span class="lines">@@ -1705,7 +1705,7 @@
</span><span class="cx"> void DOMWindow::decrementScrollEventListenersCount()
</span><span class="cx"> {
</span><span class="cx">     Document* document = this-&gt;document();
</span><del>-    if (!--m_scrollEventListenerCount &amp;&amp; document == document-&gt;topDocument()) {
</del><ins>+    if (!--m_scrollEventListenerCount &amp;&amp; document == &amp;document-&gt;topDocument()) {
</ins><span class="cx">         Frame* frame = this-&gt;frame();
</span><span class="cx">         if (frame &amp;&amp; frame-&gt;page() &amp;&amp; !document-&gt;inPageCache())
</span><span class="cx">             frame-&gt;page()-&gt;chrome().client().setNeedsScrollNotifications(frame, false);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderEmbeddedObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -424,7 +424,7 @@
</span><span class="cx">     if (rect.isEmpty())
</span><span class="cx">         return true;
</span><span class="cx"> 
</span><del>-    RenderView* rootRenderView = document().topDocument()-&gt;renderView();
</del><ins>+    RenderView* rootRenderView = document().topDocument().renderView();
</ins><span class="cx">     ASSERT(rootRenderView);
</span><span class="cx">     if (!rootRenderView)
</span><span class="cx">         return true;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.cpp (162961 => 162962)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.cpp        2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/rendering/RenderView.cpp        2014-01-28 22:32:05 UTC (rev 162962)
</span><span class="lines">@@ -1266,7 +1266,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator(RenderView* view)
</span><del>-    : m_rootView(view ? view-&gt;document().topDocument()-&gt;renderView() : nullptr)
</del><ins>+    : m_rootView(view ? view-&gt;document().topDocument().renderView() : nullptr)
</ins><span class="cx"> {
</span><span class="cx">     if (!m_rootView)
</span><span class="cx">         return;
</span></span></pre>
</div>
</div>

</body>
</html>