<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162908] trunk/Source/WebKit/mac</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162908">162908</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-27 20:04:54 -0800 (Mon, 27 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127664
Reviewed by Darin Adler.
* Configurations/Base.xcconfig:
* History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendObjectReference):
(BinaryPropertyListSerializer::startObject):
(BinaryPropertyListSerializer::addAggregateObjectReference):
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacConfigurationsBasexcconfig">trunk/Source/WebKit/mac/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWebKitmacHistoryBinaryPropertyListcpp">trunk/Source/WebKit/mac/History/BinaryPropertyList.cpp</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPDFViewmm">trunk/Source/WebKit/mac/WebView/WebPDFView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (162907 => 162908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-01-28 04:04:52 UTC (rev 162907)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-28 04:04:54 UTC (rev 162908)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-27 Joseph Pecoraro <pecoraro@apple.com>
+
+ WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
+ https://bugs.webkit.org/show_bug.cgi?id=127664
+
+ Reviewed by Darin Adler.
+
+ * Configurations/Base.xcconfig:
+ * History/BinaryPropertyList.cpp:
+ (BinaryPropertyListSerializer::appendObjectReference):
+ (BinaryPropertyListSerializer::startObject):
+ (BinaryPropertyListSerializer::addAggregateObjectReference):
+ * WebView/WebPDFView.mm:
+ (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
+
</ins><span class="cx"> 2014-01-27 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> Scrub WebKit API headers of WTF macros
</span></span></pre></div>
<a id="trunkSourceWebKitmacConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (162907 => 162908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2014-01-28 04:04:52 UTC (rev 162907)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2014-01-28 04:04:54 UTC (rev 162908)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> LINKER_DISPLAYS_MANGLED_NAMES = YES;
</span><span class="cx"> OTHER_MIGFLAGS = -F$(BUILT_PRODUCTS_DIR);
</span><span class="cx"> PREBINDING = NO;
</span><del>-WARNING_CFLAGS = -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat-security -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
</del><ins>+WARNING_CFLAGS = -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat-security -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
</ins><span class="cx">
</span><span class="cx"> TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryBinaryPropertyListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/BinaryPropertyList.cpp (162907 => 162908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/BinaryPropertyList.cpp 2014-01-28 04:04:52 UTC (rev 162907)
+++ trunk/Source/WebKit/mac/History/BinaryPropertyList.cpp 2014-01-28 04:04:54 UTC (rev 162908)
</span><span class="lines">@@ -749,19 +749,26 @@
</span><span class="cx"> #ifdef __LP64__
</span><span class="cx"> case 8:
</span><span class="cx"> appendByte(reference >> 56);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 7:
</span><span class="cx"> appendByte(reference >> 48);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 6:
</span><span class="cx"> appendByte(reference >> 40);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 5:
</span><span class="cx"> appendByte(reference >> 32);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> #endif
</span><span class="cx"> case 4:
</span><span class="cx"> appendByte(reference >> 24);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 3:
</span><span class="cx"> appendByte(reference >> 16);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 2:
</span><span class="cx"> appendByte(reference >> 8);
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 1:
</span><span class="cx"> appendByte(reference);
</span><span class="cx"> }
</span><span class="lines">@@ -778,19 +785,26 @@
</span><span class="cx"> #ifdef __LP64__
</span><span class="cx"> case 8:
</span><span class="cx"> offsetTableEntry[-8] = offset >> 56;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 7:
</span><span class="cx"> offsetTableEntry[-7] = offset >> 48;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 6:
</span><span class="cx"> offsetTableEntry[-6] = offset >> 40;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 5:
</span><span class="cx"> offsetTableEntry[-5] = offset >> 32;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> #endif
</span><span class="cx"> case 4:
</span><span class="cx"> offsetTableEntry[-4] = offset >> 24;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 3:
</span><span class="cx"> offsetTableEntry[-3] = offset >> 16;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 2:
</span><span class="cx"> offsetTableEntry[-2] = offset >> 8;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 1:
</span><span class="cx"> offsetTableEntry[-1] = offset;
</span><span class="cx"> }
</span><span class="lines">@@ -802,19 +816,26 @@
</span><span class="cx"> #ifdef __LP64__
</span><span class="cx"> case 8:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 56;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 7:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 48;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 6:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 40;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 5:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 32;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> #endif
</span><span class="cx"> case 4:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 24;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 3:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 16;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 2:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference >> 8;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case 1:
</span><span class="cx"> *--m_currentAggregateBufferByte = reference;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPDFViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPDFView.mm (162907 => 162908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPDFView.mm 2014-01-28 04:04:52 UTC (rev 162907)
+++ trunk/Source/WebKit/mac/WebView/WebPDFView.mm 2014-01-28 04:04:54 UTC (rev 162908)
</span><span class="lines">@@ -1037,6 +1037,7 @@
</span><span class="cx"> PlatformKeyboardEvent pe = PlatformEventFactory::createPlatformKeyboardEvent(nsEvent);
</span><span class="cx"> pe.disambiguateKeyDownEvent(PlatformEvent::RawKeyDown);
</span><span class="cx"> event = KeyboardEvent::create(pe, 0);
</span><ins>+ break;
</ins><span class="cx"> }
</span><span class="cx"> default:
</span><span class="cx"> break;
</span></span></pre>
</div>
</div>
</body>
</html>