<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162907] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162907">162907</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-27 20:04:52 -0800 (Mon, 27 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127671
Source/WebCore:
Reviewed by Ryosuke Niwa.
* Configurations/Base.xcconfig:
Enable the warning.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Caught a bug. CSSPropertyWebkitAlt could fall through to CSSPropertyQuotes.
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
Caught a bug. CSSPropertyWebkitSvgShadow could fall through to CSSPropertyMaskType.
* platform/Decimal.cpp:
(WebCore::Decimal::fromString):
Possible bug. Implementation doesn't seem to match its documentation.
Filed an issue to follow-up on this unclear function.
* css/makeprop.pl:
* css/makevalues.pl:
* platform/ColorData.gperf:
Ignore implicit fallthrough warnings in generated code. gperf outputs
a "/*FALLTHROUGH*/" comment, but is not easily customizable to change
this output. Easiest to just ignore the warning for now.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
There has been a "fall through" comment immediately followed by a break
since its introduction in 2003. Removing the inaccurate comment.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::realLex):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):
* css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
* dom/Node.cpp:
(WebCore::appendTextContent):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* page/EventSource.cpp:
(WebCore::EventSource::parseEventStream):
* platform/DateComponents.cpp:
(WebCore::DateComponents::toStringForTime):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
* platform/graphics/win/FullScreenController.cpp:
(FullScreenController::Private::fullscreenClientWndProc):
* platform/text/BidiResolver.h:
(WebCore::Run>::updateStatusLastFromCurrentDirection):
(WebCore::Run>::createBidiRunsForLine):
* platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::initializeLocaleData):
* rendering/PointerEventsHitRules.cpp:
(WebCore::PointerEventsHitRules::PointerEventsHitRules):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::newLine):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::replacedContentRect):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setWordSpacing):
* rendering/svg/RenderSVGResource.cpp:
(WebCore::requestPaintingResource):
* rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::updateMarkerDataForPathElement):
* svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::parsePathDataFromSource):
* svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):
Add annotation or break before falling into a default:break;
Source/WTF:
Reviewed by Ryosuke Niwa.
* wtf/text/WTFString.h:
(WTF::appendNumber):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsBasexcconfig">trunk/Source/WebCore/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBasemm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorcpp">trunk/Source/WebCore/css/CSSSelector.cpp</a></li>
<li><a href="#trunkSourceWebCorecssSVGCSSParsercpp">trunk/Source/WebCore/css/SVGCSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStylePropertiescpp">trunk/Source/WebCore/css/StyleProperties.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleSheetContentscpp">trunk/Source/WebCore/css/StyleSheetContents.cpp</a></li>
<li><a href="#trunkSourceWebCorecssmakeproppl">trunk/Source/WebCore/css/makeprop.pl</a></li>
<li><a href="#trunkSourceWebCorecssmakevaluespl">trunk/Source/WebCore/css/makevalues.pl</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLTreeBuildercpp">trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourceLoadercpp">trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventSourcecpp">trunk/Source/WebCore/page/EventSource.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformColorDatagperf">trunk/Source/WebCore/platform/ColorData.gperf</a></li>
<li><a href="#trunkSourceWebCoreplatformDateComponentscpp">trunk/Source/WebCore/platform/DateComponents.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformDecimalcpp">trunk/Source/WebCore/platform/Decimal.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationMediaPlayerPrivateAVFoundationcpp">trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp">trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp">trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicswinFullScreenControllercpp">trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextBidiResolverh">trunk/Source/WebCore/platform/text/BidiResolver.h</a></li>
<li><a href="#trunkSourceWebCoreplatformtextwinLocaleWincpp">trunk/Source/WebCore/platform/text/win/LocaleWin.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingAutoTableLayoutcpp">trunk/Source/WebCore/rendering/AutoTableLayout.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingPointerEventsHitRulescpp">trunk/Source/WebCore/rendering/PointerEventsHitRules.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockLineLayoutcpp">trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxModelObjectcpp">trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderQuotecpp">trunk/Source/WebCore/rendering/RenderQuote.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderReplacedcpp">trunk/Source/WebCore/rendering/RenderReplaced.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTablecpp">trunk/Source/WebCore/rendering/RenderTable.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourcecpp">trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGMarkerDatah">trunk/Source/WebCore/rendering/svg/SVGMarkerData.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPathParsercpp">trunk/Source/WebCore/svg/SVGPathParser.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTransformDistancecpp">trunk/Source/WebCore/svg/SVGTransformDistance.cpp</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#trunkSourceWebCorecssmakeproppl">trunk/Source/WebCore/css/makeprop.pl</a></li>
<li><a href="#trunkSourceWebCorecssmakevaluespl">trunk/Source/WebCore/css/makevalues.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WTF/ChangeLog 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-27 Joseph Pecoraro <pecoraro@apple.com>
+
+ WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
+ https://bugs.webkit.org/show_bug.cgi?id=127671
+
+ Reviewed by Ryosuke Niwa.
+
+ * wtf/text/WTFString.h:
+ (WTF::appendNumber):
+
</ins><span class="cx"> 2014-01-27 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -602,10 +602,12 @@
</span><span class="cx"> case 3:
</span><span class="cx"> vector[vectorSize + 2] = number % 10 + '0';
</span><span class="cx"> number /= 10;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx">
</span><span class="cx"> case 2:
</span><span class="cx"> vector[vectorSize + 1] = number % 10 + '0';
</span><span class="cx"> number /= 10;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx">
</span><span class="cx"> case 1:
</span><span class="cx"> vector[vectorSize] = number % 10 + '0';
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1,3 +1,125 @@
</span><ins>+2014-01-27 Joseph Pecoraro <pecoraro@apple.com>
+
+ WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
+ https://bugs.webkit.org/show_bug.cgi?id=127671
+
+ Reviewed by Ryosuke Niwa.
+
+ * Configurations/Base.xcconfig:
+ Enable the warning.
+
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::applyProperty):
+ Caught a bug. CSSPropertyWebkitAlt could fall through to CSSPropertyQuotes.
+
+ * css/SVGCSSParser.cpp:
+ (WebCore::CSSParser::parseSVGValue):
+ Caught a bug. CSSPropertyWebkitSvgShadow could fall through to CSSPropertyMaskType.
+
+ * platform/Decimal.cpp:
+ (WebCore::Decimal::fromString):
+ Possible bug. Implementation doesn't seem to match its documentation.
+ Filed an issue to follow-up on this unclear function.
+
+ * css/makeprop.pl:
+ * css/makevalues.pl:
+ * platform/ColorData.gperf:
+ Ignore implicit fallthrough warnings in generated code. gperf outputs
+ a "/*FALLTHROUGH*/" comment, but is not easily customizable to change
+ this output. Easiest to just ignore the warning for now.
+
+ * rendering/AutoTableLayout.cpp:
+ (WebCore::AutoTableLayout::recalcColumn):
+ (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
+ (WebCore::AutoTableLayout::layout):
+ There has been a "fall through" comment immediately followed by a break
+ since its introduction in 2003. Removing the inaccurate comment.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::canHaveChildren):
+ (WebCore::AccessibilityNodeObject::visibleText):
+ (WebCore::AccessibilityNodeObject::title):
+ * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
+ (-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
+ (-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::CloneSerializer::serialize):
+ (WebCore::CloneDeserializer::deserialize):
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseContent):
+ (WebCore::CSSParser::realLex):
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ (WebCore::CSSSelector::selectorText):
+ * css/StyleProperties.cpp:
+ (WebCore::StyleProperties::asText):
+ * css/StyleSheetContents.cpp:
+ (WebCore::childRulesHaveFailedOrCanceledSubresources):
+ * dom/Node.cpp:
+ (WebCore::appendTextContent):
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::processStartTag):
+ (WebCore::HTMLTreeBuilder::processEndTag):
+ (WebCore::HTMLTreeBuilder::processCharacterBuffer):
+ (WebCore::HTMLTreeBuilder::processEndOfFile):
+ * loader/cache/CachedResourceLoader.cpp:
+ (WebCore::CachedResourceLoader::requestResource):
+ * page/EventSource.cpp:
+ (WebCore::EventSource::parseEventStream):
+ * platform/DateComponents.cpp:
+ (WebCore::DateComponents::toStringForTime):
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::platformInit):
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::totalBytes):
+ * platform/graphics/win/FullScreenController.cpp:
+ (FullScreenController::Private::fullscreenClientWndProc):
+ * platform/text/BidiResolver.h:
+ (WebCore::Run>::updateStatusLastFromCurrentDirection):
+ (WebCore::Run>::createBidiRunsForLine):
+ * platform/text/win/LocaleWin.cpp:
+ (WebCore::LocaleWin::initializeLocaleData):
+ * rendering/PointerEventsHitRules.cpp:
+ (WebCore::PointerEventsHitRules::PointerEventsHitRules):
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::newLine):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::calculateFillTileSize):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::drawLineForBoxSide):
+ * rendering/RenderQuote.cpp:
+ (WebCore::RenderQuote::originalText):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::replacedContentRect):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::setWordSpacing):
+ * rendering/svg/RenderSVGResource.cpp:
+ (WebCore::requestPaintingResource):
+ * rendering/svg/SVGMarkerData.h:
+ (WebCore::SVGMarkerData::updateMarkerDataForPathElement):
+ * svg/SVGPathParser.cpp:
+ (WebCore::SVGPathParser::parsePathDataFromSource):
+ * svg/SVGTransformDistance.cpp:
+ (WebCore::SVGTransformDistance::SVGTransformDistance):
+ (WebCore::SVGTransformDistance::scaledDistance):
+ (WebCore::SVGTransformDistance::addSVGTransforms):
+ (WebCore::SVGTransformDistance::addToSVGTransform):
+ (WebCore::SVGTransformDistance::distance):
+ Add annotation or break before falling into a default:break;
+
</ins><span class="cx"> 2014-01-27 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Allow mmap encoded data replacement for WOFF fonts.
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/Base.xcconfig 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> GCC_WARN_UNUSED_VARIABLE = YES;
</span><span class="cx"> LINKER_DISPLAYS_MANGLED_NAMES = YES;
</span><span class="cx"> PREBINDING = NO;
</span><del>-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
</del><ins>+WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
</ins><span class="cx">
</span><span class="cx"> TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -401,6 +401,7 @@
</span><span class="cx"> case LegendRole:
</span><span class="cx"> if (Element* element = this->element())
</span><span class="cx"> return !ancestorsOfType<HTMLFieldSetElement>(*element).first();
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> default:
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -1337,6 +1338,7 @@
</span><span class="cx"> // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
</span><span class="cx"> if (node->hasTagName(selectTag))
</span><span class="cx"> break;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ButtonRole:
</span><span class="cx"> case ToggleButtonRole:
</span><span class="cx"> case CheckBoxRole:
</span><span class="lines">@@ -1712,6 +1714,7 @@
</span><span class="cx"> // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
</span><span class="cx"> if (node->hasTagName(selectTag))
</span><span class="cx"> return String();
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ButtonRole:
</span><span class="cx"> case ToggleButtonRole:
</span><span class="cx"> case CheckBoxRole:
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBasemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -201,6 +201,7 @@
</span><span class="cx"> case ChildrenText:
</span><span class="cx"> case LabelByElementText:
</span><span class="cx"> visibleTextAvailable = true;
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -230,6 +231,7 @@
</span><span class="cx"> case ChildrenText:
</span><span class="cx"> case LabelByElementText:
</span><span class="cx"> descriptiveTextAvailable = true;
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1182,9 +1182,9 @@
</span><span class="cx"> inputObjectStack.append(inArray);
</span><span class="cx"> indexStack.append(0);
</span><span class="cx"> lengthStack.append(length);
</span><del>- // fallthrough
</del><span class="cx"> }
</span><span class="cx"> arrayStartVisitMember:
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ArrayStartVisitMember: {
</span><span class="cx"> JSObject* array = inputObjectStack.last();
</span><span class="cx"> uint32_t index = indexStack.last();
</span><span class="lines">@@ -1244,9 +1244,9 @@
</span><span class="cx"> indexStack.append(0);
</span><span class="cx"> propertyStack.append(PropertyNameArray(m_exec));
</span><span class="cx"> inObject->methodTable()->getOwnPropertyNames(inObject, m_exec, propertyStack.last(), ExcludeDontEnumProperties);
</span><del>- // fallthrough
</del><span class="cx"> }
</span><span class="cx"> objectStartVisitMember:
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ObjectStartVisitMember: {
</span><span class="cx"> JSObject* object = inputObjectStack.last();
</span><span class="cx"> uint32_t index = indexStack.last();
</span><span class="lines">@@ -1279,7 +1279,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (terminalCode != SuccessfullyCompleted)
</span><span class="cx"> return terminalCode;
</span><del>- // fallthrough
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case ObjectEndVisitMember: {
</span><span class="cx"> if (shouldTerminate())
</span><span class="lines">@@ -2317,9 +2317,9 @@
</span><span class="cx"> JSArray* outArray = constructEmptyArray(m_exec, 0, m_globalObject, length);
</span><span class="cx"> m_gcBuffer.append(outArray);
</span><span class="cx"> outputObjectStack.append(outArray);
</span><del>- // fallthrough
</del><span class="cx"> }
</span><span class="cx"> arrayStartVisitMember:
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ArrayStartVisitMember: {
</span><span class="cx"> uint32_t index;
</span><span class="cx"> if (!read(index)) {
</span><span class="lines">@@ -2358,9 +2358,9 @@
</span><span class="cx"> JSObject* outObject = constructEmptyObject(m_exec, m_globalObject->objectPrototype());
</span><span class="cx"> m_gcBuffer.append(outObject);
</span><span class="cx"> outputObjectStack.append(outObject);
</span><del>- // fallthrough
</del><span class="cx"> }
</span><span class="cx"> objectStartVisitMember:
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ObjectStartVisitMember: {
</span><span class="cx"> CachedStringRef cachedString;
</span><span class="cx"> bool wasTerminator = false;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -2297,7 +2297,9 @@
</span><span class="cx"> return cssValuePool().createValue(style->textEmphasisCustomMark(), CSSPrimitiveValue::CSS_STRING);
</span><span class="cx"> case TextEmphasisMarkAuto:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- // Fall through
</del><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case TextEmphasisMarkDot:
</span><span class="cx"> case TextEmphasisMarkCircle:
</span><span class="cx"> case TextEmphasisMarkDoubleCircle:
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1909,7 +1909,7 @@
</span><span class="cx"> validPrimitive = true;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- /* nobreak */
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case CSSPropertyBackgroundColor: // <color> | inherit
</span><span class="cx"> case CSSPropertyBorderTopColor: // <color> | inherit
</span><span class="cx"> case CSSPropertyBorderRightColor:
</span><span class="lines">@@ -3690,6 +3690,7 @@
</span><span class="cx"> case CSSValueNone:
</span><span class="cx"> case CSSValueNormal:
</span><span class="cx"> parsedValue = cssValuePool().createIdentifierValue(val->id);
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -10930,13 +10931,14 @@
</span><span class="cx">
</span><span class="cx"> switch ((m_token <= 127) ? typesOfASCIICharacters[m_token] : CharacterIdentifierStart) {
</span><span class="cx"> case CharacterCaselessU:
</span><del>- if (UNLIKELY(*currentCharacter<SrcCharacterType>() == '+'))
</del><ins>+ if (UNLIKELY(*currentCharacter<SrcCharacterType>() == '+')) {
</ins><span class="cx"> if (parseUnicodeRange<SrcCharacterType>()) {
</span><span class="cx"> m_token = UNICODERANGE;
</span><span class="cx"> yylval->string.init(tokenStart<SrcCharacterType>(), currentCharacter<SrcCharacterType>() - tokenStart<SrcCharacterType>());
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through to CharacterIdentifierStart.
</del><ins>+ }
+ FALLTHROUGH; // To CharacterIdentifierStart.
</ins><span class="cx">
</span><span class="cx"> case CharacterIdentifierStart:
</span><span class="cx"> --currentCharacter<SrcCharacterType>();
</span><span class="lines">@@ -11011,7 +11013,7 @@
</span><span class="cx"> case CharacterDot:
</span><span class="cx"> if (!isASCIIDigit(currentCharacter<SrcCharacterType>()[0]))
</span><span class="cx"> break;
</span><del>- // Fall through to CharacterNumber.
</del><ins>+ FALLTHROUGH; // To CharacterNumber.
</ins><span class="cx">
</span><span class="cx"> case CharacterNumber: {
</span><span class="cx"> bool dotSeen = (m_token == '.');
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/CSSSelector.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -400,6 +400,7 @@
</span><span class="cx"> case PseudoFirstLetter:
</span><span class="cx"> case PseudoFirstLine:
</span><span class="cx"> compat = true;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> #if ENABLE(SHADOW_DOM)
</span><span class="cx"> case PseudoDistributed:
</span><span class="cx"> #endif
</span><span class="lines">@@ -642,6 +643,9 @@
</span><span class="cx"> return tagHistory->selectorText(" ~ " + str.toString() + rightSide);
</span><span class="cx"> case CSSSelector::SubSelector:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case CSSSelector::ShadowDescendant:
</span><span class="cx"> return tagHistory->selectorText(str.toString() + rightSide);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssSVGCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SVGCSSParser.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SVGCSSParser.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/SVGCSSParser.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -165,7 +165,8 @@
</span><span class="cx"> valid_primitive = true;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- /* fallthrough intentional */
</del><ins>+ FALLTHROUGH;
+
</ins><span class="cx"> case CSSPropertyGlyphOrientationHorizontal: // <angle> (restricted to _deg_ per SVG 1.1 spec) | inherit
</span><span class="cx"> if (value->unit == CSSPrimitiveValue::CSS_DEG || value->unit == CSSPrimitiveValue::CSS_NUMBER) {
</span><span class="cx"> parsedValue = CSSPrimitiveValue::create(value->fValue, CSSPrimitiveValue::CSS_DEG);
</span><span class="lines">@@ -270,6 +271,7 @@
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><ins>+ break;
</ins><span class="cx">
</span><span class="cx"> case CSSPropertyMaskType: // luminance | alpha | inherit
</span><span class="cx"> if (id == CSSValueLuminance || id == CSSValueAlpha)
</span></span></pre></div>
<a id="trunkSourceWebCorecssStylePropertiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleProperties.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleProperties.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -810,12 +810,14 @@
</span><span class="cx"> case CSSPropertyBorderLeftWidth:
</span><span class="cx"> if (!borderFallbackShorthandProperty)
</span><span class="cx"> borderFallbackShorthandProperty = CSSPropertyBorderWidth;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case CSSPropertyBorderTopStyle:
</span><span class="cx"> case CSSPropertyBorderRightStyle:
</span><span class="cx"> case CSSPropertyBorderBottomStyle:
</span><span class="cx"> case CSSPropertyBorderLeftStyle:
</span><span class="cx"> if (!borderFallbackShorthandProperty)
</span><span class="cx"> borderFallbackShorthandProperty = CSSPropertyBorderStyle;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case CSSPropertyBorderTopColor:
</span><span class="cx"> case CSSPropertyBorderRightColor:
</span><span class="cx"> case CSSPropertyBorderBottomColor:
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -2225,7 +2225,9 @@
</span><span class="cx"> }
</span><span class="cx"> if (!didSet)
</span><span class="cx"> state.style()->setContentAltText(emptyAtom);
</span><ins>+ return;
</ins><span class="cx"> }
</span><ins>+
</ins><span class="cx"> case CSSPropertyQuotes:
</span><span class="cx"> if (isInherit) {
</span><span class="cx"> state.style()->setQuotes(state.parentStyle()->quotes());
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleSheetContentscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleSheetContents.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleSheetContents.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/StyleSheetContents.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -456,6 +456,9 @@
</span><span class="cx"> #endif
</span><span class="cx"> case StyleRuleBase::Import:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case StyleRuleBase::Page:
</span><span class="cx"> case StyleRuleBase::Keyframes:
</span><span class="cx"> case StyleRuleBase::Unknown:
</span></span></pre></div>
<a id="trunkSourceWebCorecssmakeproppl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/makeprop.pl (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/makeprop.pl 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/makeprop.pl 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -102,6 +102,7 @@
</span><span class="cx"> #pragma clang diagnostic push
</span><span class="cx"> #pragma clang diagnostic ignored \"-Wunknown-pragmas\"
</span><span class="cx"> #pragma clang diagnostic ignored \"-Wdeprecated-register\"
</span><ins>+#pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">Property changes on: trunk/Source/WebCore/css/makeprop.pl
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCorecssmakevaluespl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/makevalues.pl (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/makevalues.pl 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/css/makevalues.pl 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -70,6 +70,7 @@
</span><span class="cx"> #pragma clang diagnostic push
</span><span class="cx"> #pragma clang diagnostic ignored \"-Wunknown-pragmas\"
</span><span class="cx"> #pragma clang diagnostic ignored \"-Wdeprecated-register\"
</span><ins>+#pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">Property changes on: trunk/Source/WebCore/css/makevalues.pl
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/dom/Node.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1303,7 +1303,7 @@
</span><span class="cx"> content.append('\n');
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Node::ATTRIBUTE_NODE:
</span><span class="cx"> case Node::ENTITY_NODE:
</span><span class="cx"> case Node::ENTITY_REFERENCE_NODE:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLTreeBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1099,7 +1099,7 @@
</span><span class="cx"> case InsertionMode::Initial:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::Initial);
</span><span class="cx"> defaultForInitial();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHTML:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHTML);
</span><span class="cx"> if (token->name() == htmlTag) {
</span><span class="lines">@@ -1108,7 +1108,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForBeforeHTML();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHead);
</span><span class="cx"> if (token->name() == htmlTag) {
</span><span class="lines">@@ -1121,13 +1121,13 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForBeforeHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InHead);
</span><span class="cx"> if (processStartTagForInHead(token))
</span><span class="cx"> return;
</span><span class="cx"> defaultForInHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::AfterHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterHead);
</span><span class="cx"> if (token->name() == htmlTag) {
</span><span class="lines">@@ -1169,7 +1169,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForAfterHead();
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InBody:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InBody);
</span><span class="cx"> processStartTagForInBody(token);
</span><span class="lines">@@ -1371,7 +1371,7 @@
</span><span class="cx"> processStartTag(token);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InSelect:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InSelect || insertionMode() == InsertionMode::InSelectInTable);
</span><span class="cx"> if (token->name() == htmlTag) {
</span><span class="lines">@@ -2049,7 +2049,7 @@
</span><span class="cx"> case InsertionMode::Initial:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::Initial);
</span><span class="cx"> defaultForInitial();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHTML:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHTML);
</span><span class="cx"> if (token->name() != headTag && token->name() != bodyTag && token->name() != htmlTag && token->name() != brTag) {
</span><span class="lines">@@ -2057,7 +2057,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForBeforeHTML();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHead);
</span><span class="cx"> if (token->name() != headTag && token->name() != bodyTag && token->name() != htmlTag && token->name() != brTag) {
</span><span class="lines">@@ -2065,7 +2065,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForBeforeHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InHead);
</span><span class="cx"> // FIXME: This case should be broken out into processEndTagForInHead,
</span><span class="lines">@@ -2087,7 +2087,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForInHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::AfterHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterHead);
</span><span class="cx"> if (token->name() != bodyTag && token->name() != htmlTag && token->name() != brTag) {
</span><span class="lines">@@ -2095,7 +2095,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> defaultForAfterHead();
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InBody:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InBody);
</span><span class="cx"> processEndTagForInBody(token);
</span><span class="lines">@@ -2175,7 +2175,7 @@
</span><span class="cx"> setInsertionMode(InsertionMode::AfterAfterBody);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::AfterAfterBody:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterBody || insertionMode() == InsertionMode::AfterAfterBody);
</span><span class="cx"> parseError(token);
</span><span class="lines">@@ -2250,7 +2250,7 @@
</span><span class="cx"> setInsertionMode(InsertionMode::AfterAfterFrameset);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::AfterAfterFrameset:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterFrameset || insertionMode() == InsertionMode::AfterAfterFrameset);
</span><span class="cx"> parseError(token);
</span><span class="lines">@@ -2270,7 +2270,7 @@
</span><span class="cx"> }
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InSelect:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InSelect || insertionMode() == InsertionMode::InSelectInTable);
</span><span class="cx"> if (token->name() == optgroupTag) {
</span><span class="lines">@@ -2475,7 +2475,7 @@
</span><span class="cx"> if (buffer.isEmpty())
</span><span class="cx"> return;
</span><span class="cx"> defaultForInitial();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::BeforeHTML: {
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHTML);
</span><span class="lines">@@ -2483,7 +2483,7 @@
</span><span class="cx"> if (buffer.isEmpty())
</span><span class="cx"> return;
</span><span class="cx"> defaultForBeforeHTML();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::BeforeHead: {
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHead);
</span><span class="lines">@@ -2491,7 +2491,7 @@
</span><span class="cx"> if (buffer.isEmpty())
</span><span class="cx"> return;
</span><span class="cx"> defaultForBeforeHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::InHead: {
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InHead);
</span><span class="lines">@@ -2501,7 +2501,7 @@
</span><span class="cx"> if (buffer.isEmpty())
</span><span class="cx"> return;
</span><span class="cx"> defaultForInHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::AfterHead: {
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterHead);
</span><span class="lines">@@ -2511,7 +2511,7 @@
</span><span class="cx"> if (buffer.isEmpty())
</span><span class="cx"> return;
</span><span class="cx"> defaultForAfterHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::InBody:
</span><span class="cx"> case InsertionMode::InCaption:
</span><span class="lines">@@ -2545,7 +2545,7 @@
</span><span class="cx"> processCharacterBufferForInBody(buffer);
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> }
</span><span class="cx"> case InsertionMode::InTableText: {
</span><span class="cx"> buffer.giveRemainingTo(m_pendingTableCharacters);
</span><span class="lines">@@ -2644,23 +2644,23 @@
</span><span class="cx"> case InsertionMode::Initial:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::Initial);
</span><span class="cx"> defaultForInitial();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHTML:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHTML);
</span><span class="cx"> defaultForBeforeHTML();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::BeforeHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::BeforeHead);
</span><span class="cx"> defaultForBeforeHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InHead);
</span><span class="cx"> defaultForInHead();
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::AfterHead:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::AfterHead);
</span><span class="cx"> defaultForAfterHead();
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InBody:
</span><span class="cx"> case InsertionMode::InCell:
</span><span class="cx"> case InsertionMode::InCaption:
</span><span class="lines">@@ -2702,7 +2702,7 @@
</span><span class="cx"> ASSERT(m_tree.currentNode()->hasTagName(colgroupTag));
</span><span class="cx"> #endif
</span><span class="cx"> processColgroupEndTagForInColumnGroup();
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case InsertionMode::InFrameset:
</span><span class="cx"> case InsertionMode::InTable:
</span><span class="cx"> case InsertionMode::InTableBody:
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -443,7 +443,7 @@
</span><span class="cx"> switch (policy) {
</span><span class="cx"> case Reload:
</span><span class="cx"> memoryCache()->remove(resource.get());
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Load:
</span><span class="cx"> resource = loadResource(type, request, request.charset());
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventSource.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventSource.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/page/EventSource.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -336,6 +336,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case '\r':
</span><span class="cx"> m_discardTrailingNewline = true;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case '\n':
</span><span class="cx"> lineLength = i - bufPos;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformColorDatagperf"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ColorData.gperf (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ColorData.gperf 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/ColorData.gperf 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> #pragma clang diagnostic push
</span><span class="cx"> #pragma clang diagnostic ignored "-Wunknown-pragmas"
</span><span class="cx"> #pragma clang diagnostic ignored "-Wdeprecated-register"
</span><ins>+#pragma clang diagnostic ignored "-Wimplicit-fallthrough"
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformDateComponentscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/DateComponents.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/DateComponents.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/DateComponents.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -689,7 +689,9 @@
</span><span class="cx"> switch (effectiveFormat) {
</span><span class="cx"> default:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- // Fallback to None.
</del><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH; // To None.
+#endif
</ins><span class="cx"> case None:
</span><span class="cx"> return String::format("%02d:%02d", m_hour, m_minute);
</span><span class="cx"> case Second:
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformDecimalcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Decimal.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Decimal.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/Decimal.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -753,6 +753,8 @@
</span><span class="cx"> state = StateDotDigit;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+ // FIXME: <http://webkit.org/b/127667> Decimal::fromString's EBNF documentation does not match implementation
+ FALLTHROUGH;
</ins><span class="cx">
</span><span class="cx"> case StateDotDigit:
</span><span class="cx"> if (ch >= '0' && ch <= '9') {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationMediaPlayerPrivateAVFoundationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -538,6 +538,7 @@
</span><span class="cx"> // If the readyState is already HaveEnoughData, don't go lower because of this state change.
</span><span class="cx"> if (m_readyState == MediaPlayer::HaveEnoughData)
</span><span class="cx"> break;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx">
</span><span class="cx"> case MediaPlayerAVPlayerItemStatusPlaybackBufferEmpty:
</span><span class="cx"> if (maxTimeLoaded() > currentTime())
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1752,6 +1752,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case BlendModeLuminosity:
</span><span class="cx"> target = kCGBlendModeLuminosity;
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1257,7 +1257,7 @@
</span><span class="cx"> gst_iterator_resync(iter);
</span><span class="cx"> break;
</span><span class="cx"> case GST_ITERATOR_ERROR:
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case GST_ITERATOR_DONE:
</span><span class="cx"> done = true;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicswinFullScreenControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> m_controller->exitFullScreen();
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> default:
</span><span class="cx"> lResult = ::DefWindowProc(hwnd, msg, wParam, lParam);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextBidiResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/BidiResolver.h (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/BidiResolver.h 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/text/BidiResolver.h 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -514,7 +514,7 @@
</span><span class="cx"> // ignore these
</span><span class="cx"> break;
</span><span class="cx"> case U_EUROPEAN_NUMBER:
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> default:
</span><span class="cx"> m_status.last = dirCurrent;
</span><span class="cx"> }
</span><span class="lines">@@ -687,6 +687,7 @@
</span><span class="cx"> }
</span><span class="cx"> appendRun();
</span><span class="cx"> }
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -702,6 +703,7 @@
</span><span class="cx"> case U_EUROPEAN_NUMBER:
</span><span class="cx"> case U_ARABIC_NUMBER:
</span><span class="cx"> appendRun();
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case U_RIGHT_TO_LEFT:
</span><span class="cx"> case U_RIGHT_TO_LEFT_ARABIC:
</span><span class="cx"> break;
</span><span class="lines">@@ -724,6 +726,7 @@
</span><span class="cx"> m_eor = m_last;
</span><span class="cx"> appendRun();
</span><span class="cx"> }
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -753,6 +756,7 @@
</span><span class="cx"> case U_COMMON_NUMBER_SEPARATOR:
</span><span class="cx"> if (m_status.eor == U_EUROPEAN_NUMBER)
</span><span class="cx"> break;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case U_EUROPEAN_NUMBER_TERMINATOR:
</span><span class="cx"> case U_BOUNDARY_NEUTRAL:
</span><span class="cx"> case U_BLOCK_SEPARATOR:
</span><span class="lines">@@ -790,6 +794,7 @@
</span><span class="cx"> // Begin a new EN run.
</span><span class="cx"> m_direction = U_EUROPEAN_NUMBER;
</span><span class="cx"> }
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -799,6 +804,7 @@
</span><span class="cx"> m_direction = U_LEFT_TO_RIGHT;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case U_ARABIC_NUMBER:
</span><span class="cx"> dirCurrent = U_ARABIC_NUMBER;
</span><span class="cx"> switch (m_status.last) {
</span><span class="lines">@@ -817,6 +823,7 @@
</span><span class="cx"> case U_COMMON_NUMBER_SEPARATOR:
</span><span class="cx"> if (m_status.eor == U_ARABIC_NUMBER)
</span><span class="cx"> break;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case U_EUROPEAN_NUMBER_SEPARATOR:
</span><span class="cx"> case U_EUROPEAN_NUMBER_TERMINATOR:
</span><span class="cx"> case U_BOUNDARY_NEUTRAL:
</span><span class="lines">@@ -835,6 +842,7 @@
</span><span class="cx"> m_direction = m_status.lastStrong == U_LEFT_TO_RIGHT ? U_LEFT_TO_RIGHT : U_RIGHT_TO_LEFT;
</span><span class="cx"> m_eor = m_last;
</span><span class="cx"> appendRun();
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextwinLocaleWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/win/LocaleWin.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/win/LocaleWin.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/platform/text/win/LocaleWin.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -523,7 +523,8 @@
</span><span class="cx"> case NegativeFormatSpaceSignSuffix:
</span><span class="cx"> negativeSuffix = " " + negativeSign;
</span><span class="cx"> break;
</span><del>- case NegativeFormatSignPrefix: // Fall through.
</del><ins>+ case NegativeFormatSignPrefix:
+ FALLTHROUGH;
</ins><span class="cx"> default:
</span><span class="cx"> negativePrefix = negativeSign;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingAutoTableLayoutcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/AutoTableLayout.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/AutoTableLayout.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/AutoTableLayout.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -116,6 +116,7 @@
</span><span class="cx"> // which are not necessarily of the same type.
</span><span class="cx"> if (cellLogicalWidth.value() > columnLayout.logicalWidth.value())
</span><span class="cx"> columnLayout.logicalWidth = cellLogicalWidth;
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -309,10 +310,10 @@
</span><span class="cx"> // legacy behaviour anyway. mozilla doesn't do this so I decided we don't neither.
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Auto:
</span><span class="cx"> haveAuto = true;
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> default:
</span><span class="cx"> // If the column is a percentage width, do not let the spanning cell overwrite the
</span><span class="cx"> // width value. This caused a mis-rendering on amazon.com.
</span><span class="lines">@@ -520,7 +521,6 @@
</span><span class="cx"> case Fixed:
</span><span class="cx"> numFixed++;
</span><span class="cx"> totalFixed += m_layoutStruct[i].effectiveMaxLogicalWidth;
</span><del>- // fall through
</del><span class="cx"> break;
</span><span class="cx"> case Auto:
</span><span class="cx"> if (m_layoutStruct[i].emptyCellsOnly)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingPointerEventsHitRulescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/PointerEventsHitRules.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/PointerEventsHitRules.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/PointerEventsHitRules.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> case PE_AUTO: // "auto" is like "visiblePainted" when in SVG content
</span><span class="cx"> requireFill = true;
</span><span class="cx"> requireStroke = true;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PE_VISIBLE:
</span><span class="cx"> requireVisible = true;
</span><span class="cx"> canHitFill = true;
</span><span class="lines">@@ -55,6 +56,7 @@
</span><span class="cx"> case PE_PAINTED:
</span><span class="cx"> requireFill = true;
</span><span class="cx"> requireStroke = true;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PE_ALL:
</span><span class="cx"> canHitFill = true;
</span><span class="cx"> canHitStroke = true;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -2370,6 +2370,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case CBOTH:
</span><span class="cx"> newY = lowestFloatLogicalBottom();
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockLineLayoutcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -602,7 +602,7 @@
</span><span class="cx"> }
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case TASTART:
</span><span class="cx"> if (style().isLeftToRightDirection())
</span><span class="cx"> updateLogicalWidthForLeftAlignedBlock(style().isLeftToRightDirection(), trailingSpaceRun, logicalLeft, totalLogicalWidth, availableLogicalWidth);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -2860,7 +2860,7 @@
</span><span class="cx"> if (cw > 0 || (!cw && (containerLogicalWidth.isFixed() || containerLogicalWidth.isPercent())))
</span><span class="cx"> return adjustContentBoxLogicalWidthForBoxSizing(minimumValueForLength(logicalWidth, cw));
</span><span class="cx"> }
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Intrinsic:
</span><span class="cx"> case MinIntrinsic:
</span><span class="cx"> case Auto:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -979,6 +979,7 @@
</span><span class="cx"> // If the image has neither an intrinsic width nor an intrinsic height, its size is determined as for ‘contain’.
</span><span class="cx"> type = Contain;
</span><span class="cx"> }
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Contain:
</span><span class="cx"> case Cover: {
</span><span class="cx"> float horizontalScaleFactor = imageIntrinsicSize.width()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -908,11 +908,11 @@
</span><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=58608
</span><span class="cx"> if (side == BSTop || side == BSLeft)
</span><span class="cx"> color = color.dark();
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case OUTSET:
</span><span class="cx"> if (borderStyle == OUTSET && (side == BSBottom || side == BSRight))
</span><span class="cx"> color = color.dark();
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case SOLID: {
</span><span class="cx"> StrokeStyle oldStrokeStyle = graphicsContext->strokeStyle();
</span><span class="cx"> graphicsContext->setStrokeStyle(NoStroke);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderQuotecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderQuote.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderQuote.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderQuote.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx"> return emptyString();
</span><span class="cx"> case OPEN_QUOTE:
</span><span class="cx"> isOpenQuote = true;
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case CLOSE_QUOTE:
</span><span class="cx"> if (const QuotesData* quotes = style().quotes())
</span><span class="cx"> return isOpenQuote ? quotes->openQuote(m_depth).impl() : quotes->closeQuote(m_depth).impl();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderReplacedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderReplaced.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -329,7 +329,7 @@
</span><span class="cx"> finalRect.setSize(finalRect.size().fitToAspectRatio(intrinsicSize, objectFit == ObjectFitCover ? AspectRatioFitGrow : AspectRatioFitShrink));
</span><span class="cx"> if (objectFit != ObjectFitScaleDown || finalRect.width() <= intrinsicSize.width())
</span><span class="cx"> break;
</span><del>- // fall through
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case ObjectFitNone:
</span><span class="cx"> finalRect.setSize(intrinsicSize);
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTable.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> wrapInAnonymousSection = false;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- // Fall through.
</del><ins>+ FALLTHROUGH;
</ins><span class="cx"> case TABLE_ROW_GROUP:
</span><span class="cx"> resetSectionPointerIfNotBefore(m_firstBody, beforeChild);
</span><span class="cx"> if (!m_firstBody)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -181,6 +181,7 @@
</span><span class="cx"> style.font().update(0);
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -1456,6 +1456,7 @@
</span><span class="cx"> switch (v.type()) {
</span><span class="cx"> case Auto:
</span><span class="cx"> fontWordSpacing = 0;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case Percent:
</span><span class="cx"> fontWordSpacing = v.getFloatValue() * font().spaceWidth() / 100;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -85,6 +85,7 @@
</span><span class="cx"> case SVGPaint::SVG_PAINTTYPE_URI_RGBCOLOR:
</span><span class="cx"> case SVGPaint::SVG_PAINTTYPE_URI_RGBCOLOR_ICCCOLOR:
</span><span class="cx"> color = applyToFill ? svgStyle.fillPaintColor() : svgStyle.strokePaintColor();
</span><ins>+ break;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGMarkerDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGMarkerData.h (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGMarkerData.h 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/rendering/svg/SVGMarkerData.h 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -127,6 +127,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case PathElementMoveToPoint:
</span><span class="cx"> m_subpathStart = points[0];
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathElementAddLineToPoint:
</span><span class="cx"> updateInslope(points[0]);
</span><span class="cx"> m_origin = points[0];
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPathParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPathParser.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPathParser.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/svg/SVGPathParser.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -314,24 +314,28 @@
</span><span class="cx"> switch (command) {
</span><span class="cx"> case PathSegMoveToRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegMoveToAbs:
</span><span class="cx"> if (!parseMoveToSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegLineToRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegLineToAbs:
</span><span class="cx"> if (!parseLineToSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegLineToHorizontalRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegLineToHorizontalAbs:
</span><span class="cx"> if (!parseLineToHorizontalSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegLineToVerticalRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegLineToVerticalAbs:
</span><span class="cx"> if (!parseLineToVerticalSegment())
</span><span class="cx"> return false;
</span><span class="lines">@@ -341,30 +345,35 @@
</span><span class="cx"> break;
</span><span class="cx"> case PathSegCurveToCubicRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegCurveToCubicAbs:
</span><span class="cx"> if (!parseCurveToCubicSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegCurveToCubicSmoothRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegCurveToCubicSmoothAbs:
</span><span class="cx"> if (!parseCurveToCubicSmoothSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegCurveToQuadraticRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegCurveToQuadraticAbs:
</span><span class="cx"> if (!parseCurveToQuadraticSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegCurveToQuadraticSmoothRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegCurveToQuadraticSmoothAbs:
</span><span class="cx"> if (!parseCurveToQuadraticSmoothSegment())
</span><span class="cx"> return false;
</span><span class="cx"> break;
</span><span class="cx"> case PathSegArcRel:
</span><span class="cx"> m_mode = RelativeCoordinates;
</span><ins>+ FALLTHROUGH;
</ins><span class="cx"> case PathSegArcAbs:
</span><span class="cx"> if (!parseArcToSegment())
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTransformDistancecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTransformDistance.cpp (162906 => 162907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTransformDistance.cpp 2014-01-28 04:04:45 UTC (rev 162906)
+++ trunk/Source/WebCore/svg/SVGTransformDistance.cpp 2014-01-28 04:04:52 UTC (rev 162907)
</span><span class="lines">@@ -58,6 +58,9 @@
</span><span class="cx"> switch (m_type) {
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_MATRIX:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case SVGTransform::SVG_TRANSFORM_UNKNOWN:
</span><span class="cx"> break;
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_ROTATE: {
</span><span class="lines">@@ -90,6 +93,9 @@
</span><span class="cx"> switch (m_type) {
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_MATRIX:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case SVGTransform::SVG_TRANSFORM_UNKNOWN:
</span><span class="cx"> return SVGTransformDistance();
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_ROTATE:
</span><span class="lines">@@ -120,6 +126,9 @@
</span><span class="cx"> switch (first.type()) {
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_MATRIX:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case SVGTransform::SVG_TRANSFORM_UNKNOWN:
</span><span class="cx"> return SVGTransform();
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_ROTATE: {
</span><span class="lines">@@ -159,6 +168,9 @@
</span><span class="cx"> switch (m_type) {
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_MATRIX:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case SVGTransform::SVG_TRANSFORM_UNKNOWN:
</span><span class="cx"> return SVGTransform();
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_TRANSLATE: {
</span><span class="lines">@@ -200,6 +212,9 @@
</span><span class="cx"> switch (m_type) {
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_MATRIX:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><ins>+#if ASSERT_DISABLED
+ FALLTHROUGH;
+#endif
</ins><span class="cx"> case SVGTransform::SVG_TRANSFORM_UNKNOWN:
</span><span class="cx"> return 0;
</span><span class="cx"> case SVGTransform::SVG_TRANSFORM_ROTATE:
</span></span></pre>
</div>
</div>
</body>
</html>