<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162806] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162806">162806</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-01-26 13:21:39 -0800 (Sun, 26 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move lastVisitWasHTTPNonGet out to WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=127657
Reviewed by Dan Bernstein.
Source/WebCore:
Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
* history/HistoryItem.h:
Source/WebKit/mac:
Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
* History/WebHistory.mm:
(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
Set entry->_private->_lastVisitWasHTTPNonGet.
* History/WebHistoryItem.h:
Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
Assign _private->_lastVisitWasHTTPNonGet.
(-[WebHistoryItem initFromDictionaryRepresentation:]):
Set _private->_lastVisitWasHTTPNonGet.
* History/WebHistoryItemInternal.h:
Move WebHistoryItemPrivate interface here.
Source/WebKit/win:
Remove uses of lastVisitWasHTTPNonGet.
* WebHistory.cpp:
(WebHistory::visitedURL):
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::lastVisitWasHTTPNonGet):
(WebHistoryItem::setLastVisitWasHTTPNonGet):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemcpp">trunk/Source/WebCore/history/HistoryItem.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemh">trunk/Source/WebCore/history/HistoryItem.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistorymm">trunk/Source/WebKit/mac/History/WebHistory.mm</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryItemh">trunk/Source/WebKit/mac/History/WebHistoryItem.h</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryItemmm">trunk/Source/WebKit/mac/History/WebHistoryItem.mm</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryItemInternalh">trunk/Source/WebKit/mac/History/WebHistoryItemInternal.h</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebHistorycpp">trunk/Source/WebKit/win/WebHistory.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebHistoryItemcpp">trunk/Source/WebKit/win/WebHistoryItem.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebCore/ChangeLog 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-01-26 Anders Carlsson <andersca@apple.com>
+
+ Move lastVisitWasHTTPNonGet out to WebHistoryItem
+ https://bugs.webkit.org/show_bug.cgi?id=127657
+
+ Reviewed by Dan Bernstein.
+
+ Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ (WebCore::HistoryItem::reset):
+ * history/HistoryItem.h:
+
</ins><span class="cx"> 2014-01-26 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.cpp (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.cpp 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -61,7 +61,6 @@
</span><span class="cx">
</span><span class="cx"> HistoryItem::HistoryItem()
</span><span class="cx"> : m_lastVisitedTime(0)
</span><del>- , m_lastVisitWasHTTPNonGet(false)
</del><span class="cx"> , m_pageScaleFactor(0)
</span><span class="cx"> , m_lastVisitWasFailure(false)
</span><span class="cx"> , m_isTargetItem(false)
</span><span class="lines">@@ -83,7 +82,6 @@
</span><span class="cx"> , m_originalURLString(urlString)
</span><span class="cx"> , m_title(title)
</span><span class="cx"> , m_lastVisitedTime(time)
</span><del>- , m_lastVisitWasHTTPNonGet(false)
</del><span class="cx"> , m_pageScaleFactor(0)
</span><span class="cx"> , m_lastVisitWasFailure(false)
</span><span class="cx"> , m_isTargetItem(false)
</span><span class="lines">@@ -107,7 +105,6 @@
</span><span class="cx"> , m_title(title)
</span><span class="cx"> , m_displayTitle(alternateTitle)
</span><span class="cx"> , m_lastVisitedTime(time)
</span><del>- , m_lastVisitWasHTTPNonGet(false)
</del><span class="cx"> , m_pageScaleFactor(0)
</span><span class="cx"> , m_lastVisitWasFailure(false)
</span><span class="cx"> , m_isTargetItem(false)
</span><span class="lines">@@ -132,7 +129,6 @@
</span><span class="cx"> , m_parent(parent)
</span><span class="cx"> , m_title(title)
</span><span class="cx"> , m_lastVisitedTime(0)
</span><del>- , m_lastVisitWasHTTPNonGet(false)
</del><span class="cx"> , m_pageScaleFactor(0)
</span><span class="cx"> , m_lastVisitWasFailure(false)
</span><span class="cx"> , m_isTargetItem(false)
</span><span class="lines">@@ -166,7 +162,6 @@
</span><span class="cx"> , m_title(item.m_title)
</span><span class="cx"> , m_displayTitle(item.m_displayTitle)
</span><span class="cx"> , m_lastVisitedTime(item.m_lastVisitedTime)
</span><del>- , m_lastVisitWasHTTPNonGet(item.m_lastVisitWasHTTPNonGet)
</del><span class="cx"> , m_scrollPoint(item.m_scrollPoint)
</span><span class="cx"> , m_pageScaleFactor(item.m_pageScaleFactor)
</span><span class="cx"> , m_lastVisitWasFailure(item.m_lastVisitWasFailure)
</span><span class="lines">@@ -214,7 +209,6 @@
</span><span class="cx"> m_displayTitle = String();
</span><span class="cx">
</span><span class="cx"> m_lastVisitedTime = 0;
</span><del>- m_lastVisitWasHTTPNonGet = false;
</del><span class="cx">
</span><span class="cx"> m_lastVisitWasFailure = false;
</span><span class="cx"> m_isTargetItem = false;
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.h (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.h 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebCore/history/HistoryItem.h 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -117,7 +117,6 @@
</span><span class="cx">
</span><span class="cx"> int visitCount() const;
</span><span class="cx"> bool lastVisitWasFailure() const { return m_lastVisitWasFailure; }
</span><del>- bool lastVisitWasHTTPNonGet() const { return m_lastVisitWasHTTPNonGet; }
</del><span class="cx">
</span><span class="cx"> void mergeAutoCompleteHints(HistoryItem* otherItem);
</span><span class="cx">
</span><span class="lines">@@ -158,7 +157,6 @@
</span><span class="cx">
</span><span class="cx"> void setVisitCount(int);
</span><span class="cx"> void setLastVisitWasFailure(bool wasFailure) { m_lastVisitWasFailure = wasFailure; }
</span><del>- void setLastVisitWasHTTPNonGet(bool wasNotGet) { m_lastVisitWasHTTPNonGet = wasNotGet; }
</del><span class="cx">
</span><span class="cx"> void addChildItem(PassRefPtr<HistoryItem>);
</span><span class="cx"> void setChildItem(PassRefPtr<HistoryItem>);
</span><span class="lines">@@ -249,7 +247,6 @@
</span><span class="cx"> String m_displayTitle;
</span><span class="cx">
</span><span class="cx"> double m_lastVisitedTime;
</span><del>- bool m_lastVisitWasHTTPNonGet;
</del><span class="cx">
</span><span class="cx"> IntPoint m_scrollPoint;
</span><span class="cx"> float m_pageScaleFactor;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -1,5 +1,31 @@
</span><span class="cx"> 2014-01-26 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Move lastVisitWasHTTPNonGet out to WebHistoryItem
+ https://bugs.webkit.org/show_bug.cgi?id=127657
+
+ Reviewed by Dan Bernstein.
+
+ Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
+
+ * History/WebHistory.mm:
+ (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
+ Set entry->_private->_lastVisitWasHTTPNonGet.
+
+ * History/WebHistoryItem.h:
+ Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
+
+ * History/WebHistoryItem.mm:
+ (-[WebHistoryItem copyWithZone:]):
+ Assign _private->_lastVisitWasHTTPNonGet.
+
+ (-[WebHistoryItem initFromDictionaryRepresentation:]):
+ Set _private->_lastVisitWasHTTPNonGet.
+
+ * History/WebHistoryItemInternal.h:
+ Move WebHistoryItemPrivate interface here.
+
+2014-01-26 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Turn WebHistoryItemPrivate back into a real Objective-C class
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=127653
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistorymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistory.mm (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistory.mm 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/mac/History/WebHistory.mm 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -938,7 +938,7 @@
</span><span class="cx"> item->setLastVisitWasFailure(wasFailure);
</span><span class="cx">
</span><span class="cx"> if ([method length])
</span><del>- item->setLastVisitWasHTTPNonGet([method caseInsensitiveCompare:@"GET"] && (![[url scheme] caseInsensitiveCompare:@"http"] || ![[url scheme] caseInsensitiveCompare:@"https"]));
</del><ins>+ entry->_private->_lastVisitWasHTTPNonGet = [method caseInsensitiveCompare:@"GET"] && (![[url scheme] caseInsensitiveCompare:@"http"] || ![[url scheme] caseInsensitiveCompare:@"https"]);
</ins><span class="cx">
</span><span class="cx"> item->setRedirectURLs(nullptr);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryItemh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryItem.h (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryItem.h 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/mac/History/WebHistoryItem.h 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> */
</span><span class="cx"> @interface WebHistoryItem : NSObject <NSCopying>
</span><span class="cx"> {
</span><del>-@private
</del><ins>+@package
</ins><span class="cx"> WebHistoryItemPrivate *_private;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryItemmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryItem.mm (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -94,12 +94,6 @@
</span><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><del>-@interface WebHistoryItemPrivate : NSObject {
-@package
- RefPtr<HistoryItem> _historyItem;
-}
-@end
-
</del><span class="cx"> @implementation WebHistoryItemPrivate
</span><span class="cx">
</span><span class="cx"> @end
</span><span class="lines">@@ -177,6 +171,9 @@
</span><span class="cx"> {
</span><span class="cx"> WebCoreThreadViolationCheckRoundOne();
</span><span class="cx"> WebHistoryItem *copy = [[[self class] alloc] initWithWebCoreHistoryItem:core(_private)->copy()];
</span><ins>+
+ copy->_private->_lastVisitWasHTTPNonGet = _private->_lastVisitWasHTTPNonGet;
+
</ins><span class="cx"> historyItemWrappers().set(core(copy->_private), copy);
</span><span class="cx">
</span><span class="cx"> return copy;
</span><span class="lines">@@ -395,7 +392,7 @@
</span><span class="cx"> BOOL lastVisitWasHTTPNonGet = [dict _webkit_boolForKey:lastVisitWasHTTPNonGetKey];
</span><span class="cx"> NSString *tempURLString = [URLString lowercaseString];
</span><span class="cx"> if (lastVisitWasHTTPNonGet && ([tempURLString hasPrefix:@"http:"] || [tempURLString hasPrefix:@"https:"]))
</span><del>- core(_private)->setLastVisitWasHTTPNonGet(lastVisitWasHTTPNonGet);
</del><ins>+ _private->_lastVisitWasHTTPNonGet = lastVisitWasHTTPNonGet;
</ins><span class="cx">
</span><span class="cx"> if (NSArray *redirectURLs = [dict _webkit_arrayForKey:redirectURLsKey]) {
</span><span class="cx"> NSUInteger size = [redirectURLs count];
</span><span class="lines">@@ -679,7 +676,7 @@
</span><span class="cx">
</span><span class="cx"> - (BOOL)_lastVisitWasHTTPNonGet
</span><span class="cx"> {
</span><del>- return core(_private)->lastVisitWasHTTPNonGet();
</del><ins>+ return _private->_lastVisitWasHTTPNonGet;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (NSArray *)_redirectURLs
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryItemInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryItemInternal.h (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryItemInternal.h 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/mac/History/WebHistoryItemInternal.h 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #import "WebBackForwardList.h"
</span><span class="cx"> #import "WebHistoryItemPrivate.h"
</span><del>-#import <wtf/Forward.h>
</del><ins>+#import <wtf/RefPtr.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> class HistoryItem;
</span><span class="lines">@@ -58,3 +58,11 @@
</span><span class="cx"> @interface WebBackForwardList (WebInternal)
</span><span class="cx"> - (void)_close;
</span><span class="cx"> @end
</span><ins>+
+@interface WebHistoryItemPrivate : NSObject {
+@package
+ RefPtr<WebCore::HistoryItem> _historyItem;
+
+ bool _lastVisitWasHTTPNonGet;
+}
+@end
</ins></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/win/ChangeLog 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-01-26 Anders Carlsson <andersca@apple.com>
+
+ Move lastVisitWasHTTPNonGet out to WebHistoryItem
+ https://bugs.webkit.org/show_bug.cgi?id=127657
+
+ Reviewed by Dan Bernstein.
+
+ Remove uses of lastVisitWasHTTPNonGet.
+
+ * WebHistory.cpp:
+ (WebHistory::visitedURL):
+ * WebHistoryItem.cpp:
+ (WebHistoryItem::initFromDictionaryRepresentation):
+ (WebHistoryItem::lastVisitWasHTTPNonGet):
+ (WebHistoryItem::setLastVisitWasHTTPNonGet):
+
</ins><span class="cx"> 2014-01-25 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove an unused FrameLoaderClient function
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebHistorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebHistory.cpp (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebHistory.cpp 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/win/WebHistory.cpp 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -585,8 +585,6 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> entryPrivate->setLastVisitWasFailure(wasFailure);
</span><del>- if (!httpMethod.isEmpty())
- entryPrivate->setLastVisitWasHTTPNonGet(!equalIgnoringCase(httpMethod, "GET") && url.protocolIsInHTTPFamily());
</del><span class="cx">
</span><span class="cx"> COMPtr<WebHistoryItem> item(Query, entry);
</span><span class="cx"> item->historyItem()->setRedirectURLs(nullptr);
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebHistoryItemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebHistoryItem.cpp (162805 => 162806)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebHistoryItem.cpp 2014-01-26 20:04:29 UTC (rev 162805)
+++ trunk/Source/WebKit/win/WebHistoryItem.cpp 2014-01-26 21:21:39 UTC (rev 162806)
</span><span class="lines">@@ -187,9 +187,6 @@
</span><span class="cx"> if (lastVisitWasFailure)
</span><span class="cx"> m_historyItem->setLastVisitWasFailure(true);
</span><span class="cx">
</span><del>- if (lastVisitWasHTTPNonGet && (protocolIs(m_historyItem->urlString(), "http") || protocolIs(m_historyItem->urlString(), "https")))
- m_historyItem->setLastVisitWasHTTPNonGet(true);
-
</del><span class="cx"> if (redirectURLsVector.get())
</span><span class="cx"> m_historyItem->setRedirectURLs(std::move(redirectURLsVector));
</span><span class="cx">
</span><span class="lines">@@ -445,22 +442,16 @@
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+// FIXME: This function should be removed from the IWebHistoryItem interface.
</ins><span class="cx"> HRESULT STDMETHODCALLTYPE WebHistoryItem::lastVisitWasHTTPNonGet(BOOL* HTTPNonGet)
</span><span class="cx"> {
</span><del>- if (!HTTPNonGet) {
- ASSERT_NOT_REACHED();
- return E_POINTER;
- }
-
- *HTTPNonGet = m_historyItem->lastVisitWasHTTPNonGet();
-
- return S_OK;
</del><ins>+ return E_NOTIMPL;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+// FIXME: This function should be removed from the IWebHistoryItem interface.
</ins><span class="cx"> HRESULT STDMETHODCALLTYPE WebHistoryItem::setLastVisitWasHTTPNonGet(BOOL HTTPNonGet)
</span><span class="cx"> {
</span><del>- m_historyItem->setLastVisitWasHTTPNonGet(HTTPNonGet);
- return S_OK;
</del><ins>+ return E_NOTIMPL;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HRESULT STDMETHODCALLTYPE WebHistoryItem::redirectURLs(IEnumVARIANT** urls)
</span></span></pre>
</div>
</div>
</body>
</html>