<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162786] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162786">162786</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-01-25 15:04:54 -0800 (Sat, 25 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove an unused FrameLoaderClient function
https://bugs.webkit.org/show_bug.cgi?id=127628
Reviewed by Andreas Kling.
Source/WebCore:
All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
was only used by Chromium so we can get rid of it.
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::shouldStopLoadingForHistoryItem):
Source/WebKit/efl:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/mac:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit/win:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:
Source/WebKit2:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientsh">trunk/Source/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoaderClienth">trunk/Source/WebCore/loader/FrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebCoreloaderHistoryControllercpp">trunk/Source/WebCore/loader/HistoryController.cpp</a></li>
<li><a href="#trunkSourceWebKiteflChangeLog">trunk/Source/WebKit/efl/ChangeLog</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportFrameLoaderClientEflcpp">trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportFrameLoaderClientEflh">trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h</a></li>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkh">trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebFrameLoaderClientcpp">trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKitwinceChangeLog">trunk/Source/WebKit/wince/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportFrameLoaderClientWinCEcpp">trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportFrameLoaderClientWinCEh">trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebCore/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-25 Anders Carlsson <andersca@apple.com>
+
+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
+ was only used by Chromium so we can get rid of it.
+
+ * loader/EmptyClients.h:
+ * loader/FrameLoaderClient.h:
+ * loader/HistoryController.cpp:
+ (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
+
</ins><span class="cx"> 2014-01-25 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Call deprecatedCharacters instead of characters at more call sites
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -366,7 +366,6 @@
</span><span class="cx"> virtual void updateGlobalHistory() override { }
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() override { }
</span><span class="cx"> virtual bool shouldGoToHistoryItem(HistoryItem*) const override { return false; }
</span><del>- virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const override { return false; }
</del><span class="cx"> virtual void updateGlobalHistoryItemForPage() override { }
</span><span class="cx"> virtual void saveViewStateToItem(HistoryItem*) override { }
</span><span class="cx"> virtual bool canCachePage() const override { return false; }
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -201,7 +201,6 @@
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() = 0;
</span><span class="cx">
</span><span class="cx"> virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const = 0;
</del><span class="cx"> virtual void updateGlobalHistoryItemForPage() { }
</span><span class="cx">
</span><span class="cx"> // This frame has set its opener to null, disowning it for the lifetime of the frame.
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderHistoryControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/HistoryController.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/HistoryController.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebCore/loader/HistoryController.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> if (m_currentItem->shouldDoSameDocumentNavigationTo(targetItem))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- return m_frame.loader().client().shouldStopLoadingForHistoryItem(targetItem);
</del><ins>+ return true;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Main funnel for navigating to a previous location (back/forward, non-search snap-back)
</span></span></pre></div>
<a id="trunkSourceWebKiteflChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-25 Anders Carlsson <andersca@apple.com>
+
+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/FrameLoaderClientEfl.cpp:
+ * WebCoreSupport/FrameLoaderClientEfl.h:
+
</ins><span class="cx"> 2014-01-25 Ryuan Choi <ryuan.choi@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL][WK1] Fix broken rendering while navigating history in EWebLauncher
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportFrameLoaderClientEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -538,11 +538,6 @@
</span><span class="cx"> return item;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClientEfl::shouldStopLoadingForHistoryItem(HistoryItem*) const
-{
- return true;
-}
-
</del><span class="cx"> void FrameLoaderClientEfl::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx"> ewk_frame_mixed_content_displayed_set(m_frame, true);
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportFrameLoaderClientEflh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -150,7 +150,6 @@
</span><span class="cx"> virtual void updateGlobalHistory();
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx"> virtual bool shouldGoToHistoryItem(HistoryItem*) const;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
</del><span class="cx"> virtual void didDisplayInsecureContent();
</span><span class="cx"> virtual void didRunInsecureContent(SecurityOrigin*, const URL&);
</span><span class="cx"> virtual void didDetectXSS(const URL&, bool didBlockEntirePage);
</span></span></pre></div>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-25 Anders Carlsson <andersca@apple.com>
+
+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/FrameLoaderClientGtk.cpp:
+ * WebCoreSupport/FrameLoaderClientGtk.h:
+
</ins><span class="cx"> 2014-01-24 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> GTK+ build fix.
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -621,11 +621,6 @@
</span><span class="cx"> return item != 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) const
-{
- return true;
-}
-
</del><span class="cx"> void FrameLoaderClient::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx"> if (!DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled() || !DumpRenderTreeSupportGtk::s_frameLoadEventCallback)
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -137,7 +137,6 @@
</span><span class="cx"> virtual void updateGlobalHistory();
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx"> virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
</del><span class="cx">
</span><span class="cx"> virtual void didDisplayInsecureContent();
</span><span class="cx"> virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::URL&);
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2014-01-25 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/WebFrameLoaderClient.h:
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+
+2014-01-25 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Build fix.
</span><span class="cx">
</span><span class="cx"> * WebView/WebViewData.h:
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -147,7 +147,6 @@
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() override;
</span><span class="cx">
</span><span class="cx"> virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
</del><span class="cx"> virtual void updateGlobalHistoryItemForPage() override;
</span><span class="cx">
</span><span class="cx"> virtual void didDisplayInsecureContent() override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1134,11 +1134,6 @@
</span><span class="cx"> return [[view _policyDelegateForwarder] webView:view shouldGoToHistoryItem:webItem];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) const
-{
- return true;
-}
-
</del><span class="cx"> void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
</span><span class="cx"> {
</span><span class="cx"> HistoryItem* historyItem = 0;
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/win/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2014-01-25 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/WebFrameLoaderClient.cpp:
+ * WebCoreSupport/WebFrameLoaderClient.h:
+
+2014-01-25 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Modernize HashTable threading code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=127621
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -814,11 +814,6 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem*) const
-{
- return true;
-}
-
</del><span class="cx"> void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
</span><span class="cx"> {
</span><span class="cx"> HistoryItem* historyItem = 0;
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -132,7 +132,6 @@
</span><span class="cx"> virtual void updateGlobalHistory() override;
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() override;
</span><span class="cx"> virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
</del><span class="cx"> virtual void updateGlobalHistoryItemForPage() override;
</span><span class="cx">
</span><span class="cx"> virtual void didDisplayInsecureContent() override;
</span></span></pre></div>
<a id="trunkSourceWebKitwinceChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/wince/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-25 Anders Carlsson <andersca@apple.com>
+
+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/FrameLoaderClientWinCE.cpp:
+ * WebCoreSupport/FrameLoaderClientWinCE.h:
+
</ins><span class="cx"> 2014-01-17 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove another unused FrameLoaderClient callback
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportFrameLoaderClientWinCEcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -243,11 +243,6 @@
</span><span class="cx"> return item;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem(HistoryItem* item) const
-{
- return true;
-}
-
</del><span class="cx"> void FrameLoaderClientWinCE::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportFrameLoaderClientWinCEh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -130,7 +130,6 @@
</span><span class="cx"> virtual void updateGlobalHistory() override;
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() override;
</span><span class="cx"> virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
</del><span class="cx">
</span><span class="cx"> virtual void didDisplayInsecureContent() override;
</span><span class="cx"> virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::URL&) override;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2014-01-25 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove an unused FrameLoaderClient function
+ https://bugs.webkit.org/show_bug.cgi?id=127628
+
+ Reviewed by Andreas Kling.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+
+2014-01-25 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Remove atomicIncrement/atomicDecrement
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=127625
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -946,11 +946,6 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem*) const
-{
- return true;
-}
-
</del><span class="cx"> void WebFrameLoaderClient::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx"> WebPage* webPage = m_frame->page();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (162785 => 162786)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 22:58:43 UTC (rev 162785)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-01-25 23:04:54 UTC (rev 162786)
</span><span class="lines">@@ -129,7 +129,6 @@
</span><span class="cx"> virtual void updateGlobalHistoryRedirectLinks() override;
</span><span class="cx">
</span><span class="cx"> virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
</span><del>- virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
</del><span class="cx">
</span><span class="cx"> virtual void didDisplayInsecureContent() override;
</span><span class="cx"> virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::URL&) override;
</span></span></pre>
</div>
</div>
</body>
</html>