<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162683] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162683">162683</a></dd>
<dt>Author</dt> <dd>changseok.oh@collabora.com</dd>
<dt>Date</dt> <dd>2014-01-23 20:12:23 -0800 (Thu, 23 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Dragging from inner side of video to outside causes a crash
https://bugs.webkit.org/show_bug.cgi?id=126338
Reviewed by Jer Noble.
Source/WebCore:
The crash happens while dragging mouse cursor through timeline control to outside
of video region. This is beacause media controls are selected with the drag.
The media controls disappear when mouse cursor goes outside of video though
the dragging/selection proceeds. If once media controls are hidden, related element
lose their renderers. However the drag is still under going. it requires shadowPseudoId
of the selected controls. Untorntunately, SliderThumbElement/SliderContainerElement
don't return a static value for the shadowPseudoId unlike other media controls,
but they need a renderer to determine it. This is the reason of crash.
Test: media/media-controller-drag-crash.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
LayoutTests:
This tests that dragging through timeslider control to outside of video causes a crash.
The crash happened on both gtk+ and efl ports not using MEDIA_CONTROL_SCRIPT.
* media/media-controller-drag-crash-expected.txt: Added.
* media/media-controller-drag-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamediacontrollerdragcrashexpectedtxt">trunk/LayoutTests/media/media-controller-drag-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamediacontrollerdragcrashhtml">trunk/LayoutTests/media/media-controller-drag-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162682 => 162683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-24 03:52:30 UTC (rev 162682)
+++ trunk/LayoutTests/ChangeLog 2014-01-24 04:12:23 UTC (rev 162683)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-01-23 ChangSeok Oh <changseok.oh@collabora.com>
+
+ Dragging from inner side of video to outside causes a crash
+ https://bugs.webkit.org/show_bug.cgi?id=126338
+
+ Reviewed by Jer Noble.
+
+ This tests that dragging through timeslider control to outside of video causes a crash.
+ The crash happened on both gtk+ and efl ports not using MEDIA_CONTROL_SCRIPT.
+
+ * media/media-controller-drag-crash-expected.txt: Added.
+ * media/media-controller-drag-crash.html: Added.
+
</ins><span class="cx"> 2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
</span><span class="cx">
</span><span class="cx"> Assertion failure in WebCore::PseudoElement::didRecalcStyle()
</span></span></pre></div>
<a id="trunkLayoutTestsmediamediacontrollerdragcrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-controller-drag-crash-expected.txt (0 => 162683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-controller-drag-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-controller-drag-crash-expected.txt 2014-01-24 04:12:23 UTC (rev 162683)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+Test that dragging through the timebar causes a crash.
+
+
+EVENT(canplaythrough)
+RUN(video.play())
+Mouse dragging.
+No crash. PASS.
+END OF TEST
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamediacontrollerdragcrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-controller-drag-crash.html (0 => 162683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-controller-drag-crash.html (rev 0)
+++ trunk/LayoutTests/media/media-controller-drag-crash.html 2014-01-24 04:12:23 UTC (rev 162683)
</span><span class="lines">@@ -0,0 +1,59 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Dragging through timebar test</title>
+ <script src=media-controls.js></script>
+ <script src=media-file.js></script>
+ <script src=video-test.js></script>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function test()
+ {
+ run('video.play()');
+
+ if (window.eventSender) {
+ consoleWrite("Mouse dragging.");
+
+ var timelineCoordinate;
+ try {
+ timelineCoordinate = mediaControlsButtonCoordinates(video, "timeline");
+ } catch (exception) {
+ failTest(exception.description);
+ return;
+ }
+ var x = timelineCoordinate[0];
+ var y = timelineCoordinate[1];
+
+ eventSender.dragMode = false;
+ eventSender.mouseMoveTo(x, y - 100);
+ eventSender.mouseDown();
+ eventSender.mouseMoveTo(x, y);
+ eventSender.mouseMoveTo(x, y + 100);
+ }
+ window.setTimeout("finish()", 1000);
+ }
+
+ function finish()
+ {
+ consoleWrite("No crash. PASS.")
+ if (window.eventSender)
+ eventSender.mouseUp();
+ endTest();
+ }
+
+ function start()
+ {
+ findMediaElement();
+ waitForEvent('canplaythrough', test);
+ video.src = findMediaFile("video", "content/test");
+ }
+ </script>
+ </head>
+ <body onload="start()">
+ <p>Test that dragging through the timebar causes a crash.</p>
+ <video controls></video>
+ </body>
+</html>
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162682 => 162683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-24 03:52:30 UTC (rev 162682)
+++ trunk/Source/WebCore/ChangeLog 2014-01-24 04:12:23 UTC (rev 162683)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-01-23 ChangSeok Oh <changseok.oh@collabora.com>
+
+ Dragging from inner side of video to outside causes a crash
+ https://bugs.webkit.org/show_bug.cgi?id=126338
+
+ Reviewed by Jer Noble.
+
+ The crash happens while dragging mouse cursor through timeline control to outside
+ of video region. This is beacause media controls are selected with the drag.
+ The media controls disappear when mouse cursor goes outside of video though
+ the dragging/selection proceeds. If once media controls are hidden, related element
+ lose their renderers. However the drag is still under going. it requires shadowPseudoId
+ of the selected controls. Untorntunately, SliderThumbElement/SliderContainerElement
+ don't return a static value for the shadowPseudoId unlike other media controls,
+ but they need a renderer to determine it. This is the reason of crash.
+
+ Test: media/media-controller-drag-crash.html
+
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::shadowPseudoId):
+ (WebCore::SliderContainerElement::shadowPseudoId):
+
</ins><span class="cx"> 2014-01-23 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IDB: Implement SQLite backing store 'get' support
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (162682 => 162683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-01-24 03:52:30 UTC (rev 162682)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-01-24 04:12:23 UTC (rev 162683)
</span><span class="lines">@@ -579,6 +579,8 @@
</span><span class="cx"> HTMLInputElement* input = hostInput();
</span><span class="cx"> if (!input)
</span><span class="cx"> return sliderThumbShadowPseudoId();
</span><ins>+ if (!input->renderer())
+ return emptyAtom;
</ins><span class="cx">
</span><span class="cx"> const RenderStyle& sliderStyle = input->renderer()->style();
</span><span class="cx"> switch (sliderStyle.appearance()) {
</span><span class="lines">@@ -624,6 +626,8 @@
</span><span class="cx"> HTMLInputElement* input = shadowHost()->toInputElement();
</span><span class="cx"> if (!input)
</span><span class="cx"> return sliderContainer;
</span><ins>+ if (!input->renderer())
+ return emptyAtom;
</ins><span class="cx">
</span><span class="cx"> const RenderStyle& sliderStyle = input->renderer()->style();
</span><span class="cx"> switch (sliderStyle.appearance()) {
</span></span></pre>
</div>
</div>
</body>
</html>