<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162679] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162679">162679</a></dd>
<dt>Author</dt> <dd>jhoneycutt@apple.com</dd>
<dt>Date</dt> <dd>2014-01-23 18:55:15 -0800 (Thu, 23 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>
Source/WebCore:
Reviewed by Andy Estes.
Test: fast/images/animate-list-item-image-assertion.html
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
Check isRenderImage() rather than isImage() before casting to
RenderImage.
* editing/ios/EditorIOS.mm:
(WebCore::getImage):
Ditto.
* editing/mac/EditorMac.mm:
(WebCore::getImage):
Ditto.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::didAttachRenderers):
Ditto.
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
Ditto.
* page/DragController.cpp:
(WebCore::getCachedImage):
Ditto.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
(WebCore::RenderLayerBacking::updateImageContents):
Ditto.
Source/WebKit/mac:
Some areas of code were erroneously checking the value of
RenderObject::isImage() rather than RenderObject::isRenderImage()
before casting the object to RenderImage.
This could lead to an assertion failure for RenderListMarkers, which
may return true for isImage(), but are not RenderImages.
Reviewed by Andy Estes.
* Misc/WebNSPasteboardExtras.mm:
(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
Check isRenderImage() rather than isImage() before casting to
RenderImage.
Source/WebKit2:
Reviewed by Andy Estes.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Check isRenderImage() rather than isImage() before casting to
RenderImage.
LayoutTests:
Reviewed by Andy Estes.
* fast/images/animate-list-item-image-assertion-expected.txt: Added.
* fast/images/animate-list-item-image-assertion.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomPseudoElementcpp">trunk/Source/WebCore/dom/PseudoElement.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingiosEditorIOSmm">trunk/Source/WebCore/editing/ios/EditorIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreeditingmacEditorMacmm">trunk/Source/WebCore/editing/mac/EditorMac.mm</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAreaElementcpp">trunk/Source/WebCore/html/HTMLAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLImageElementcpp">trunk/Source/WebCore/html/HTMLImageElement.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderImageLoadercpp">trunk/Source/WebCore/loader/ImageLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDragControllercpp">trunk/Source/WebCore/page/DragController.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacMiscWebNSPasteboardExtrasmm">trunk/Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastimagesanimatelistitemimageassertionexpectedtxt">trunk/LayoutTests/fast/images/animate-list-item-image-assertion-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastimagesanimatelistitemimageassertionhtml">trunk/LayoutTests/fast/images/animate-list-item-image-assertion.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/LayoutTests/ChangeLog 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Assertion failure in WebCore::PseudoElement::didRecalcStyle()
+ <https://bugs.webkit.org/show_bug.cgi?id=126761>
+ <rdar://problem/15793540>
+
+ Reviewed by Andy Estes.
+
+ * fast/images/animate-list-item-image-assertion-expected.txt: Added.
+ * fast/images/animate-list-item-image-assertion.html: Added.
+
</ins><span class="cx"> 2014-01-23 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
</span></span></pre></div>
<a id="trunkLayoutTestsfastimagesanimatelistitemimageassertionexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/images/animate-list-item-image-assertion-expected.txt (0 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/images/animate-list-item-image-assertion-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/animate-list-item-image-assertion-expected.txt 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASSED
</ins></span></pre></div>
<a id="trunkLayoutTestsfastimagesanimatelistitemimageassertionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/images/animate-list-item-image-assertion.html (0 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/images/animate-list-item-image-assertion.html (rev 0)
+++ trunk/LayoutTests/fast/images/animate-list-item-image-assertion.html 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<!DOCTYPE html>
+
+<!-- Test passes if it doesn't assert in a debug build. -->
+
+<style>
+ #anchor:after {
+ content: ".";
+ display: block;
+ }
+ span {
+ float: left;
+ }
+ ul {
+ -webkit-animation-name: n;
+ -webkit-animation-duration: .1s;
+ }
+ @-webkit-keyframes n {
+ from { }
+ to { list-style-image: -webkit-repeating-radial-gradient(circle cover, rgb(23,136,16) , rgb(2%,5%,72%) , #373f74); }
+ }
+</style>
+
+<ul id="u">
+ <li>
+ <a id="anchor" href="#"><span id="text">PASSED</span></a>
+ </li>
+</ul>
+
+<script>
+ if (window.testRunner) {
+ window.testRunner.dumpAsText(true);
+ window.testRunner.waitUntilDone();
+
+ document.getElementById("u").addEventListener('webkitAnimationStart', function() {
+ window.testRunner.notifyDone();
+ }, false);
+ }
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/ChangeLog 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Assertion failure in WebCore::PseudoElement::didRecalcStyle()
+ <https://bugs.webkit.org/show_bug.cgi?id=126761>
+ <rdar://problem/15793540>
+
+ Reviewed by Andy Estes.
+
+ Test: fast/images/animate-list-item-image-assertion.html
+
+ * dom/PseudoElement.cpp:
+ (WebCore::PseudoElement::didRecalcStyle):
+ Check isRenderImage() rather than isImage() before casting to
+ RenderImage.
+
+ * editing/ios/EditorIOS.mm:
+ (WebCore::getImage):
+ Ditto.
+
+ * editing/mac/EditorMac.mm:
+ (WebCore::getImage):
+ Ditto.
+
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseAttribute):
+ (WebCore::HTMLImageElement::didAttachRenderers):
+ Ditto.
+
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::renderImageResource):
+ Ditto.
+
+ * page/DragController.cpp:
+ (WebCore::getCachedImage):
+ Ditto.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
+ (WebCore::RenderLayerBacking::updateImageContents):
+ Ditto.
+
</ins><span class="cx"> 2014-01-23 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
</span></span></pre></div>
<a id="trunkSourceWebCoredomPseudoElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/PseudoElement.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/PseudoElement.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/dom/PseudoElement.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> RenderObject* renderer = this->renderer();
</span><span class="cx"> for (RenderObject* child = renderer->nextInPreOrder(renderer); child; child = child->nextInPreOrder(renderer)) {
</span><span class="cx"> // We only manage the style for the generated content which must be images or text.
</span><del>- if (!child->isImage())
</del><ins>+ if (!child->isRenderImage())
</ins><span class="cx"> continue;
</span><span class="cx"> toRenderImage(*child).setStyle(RenderImage::createStyleInheritingFromPseudoStyle(renderer->style()));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingiosEditorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -345,7 +345,7 @@
</span><span class="cx"> static void getImage(Element& imageElement, RefPtr<Image>& image, CachedImage*& cachedImage)
</span><span class="cx"> {
</span><span class="cx"> auto renderer = imageElement.renderer();
</span><del>- if (!renderer || !renderer->isImage())
</del><ins>+ if (!renderer || !renderer->isRenderImage())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> CachedImage* tentativeCachedImage = toRenderImage(renderer)->cachedImage();
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmacEditorMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/mac/EditorMac.mm (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/mac/EditorMac.mm 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/editing/mac/EditorMac.mm 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -366,7 +366,7 @@
</span><span class="cx"> static void getImage(Element& imageElement, RefPtr<Image>& image, CachedImage*& cachedImage)
</span><span class="cx"> {
</span><span class="cx"> auto renderer = imageElement.renderer();
</span><del>- if (!renderer || !renderer->isImage())
</del><ins>+ if (!renderer || !renderer->isRenderImage())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> CachedImage* tentativeCachedImage = toRenderImage(renderer)->cachedImage();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAreaElement.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAreaElement.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/html/HTMLAreaElement.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> auto renderer = imageElement->renderer();
</span><del>- if (!renderer || !renderer->isImage())
</del><ins>+ if (!renderer || !renderer->isRenderImage())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> toRenderImage(renderer)->areaElementFocusChanged(this);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
</span><span class="cx"> {
</span><span class="cx"> if (name == altAttr) {
</span><del>- if (renderer() && renderer()->isImage())
</del><ins>+ if (renderer() && renderer()->isRenderImage())
</ins><span class="cx"> toRenderImage(renderer())->updateAltText();
</span><span class="cx"> } else if (name == srcAttr || name == srcsetAttr) {
</span><span class="cx"> m_bestFitImageURL = bestFitSourceForImageAttributes(document().deviceScaleFactor(), fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx">
</span><span class="cx"> void HTMLImageElement::didAttachRenderers()
</span><span class="cx"> {
</span><del>- if (!renderer() || !renderer()->isImage())
</del><ins>+ if (!renderer() || !renderer()->isRenderImage())
</ins><span class="cx"> return;
</span><span class="cx"> if (m_imageLoader.hasPendingBeforeLoadEvent())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderImageLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ImageLoader.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ImageLoader.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/loader/ImageLoader.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -325,7 +325,7 @@
</span><span class="cx">
</span><span class="cx"> // We don't return style generated image because it doesn't belong to the ImageLoader.
</span><span class="cx"> // See <https://bugs.webkit.org/show_bug.cgi?id=42840>
</span><del>- if (renderer->isImage() && !toRenderImage(*renderer).isGeneratedContent())
</del><ins>+ if (renderer->isRenderImage() && !toRenderImage(*renderer).isGeneratedContent())
</ins><span class="cx"> return &toRenderImage(*renderer).imageResource();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(SVG)
</span></span></pre></div>
<a id="trunkSourceWebCorepageDragControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DragController.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DragController.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/page/DragController.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -655,7 +655,7 @@
</span><span class="cx"> static CachedImage* getCachedImage(Element& element)
</span><span class="cx"> {
</span><span class="cx"> RenderObject* renderer = element.renderer();
</span><del>- if (!renderer || !renderer->isImage())
</del><ins>+ if (!renderer || !renderer->isRenderImage())
</ins><span class="cx"> return 0;
</span><span class="cx"> RenderImage* image = toRenderImage(renderer);
</span><span class="cx"> return image->cachedImage();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -1865,7 +1865,7 @@
</span><span class="cx"> // that require painting. Direct compositing saves backing store.
</span><span class="cx"> bool RenderLayerBacking::isDirectlyCompositedImage() const
</span><span class="cx"> {
</span><del>- if (!renderer().isImage() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
</del><ins>+ if (!renderer().isRenderImage() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> RenderImage& imageRenderer = toRenderImage(renderer());
</span><span class="lines">@@ -1912,7 +1912,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderLayerBacking::updateImageContents()
</span><span class="cx"> {
</span><del>- ASSERT(renderer().isImage());
</del><ins>+ ASSERT(renderer().isRenderImage());
</ins><span class="cx"> RenderImage& imageRenderer = toRenderImage(renderer());
</span><span class="cx">
</span><span class="cx"> CachedImage* cachedImage = imageRenderer.cachedImage();
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Assertion failure in WebCore::PseudoElement::didRecalcStyle()
+ <https://bugs.webkit.org/show_bug.cgi?id=126761>
+ <rdar://problem/15793540>
+
+ Some areas of code were erroneously checking the value of
+ RenderObject::isImage() rather than RenderObject::isRenderImage()
+ before casting the object to RenderImage.
+
+ This could lead to an assertion failure for RenderListMarkers, which
+ may return true for isImage(), but are not RenderImages.
+
+ Reviewed by Andy Estes.
+
+ * Misc/WebNSPasteboardExtras.mm:
+ (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
+ Check isRenderImage() rather than isImage() before casting to
+ RenderImage.
+
</ins><span class="cx"> 2014-01-23 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
</span></span></pre></div>
<a id="trunkSourceWebKitmacMiscWebNSPasteboardExtrasmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx">
</span><span class="cx"> NSString *extension = @"";
</span><span class="cx"> if (RenderObject* renderer = core(element)->renderer()) {
</span><del>- if (renderer->isImage()) {
</del><ins>+ if (renderer->isRenderImage()) {
</ins><span class="cx"> if (CachedImage* image = toRenderImage(renderer)->cachedImage()) {
</span><span class="cx"> extension = image->image()->filenameExtension();
</span><span class="cx"> if (![extension length])
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Assertion failure in WebCore::PseudoElement::didRecalcStyle()
+ <https://bugs.webkit.org/show_bug.cgi?id=126761>
+ <rdar://problem/15793540>
+
+ Reviewed by Andy Estes.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::getPositionInformation):
+ Check isRenderImage() rather than isImage() before casting to
+ RenderImage.
+
</ins><span class="cx"> 2014-01-23 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Move policy client into WKPage.cpp and get rid of WebPolicyClient files
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (162678 => 162679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-01-24 02:49:42 UTC (rev 162678)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-01-24 02:55:15 UTC (rev 162679)
</span><span class="lines">@@ -823,7 +823,7 @@
</span><span class="cx"> if (!element)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (element->renderer() && element->renderer()->isImage()) {
</del><ins>+ if (element->renderer() && element->renderer()->isRenderImage()) {
</ins><span class="cx"> URL url = toRenderImage(element->renderer())->cachedImage()->url();
</span><span class="cx"> if (!url.string().isNull())
</span><span class="cx"> info.url = url.string();
</span></span></pre>
</div>
</div>
</body>
</html>