<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162601] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162601">162601</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-23 00:36:56 -0800 (Thu, 23 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Range should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115639
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-23
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://www.w3.org/TR/2013/WD-dom-20131107/#interface-range
Now we can do `new Range()` instead of `document.createRange()`.
Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/47ca40efdf58a4787aa33aa75a35778899b1c002%5E%21
Test: fast/dom/Range/range-constructor.html
* dom/Range.cpp:
(WebCore::Range::create):
* dom/Range.h:
* dom/Range.idl:
LayoutTests:
* fast/dom/Range/range-constructor-expected.txt: Added.
* fast/dom/Range/range-constructor.html: Added.
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomdomconstructorsexpectedtxt">trunk/LayoutTests/fast/dom/dom-constructors-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomdomconstructorshtml">trunk/LayoutTests/fast/dom/dom-constructors.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomRangecpp">trunk/Source/WebCore/dom/Range.cpp</a></li>
<li><a href="#trunkSourceWebCoredomRangeh">trunk/Source/WebCore/dom/Range.h</a></li>
<li><a href="#trunkSourceWebCoredomRangeidl">trunk/Source/WebCore/dom/Range.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomRangerangeconstructorexpectedtxt">trunk/LayoutTests/fast/dom/Range/range-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomRangerangeconstructorhtml">trunk/LayoutTests/fast/dom/Range/range-constructor.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/LayoutTests/ChangeLog 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-23 László Langó <llango.u-szeged@partner.samsung.com>
+
+ Range should be constructable.
+ https://bugs.webkit.org/show_bug.cgi?id=115639
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/dom/Range/range-constructor-expected.txt: Added.
+ * fast/dom/Range/range-constructor.html: Added.
+ * fast/dom/dom-constructors-expected.txt:
+ * fast/dom/dom-constructors.html:
+
</ins><span class="cx"> 2014-01-22 Jinwoo Song <jinwoo7.song@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL gardening after r162553.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomRangerangeconstructorexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Range/range-constructor-expected.txt (0 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Range/range-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Range/range-constructor-expected.txt 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+Tests that we can create instances of Range using new
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS typeof new Range is "object"
+PASS Object.prototype.toString.call(new Range) is "[object Range]"
+PASS new Range instanceof Range is true
+PASS Object.getPrototypeOf(new Range) is Range.prototype
+PASS r.toString() is "Test"
+PASS new innerWindow.Range instanceof innerWindow.Range is true
+PASS Object.getPrototypeOf(new innerWindow.Range) is innerWindow.Range.prototype
+PASS r.toString() is "Inner"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Test
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomRangerangeconstructorhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Range/range-constructor.html (0 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Range/range-constructor.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Range/range-constructor.html 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test-pre.js"></script>
+<div id="test-div">Test</div>
+<script>
+
+description('Tests that we can create instances of Range using new');
+
+shouldBe('typeof new Range', '"object"');
+shouldBe('Object.prototype.toString.call(new Range)', '"[object Range]"');
+shouldBeTrue('new Range instanceof Range');
+shouldBe('Object.getPrototypeOf(new Range)', 'Range.prototype');
+
+var r = new Range();
+r.selectNodeContents(document.getElementById('test-div'));
+shouldBe('r.toString()', '"Test"')
+
+var frame = document.createElement('iframe');
+document.body.appendChild(frame);
+var innerWindow = frame.contentWindow;
+var innerDocument = frame.contentDocument;
+innerDocument.body.textContent = 'Inner';
+
+shouldBeTrue('new innerWindow.Range instanceof innerWindow.Range');
+shouldBe('Object.getPrototypeOf(new innerWindow.Range)', 'innerWindow.Range.prototype');
+
+var r = new innerWindow.Range();
+r.selectNodeContents(innerDocument.body);
+shouldBe('r.toString()', '"Inner"');
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomdomconstructorsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -98,7 +98,6 @@
</span><span class="cx"> PASS TryAllocate('NodeList') is 'exception'
</span><span class="cx"> PASS TryAllocate('Plugin') is 'exception'
</span><span class="cx"> PASS TryAllocate('PluginArray') is 'exception'
</span><del>-PASS TryAllocate('Range') is 'exception'
</del><span class="cx"> PASS TryAllocate('Rect') is 'exception'
</span><span class="cx"> PASS TryAllocate('StyleSheet') is 'exception'
</span><span class="cx"> PASS TryAllocate('StyleSheetList') is 'exception'
</span><span class="lines">@@ -135,6 +134,9 @@
</span><span class="cx"> PASS TryAllocate('DocumentFragment') is '[object DocumentFragment]'
</span><span class="cx"> PASS TryAllocate('DocumentFragment') is '[object DocumentFragment]'
</span><span class="cx"> PASS TryAllocate('DocumentFragment') is '[object DocumentFragment]'
</span><ins>+PASS TryAllocate('Range') is '[object Range]'
+PASS TryAllocate('Range') is '[object Range]'
+PASS TryAllocate('Range') is '[object Range]'
</ins><span class="cx"> PASS TryAllocate('Text') is '[object Text]'
</span><span class="cx"> PASS TryAllocate('Text') is '[object Text]'
</span><span class="cx"> PASS TryAllocate('Text') is '[object Text]'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdomconstructorshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dom-constructors.html 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -108,7 +108,6 @@
</span><span class="cx"> 'NodeList',
</span><span class="cx"> 'Plugin',
</span><span class="cx"> 'PluginArray',
</span><del>- 'Range',
</del><span class="cx"> 'Rect',
</span><span class="cx"> 'StyleSheet',
</span><span class="cx"> 'StyleSheetList',
</span><span class="lines">@@ -137,6 +136,7 @@
</span><span class="cx"> 'Comment',
</span><span class="cx"> 'DOMParser',
</span><span class="cx"> 'DocumentFragment',
</span><ins>+ 'Range',
</ins><span class="cx"> 'Text',
</span><span class="cx"> 'XMLHttpRequest',
</span><span class="cx"> 'XMLSerializer',
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> function TryAllocate(node) {
</span><span class="cx"> var Cons = this[node];
</span><span class="cx"> if (!Cons) return 'no constructor';
</span><del>- try { return new Cons() + ''; }
</del><ins>+ try { return Object.prototype.toString.call(new Cons()); }
</ins><span class="cx"> catch (e) { return 'exception'; }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/Source/WebCore/ChangeLog 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-01-23 László Langó <llango.u-szeged@partner.samsung.com>
+
+ Range should be constructable.
+ https://bugs.webkit.org/show_bug.cgi?id=115639
+
+ Reviewed by Ryosuke Niwa.
+
+ http://www.w3.org/TR/2013/WD-dom-20131107/#interface-range
+ Now we can do `new Range()` instead of `document.createRange()`.
+
+ Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/47ca40efdf58a4787aa33aa75a35778899b1c002%5E%21
+
+ Test: fast/dom/Range/range-constructor.html
+
+ * dom/Range.cpp:
+ (WebCore::Range::create):
+ * dom/Range.h:
+ * dom/Range.idl:
+
</ins><span class="cx"> 2014-01-23 ChangSeok Oh <changseok.oh@collabora.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix for gles after r162565. Add missing definitions.
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.cpp (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.cpp 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/Source/WebCore/dom/Range.cpp 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -104,6 +104,11 @@
</span><span class="cx"> return adoptRef(new Range(ownerDocument, start.containerNode(), start.computeOffsetInContainerNode(), end.containerNode(), end.computeOffsetInContainerNode()));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+PassRefPtr<Range> Range::create(ScriptExecutionContext& context)
+{
+ return adoptRef(new Range(toDocument(context)));
+}
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> PassRefPtr<Range> Range::create(Document& ownerDocument, const VisiblePosition& visibleStart, const VisiblePosition& visibleEnd)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.h (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.h 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/Source/WebCore/dom/Range.h 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -55,6 +55,7 @@
</span><span class="cx"> static PassRefPtr<Range> create(Document&);
</span><span class="cx"> static PassRefPtr<Range> create(Document&, PassRefPtr<Node> startContainer, int startOffset, PassRefPtr<Node> endContainer, int endOffset);
</span><span class="cx"> static PassRefPtr<Range> create(Document&, const Position&, const Position&);
</span><ins>+ static PassRefPtr<Range> create(ScriptExecutionContext&);
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> // FIXME: Consider making this a static non-member, non-friend function.
</span><span class="cx"> static PassRefPtr<Range> create(Document&, const VisiblePosition&, const VisiblePosition&);
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.idl (162600 => 162601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.idl 2014-01-23 08:10:47 UTC (rev 162600)
+++ trunk/Source/WebCore/dom/Range.idl 2014-01-23 08:36:56 UTC (rev 162601)
</span><span class="lines">@@ -20,7 +20,9 @@
</span><span class="cx">
</span><span class="cx"> // Introduced in DOM Level 2:
</span><span class="cx"> [
</span><del>- ImplementationLacksVTable,
</del><ins>+ Constructor,
+ ConstructorCallWith=ScriptExecutionContext,
+ ImplementationLacksVTable
</ins><span class="cx"> ] interface Range {
</span><span class="cx">
</span><span class="cx"> [GetterRaisesException] readonly attribute Node startContainer;
</span></span></pre>
</div>
</div>
</body>
</html>