<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162538] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162538">162538</a></dd>
<dt>Author</dt> <dd>thiago.lacerda@openbossa.org</dd>
<dt>Date</dt> <dd>2014-01-22 11:21:55 -0800 (Wed, 22 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
https://bugs.webkit.org/show_bug.cgi?id=127119
Reviewed by Mario Sanchez Prada.
Source/WebCore:
At build time, the compiler was not able to determine which Timer's constructor to call in AXObjectCache when
ACCESSIBILITY is not enabled, fixing that.
Also guarding some members in AccessibilityObject that are only being used by EFL and GTK with ACCESSIBILITY.
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
* accessibility/AccessibilityObject.h:
Source/WebKit/gtk:
Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
Source/WebKit2:
Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
Tools:
Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
(webViewWindowObjectCleared):
(main):
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::platformName):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::isIndeterminate):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCacheh">trunk/Source/WebCore/accessibility/AXObjectCache.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjecth">trunk/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitwebviewcpp">trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageh">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagegtkWebPageGtkcpp">trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeeflDumpRenderTreeChromecpp">trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreegtkAccessibilityControllerGtkcpp">trunk/Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreegtkDumpRenderTreecpp">trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleAccessibilityControllercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleAccessibilityUIElementcpp">trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebCore/ChangeLog 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-22 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
+ https://bugs.webkit.org/show_bug.cgi?id=127119
+
+ Reviewed by Mario Sanchez Prada.
+
+ At build time, the compiler was not able to determine which Timer's constructor to call in AXObjectCache when
+ ACCESSIBILITY is not enabled, fixing that.
+ Also guarding some members in AccessibilityObject that are only being used by EFL and GTK with ACCESSIBILITY.
+
+ * accessibility/AXObjectCache.h:
+ (WebCore::AXObjectCache::AXObjectCache):
+ * accessibility/AccessibilityObject.h:
+
</ins><span class="cx"> 2014-01-22 Peter Molnar <pmolnar.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Refactor calculation of hasRx and hasRy values in SVGPathData
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> #if !HAVE(ACCESSIBILITY)
</span><span class="cx"> inline AccessibilityObjectInclusion AXComputedObjectAttributeCache::getIgnored(AXID) const { return DefaultBehavior; }
</span><span class="cx"> inline void AXComputedObjectAttributeCache::setIgnored(AXID, AccessibilityObjectInclusion) { }
</span><del>-inline AXObjectCache::AXObjectCache(Document& document) : m_document(document), m_notificationPostTimer(this, 0) { }
</del><ins>+inline AXObjectCache::AXObjectCache(Document& document) : m_document(document), m_notificationPostTimer(this, (Timer<AXObjectCache>::TimerFiredFunction) nullptr) { }
</ins><span class="cx"> inline AXObjectCache::~AXObjectCache() { }
</span><span class="cx"> inline AccessibilityObject* AXObjectCache::focusedUIElementForPage(const Page*) { return 0; }
</span><span class="cx"> inline AccessibilityObject* AXObjectCache::get(RenderObject*) { return 0; }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -924,7 +924,7 @@
</span><span class="cx"> virtual AccessibilityRole buttonRoleType() const;
</span><span class="cx"> bool isOnscreen() const;
</span><span class="cx">
</span><del>-#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
</del><ins>+#if (PLATFORM(GTK) || PLATFORM(EFL)) && HAVE(ACCESSIBILITY)
</ins><span class="cx"> bool allowsTextRanges() const;
</span><span class="cx"> unsigned getLengthForTextRange() const;
</span><span class="cx"> #else
</span></span></pre></div>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-22 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
+ https://bugs.webkit.org/show_bug.cgi?id=127119
+
+ Reviewed by Mario Sanchez Prada.
+
+ Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_class_init):
+
</ins><span class="cx"> 2014-01-18 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Page should use std::unique_ptr for InspectorController
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitwebviewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -1417,6 +1417,7 @@
</span><span class="cx"> return TRUE;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> static AtkObject* webkit_web_view_get_accessible(GtkWidget* widget)
</span><span class="cx"> {
</span><span class="cx"> WebKitWebView* webView = WEBKIT_WEB_VIEW(widget);
</span><span class="lines">@@ -1448,6 +1449,7 @@
</span><span class="cx">
</span><span class="cx"> return axRoot;
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> static double screenDPI(GdkScreen* screen)
</span><span class="cx"> {
</span><span class="lines">@@ -3107,7 +3109,9 @@
</span><span class="cx"> widgetClass->grab_focus = webkit_web_view_grab_focus;
</span><span class="cx"> widgetClass->focus_in_event = webkit_web_view_focus_in_event;
</span><span class="cx"> widgetClass->focus_out_event = webkit_web_view_focus_out_event;
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> widgetClass->get_accessible = webkit_web_view_get_accessible;
</span><ins>+#endif
</ins><span class="cx"> widgetClass->screen_changed = webkit_web_view_screen_changed;
</span><span class="cx"> #if ENABLE(DRAG_SUPPORT)
</span><span class="cx"> widgetClass->drag_end = webkit_web_view_drag_end;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-22 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
+ https://bugs.webkit.org/show_bug.cgi?id=127119
+
+ Reviewed by Mario Sanchez Prada.
+
+ Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::WebPage):
+ * WebProcess/WebPage/WebPage.h:
+ * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+ (WebKit::WebPage::platformInitialize):
+
</ins><span class="cx"> 2014-01-22 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK][CMake] Add support for building the NetworkProcess
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -248,7 +248,7 @@
</span><span class="cx"> , m_hasCachedWindowFrame(false)
</span><span class="cx"> , m_keyboardEventBeingInterpreted(0)
</span><span class="cx"> , m_viewGestureGeometryCollector(*this)
</span><del>-#elif PLATFORM(GTK)
</del><ins>+#elif PLATFORM(GTK) && HAVE(ACCESSIBILITY)
</ins><span class="cx"> , m_accessibilityObject(0)
</span><span class="cx"> #endif
</span><span class="cx"> , m_setCanStartMediaTimer(RunLoop::main(), this, &WebPage::setCanStartMediaTimerFired)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -948,12 +948,12 @@
</span><span class="cx">
</span><span class="cx"> #elif HAVE(ACCESSIBILITY) && (PLATFORM(GTK) || PLATFORM(EFL))
</span><span class="cx"> GRefPtr<WebPageAccessibilityObject> m_accessibilityObject;
</span><ins>+#endif
</ins><span class="cx">
</span><del>-#if USE(TEXTURE_MAPPER_GL)
</del><ins>+#if PLATFORM(GTK) && USE(TEXTURE_MAPPER_GL)
</ins><span class="cx"> // Our view's window in the UI process.
</span><span class="cx"> uint64_t m_nativeWindowHandle;
</span><span class="cx"> #endif
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> RefPtr<PageBanner> m_headerBanner;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagegtkWebPageGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx">
</span><span class="cx"> void WebPage::platformInitialize()
</span><span class="cx"> {
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> // Create the accessible object (the plug) that will serve as the
</span><span class="cx"> // entry point to the Web process, and send a message to the UI
</span><span class="cx"> // process to connect the two worlds through the accessibility
</span><span class="lines">@@ -56,12 +57,14 @@
</span><span class="cx"> m_accessibilityObject = adoptGRef(webPageAccessibilityObjectNew(this));
</span><span class="cx"> GOwnPtr<gchar> plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject.get())));
</span><span class="cx"> send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get())));
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> #if USE(TEXTURE_MAPPER_GL)
</span><span class="cx"> m_nativeWindowHandle = 0;
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> void WebPage::updateAccessibilityTree()
</span><span class="cx"> {
</span><span class="cx"> if (!m_accessibilityObject)
</span><span class="lines">@@ -69,6 +72,7 @@
</span><span class="cx">
</span><span class="cx"> webPageAccessibilityObjectRefresh(m_accessibilityObject.get());
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> void WebPage::platformPreferencesDidChange(const WebPreferencesStore&)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/ChangeLog 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-01-22 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
+ https://bugs.webkit.org/show_bug.cgi?id=127119
+
+ Reviewed by Mario Sanchez Prada.
+
+ Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (resetDefaultsToConsistentValues):
+ (webViewWindowObjectCleared):
+ (main):
+ * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
+ (WTR::AccessibilityController::platformName):
+ * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
+ (WTR::AccessibilityUIElement::isIndeterminate):
+
</ins><span class="cx"> 2014-01-22 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeeflDumpRenderTreeChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> #include "EditingCallbacks.h"
</span><span class="cx"> #include "EventSender.h"
</span><span class="cx"> #include "GCController.h"
</span><ins>+#include "JSRetainPtr.h"
</ins><span class="cx"> #include "URL.h"
</span><span class="cx"> #include "NotImplemented.h"
</span><span class="cx"> #include "TestRunner.h"
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreegtkAccessibilityControllerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -25,6 +25,9 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+
+#if HAVE(ACCESSIBILITY)
+
</ins><span class="cx"> #include "AccessibilityController.h"
</span><span class="cx">
</span><span class="cx"> #include "AccessibilityCallbacks.h"
</span><span class="lines">@@ -72,3 +75,5 @@
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="cx"> }
</span><ins>+
+#endif // HAVE(ACCESSIBILITY)
</ins></span></pre></div>
<a id="trunkToolsDumpRenderTreegtkDumpRenderTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -81,7 +81,9 @@
</span><span class="cx"> static int dumpTree = 1;
</span><span class="cx"> static int useTimeoutWatchdog = 1;
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> AccessibilityController* axController = 0;
</span><ins>+#endif
</ins><span class="cx"> RefPtr<TestRunner> gTestRunner;
</span><span class="cx"> static GCController* gcController = 0;
</span><span class="cx"> static WebKitWebView* webView;
</span><span class="lines">@@ -529,8 +531,10 @@
</span><span class="cx"> DumpRenderTreeSupportGtk::setDefersLoading(webView, false);
</span><span class="cx"> DumpRenderTreeSupportGtk::setSerializeHTTPLoads(false);
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> if (axController)
</span><span class="cx"> axController->resetToConsistentState();
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> DumpRenderTreeSupportGtk::clearOpener(mainFrame);
</span><span class="cx"> DumpRenderTreeSupportGtk::setTracksRepaints(mainFrame, false);
</span><span class="lines">@@ -921,8 +925,10 @@
</span><span class="cx"> gcController->makeWindowObject(context, windowObject, &exception);
</span><span class="cx"> ASSERT(!exception);
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> axController->makeWindowObject(context, windowObject, &exception);
</span><span class="cx"> ASSERT(!exception);
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> addControllerToWindow(context, windowObject, "eventSender", makeEventSender(context, !webkit_web_frame_get_parent(frame)));
</span><span class="cx"> addControllerToWindow(context, windowObject, "textInputController", makeTextInputController(context));
</span><span class="lines">@@ -1524,7 +1530,9 @@
</span><span class="cx"> setDefaultsToConsistentStateValuesForTesting();
</span><span class="cx">
</span><span class="cx"> gcController = new GCController();
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> axController = new AccessibilityController();
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> if (useLongRunningServerMode(argc, argv)) {
</span><span class="cx"> printSeparators = true;
</span><span class="lines">@@ -1538,8 +1546,10 @@
</span><span class="cx"> delete gcController;
</span><span class="cx"> gcController = 0;
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
</ins><span class="cx"> delete axController;
</span><span class="cx"> axController = 0;
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> gtk_widget_destroy(window);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleAccessibilityControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -93,6 +93,7 @@
</span><span class="cx"> PassRefPtr<AccessibilityUIElement> AccessibilityController::accessibleElementById(JSStringRef attribute) { return nullptr; }
</span><span class="cx"> void AccessibilityController::logAccessibilityEvents() { }
</span><span class="cx"> void AccessibilityController::resetToConsistentState() { }
</span><ins>+JSRetainPtr<JSStringRef> AccessibilityController::platformName() { return JSRetainPtr<JSStringRef>(Adopt, JSStringCreateWithUTF8CString("")); }
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if !HAVE(ACCESSIBILITY) && (PLATFORM(GTK) || PLATFORM(EFL))
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleAccessibilityUIElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp (162537 => 162538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2014-01-22 19:10:51 UTC (rev 162537)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2014-01-22 19:21:55 UTC (rev 162538)
</span><span class="lines">@@ -129,6 +129,7 @@
</span><span class="cx"> PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::selectedChildAtIndex(unsigned) const { return 0; }
</span><span class="cx"> bool AccessibilityUIElement::isExpanded() const { return false; }
</span><span class="cx"> bool AccessibilityUIElement::isChecked() const { return false; }
</span><ins>+bool AccessibilityUIElement::isIndeterminate() const { return false; }
</ins><span class="cx"> bool AccessibilityUIElement::isVisible() const { return false; }
</span><span class="cx"> bool AccessibilityUIElement::isOffScreen() const { return false; }
</span><span class="cx"> bool AccessibilityUIElement::isCollapsed() const { return false; }
</span></span></pre>
</div>
</div>
</body>
</html>