<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162576] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162576">162576</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-01-22 18:01:39 -0800 (Wed, 22 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore: AX: Do not return an accessible name for an object just because it has tabindex=0
https://bugs.webkit.org/show_bug.cgi?id=126914
Reviewed by Mario Sanchez Prada.
WebKit has code to return an accessible name for any object that is "generically" focusable (ie. tabindex=0).
This behavior, which is not supported in ARIA, has caused many problems for VoiceOver. Often VoiceOver will
speak all the text underneath any type of group.
I think we need to revert this behavior and follow the ARIA spec more closely.
Test: accessibility/aria-describedby-ensures-visibility.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
LayoutTests: AX: WebKit concatenates name of all toolbar buttons in the apple.com video player
https://bugs.webkit.org/show_bug.cgi?id=126914
Reviewed by Mario Sanchez Prada.
* accessibility/focusable-div-expected.txt:
* accessibility/focusable-div.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilityfocusabledivexpectedtxt">trunk/LayoutTests/accessibility/focusable-div-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityfocusabledivhtml">trunk/LayoutTests/accessibility/focusable-div.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162575 => 162576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-23 01:35:51 UTC (rev 162575)
+++ trunk/LayoutTests/ChangeLog 2014-01-23 02:01:39 UTC (rev 162576)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-22 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WebKit concatenates name of all toolbar buttons in the apple.com video player
+ https://bugs.webkit.org/show_bug.cgi?id=126914
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/focusable-div-expected.txt:
+ * accessibility/focusable-div.html:
+
</ins><span class="cx"> 2014-01-22 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Implement ANGLE_instanced_arrays
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityfocusabledivexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/focusable-div-expected.txt (162575 => 162576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/focusable-div-expected.txt 2014-01-23 01:35:51 UTC (rev 162575)
+++ trunk/LayoutTests/accessibility/focusable-div-expected.txt 2014-01-23 02:01:39 UTC (rev 162576)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> List item
</span><span class="cx"> Initial text before list
</span><span class="cx"> List item
</span><del>-This test makes sure that a generic focusable div can get accessibility focus and gets its accessible text from contents..
</del><ins>+This test makes sure that a generic focusable div can get accessibility focus. It should not get accessible text from its children automatically though.
</ins><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="lines">@@ -14,21 +14,21 @@
</span><span class="cx"> PASS document.activeElement == link is true
</span><span class="cx"> PASS lastChar(axLink.title) is "A"
</span><span class="cx"> PASS document.activeElement == div is true
</span><del>-PASS lastChar(axDiv.title) is "B"
</del><ins>+PASS lastChar(axDiv.title) is ' '
</ins><span class="cx"> PASS document.activeElement == div2 is true
</span><del>-PASS lastChar(axDiv2.title) is "C"
</del><ins>+PASS lastChar(axDiv2.title) is ' '
</ins><span class="cx"> PASS document.activeElement == div3 is true
</span><span class="cx"> PASS lastChar(axDiv3.description) is "D"
</span><span class="cx"> PASS document.activeElement == div4 is true
</span><span class="cx"> PASS axDiv4.title.indexOf('Link') is -1
</span><span class="cx"> PASS document.activeElement == div5 is true
</span><span class="cx"> PASS axDiv5.title.indexOf('Link') is -1
</span><del>-PASS axDiv5.title.indexOf('Initial text before link') >= 0 is true
</del><ins>+PASS axDiv5.title.indexOf('Initial text before link') >= 0 is false
</ins><span class="cx"> PASS document.activeElement == div6 is true
</span><span class="cx"> PASS axDiv6.title.indexOf('List item') is -1
</span><span class="cx"> PASS document.activeElement == div7 is true
</span><span class="cx"> PASS axDiv7.title.indexOf('List item') is -1
</span><del>-PASS axDiv7.title.indexOf('Initial text before list') >= 0 is true
</del><ins>+PASS axDiv7.title.indexOf('Initial text before list') >= 0 is false
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityfocusabledivhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/focusable-div.html (162575 => 162576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/focusable-div.html 2014-01-23 01:35:51 UTC (rev 162575)
+++ trunk/LayoutTests/accessibility/focusable-div.html 2014-01-23 02:01:39 UTC (rev 162576)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> <!-- A link always gets its accessible text from contents. -->
</span><span class="cx"> <a id="link" href="#">A</a>
</span><span class="cx">
</span><del>-<!-- A generic focusable div should also get its accessible text from contents. -->
</del><ins>+<!-- A generic focusable div should not get its accessible text from contents. -->
</ins><span class="cx"> <div id="div" tabindex="0">B</div>
</span><span class="cx"> <div id="div2" tabindex="0"><div></div>C</div>
</span><span class="cx"> <div id="div3" tabindex="0" aria-label="D"></div>
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx">
</span><span class="cx"> <div id="console"></div>
</span><span class="cx"> <script>
</span><del>-description("This test makes sure that a generic focusable div can get accessibility focus and gets its accessible text from contents..");
</del><ins>+description("This test makes sure that a generic focusable div can get accessibility focus. It should not get accessible text from its children automatically though.");
</ins><span class="cx">
</span><span class="cx"> if (window.testRunner && window.accessibilityController) {
</span><span class="cx"> window.testRunner.dumpAsText();
</span><span class="lines">@@ -38,13 +38,13 @@
</span><span class="cx"> div.focus();
</span><span class="cx"> shouldBe("document.activeElement == div", "true");
</span><span class="cx"> window.axDiv = accessibilityController.focusedElement;
</span><del>- shouldBe("lastChar(axDiv.title)", "\"B\"");
</del><ins>+ shouldBe("lastChar(axDiv.title)", "' '");
</ins><span class="cx">
</span><span class="cx"> var div2 = document.getElementById('div2');
</span><span class="cx"> div2.focus();
</span><span class="cx"> shouldBe("document.activeElement == div2", "true");
</span><span class="cx"> window.axDiv2 = accessibilityController.focusedElement;
</span><del>- shouldBe("lastChar(axDiv2.title)", "\"C\"");
</del><ins>+ shouldBe("lastChar(axDiv2.title)", "' '");
</ins><span class="cx">
</span><span class="cx"> var div3 = document.getElementById('div3');
</span><span class="cx"> div3.focus();
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> shouldBe("document.activeElement == div5", "true");
</span><span class="cx"> window.axDiv5 = accessibilityController.focusedElement;
</span><span class="cx"> shouldBe("axDiv5.title.indexOf('Link')", "-1");
</span><del>- shouldBe("axDiv5.title.indexOf('Initial text before link') >= 0", "true");
</del><ins>+ shouldBe("axDiv5.title.indexOf('Initial text before link') >= 0", "false");
</ins><span class="cx">
</span><span class="cx"> var div6 = document.getElementById('div6');
</span><span class="cx"> div6.focus();
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> shouldBe("document.activeElement == div7", "true");
</span><span class="cx"> window.axDiv7 = accessibilityController.focusedElement;
</span><span class="cx"> shouldBe("axDiv7.title.indexOf('List item')", "-1");
</span><del>- shouldBe("axDiv7.title.indexOf('Initial text before list') >= 0", "true");
</del><ins>+ shouldBe("axDiv7.title.indexOf('Initial text before list') >= 0", "false");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162575 => 162576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-23 01:35:51 UTC (rev 162575)
+++ trunk/Source/WebCore/ChangeLog 2014-01-23 02:01:39 UTC (rev 162576)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-01-22 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Do not return an accessible name for an object just because it has tabindex=0
+ https://bugs.webkit.org/show_bug.cgi?id=126914
+
+ Reviewed by Mario Sanchez Prada.
+
+ WebKit has code to return an accessible name for any object that is "generically" focusable (ie. tabindex=0).
+ This behavior, which is not supported in ARIA, has caused many problems for VoiceOver. Often VoiceOver will
+ speak all the text underneath any type of group.
+
+ I think we need to revert this behavior and follow the ARIA spec more closely.
+
+ Test: accessibility/aria-describedby-ensures-visibility.html
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::visibleText):
+ (WebCore::AccessibilityNodeObject::title):
+
</ins><span class="cx"> 2014-01-22 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> The IDB backing store get() method shouldn't call IDB callbacks directly
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (162575 => 162576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-23 01:35:51 UTC (rev 162575)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-23 02:01:39 UTC (rev 162576)
</span><span class="lines">@@ -1354,11 +1354,6 @@
</span><span class="cx"> // the user as a single atomic object, so we should use its text as the default title.
</span><span class="cx"> if (isHeading() || isLink())
</span><span class="cx"> useTextUnderElement = true;
</span><del>- else if (isGenericFocusableElement()) {
- // If a node uses a negative tabindex, do not expose it as a generic focusable element, because keyboard focus management
- // will never land on this specific element.
- useTextUnderElement = !(node && node->isElementNode() && toElement(node)->tabIndex() < 0);
- }
</del><span class="cx">
</span><span class="cx"> if (useTextUnderElement) {
</span><span class="cx"> AccessibilityTextUnderElementMode mode;
</span><span class="lines">@@ -1733,18 +1728,6 @@
</span><span class="cx"> if (isHeading())
</span><span class="cx"> return textUnderElement(AccessibilityTextUnderElementMode(AccessibilityTextUnderElementMode::TextUnderElementModeSkipIgnoredChildren, true));
</span><span class="cx">
</span><del>- // If it's focusable but it's not content editable or a known control type, then it will appear to
- // the user as a single atomic object, so we should use its text as the default title.
- if (isGenericFocusableElement()) {
- // If a node uses a negative tabindex, do not expose it as a generic focusable element, because keyboard focus management
- // will never land on this specific element.
- Node* node = this->node();
- if (node && node->isElementNode() && toElement(node)->tabIndex() < 0)
- return String();
-
- return textUnderElement();
- }
-
</del><span class="cx"> return String();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>