<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162580] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162580">162580</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-01-22 18:24:06 -0800 (Wed, 22 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WKBrowsingContextController should not be an API wrapper around WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=127454
Reviewed by Dan Bernstein.
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _initWithPageRef:]):
(+[WKBrowsingContextController _browsingContextControllerForPageRef:]):
* UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
* UIProcess/API/Cocoa/WKProcessGroup.mm:
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView browsingContextController]):
* UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::platformInitialize):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::platformInitialize):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedCocoaAPIObjectmm">trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm</a></li>
<li><a href="#trunkSourceWebKit2SharedmacObjCObjectGraphCodersmm">trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKBrowsingContextControllermm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKBrowsingContextControllerInternalh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKProcessGroupmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIiosWKContentViewmm">trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm">trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacWebPageProxyMacmm">trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2014-01-22 Anders Carlsson <andersca@apple.com>
+
+ WKBrowsingContextController should not be an API wrapper around WebPageProxy
+ https://bugs.webkit.org/show_bug.cgi?id=127454
+
+ Reviewed by Dan Bernstein.
+
+ * Shared/Cocoa/APIObject.mm:
+ (API::Object::newObject):
+ * Shared/mac/ObjCObjectGraphCoders.mm:
+ (WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
+ * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+ (-[WKBrowsingContextController _initWithPageRef:]):
+ (+[WKBrowsingContextController _browsingContextControllerForPageRef:]):
+ * UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
+ * UIProcess/API/Cocoa/WKProcessGroup.mm:
+ (didNavigateWithNavigationData):
+ (didPerformClientRedirect):
+ (didPerformServerRedirect):
+ (didUpdateHistoryTitle):
+ * UIProcess/API/ios/WKContentView.mm:
+ (-[WKContentView browsingContextController]):
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView browsingContextController]):
+ * UIProcess/ios/WebPageProxyIOS.mm:
+ (WebKit::WebPageProxy::platformInitialize):
+ * UIProcess/mac/WebPageProxyMac.mm:
+ (WebKit::WebPageProxy::platformInitialize):
+
</ins><span class="cx"> 2014-01-22 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove CSS3_TEXT_DECORATION define
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedCocoaAPIObjectmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -120,10 +120,6 @@
</span><span class="cx"> wrapper = [WKNavigationData alloc];
</span><span class="cx"> break;
</span><span class="cx">
</span><del>- case Type::Page:
- wrapper = [WKBrowsingContextController alloc];
- break;
-
</del><span class="cx"> case Type::PageGroup:
</span><span class="cx"> wrapper = [WKBrowsingContextGroup alloc];
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacObjCObjectGraphCodersmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -351,7 +351,7 @@
</span><span class="cx"> if (!webPage)
</span><span class="cx"> coder.m_root = [NSNull null];
</span><span class="cx"> else
</span><del>- coder.m_root = wrapper(*webPage);
</del><ins>+ coder.m_root = [WKBrowsingContextController _browsingContextControllerForPageRef:toAPI(webPage)];
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> case WKTypeRefWrapperType: {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKBrowsingContextControllermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @implementation WKBrowsingContextController {
</span><del>- API::ObjectStorage<WebPageProxy> _page;
</del><ins>+ RefPtr<WebPageProxy> _page;
</ins><span class="cx"> std::unique_ptr<PageLoadStateObserver> _pageLoadStateObserver;
</span><span class="cx">
</span><span class="cx"> WeakObjCPtr<id <WKBrowsingContextLoadDelegate>> _loadDelegate;
</span><span class="lines">@@ -158,12 +158,6 @@
</span><span class="cx"> [super dealloc];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_finishInitialization
-{
- _pageLoadStateObserver = std::make_unique<PageLoadStateObserver>(self);
- _page->pageLoadState().addObserver(*_pageLoadStateObserver);
-}
-
</del><span class="cx"> #pragma mark Loading
</span><span class="cx">
</span><span class="cx"> + (void)registerSchemeForCustomProtocol:(NSString *)scheme
</span><span class="lines">@@ -797,6 +791,24 @@
</span><span class="cx"> return *reinterpret_cast<API::Object*>(&_page);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (instancetype)_initWithPageRef:(WKPageRef)pageRef
+{
+ if (!(self = [super init]))
+ return nil;
+
+ _page = toImpl(pageRef);
+
+ _pageLoadStateObserver = std::make_unique<PageLoadStateObserver>(self);
+ _page->pageLoadState().addObserver(*_pageLoadStateObserver);
+
+ return self;
+}
+
++ (WKBrowsingContextController *)_browsingContextControllerForPageRef:(WKPageRef)pageRef
+{
+ return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient().client().base.clientInfo;
+}
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @implementation WKBrowsingContextController (Private)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKBrowsingContextControllerInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -31,24 +31,16 @@
</span><span class="cx"> #import "WeakObjCPtr.h"
</span><span class="cx"> #import "WebPageProxy.h"
</span><span class="cx">
</span><del>-namespace WebKit {
-
-inline WKBrowsingContextController *wrapper(WebPageProxy& page)
-{
- ASSERT([page.wrapper() isKindOfClass:[WKBrowsingContextController class]]);
- return (WKBrowsingContextController *)page.wrapper();
-}
-
-}
-
</del><span class="cx"> @interface WKBrowsingContextController () <WKObject> {
</span><span class="cx"> @package
</span><span class="cx"> WebKit::WeakObjCPtr<id <WKBrowsingContextHistoryDelegate>> _historyDelegate;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_finishInitialization;
</del><span class="cx"> + (NSMutableSet *)customSchemes;
</span><ins>++ (WKBrowsingContextController *)_browsingContextControllerForPageRef:(WKPageRef)pageRef;
</ins><span class="cx">
</span><ins>+- (instancetype)_initWithPageRef:(WKPageRef)pageRef;
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> #endif // WK_API_ENABLED
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKProcessGroupmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> if (!toImpl(frameRef)->isMainFrame())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- WKBrowsingContextController *controller = wrapper(*toImpl(pageRef));
</del><ins>+ WKBrowsingContextController *controller = [WKBrowsingContextController _browsingContextControllerForPageRef:pageRef];
</ins><span class="cx"> auto historyDelegate = controller->_historyDelegate.get();
</span><span class="cx">
</span><span class="cx"> if ([historyDelegate respondsToSelector:@selector(browsingContextController:didNavigateWithNavigationData:)])
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> if (!toImpl(frameRef)->isMainFrame())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- WKBrowsingContextController *controller = wrapper(*toImpl(pageRef));
</del><ins>+ WKBrowsingContextController *controller = [WKBrowsingContextController _browsingContextControllerForPageRef:pageRef];
</ins><span class="cx"> auto historyDelegate = controller->_historyDelegate.get();
</span><span class="cx">
</span><span class="cx"> if ([historyDelegate respondsToSelector:@selector(browsingContextController:didPerformClientRedirectFromURL:toURL:)])
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> if (!toImpl(frameRef)->isMainFrame())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- WKBrowsingContextController *controller = wrapper(*toImpl(pageRef));
</del><ins>+ WKBrowsingContextController *controller = [WKBrowsingContextController _browsingContextControllerForPageRef:pageRef];
</ins><span class="cx"> auto historyDelegate = controller->_historyDelegate.get();
</span><span class="cx">
</span><span class="cx"> if ([historyDelegate respondsToSelector:@selector(browsingContextController:didPerformServerRedirectFromURL:toURL:)])
</span><span class="lines">@@ -151,7 +151,7 @@
</span><span class="cx"> if (!toImpl(frameRef)->isMainFrame())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- WKBrowsingContextController *controller = wrapper(*toImpl(pageRef));
</del><ins>+ WKBrowsingContextController *controller = [WKBrowsingContextController _browsingContextControllerForPageRef:pageRef];
</ins><span class="cx"> auto historyDelegate = controller->_historyDelegate.get();
</span><span class="cx">
</span><span class="cx"> if ([historyDelegate respondsToSelector:@selector(browsingContextController:didUpdateHistoryTitle:forURL:)])
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIiosWKContentViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx"> @implementation WKContentView {
</span><span class="cx"> std::unique_ptr<PageClientImpl> _pageClient;
</span><span class="cx"> RefPtr<WebPageProxy> _page;
</span><ins>+ RetainPtr<WKBrowsingContextController> _browsingContextController;
</ins><span class="cx">
</span><span class="cx"> RetainPtr<UIView> _rootContentView;
</span><span class="cx"> RetainPtr<WKInteractionView> _interactionView;
</span><span class="lines">@@ -116,7 +117,10 @@
</span><span class="cx">
</span><span class="cx"> - (WKBrowsingContextController *)browsingContextController
</span><span class="cx"> {
</span><del>- return wrapper(*_page);
</del><ins>+ if (!_browsingContextController)
+ _browsingContextController = [[WKBrowsingContextController alloc] _initWithPageRef:toAPI(_page.get())];
+
+ return _browsingContextController.get();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (WKContentType)contentType
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -145,6 +145,10 @@
</span><span class="cx"> std::unique_ptr<PageClientImpl> _pageClient;
</span><span class="cx"> RefPtr<WebPageProxy> _page;
</span><span class="cx">
</span><ins>+#if WK_API_ENABLED
+ RetainPtr<WKBrowsingContextController> _browsingContextController;
+#endif
+
</ins><span class="cx"> // For ToolTips.
</span><span class="cx"> NSToolTipTag _lastToolTipTag;
</span><span class="cx"> id _trackingRectOwner;
</span><span class="lines">@@ -284,7 +288,10 @@
</span><span class="cx">
</span><span class="cx"> - (WKBrowsingContextController *)browsingContextController
</span><span class="cx"> {
</span><del>- return wrapper(*_data->_page);
</del><ins>+ if (!_data->_browsingContextController)
+ _data->_browsingContextController = [[WKBrowsingContextController alloc] _initWithPageRef:toAPI(_data->_page.get())];
+
+ return _data->_browsingContextController.get();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif // WK_API_ENABLED
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -42,9 +42,6 @@
</span><span class="cx">
</span><span class="cx"> void WebPageProxy::platformInitialize()
</span><span class="cx"> {
</span><del>-#if WK_API_ENABLED
- [WebKit::wrapper(*this) _finishInitialization];
-#endif
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static String userVisibleWebKitVersionString()
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacWebPageProxyMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (162579 => 162580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2014-01-23 02:19:42 UTC (rev 162579)
+++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2014-01-23 02:24:06 UTC (rev 162580)
</span><span class="lines">@@ -69,10 +69,6 @@
</span><span class="cx"> void WebPageProxy::platformInitialize()
</span><span class="cx"> {
</span><span class="cx"> m_useLegacyImplicitRubberBandControl = shouldUseLegacyImplicitRubberBandControl();
</span><del>-
-#if WK_API_ENABLED
- [WebKit::wrapper(*this) _finishInitialization];
-#endif
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static String userVisibleWebKitVersionString()
</span></span></pre>
</div>
</div>
</body>
</html>