<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162474] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162474">162474</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-01-21 14:14:37 -0800 (Tue, 21 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>platform/mac/accessibility/iframe-aria-hidden.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127323
Reviewed by Chris Fleizach.
This test got de-flaked on bots by rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/162354">r162354</a>. But there was still
a potential race in it, which this change fixes.
* platform/mac-wk2/TestExpectations: Removed expectation.
* platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as
frames load asynchronously.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityiframeariahiddenhtml">trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162473 => 162474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/ChangeLog        2014-01-21 22:14:37 UTC (rev 162474)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-21 Alexey Proskuryakov <ap@apple.com>
+
+ platform/mac/accessibility/iframe-aria-hidden.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=127323
+
+ Reviewed by Chris Fleizach.
+
+ This test got de-flaked on bots by rolling out r162354. But there was still
+ a potential race in it, which this change fixes.
+
+ * platform/mac-wk2/TestExpectations: Removed expectation.
+
+ * platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as
+ frames load asynchronously.
+
</ins><span class="cx"> 2014-01-21 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Mac: Expose the visible text of a password field to AX
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityiframeariahiddenhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html (162473 => 162474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html        2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html        2014-01-21 22:14:37 UTC (rev 162474)
</span><span class="lines">@@ -14,24 +14,29 @@
</span><span class="cx"> <div id="console"></div>
</span><span class="cx">
</span><span class="cx"> <script>
</span><ins>+description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
</ins><span class="cx">
</span><del>- description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
</del><ins>+if (window.accessibilityController) {
+ jsTestIsAsync = true;
</ins><span class="cx">
</span><del>- if (window.accessibilityController) {
</del><ins>+ // Get the iframe reference.
+ document.getElementById("body").focus();
+ var body = accessibilityController.focusedElement;
</ins><span class="cx">
</span><del>- document.getElementById("body").focus();
-
- // Get the iframe reference.
- var body = accessibilityController.focusedElement;
</del><ins>+ window.onload = function() {
</ins><span class="cx"> shouldBe("body.childrenCount", "3");
</span><span class="cx"> shouldBe("body.childAtIndex(0).childrenCount", "0");
</span><span class="cx">
</span><span class="cx"> document.getElementById("iframe").setAttribute("aria-hidden", "false");
</span><span class="cx"> shouldBe("body.childrenCount", "4");
</span><span class="cx"> shouldBe("body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role", "'AXRole: AXWebArea'");
</span><ins>+
+ finishJSTest();
</ins><span class="cx"> }
</span><ins>+} else
+ testFailed("This test relies on accessibilityController, please use run-webkit-tests to run it.")
</ins><span class="cx">
</span><del>- successfullyParsed = true;
</del><ins>+successfullyParsed = true;
</ins><span class="cx"> </script>
</span><span class="cx">
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (162473 => 162474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations        2014-01-21 21:45:19 UTC (rev 162473)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations        2014-01-21 22:14:37 UTC (rev 162474)
</span><span class="lines">@@ -451,8 +451,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/127316 svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html [ Pass Timeout ]
</span><span class="cx">
</span><del>-webkit.org/b/127323 platform/mac/accessibility/iframe-aria-hidden.html [ Pass Failure ]
-
</del><span class="cx"> ### END OF (3) Unclassified failures
</span><span class="cx"> ########################################
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>