<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162454] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162454">162454</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2014-01-21 11:36:19 -0800 (Tue, 21 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Address late review naming comments after <a href="http://trac.webkit.org/projects/webkit/changeset/162453">r162453</a>.
* UIProcess/API/mac/WKView.mm:
And, fix the build by adding an include I accidentally missed.
* UIProcess/mac/RemoteLayerTreeHost.mm:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
* platform/graphics/mac/CALayerWebAdditions.h: Removed.
* platform/graphics/mac/CALayerWebAdditions.mm: Removed.
* platform/graphics/mac/WebCoreCALayerExtras.h: Added.
* platform/graphics/mac/WebCoreCALayerExtras.mm: Added.
Rename.
(-[CALayer web_disableAllActions]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscamacPlatformCALayerMacmm">trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeHostmm">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemoteCustommm">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacWebCoreCALayerExtrash">trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacWebCoreCALayerExtrasmm">trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacCALayerWebAdditionsh">trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacCALayerWebAdditionsmm">trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebCore/ChangeLog 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2014-01-21 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><ins>+ Address late review naming comments after r162453.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/ca/mac/PlatformCALayerMac.mm:
+ * platform/graphics/mac/CALayerWebAdditions.h: Removed.
+ * platform/graphics/mac/CALayerWebAdditions.mm: Removed.
+ * platform/graphics/mac/WebCoreCALayerExtras.h: Added.
+ * platform/graphics/mac/WebCoreCALayerExtras.mm: Added.
+ (-[CALayer web_disableAllActions]):
+
+2014-01-21 Tim Horton <timothy_horton@apple.com>
+
</ins><span class="cx"> Keep CALayer implicit animation disabling code in a single place
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=127355
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -1063,8 +1063,8 @@
</span><span class="cx"> 2D9A247515B9C2E300D34527 /* DOMDOMSecurityPolicyInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D9A247115B9C29500D34527 /* DOMDOMSecurityPolicyInternal.h */; };
</span><span class="cx"> 2D9A247615B9C2F400D34527 /* DOMDOMSecurityPolicy.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 2D9A247015B9C29500D34527 /* DOMDOMSecurityPolicy.h */; };
</span><span class="cx"> 2D9F0E1314FF1CBF00BA0FF7 /* linearSRGB.icc in Resources */ = {isa = PBXBuildFile; fileRef = 2D9F0E1214FF1CBF00BA0FF7 /* linearSRGB.icc */; };
</span><del>- 2DBADE0B188E5915004D7981 /* CALayerWebAdditions.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DBADE09188E5915004D7981 /* CALayerWebAdditions.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 2DBADE0C188E5915004D7981 /* CALayerWebAdditions.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DBADE0A188E5915004D7981 /* CALayerWebAdditions.mm */; };
</del><ins>+ 2DBADE0B188E5915004D7981 /* WebCoreCALayerExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DBADE09188E5915004D7981 /* WebCoreCALayerExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 2DBADE0C188E5915004D7981 /* WebCoreCALayerExtras.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DBADE0A188E5915004D7981 /* WebCoreCALayerExtras.mm */; };
</ins><span class="cx"> 2DF2E9D5166E39750035BEF2 /* ConsoleAPITypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DF2E9D4166E39740035BEF2 /* ConsoleAPITypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 2E0888D41148848A00AF4265 /* JSDOMFormData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2E0888D21148848A00AF4265 /* JSDOMFormData.cpp */; };
</span><span class="cx"> 2E0888D51148848A00AF4265 /* JSDOMFormData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E0888D31148848A00AF4265 /* JSDOMFormData.h */; };
</span><span class="lines">@@ -7929,8 +7929,8 @@
</span><span class="cx"> 2D9A247115B9C29500D34527 /* DOMDOMSecurityPolicyInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMDOMSecurityPolicyInternal.h; sourceTree = "<group>"; };
</span><span class="cx"> 2D9A247215B9C2C700D34527 /* DOMDOMSecurityPolicy.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMDOMSecurityPolicy.mm; sourceTree = "<group>"; };
</span><span class="cx"> 2D9F0E1214FF1CBF00BA0FF7 /* linearSRGB.icc */ = {isa = PBXFileReference; lastKnownFileType = file; path = linearSRGB.icc; sourceTree = "<group>"; };
</span><del>- 2DBADE09188E5915004D7981 /* CALayerWebAdditions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CALayerWebAdditions.h; sourceTree = "<group>"; };
- 2DBADE0A188E5915004D7981 /* CALayerWebAdditions.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CALayerWebAdditions.mm; sourceTree = "<group>"; };
</del><ins>+ 2DBADE09188E5915004D7981 /* WebCoreCALayerExtras.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreCALayerExtras.h; sourceTree = "<group>"; };
+ 2DBADE0A188E5915004D7981 /* WebCoreCALayerExtras.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebCoreCALayerExtras.mm; sourceTree = "<group>"; };
</ins><span class="cx"> 2DF2E9D4166E39740035BEF2 /* ConsoleAPITypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ConsoleAPITypes.h; sourceTree = "<group>"; };
</span><span class="cx"> 2E0888C3114883A900AF4265 /* DOMFormData.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMFormData.idl; sourceTree = "<group>"; };
</span><span class="cx"> 2E0888D21148848A00AF4265 /* JSDOMFormData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMFormData.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -19872,8 +19872,8 @@
</span><span class="cx"> B27535490B053814002CE64F /* mac */ = {
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><del>- 2DBADE09188E5915004D7981 /* CALayerWebAdditions.h */,
- 2DBADE0A188E5915004D7981 /* CALayerWebAdditions.mm */,
</del><ins>+ 2DBADE09188E5915004D7981 /* WebCoreCALayerExtras.h */,
+ 2DBADE0A188E5915004D7981 /* WebCoreCALayerExtras.mm */,
</ins><span class="cx"> EDE3A4FF0C7A430600956A37 /* ColorMac.h */,
</span><span class="cx"> B275354A0B053814002CE64F /* ColorMac.mm */,
</span><span class="cx"> 37C2360E1097EE7700EF9F72 /* ComplexTextController.cpp */,
</span><span class="lines">@@ -24399,7 +24399,7 @@
</span><span class="cx"> AB4CB4EB0B8BDA3D009F40B0 /* JSHTMLSelectElementCustom.h in Headers */,
</span><span class="cx"> E446143C0CD689CC00FADA75 /* JSHTMLSourceElement.h in Headers */,
</span><span class="cx"> 078E093F17D16E1C00420AA1 /* RTCDTMFSenderHandlerClient.h in Headers */,
</span><del>- 2DBADE0B188E5915004D7981 /* CALayerWebAdditions.h in Headers */,
</del><ins>+ 2DBADE0B188E5915004D7981 /* WebCoreCALayerExtras.h in Headers */,
</ins><span class="cx"> 9752D38E1413104B003305BD /* JSHTMLSpanElement.h in Headers */,
</span><span class="cx"> A80E7B0E0A19D606007FB8C5 /* JSHTMLStyleElement.h in Headers */,
</span><span class="cx"> BCA169A30BFD55B40019CA76 /* JSHTMLTableCaptionElement.h in Headers */,
</span><span class="lines">@@ -27907,7 +27907,7 @@
</span><span class="cx"> 598365E41355F604001B185D /* JSPositionCallback.cpp in Sources */,
</span><span class="cx"> FE80DA710E9C472F000D6F75 /* JSPositionError.cpp in Sources */,
</span><span class="cx"> 598365E61355F60D001B185D /* JSPositionErrorCallback.cpp in Sources */,
</span><del>- 2DBADE0C188E5915004D7981 /* CALayerWebAdditions.mm in Sources */,
</del><ins>+ 2DBADE0C188E5915004D7981 /* WebCoreCALayerExtras.mm in Sources */,
</ins><span class="cx"> 65DF31FF09D1CC60000BE325 /* JSProcessingInstruction.cpp in Sources */,
</span><span class="cx"> E44613ED0CD681BA00FADA75 /* JSProgressEvent.cpp in Sources */,
</span><span class="cx"> B658FFA11522EF3A00DD5595 /* JSRadioNodeList.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscamacPlatformCALayerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx">
</span><span class="cx"> #import "AnimationUtilities.h"
</span><span class="cx"> #import "BlockExceptions.h"
</span><del>-#import "CALayerWebAdditions.h"
</del><span class="cx"> #import "GraphicsContext.h"
</span><span class="cx"> #import "GraphicsLayerCA.h"
</span><span class="cx"> #import "LengthFunctions.h"
</span><span class="lines">@@ -41,6 +40,7 @@
</span><span class="cx"> #import "SoftLinking.h"
</span><span class="cx"> #import "TiledBacking.h"
</span><span class="cx"> #import "TileController.h"
</span><ins>+#import "WebCoreCALayerExtras.h"
</ins><span class="cx"> #import "WebLayer.h"
</span><span class="cx"> #import "WebTiledBackingLayer.h"
</span><span class="cx"> #import <objc/objc-auto.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacCALayerWebAdditionsh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.h (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.h 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.h 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -1,37 +0,0 @@
</span><del>-/*
- * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef CALayerWebAdditions_h
-#define CALayerWebAdditions_h
-
-#import <QuartzCore/QuartzCore.h>
-
-@interface CALayer (WebAdditions)
-
-- (void)web_disableAllActions;
-
-@end
-
-#endif // CALayerWebAdditions_h
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacCALayerWebAdditionsmm"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.mm (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.mm 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebCore/platform/graphics/mac/CALayerWebAdditions.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -1,58 +0,0 @@
</span><del>-/*
- * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#import "CALayerWebAdditions.h"
-
-@implementation CALayer (WebAdditions)
-
-- (void)web_disableAllActions
-{
- NSNull *nullValue = [NSNull null];
- self.style = @{
- @"actions" : @{
- @"anchorPoint" : nullValue,
- @"anchorPointZ" : nullValue,
- @"backgroundColor" : nullValue,
- @"borderColor" : nullValue,
- @"borderWidth" : nullValue,
- @"bounds" : nullValue,
- @"contents" : nullValue,
- @"contentsRect" : nullValue,
- @"contentsScale" : nullValue,
- @"cornerRadius" : nullValue,
- @"opacity" : nullValue,
- @"position" : nullValue,
- @"shadowColor" : nullValue,
- @"sublayerTransform" : nullValue,
- @"sublayers" : nullValue,
- @"transform" : nullValue,
- @"zPosition" : nullValue
- }
- };
-}
-
-@end
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacWebCoreCALayerExtrash"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.h (0 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.h (rev 0)
+++ trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.h 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+/*
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebCoreCALayerExtras_h
+#define WebCoreCALayerExtras_h
+
+#import <QuartzCore/QuartzCore.h>
+
+@interface CALayer (WebCoreCALayerExtras)
+
+- (void)web_disableAllActions;
+
+@end
+
+#endif // WebCoreCALayerExtras_h
</ins></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacWebCoreCALayerExtrasmm"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.mm (0 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.mm (rev 0)
+++ trunk/Source/WebCore/platform/graphics/mac/WebCoreCALayerExtras.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -0,0 +1,58 @@
</span><ins>+/*
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#import "WebCoreCALayerExtras.h"
+
+@implementation CALayer (WebCoreCALayerExtras)
+
+- (void)web_disableAllActions
+{
+ NSNull *nullValue = [NSNull null];
+ self.style = @{
+ @"actions" : @{
+ @"anchorPoint" : nullValue,
+ @"anchorPointZ" : nullValue,
+ @"backgroundColor" : nullValue,
+ @"borderColor" : nullValue,
+ @"borderWidth" : nullValue,
+ @"bounds" : nullValue,
+ @"contents" : nullValue,
+ @"contentsRect" : nullValue,
+ @"contentsScale" : nullValue,
+ @"cornerRadius" : nullValue,
+ @"opacity" : nullValue,
+ @"position" : nullValue,
+ @"shadowColor" : nullValue,
+ @"sublayerTransform" : nullValue,
+ @"sublayers" : nullValue,
+ @"transform" : nullValue,
+ @"zPosition" : nullValue
+ }
+ };
+}
+
+@end
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2014-01-21 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><ins>+ Address late review naming comments after r162453.
+
+ * UIProcess/API/mac/WKView.mm:
+ And, fix the build by adding an include I accidentally missed.
+
+ * UIProcess/mac/RemoteLayerTreeHost.mm:
+ * WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
+
+2014-01-21 Tim Horton <timothy_horton@apple.com>
+
</ins><span class="cx"> Keep CALayer implicit animation disabling code in a single place
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=127355
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -83,6 +83,7 @@
</span><span class="cx"> #import <WebCore/Region.h>
</span><span class="cx"> #import <WebCore/SharedBuffer.h>
</span><span class="cx"> #import <WebCore/TextAlternativeWithRange.h>
</span><ins>+#import <WebCore/WebCoreCALayerExtras.h>
</ins><span class="cx"> #import <WebCore/WebCoreFullScreenPlaceholderView.h>
</span><span class="cx"> #import <WebCore/WebCoreFullScreenWindow.h>
</span><span class="cx"> #import <WebCore/WebCoreNSStringExtras.h>
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeHostmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> #import "ShareableBitmap.h"
</span><span class="cx"> #import "WebPageProxy.h"
</span><span class="cx"> #import "WebProcessProxy.h"
</span><del>-#import <WebCore/CALayerWebAdditions.h>
</del><ins>+#import <WebCore/WebCoreCALayerExtras.h>
</ins><span class="cx"> #import <WebCore/PlatformLayer.h>
</span><span class="cx"> #import <WebKitSystemInterface.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemoteCustommm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm (162453 => 162454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm 2014-01-21 19:19:19 UTC (rev 162453)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm 2014-01-21 19:36:19 UTC (rev 162454)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> #import "RemoteLayerTreeContext.h"
</span><span class="cx"> #import "RemoteLayerTreePropertyApplier.h"
</span><span class="cx"> #import "WebProcess.h"
</span><del>-#import <WebCore/CALayerWebAdditions.h>
</del><ins>+#import <WebCore/WebCoreCALayerExtras.h>
</ins><span class="cx"> #import <WebCore/GraphicsLayerCA.h>
</span><span class="cx"> #import <WebCore/PlatformCALayerMac.h>
</span><span class="cx"> #import <WebCore/SoftLinking.h>
</span></span></pre>
</div>
</div>
</body>
</html>