<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162334] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162334">162334</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-20 03:59:14 -0800 (Mon, 20 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Col width is not honored when dynamically updated and it would make table narrower
https://bugs.webkit.org/show_bug.cgi?id=104711
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-20
Reviewed by Antti Koivisto.
Source/WebCore:
Increasing the table width by increasing the colgroup width
was working but decreasing the table width by decreasing the
colgroup width is not working.
Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
When colgroup width is defined table cell should adjust according to
that. On decreasing colgroup width the cells maxPreferredLogicalWidth
was still set to the earlier value. Setting the
setPreferredLogicalWidthsDirty to true so that cells pref width is
calculated again.
LayoutTests:
* fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
* fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
Added new test case to verify that table cell width decreases by
decreasing the colgroup width.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableColcpp">trunk/Source/WebCore/rendering/RenderTableCol.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLTableColElementresizetablewidthusingcolwidthexpectedtxt">trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLTableColElementresizetablewidthusingcolwidthhtml">trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162333 => 162334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-20 11:58:27 UTC (rev 162333)
+++ trunk/LayoutTests/ChangeLog 2014-01-20 11:59:14 UTC (rev 162334)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-20 Gurpreet Kaur <k.gurpreet@samsung.com>
+
+ Col width is not honored when dynamically updated and it would make table narrower
+ https://bugs.webkit.org/show_bug.cgi?id=104711
+
+ Reviewed by Antti Koivisto.
+
+ * fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
+ * fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
+ Added new test case to verify that table cell width decreases by
+ decreasing the colgroup width.
+
</ins><span class="cx"> 2014-01-20 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed GTK gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLTableColElementresizetablewidthusingcolwidthexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt (0 => 162334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt 2014-01-20 11:59:14 UTC (rev 162334)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Tests that the width of table cell changes on changing the colgroup width to new width which is less than its originally defined width. New width should be 100
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.getElementById('colWidth').offsetWidth is 100
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkLayoutTestsfastdomHTMLTableColElementresizetablewidthusingcolwidthhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html (0 => 162334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html 2014-01-20 11:59:14 UTC (rev 162334)
</span><span class="lines">@@ -0,0 +1,41 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <style>
+ col {
+ width: 200px;
+ }
+ td {
+ background-color: #66f;
+ height: 25px;
+ }
+ </style>
+ <script src="../../../resources/js-test-pre.js"></script>
+ <script>
+ function runTest() {
+ description('Tests that the width of table cell changes on changing the colgroup width to new width which is less than its originally defined width. New width should be 100');
+
+ setTimeout(function() {
+ var col = document.getElementById('thecol');
+ col.style.width="100px";
+ shouldBe("document.getElementById('colWidth').offsetWidth","100");
+ finishJSTest();
+ }, 0);
+ }
+ var jsTestIsAsync = true;
+ </script>
+ </head>
+ <body onload="runTest()">
+ <table>
+ <colgroup>
+ <col id="thecol">
+ </colgroup>
+ <tbody>
+ <tr>
+ <td id="colWidth"></td>
+ </tr>
+ </tbody>
+ </table>
+ <script src="../../../resources/js-test-post.js"></script>
+ </body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span><span class="cx">Property changes on: trunk/LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162333 => 162334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-20 11:58:27 UTC (rev 162333)
+++ trunk/Source/WebCore/ChangeLog 2014-01-20 11:59:14 UTC (rev 162334)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-01-20 Gurpreet Kaur <k.gurpreet@samsung.com>
+
+ Col width is not honored when dynamically updated and it would make table narrower
+ https://bugs.webkit.org/show_bug.cgi?id=104711
+
+ Reviewed by Antti Koivisto.
+
+ Increasing the table width by increasing the colgroup width
+ was working but decreasing the table width by decreasing the
+ colgroup width is not working.
+
+ Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
+
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::styleDidChange):
+ When colgroup width is defined table cell should adjust according to
+ that. On decreasing colgroup width the cells maxPreferredLogicalWidth
+ was still set to the earlier value. Setting the
+ setPreferredLogicalWidthsDirty to true so that cells pref width is
+ calculated again.
+
</ins><span class="cx"> 2014-01-20 Edit Balint <edbalint@inf.u-szeged.hu>
</span><span class="cx">
</span><span class="cx"> [CoordinatedGraphics] Segmentation fault at CoordinatedGraphicsScene::clearImageBackingContents
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableColcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableCol.cpp (162333 => 162334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableCol.cpp 2014-01-20 11:58:27 UTC (rev 162333)
+++ trunk/Source/WebCore/rendering/RenderTableCol.cpp 2014-01-20 11:59:14 UTC (rev 162334)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLTableColElement.h"
</span><ins>+#include "RenderIterator.h"
</ins><span class="cx"> #include "RenderTable.h"
</span><span class="cx"> #include "RenderTableCell.h"
</span><span class="cx">
</span><span class="lines">@@ -53,6 +54,20 @@
</span><span class="cx"> RenderTable* table = this->table();
</span><span class="cx"> if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style().border())
</span><span class="cx"> table->invalidateCollapsedBorders();
</span><ins>+ else if (oldStyle->width() != style().width()) {
+ for (auto& section : childrenOfType<RenderTableSection>(*table)) {
+ unsigned nEffCols = table->numEffCols();
+ for (unsigned j = 0; j < nEffCols; j++) {
+ unsigned rowCount = section.numRows();
+ for (unsigned i = 0; i < rowCount; i++) {
+ RenderTableCell* cell = section.primaryCellAt(i, j);
+ if (!cell)
+ continue;
+ cell->setPreferredLogicalWidthsDirty(true);
+ }
+ }
+ }
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>