<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162369] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162369">162369</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-20 13:15:39 -0800 (Mon, 20 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=127206
Reviewed by Anders Carlsson.
Let clang-modernize add overrides.
* inspector/DOMEditor.cpp:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/PageDebuggerAgent.h:
* inspector/PageRuntimeAgent.h:
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerInspectorController.cpp:
* inspector/WorkerRuntimeAgent.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorDOMEditorcpp">trunk/Source/WebCore/inspector/DOMEditor.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgenth">trunk/Source/WebCore/inspector/InspectorCSSAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCanvasAgenth">trunk/Source/WebCore/inspector/InspectorCanvasAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorConsoleAgenth">trunk/Source/WebCore/inspector/InspectorConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgenth">trunk/Source/WebCore/inspector/InspectorDOMAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth">trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMStorageAgenth">trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDatabaseAgentcpp">trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDatabaseAgenth">trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDebuggerAgenth">trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostcpp">trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHeapProfilerAgentcpp">trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHeapProfilerAgenth">trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHistorycpp">trunk/Source/WebCore/inspector/InspectorHistory.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgenth">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInputAgenth">trunk/Source/WebCore/inspector/InspectorInputAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorLayerTreeAgenth">trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorMemoryAgenth">trunk/Source/WebCore/inspector/InspectorMemoryAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorProfilerAgentcpp">trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorProfilerAgenth">trunk/Source/WebCore/inspector/InspectorProfilerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorResourceAgenth">trunk/Source/WebCore/inspector/InspectorResourceAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorRuntimeAgenth">trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheeth">trunk/Source/WebCore/inspector/InspectorStyleSheet.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgenth">trunk/Source/WebCore/inspector/InspectorTimelineAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorWorkerAgentcpp">trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorWorkerAgenth">trunk/Source/WebCore/inspector/InspectorWorkerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageConsoleAgenth">trunk/Source/WebCore/inspector/PageConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageDebuggerAgenth">trunk/Source/WebCore/inspector/PageDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageRuntimeAgenth">trunk/Source/WebCore/inspector/PageRuntimeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerConsoleAgenth">trunk/Source/WebCore/inspector/WorkerConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerDebuggerAgentcpp">trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerInspectorControllercpp">trunk/Source/WebCore/inspector/WorkerInspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerRuntimeAgenth">trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/ChangeLog 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -1,3 +1,51 @@
</span><ins>+2014-01-20 Joseph Pecoraro <pecoraro@apple.com>
+
+ Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
+ https://bugs.webkit.org/show_bug.cgi?id=127206
+
+ Reviewed by Anders Carlsson.
+
+ Let clang-modernize add overrides.
+
+ * inspector/DOMEditor.cpp:
+ * inspector/InspectorApplicationCacheAgent.h:
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorCanvasAgent.h:
+ * inspector/InspectorConsoleAgent.h:
+ * inspector/InspectorDOMAgent.h:
+ * inspector/InspectorDOMDebuggerAgent.h:
+ * inspector/InspectorDOMStorageAgent.h:
+ * inspector/InspectorDatabaseAgent.cpp:
+ * inspector/InspectorDatabaseAgent.h:
+ * inspector/InspectorDebuggerAgent.h:
+ * inspector/InspectorFrontendHost.cpp:
+ * inspector/InspectorHeapProfilerAgent.cpp:
+ (WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
+ (WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
+ * inspector/InspectorHeapProfilerAgent.h:
+ * inspector/InspectorHistory.cpp:
+ * inspector/InspectorIndexedDBAgent.cpp:
+ * inspector/InspectorIndexedDBAgent.h:
+ * inspector/InspectorInputAgent.h:
+ * inspector/InspectorLayerTreeAgent.h:
+ * inspector/InspectorMemoryAgent.h:
+ * inspector/InspectorPageAgent.h:
+ * inspector/InspectorProfilerAgent.cpp:
+ * inspector/InspectorProfilerAgent.h:
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorRuntimeAgent.h:
+ * inspector/InspectorStyleSheet.h:
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/InspectorWorkerAgent.cpp:
+ * inspector/InspectorWorkerAgent.h:
+ * inspector/PageConsoleAgent.h:
+ * inspector/PageDebuggerAgent.h:
+ * inspector/PageRuntimeAgent.h:
+ * inspector/WorkerConsoleAgent.h:
+ * inspector/WorkerDebuggerAgent.cpp:
+ * inspector/WorkerInspectorController.cpp:
+ * inspector/WorkerRuntimeAgent.h:
+
</ins><span class="cx"> 2014-01-20 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Move WebAudio source code to std::unique_ptr
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorDOMEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/DOMEditor.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/DOMEditor.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/DOMEditor.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -56,18 +56,18 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_anchorNode = m_node->nextSibling();
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_parentNode->removeChild(m_node.get(), ec);
</span><span class="cx"> }
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_node->parentNode()) {
</span><span class="cx"> m_removeChildAction = adoptPtr(new RemoveChildAction(m_node->parentNode(), m_node.get()));
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> if (!m_parentNode->removeChild(m_node.get(), ec))
</span><span class="cx"> return false;
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_removeChildAction && !m_removeChildAction->redo(ec))
</span><span class="cx"> return false;
</span><span class="lines">@@ -132,19 +132,19 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_value = m_element->getAttribute(m_name);
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_element->setAttribute(m_name, m_value, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode&)
</del><ins>+ virtual bool redo(ExceptionCode&) override
</ins><span class="cx"> {
</span><span class="cx"> m_element->removeAttribute(m_name);
</span><span class="cx"> return true;
</span><span class="lines">@@ -168,7 +168,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_hadAttribute = m_element->hasAttribute(m_name);
</span><span class="cx"> if (m_hadAttribute)
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_hadAttribute)
</span><span class="cx"> m_element->setAttribute(m_name, m_oldValue, ec);
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_element->setAttribute(m_name, m_value, ec);
</span><span class="cx"> return true;
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_oldHTML = createMarkup(m_node.get());
</span><span class="cx"> DOMPatchSupport domPatchSupport(m_domEditor.get(), &m_node->document());
</span><span class="lines">@@ -221,12 +221,12 @@
</span><span class="cx"> return !ec;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_history->undo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_history->redo(ec);
</span><span class="cx"> }
</span><span class="lines">@@ -256,19 +256,19 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_oldText = m_textNode->wholeText();
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_textNode->replaceWholeText(m_oldText, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_textNode->replaceWholeText(m_text, ec);
</span><span class="cx"> return true;
</span><span class="lines">@@ -291,17 +291,17 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_parentNode->replaceChild(m_oldNode, m_newNode.get(), ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> return m_parentNode->replaceChild(m_newNode, m_oldNode.get(), ec);
</span><span class="cx"> }
</span><span class="lines">@@ -322,19 +322,19 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode& ec)
</del><ins>+ virtual bool perform(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_oldValue = m_node->nodeValue();
</span><span class="cx"> return redo(ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool undo(ExceptionCode& ec)
</del><ins>+ virtual bool undo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_node->setNodeValue(m_oldValue, ec);
</span><span class="cx"> return !ec;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool redo(ExceptionCode& ec)
</del><ins>+ virtual bool redo(ExceptionCode& ec) override
</ins><span class="cx"> {
</span><span class="cx"> m_node->setNodeValue(m_value, ec);
</span><span class="cx"> return !ec;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -62,10 +62,10 @@
</span><span class="cx"> void updateApplicationCacheStatus(Frame*);
</span><span class="cx"> void networkStateChanged();
</span><span class="cx">
</span><del>- virtual void enable(ErrorString*);
- virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result);
- virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL);
- virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result) override;
+ virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL) override;
+ virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> PassRefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -97,9 +97,9 @@
</span><span class="cx"> bool forcePseudoState(Element*, CSSSelector::PseudoType);
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><del>- virtual void discardAgent();
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
</del><ins>+ virtual void discardAgent() override;
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
</ins><span class="cx"> void reset();
</span><span class="cx"> void mediaQueryResultChanged();
</span><span class="cx"> void didCreateNamedFlow(Document*, WebKitNamedFlow*);
</span><span class="lines">@@ -111,21 +111,21 @@
</span><span class="cx"> void didRegisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
</span><span class="cx"> void didUnregisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement);
</span><span class="cx">
</span><del>- virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&);
- virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes);
- virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries);
- virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos);
- virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result);
- virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result);
- virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text);
- virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
- virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
- virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result);
- virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses);
- virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result);
</del><ins>+ virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&) override;
+ virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes) override;
+ virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries) override;
+ virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos) override;
+ virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result) override;
+ virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result) override;
+ virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text) override;
+ virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
+ virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
+ virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result) override;
+ virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses) override;
+ virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> class StyleSheetAction;
</span><span class="lines">@@ -162,12 +162,12 @@
</span><span class="cx"> PassRefPtr<Inspector::TypeBuilder::CSS::NamedFlow> buildObjectForNamedFlow(ErrorString*, WebKitNamedFlow*, int documentNodeId);
</span><span class="cx">
</span><span class="cx"> // InspectorDOMAgent::DOMListener implementation
</span><del>- virtual void didRemoveDocument(Document*);
- virtual void didRemoveDOMNode(Node*);
- virtual void didModifyDOMAttr(Element*);
</del><ins>+ virtual void didRemoveDocument(Document*) override;
+ virtual void didRemoveDOMNode(Node*) override;
+ virtual void didModifyDOMAttr(Element*) override;
</ins><span class="cx">
</span><span class="cx"> // InspectorCSSAgent::Listener implementation
</span><del>- virtual void styleSheetChanged(InspectorStyleSheet*);
</del><ins>+ virtual void styleSheetChanged(InspectorStyleSheet*) override;
</ins><span class="cx">
</span><span class="cx"> void resetPseudoStates();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCanvasAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCanvasAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCanvasAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorCanvasAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -79,17 +79,17 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> // Called from the front-end.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
- virtual void hasUninstrumentedCanvases(ErrorString*, bool*);
- virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
- virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
- virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
- virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&);
- virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
- virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&);
- virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
+ virtual void hasUninstrumentedCanvases(ErrorString*, bool*) override;
+ virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
+ virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
+ virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
+ virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&) override;
+ virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
+ virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&) override;
+ virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, JSC::ExecState*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -59,9 +59,9 @@
</span><span class="cx"> InspectorConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*);
</span><span class="cx"> virtual ~InspectorConsoleAgent();
</span><span class="cx">
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void clearMessages(ErrorString*);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void clearMessages(ErrorString*) override;
</ins><span class="cx"> bool enabled() const { return m_enabled; }
</span><span class="cx"> void reset();
</span><span class="cx">
</span><span class="lines">@@ -89,9 +89,9 @@
</span><span class="cx"> void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
</span><span class="cx"> void addStartProfilingMessageToConsole(const String& title, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
</span><span class="cx"> #endif
</span><del>- virtual void setMonitoringXHREnabled(ErrorString*, bool enabled);
</del><ins>+ virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override;
</ins><span class="cx"> virtual void addInspectedNode(ErrorString*, int nodeId) = 0;
</span><del>- virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId);
</del><ins>+ virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override;
</ins><span class="cx">
</span><span class="cx"> virtual bool isWorkerAgent() = 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -118,40 +118,40 @@
</span><span class="cx"> void reset();
</span><span class="cx">
</span><span class="cx"> // Methods called from the frontend for DOM nodes inspection.
</span><del>- virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId);
- virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result);
- virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root);
- virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth);
- virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value);
- virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name);
- virtual void removeAttribute(ErrorString*, int elementId, const String& name);
- virtual void removeNode(ErrorString*, int nodeId);
- virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId);
- virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML);
- virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML);
- virtual void setNodeValue(ErrorString*, int nodeId, const String& value);
- virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray);
- virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount);
- virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&);
- virtual void discardSearchResults(ErrorString*, const String& searchId);
- virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result);
- virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig);
- virtual void requestNode(ErrorString*, const String& objectId, int* nodeId);
- virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId);
- virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId);
- virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup);
- virtual void hideHighlight(ErrorString*);
- virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
- virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
- virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId);
- virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor);
</del><ins>+ virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
+ virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result) override;
+ virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root) override;
+ virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
+ virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
+ virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
+ virtual void removeAttribute(ErrorString*, int elementId, const String& name) override;
+ virtual void removeNode(ErrorString*, int nodeId) override;
+ virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
+ virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
+ virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
+ virtual void setNodeValue(ErrorString*, int nodeId, const String& value) override;
+ virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray) override;
+ virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount) override;
+ virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&) override;
+ virtual void discardSearchResults(ErrorString*, const String& searchId) override;
+ virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result) override;
+ virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig) override;
+ virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
+ virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
+ virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId) override;
+ virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup) override;
+ virtual void hideHighlight(ErrorString*) override;
+ virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
+ virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
+ virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId) override;
+ virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor) override;
</ins><span class="cx">
</span><del>- virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId);
- virtual void undo(ErrorString*);
- virtual void redo(ErrorString*);
- virtual void markUndoableState(ErrorString*);
- virtual void focus(ErrorString*, int nodeId);
</del><ins>+ virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
+ virtual void undo(ErrorString*) override;
+ virtual void redo(ErrorString*) override;
+ virtual void markUndoableState(ErrorString*) override;
+ virtual void focus(ErrorString*, int nodeId) override;
</ins><span class="cx">
</span><span class="cx"> void getEventListeners(Node*, Vector<EventListenerInfo>& listenersArray, bool includeAncestors);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -62,14 +62,14 @@
</span><span class="cx"> virtual ~InspectorDOMDebuggerAgent();
</span><span class="cx">
</span><span class="cx"> // DOMDebugger API
</span><del>- virtual void setXHRBreakpoint(ErrorString*, const String& url);
- virtual void removeXHRBreakpoint(ErrorString*, const String& url);
- virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type);
- virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type);
</del><ins>+ virtual void setXHRBreakpoint(ErrorString*, const String& url) override;
+ virtual void removeXHRBreakpoint(ErrorString*, const String& url) override;
+ virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
+ virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
</ins><span class="cx">
</span><span class="cx"> // InspectorInstrumentation API
</span><span class="cx"> void willInsertDOMNode(Node* parent);
</span><span class="lines">@@ -83,14 +83,14 @@
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><del>- virtual void discardAgent();
</del><ins>+ virtual void discardAgent() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // InspectorDebuggerAgent::Listener implementation.
</span><del>- virtual void debuggerWasEnabled();
- virtual void debuggerWasDisabled();
- virtual void stepInto();
- virtual void didPause();
</del><ins>+ virtual void debuggerWasEnabled() override;
+ virtual void debuggerWasDisabled() override;
+ virtual void stepInto() override;
+ virtual void didPause() override;
</ins><span class="cx"> void disable();
</span><span class="cx">
</span><span class="cx"> void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, Inspector::InspectorObject* description);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMStorageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -61,11 +61,11 @@
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><span class="cx"> // Called from the front-end.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items);
- virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value);
- virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items) override;
+ virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value) override;
+ virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key) override;
</ins><span class="cx">
</span><span class="cx"> // Called from the injected script.
</span><span class="cx"> String storageId(Storage*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDatabaseAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~StatementCallback() { }
</span><span class="cx">
</span><del>- virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet)
</del><ins>+ virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
</ins><span class="cx"> {
</span><span class="cx"> SQLResultSetRowList* rowList = resultSet->rows();
</span><span class="cx">
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~StatementErrorCallback() { }
</span><span class="cx">
</span><del>- virtual bool handleEvent(SQLTransaction*, SQLError* error)
</del><ins>+ virtual bool handleEvent(SQLTransaction*, SQLError* error) override
</ins><span class="cx"> {
</span><span class="cx"> reportTransactionFailed(m_requestCallback.get(), error);
</span><span class="cx"> return true;
</span><span class="lines">@@ -135,7 +135,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~TransactionCallback() { }
</span><span class="cx">
</span><del>- virtual bool handleEvent(SQLTransaction* transaction)
</del><ins>+ virtual bool handleEvent(SQLTransaction* transaction) override
</ins><span class="cx"> {
</span><span class="cx"> if (!m_requestCallback->isActive())
</span><span class="cx"> return true;
</span><span class="lines">@@ -163,7 +163,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~TransactionErrorCallback() { }
</span><span class="cx">
</span><del>- virtual bool handleEvent(SQLError* error)
</del><ins>+ virtual bool handleEvent(SQLError* error) override
</ins><span class="cx"> {
</span><span class="cx"> reportTransactionFailed(m_requestCallback.get(), error);
</span><span class="cx"> return true;
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~TransactionSuccessCallback() { }
</span><span class="cx">
</span><del>- virtual bool handleEvent() { return false; }
</del><ins>+ virtual bool handleEvent() override { return false; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> TransactionSuccessCallback() { }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDatabaseAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -61,10 +61,10 @@
</span><span class="cx"> void clearResources();
</span><span class="cx">
</span><span class="cx"> // Called from the front-end.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names);
- virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names) override;
+ virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>) override;
</ins><span class="cx">
</span><span class="cx"> // Called from the injected script.
</span><span class="cx"> String databaseId(Database*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -77,24 +77,24 @@
</span><span class="cx"> void addMessageToConsole(MessageSource, MessageType);
</span><span class="cx">
</span><span class="cx"> // Part of the protocol.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void setBreakpointsActive(ErrorString*, bool active);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void setBreakpointsActive(ErrorString*, bool active) override;
</ins><span class="cx">
</span><del>- virtual void setBreakpointByUrl(ErrorString*, int lineNumber, const String* optionalURL, const String* optionalURLRegex, const int* optionalColumnNumber, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::Location>>& locations, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
- virtual void setBreakpoint(ErrorString*, const RefPtr<Inspector::InspectorObject>& location, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Debugger::Location>& actualLocation, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
- virtual void removeBreakpoint(ErrorString*, const String& breakpointIdentifier);
- virtual void continueToLocation(ErrorString*, const RefPtr<Inspector::InspectorObject>& location);
</del><ins>+ virtual void setBreakpointByUrl(ErrorString*, int lineNumber, const String* optionalURL, const String* optionalURLRegex, const int* optionalColumnNumber, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::Location>>& locations, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers) override;
+ virtual void setBreakpoint(ErrorString*, const RefPtr<Inspector::InspectorObject>& location, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Debugger::Location>& actualLocation, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers) override;
+ virtual void removeBreakpoint(ErrorString*, const String& breakpointIdentifier) override;
+ virtual void continueToLocation(ErrorString*, const RefPtr<Inspector::InspectorObject>& location) override;
</ins><span class="cx">
</span><del>- virtual void searchInContent(ErrorString*, const String& scriptID, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
- virtual void getScriptSource(ErrorString*, const String& scriptID, String* scriptSource);
- virtual void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<Inspector::TypeBuilder::Debugger::FunctionDetails>&);
- virtual void pause(ErrorString*);
- virtual void resume(ErrorString*);
- virtual void stepOver(ErrorString*);
- virtual void stepInto(ErrorString*);
- virtual void stepOut(ErrorString*);
- virtual void setPauseOnExceptions(ErrorString*, const String& pauseState);
</del><ins>+ virtual void searchInContent(ErrorString*, const String& scriptID, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&) override;
+ virtual void getScriptSource(ErrorString*, const String& scriptID, String* scriptSource) override;
+ virtual void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<Inspector::TypeBuilder::Debugger::FunctionDetails>&) override;
+ virtual void pause(ErrorString*) override;
+ virtual void resume(ErrorString*) override;
+ virtual void stepOver(ErrorString*) override;
+ virtual void stepInto(ErrorString*) override;
+ virtual void stepOut(ErrorString*) override;
+ virtual void setPauseOnExceptions(ErrorString*, const String& pauseState) override;
</ins><span class="cx"> virtual void evaluateOnCallFrame(ErrorString*,
</span><span class="cx"> const String& callFrameId,
</span><span class="cx"> const String& expression,
</span><span class="lines">@@ -104,8 +104,8 @@
</span><span class="cx"> const bool* returnByValue,
</span><span class="cx"> const bool* generatePreview,
</span><span class="cx"> RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
</span><del>- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
- virtual void setOverlayMessage(ErrorString*, const String*);
</del><ins>+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
+ virtual void setOverlayMessage(ErrorString*, const String*) override;
</ins><span class="cx">
</span><span class="cx"> void schedulePauseOnNextStatement(Inspector::InspectorDebuggerFrontendDispatcher::Reason::Enum breakReason, PassRefPtr<Inspector::InspectorObject> data);
</span><span class="cx"> void cancelPauseOnNextStatement();
</span><span class="lines">@@ -136,8 +136,8 @@
</span><span class="cx">
</span><span class="cx"> virtual void enable();
</span><span class="cx"> virtual void disable();
</span><del>- virtual void didPause(JSC::ExecState*, const Deprecated::ScriptValue& callFrames, const Deprecated::ScriptValue& exception);
- virtual void didContinue();
</del><ins>+ virtual void didPause(JSC::ExecState*, const Deprecated::ScriptValue& callFrames, const Deprecated::ScriptValue& exception) override;
+ virtual void didContinue() override;
</ins><span class="cx"> void didClearGlobalObject();
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHostcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -90,13 +90,13 @@
</span><span class="cx"> contextMenuCleared();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void populateContextMenu(ContextMenu* menu)
</del><ins>+ virtual void populateContextMenu(ContextMenu* menu) override
</ins><span class="cx"> {
</span><span class="cx"> for (size_t i = 0; i < m_items.size(); ++i)
</span><span class="cx"> menu->appendItem(m_items[i]);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void contextMenuItemSelected(ContextMenuItem* item)
</del><ins>+ virtual void contextMenuItemSelected(ContextMenuItem* item) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_frontendHost) {
</span><span class="cx"> UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void contextMenuCleared()
</del><ins>+ virtual void contextMenuCleared() override
</ins><span class="cx"> {
</span><span class="cx"> if (m_frontendHost) {
</span><span class="cx"> Deprecated::ScriptFunctionCall function(m_frontendApiObject, "contextMenuCleared", WebCore::functionCallHandlerFromAnyThread);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHeapProfilerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -128,8 +128,8 @@
</span><span class="cx"> public:
</span><span class="cx"> OutputStream(InspectorHeapProfilerFrontendDispatcher* frontend, unsigned uid)
</span><span class="cx"> : m_frontendDispatcher(frontend), m_uid(uid) { }
</span><del>- void Write(const String& chunk) { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
- void Close() { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
</del><ins>+ void Write(const String& chunk) override { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
+ void Close() override { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
</ins><span class="cx"> private:
</span><span class="cx"> InspectorHeapProfilerFrontendDispatcher* m_frontendDispatcher;
</span><span class="cx"> int m_uid;
</span><span class="lines">@@ -161,16 +161,16 @@
</span><span class="cx"> public:
</span><span class="cx"> explicit HeapSnapshotProgress(InspectorHeapProfilerFrontendDispatcher* frontend)
</span><span class="cx"> : m_frontendDispatcher(frontend) { }
</span><del>- void Start(int totalWork)
</del><ins>+ void Start(int totalWork) override
</ins><span class="cx"> {
</span><span class="cx"> m_totalWork = totalWork;
</span><span class="cx"> }
</span><del>- void Worked(int workDone)
</del><ins>+ void Worked(int workDone) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_frontendDispatcher)
</span><span class="cx"> m_frontendDispatcher->reportHeapSnapshotProgress(workDone, m_totalWork);
</span><span class="cx"> }
</span><del>- void Done() { }
</del><ins>+ void Done() override { }
</ins><span class="cx"> bool isCanceled() { return false; }
</span><span class="cx"> private:
</span><span class="cx"> InspectorHeapProfilerFrontendDispatcher* m_frontendDispatcher;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHeapProfilerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -56,23 +56,23 @@
</span><span class="cx"> InspectorHeapProfilerAgent(InstrumentingAgents*, PageInjectedScriptManager*);
</span><span class="cx"> virtual ~InspectorHeapProfilerAgent();
</span><span class="cx">
</span><del>- virtual void collectGarbage(ErrorString*);
- virtual void clearProfiles(ErrorString*) { resetState(); }
</del><ins>+ virtual void collectGarbage(ErrorString*) override;
+ virtual void clearProfiles(ErrorString*) override { resetState(); }
</ins><span class="cx"> void resetState();
</span><span class="cx">
</span><del>- virtual void hasHeapProfiler(ErrorString*, bool*);
</del><ins>+ virtual void hasHeapProfiler(ErrorString*, bool*) override;
</ins><span class="cx">
</span><del>- virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::HeapProfiler::ProfileHeader>>&);
- virtual void getHeapSnapshot(ErrorString*, int uid);
- virtual void removeProfile(ErrorString*, int uid);
</del><ins>+ virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::HeapProfiler::ProfileHeader>>&) override;
+ virtual void getHeapSnapshot(ErrorString*, int uid) override;
+ virtual void removeProfile(ErrorString*, int uid) override;
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><del>- virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress);
</del><ins>+ virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;
</ins><span class="cx">
</span><del>- virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId);
</del><ins>+ virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> typedef HashMap<unsigned, RefPtr<ScriptHeapSnapshot>> IdToHeapSnapshotMap;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHistorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHistory.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHistory.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorHistory.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -45,13 +45,13 @@
</span><span class="cx"> public:
</span><span class="cx"> UndoableStateMark() : InspectorHistory::Action("[UndoableState]") { }
</span><span class="cx">
</span><del>- virtual bool perform(ExceptionCode&) { return true; }
</del><ins>+ virtual bool perform(ExceptionCode&) override { return true; }
</ins><span class="cx">
</span><del>- virtual bool undo(ExceptionCode&) { return true; }
</del><ins>+ virtual bool undo(ExceptionCode&) override { return true; }
</ins><span class="cx">
</span><del>- virtual bool redo(ExceptionCode&) { return true; }
</del><ins>+ virtual bool redo(ExceptionCode&) override { return true; }
</ins><span class="cx">
</span><del>- virtual bool isUndoableStateMark() { return true; }
</del><ins>+ virtual bool isUndoableStateMark() override { return true; }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -276,7 +276,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~DatabaseLoader() { }
</span><span class="cx">
</span><del>- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
</del><ins>+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> ASSERT_UNUSED(prpDatabase, prpDatabase);
</span><span class="lines">@@ -322,7 +322,7 @@
</span><span class="cx"> #endif // PLATFORM(MAC)
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
</del><ins>+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
</ins><span class="cx"> private:
</span><span class="cx"> DatabaseLoader(ScriptExecutionContext* context, PassRefPtr<RequestDatabaseCallback> requestCallback)
</span><span class="cx"> : ExecutableWithDatabase(context)
</span><span class="lines">@@ -504,7 +504,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~DataLoader() { }
</span><span class="cx">
</span><del>- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
</del><ins>+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<IDBDatabase> idbDatabase = prpDatabase;
</span><span class="cx"> if (!requestCallback()->isActive())
</span><span class="lines">@@ -537,7 +537,7 @@
</span><span class="cx"> idbRequest->addEventListener(eventNames().successEvent, openCursorCallback, false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
</del><ins>+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
</ins><span class="cx"> DataLoader(ScriptExecutionContext* scriptExecutionContext, PassRefPtr<RequestDataCallback> requestCallback, const InjectedScript& injectedScript, const String& objectStoreName, const String& indexName, PassRefPtr<IDBKeyRange> idbKeyRange, int skipCount, unsigned pageSize)
</span><span class="cx"> : ExecutableWithDatabase(scriptExecutionContext)
</span><span class="cx"> , m_requestCallback(requestCallback)
</span><span class="lines">@@ -720,7 +720,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
</del><ins>+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<IDBDatabase> idbDatabase = prpDatabase;
</span><span class="cx"> if (!requestCallback()->isActive())
</span><span class="lines">@@ -746,7 +746,7 @@
</span><span class="cx"> idbTransaction->addEventListener(eventNames().completeEvent, ClearObjectStoreListener::create(m_requestCallback), false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
</del><ins>+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
</ins><span class="cx"> private:
</span><span class="cx"> const String m_objectStoreName;
</span><span class="cx"> RefPtr<ClearObjectStoreCallback> m_requestCallback;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -57,12 +57,12 @@
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><span class="cx"> // Called from the front-end.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void requestDatabaseNames(ErrorString*, const String& securityOrigin, PassRefPtr<RequestDatabaseNamesCallback>);
- virtual void requestDatabase(ErrorString*, const String& securityOrigin, const String& databaseName, PassRefPtr<RequestDatabaseCallback>);
- virtual void requestData(ErrorString*, const String& securityOrigin, const String& databaseName, const String& objectStoreName, const String& indexName, int skipCount, int pageSize, const RefPtr<Inspector::InspectorObject>* keyRange, PassRefPtr<RequestDataCallback>);
- virtual void clearObjectStore(ErrorString*, const String& in_securityOrigin, const String& in_databaseName, const String& in_objectStoreName, PassRefPtr<ClearObjectStoreCallback>);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void requestDatabaseNames(ErrorString*, const String& securityOrigin, PassRefPtr<RequestDatabaseNamesCallback>) override;
+ virtual void requestDatabase(ErrorString*, const String& securityOrigin, const String& databaseName, PassRefPtr<RequestDatabaseCallback>) override;
+ virtual void requestData(ErrorString*, const String& securityOrigin, const String& databaseName, const String& objectStoreName, const String& indexName, int skipCount, int pageSize, const RefPtr<Inspector::InspectorObject>* keyRange, PassRefPtr<RequestDataCallback>) override;
+ virtual void clearObjectStore(ErrorString*, const String& in_securityOrigin, const String& in_databaseName, const String& in_objectStoreName, PassRefPtr<ClearObjectStoreCallback>) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> Inspector::InjectedScriptManager* m_injectedScriptManager;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInputAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInputAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInputAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorInputAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -54,8 +54,8 @@
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><span class="cx"> // Methods called from the frontend for simulating input.
</span><del>- virtual void dispatchKeyEvent(ErrorString*, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const int* macCharCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey);
- virtual void dispatchMouseEvent(ErrorString*, const String& type, int x, int y, const int* modifiers, const double* timestamp, const String* button, const int* clickCount);
</del><ins>+ virtual void dispatchKeyEvent(ErrorString*, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const int* macCharCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey) override;
+ virtual void dispatchMouseEvent(ErrorString*, const String& type, int x, int y, const int* modifiers, const double* timestamp, const String* button, const int* clickCount) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> Page* m_page;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorLayerTreeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -61,10 +61,10 @@
</span><span class="cx"> void pseudoElementDestroyed(PseudoElement*);
</span><span class="cx">
</span><span class="cx"> // Called from the front-end.
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void layersForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::LayerTree::Layer>>&);
- virtual void reasonsForCompositingLayer(ErrorString*, const String& layerId, RefPtr<Inspector::TypeBuilder::LayerTree::CompositingReasons>&);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void layersForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::LayerTree::Layer>>&) override;
+ virtual void reasonsForCompositingLayer(ErrorString*, const String& layerId, RefPtr<Inspector::TypeBuilder::LayerTree::CompositingReasons>&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // RenderLayer-related methods.
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorMemoryAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><del>- virtual void getDOMCounters(ErrorString*, int* documents, int* nodes, int* jsEventListeners);
</del><ins>+ virtual void getDOMCounters(ErrorString*, int* documents, int* nodes, int* jsEventListeners) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RefPtr<Inspector::InspectorMemoryBackendDispatcher> m_backendDispatcher;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -95,36 +95,36 @@
</span><span class="cx"> static Inspector::TypeBuilder::Page::ResourceType::Enum cachedResourceTypeJson(const CachedResource&);
</span><span class="cx">
</span><span class="cx"> // Page API for InspectorFrontend
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void addScriptToEvaluateOnLoad(ErrorString*, const String& source, String* result);
- virtual void removeScriptToEvaluateOnLoad(ErrorString*, const String& identifier);
- virtual void reload(ErrorString*, const bool* optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad);
- virtual void navigate(ErrorString*, const String& url);
- virtual void getCookies(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::Cookie>>& cookies);
- virtual void deleteCookie(ErrorString*, const String& cookieName, const String& url);
- virtual void getResourceTree(ErrorString*, RefPtr<Inspector::TypeBuilder::Page::FrameResourceTree>&);
- virtual void getResourceContent(ErrorString*, const String& frameId, const String& url, String* content, bool* base64Encoded);
- virtual void searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
- virtual void searchInResources(ErrorString*, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::SearchResult>>&);
- virtual void setDocumentContent(ErrorString*, const String& frameId, const String& html);
- virtual void setShowPaintRects(ErrorString*, bool show);
- virtual void canShowDebugBorders(ErrorString*, bool*);
- virtual void setShowDebugBorders(ErrorString*, bool show);
- virtual void canShowFPSCounter(ErrorString*, bool*);
- virtual void setShowFPSCounter(ErrorString*, bool show);
- virtual void canContinuouslyPaint(ErrorString*, bool*);
- virtual void setContinuousPaintingEnabled(ErrorString*, bool enabled);
- virtual void getScriptExecutionStatus(ErrorString*, Inspector::InspectorPageBackendDispatcherHandler::Result::Enum*);
- virtual void setScriptExecutionDisabled(ErrorString*, bool);
- virtual void setTouchEmulationEnabled(ErrorString*, bool);
- virtual void setEmulatedMedia(ErrorString*, const String&);
- virtual void getCompositingBordersVisible(ErrorString*, bool* out_param);
- virtual void setCompositingBordersVisible(ErrorString*, bool);
- virtual void snapshotNode(ErrorString*, int nodeId, String* outDataURL);
- virtual void snapshotRect(ErrorString*, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL);
- virtual void handleJavaScriptDialog(ErrorString*, bool accept, const String* promptText);
- virtual void archive(ErrorString*, String* data);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void addScriptToEvaluateOnLoad(ErrorString*, const String& source, String* result) override;
+ virtual void removeScriptToEvaluateOnLoad(ErrorString*, const String& identifier) override;
+ virtual void reload(ErrorString*, const bool* optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad) override;
+ virtual void navigate(ErrorString*, const String& url) override;
+ virtual void getCookies(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::Cookie>>& cookies) override;
+ virtual void deleteCookie(ErrorString*, const String& cookieName, const String& url) override;
+ virtual void getResourceTree(ErrorString*, RefPtr<Inspector::TypeBuilder::Page::FrameResourceTree>&) override;
+ virtual void getResourceContent(ErrorString*, const String& frameId, const String& url, String* content, bool* base64Encoded) override;
+ virtual void searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&) override;
+ virtual void searchInResources(ErrorString*, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::SearchResult>>&) override;
+ virtual void setDocumentContent(ErrorString*, const String& frameId, const String& html) override;
+ virtual void setShowPaintRects(ErrorString*, bool show) override;
+ virtual void canShowDebugBorders(ErrorString*, bool*) override;
+ virtual void setShowDebugBorders(ErrorString*, bool show) override;
+ virtual void canShowFPSCounter(ErrorString*, bool*) override;
+ virtual void setShowFPSCounter(ErrorString*, bool show) override;
+ virtual void canContinuouslyPaint(ErrorString*, bool*) override;
+ virtual void setContinuousPaintingEnabled(ErrorString*, bool enabled) override;
+ virtual void getScriptExecutionStatus(ErrorString*, Inspector::InspectorPageBackendDispatcherHandler::Result::Enum*) override;
+ virtual void setScriptExecutionDisabled(ErrorString*, bool) override;
+ virtual void setTouchEmulationEnabled(ErrorString*, bool) override;
+ virtual void setEmulatedMedia(ErrorString*, const String&) override;
+ virtual void getCompositingBordersVisible(ErrorString*, bool* out_param) override;
+ virtual void setCompositingBordersVisible(ErrorString*, bool) override;
+ virtual void snapshotNode(ErrorString*, int nodeId, String* outDataURL) override;
+ virtual void snapshotRect(ErrorString*, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL) override;
+ virtual void handleJavaScriptDialog(ErrorString*, bool accept, const String* promptText) override;
+ virtual void archive(ErrorString*, String* data) override;
</ins><span class="cx">
</span><span class="cx"> // InspectorInstrumentation API
</span><span class="cx"> void didClearWindowObjectInWorld(Frame*, DOMWrapperWorld&);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorProfilerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -71,17 +71,17 @@
</span><span class="cx"> virtual ~PageProfilerAgent() { }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void recompileScript()
</del><ins>+ virtual void recompileScript() override
</ins><span class="cx"> {
</span><span class="cx"> PageScriptDebugServer::shared().recompileAllJSFunctionsSoon();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void startProfiling(const String& title)
</del><ins>+ virtual void startProfiling(const String& title) override
</ins><span class="cx"> {
</span><span class="cx"> ScriptProfiler::startForPage(m_inspectedPage, title);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title)
</del><ins>+ virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title) override
</ins><span class="cx"> {
</span><span class="cx"> return ScriptProfiler::stopForPage(m_inspectedPage, title);
</span><span class="cx"> }
</span><span class="lines">@@ -101,14 +101,14 @@
</span><span class="cx"> virtual ~WorkerProfilerAgent() { }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void recompileScript() { }
</del><ins>+ virtual void recompileScript() override { }
</ins><span class="cx">
</span><del>- virtual void startProfiling(const String& title)
</del><ins>+ virtual void startProfiling(const String& title) override
</ins><span class="cx"> {
</span><span class="cx"> ScriptProfiler::startForWorkerGlobalScope(m_workerGlobalScope, title);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title)
</del><ins>+ virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title) override
</ins><span class="cx"> {
</span><span class="cx"> return ScriptProfiler::stopForWorkerGlobalScope(m_workerGlobalScope, title);
</span><span class="cx"> }
</span><span class="lines">@@ -257,8 +257,8 @@
</span><span class="cx"> public:
</span><span class="cx"> OutputStream(InspectorProfilerFrontendDispatcher* frontend, unsigned uid)
</span><span class="cx"> : m_frontendDispatcher(frontend), m_uid(uid) { }
</span><del>- void Write(const String& chunk) { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
- void Close() { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
</del><ins>+ void Write(const String& chunk) override { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
+ void Close() override { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
</ins><span class="cx"> private:
</span><span class="cx"> InspectorProfilerFrontendDispatcher* m_frontendDispatcher;
</span><span class="cx"> int m_uid;
</span><span class="lines">@@ -376,16 +376,16 @@
</span><span class="cx"> public:
</span><span class="cx"> explicit HeapSnapshotProgress(InspectorProfilerFrontendDispatcher* frontend)
</span><span class="cx"> : m_frontendDispatcher(frontend) { }
</span><del>- void Start(int totalWork)
</del><ins>+ void Start(int totalWork) override
</ins><span class="cx"> {
</span><span class="cx"> m_totalWork = totalWork;
</span><span class="cx"> }
</span><del>- void Worked(int workDone)
</del><ins>+ void Worked(int workDone) override
</ins><span class="cx"> {
</span><span class="cx"> if (m_frontendDispatcher)
</span><span class="cx"> m_frontendDispatcher->reportHeapSnapshotProgress(workDone, m_totalWork);
</span><span class="cx"> }
</span><del>- void Done() { }
</del><ins>+ void Done() override { }
</ins><span class="cx"> bool isCanceled() { return false; }
</span><span class="cx"> private:
</span><span class="cx"> InspectorProfilerFrontendDispatcher* m_frontendDispatcher;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorProfilerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -69,36 +69,36 @@
</span><span class="cx"> void addProfile(PassRefPtr<ScriptProfile> prpProfile, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
</span><span class="cx"> void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
</span><span class="cx"> void addStartProfilingMessageToConsole(const String& title, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
</span><del>- virtual void collectGarbage(ErrorString*);
- virtual void clearProfiles(ErrorString*) { resetState(); }
</del><ins>+ virtual void collectGarbage(ErrorString*) override;
+ virtual void clearProfiles(ErrorString*) override { resetState(); }
</ins><span class="cx"> void resetState();
</span><span class="cx">
</span><span class="cx"> virtual void recompileScript() = 0;
</span><del>- virtual void isSampling(ErrorString*, bool*);
- virtual void hasHeapProfiler(ErrorString*, bool*);
</del><ins>+ virtual void isSampling(ErrorString*, bool*) override;
+ virtual void hasHeapProfiler(ErrorString*, bool*) override;
</ins><span class="cx">
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void start(ErrorString* = 0);
- virtual void stop(ErrorString* = 0);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void start(ErrorString* = 0) override;
+ virtual void stop(ErrorString* = 0) override;
</ins><span class="cx">
</span><span class="cx"> void disable();
</span><span class="cx"> void enable(bool skipRecompile);
</span><span class="cx"> bool enabled() const { return m_enabled; }
</span><span class="cx"> String getCurrentUserInitiatedProfileName(bool incrementProfileNumber = false);
</span><del>- virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Profiler::ProfileHeader>>&);
- virtual void getCPUProfile(ErrorString*, int uid, RefPtr<Inspector::TypeBuilder::Profiler::CPUProfile>&);
- virtual void getHeapSnapshot(ErrorString*, int uid);
- virtual void removeProfile(ErrorString*, const String& type, int uid);
</del><ins>+ virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Profiler::ProfileHeader>>&) override;
+ virtual void getCPUProfile(ErrorString*, int uid, RefPtr<Inspector::TypeBuilder::Profiler::CPUProfile>&) override;
+ virtual void getHeapSnapshot(ErrorString*, int uid) override;
+ virtual void removeProfile(ErrorString*, const String& type, int uid) override;
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><del>- virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress);
</del><ins>+ virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;
</ins><span class="cx"> void toggleRecordButton(bool isProfiling);
</span><span class="cx">
</span><del>- virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId);
</del><ins>+ virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> InspectorProfilerAgent(InstrumentingAgents*, InspectorConsoleAgent*, PageInjectedScriptManager*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorResourceAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -125,18 +125,18 @@
</span><span class="cx"> void setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize);
</span><span class="cx">
</span><span class="cx"> // Called from frontend
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void setExtraHTTPHeaders(ErrorString*, const RefPtr<Inspector::InspectorObject>&);
- virtual void getResponseBody(ErrorString*, const String& requestId, String* content, bool* base64Encoded);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void setExtraHTTPHeaders(ErrorString*, const RefPtr<Inspector::InspectorObject>&) override;
+ virtual void getResponseBody(ErrorString*, const String& requestId, String* content, bool* base64Encoded) override;
</ins><span class="cx">
</span><del>- virtual void replayXHR(ErrorString*, const String& requestId);
</del><ins>+ virtual void replayXHR(ErrorString*, const String& requestId) override;
</ins><span class="cx">
</span><del>- virtual void canClearBrowserCache(ErrorString*, bool*);
- virtual void clearBrowserCache(ErrorString*);
- virtual void canClearBrowserCookies(ErrorString*, bool*);
- virtual void clearBrowserCookies(ErrorString*);
- virtual void setCacheDisabled(ErrorString*, bool cacheDisabled);
</del><ins>+ virtual void canClearBrowserCache(ErrorString*, bool*) override;
+ virtual void clearBrowserCache(ErrorString*) override;
+ virtual void canClearBrowserCookies(ErrorString*, bool*) override;
+ virtual void clearBrowserCookies(ErrorString*) override;
+ virtual void setCacheDisabled(ErrorString*, bool cacheDisabled) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void enable();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorRuntimeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -62,9 +62,9 @@
</span><span class="cx"> virtual ~InspectorRuntimeAgent();
</span><span class="cx">
</span><span class="cx"> // Part of the protocol.
</span><del>- virtual void enable(ErrorString*) { m_enabled = true; }
- virtual void disable(ErrorString*) { m_enabled = false; }
- virtual void parse(ErrorString*, const String& expression, Inspector::TypeBuilder::Runtime::SyntaxErrorType::Enum* result, Inspector::TypeBuilder::OptOutput<String>* message, RefPtr<Inspector::TypeBuilder::Runtime::ErrorRange>&);
</del><ins>+ virtual void enable(ErrorString*) override { m_enabled = true; }
+ virtual void disable(ErrorString*) override { m_enabled = false; }
+ virtual void parse(ErrorString*, const String& expression, Inspector::TypeBuilder::Runtime::SyntaxErrorType::Enum* result, Inspector::TypeBuilder::OptOutput<String>* message, RefPtr<Inspector::TypeBuilder::Runtime::ErrorRange>&) override;
</ins><span class="cx"> virtual void evaluate(ErrorString*,
</span><span class="cx"> const String& expression,
</span><span class="cx"> const String* objectGroup,
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> const bool* returnByValue,
</span><span class="cx"> const bool* generatePreview,
</span><span class="cx"> RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
</span><del>- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
</del><ins>+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
</ins><span class="cx"> virtual void callFunctionOn(ErrorString*,
</span><span class="cx"> const String& objectId,
</span><span class="cx"> const String& expression,
</span><span class="lines">@@ -83,11 +83,11 @@
</span><span class="cx"> const bool* returnByValue,
</span><span class="cx"> const bool* generatePreview,
</span><span class="cx"> RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
</span><del>- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
- virtual void releaseObject(ErrorString*, const String& objectId);
- virtual void getProperties(ErrorString*, const String& objectId, const bool* ownProperties, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalProperties);
- virtual void releaseObjectGroup(ErrorString*, const String& objectGroup);
- virtual void run(ErrorString*);
</del><ins>+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
+ virtual void releaseObject(ErrorString*, const String& objectId) override;
+ virtual void getProperties(ErrorString*, const String& objectId, const bool* ownProperties, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalProperties) override;
+ virtual void releaseObjectGroup(ErrorString*, const String& objectGroup) override;
+ virtual void run(ErrorString*) override;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(JAVASCRIPT_DEBUGGER)
</span><span class="cx"> void setScriptDebugServer(ScriptDebugServer*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -262,23 +262,23 @@
</span><span class="cx"> static PassRefPtr<InspectorStyleSheetForInlineStyle> create(InspectorPageAgent*, const String& id, PassRefPtr<Element>, Inspector::TypeBuilder::CSS::StyleSheetOrigin::Enum, Listener*);
</span><span class="cx">
</span><span class="cx"> void didModifyElementAttribute();
</span><del>- virtual bool getText(String* result) const;
- virtual CSSStyleDeclaration* styleForId(const InspectorCSSId& id) const { ASSERT_UNUSED(id, !id.ordinal()); return inlineStyle(); }
</del><ins>+ virtual bool getText(String* result) const override;
+ virtual CSSStyleDeclaration* styleForId(const InspectorCSSId& id) const override { ASSERT_UNUSED(id, !id.ordinal()); return inlineStyle(); }
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> InspectorStyleSheetForInlineStyle(InspectorPageAgent*, const String& id, PassRefPtr<Element>, Inspector::TypeBuilder::CSS::StyleSheetOrigin::Enum, Listener*);
</span><span class="cx">
</span><del>- virtual Document* ownerDocument() const;
- virtual RefPtr<CSSRuleSourceData> ruleSourceDataFor(CSSStyleDeclaration* style) const { ASSERT_UNUSED(style, style == inlineStyle()); return m_ruleSourceData; }
- virtual unsigned ruleIndexByStyle(CSSStyleDeclaration*) const { return 0; }
- virtual bool ensureParsedDataReady();
- virtual PassRefPtr<InspectorStyle> inspectorStyleForId(const InspectorCSSId&);
- virtual void rememberInspectorStyle(RefPtr<InspectorStyle>) { }
- virtual void forgetInspectorStyle(CSSStyleDeclaration*) { }
</del><ins>+ virtual Document* ownerDocument() const override;
+ virtual RefPtr<CSSRuleSourceData> ruleSourceDataFor(CSSStyleDeclaration* style) const override { ASSERT_UNUSED(style, style == inlineStyle()); return m_ruleSourceData; }
+ virtual unsigned ruleIndexByStyle(CSSStyleDeclaration*) const override { return 0; }
+ virtual bool ensureParsedDataReady() override;
+ virtual PassRefPtr<InspectorStyle> inspectorStyleForId(const InspectorCSSId&) override;
+ virtual void rememberInspectorStyle(RefPtr<InspectorStyle>) override { }
+ virtual void forgetInspectorStyle(CSSStyleDeclaration*) override { }
</ins><span class="cx">
</span><span class="cx"> // Also accessed by friend class InspectorStyle.
</span><del>- virtual bool setStyleText(CSSStyleDeclaration*, const String&, ExceptionCode&);
- virtual PassOwnPtr<Vector<size_t>> lineEndings() const;
</del><ins>+ virtual bool setStyleText(CSSStyleDeclaration*, const String&, ExceptionCode&) override;
+ virtual PassOwnPtr<Vector<size_t>> lineEndings() const override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> CSSStyleDeclaration* inlineStyle() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -134,10 +134,10 @@
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><del>- virtual void start(ErrorString*, const int* maxCallStackDepth, const bool* includeDomCounters);
- virtual void stop(ErrorString*);
- virtual void canMonitorMainThread(ErrorString*, bool*);
- virtual void supportsFrameInstrumentation(ErrorString*, bool*);
</del><ins>+ virtual void start(ErrorString*, const int* maxCallStackDepth, const bool* includeDomCounters) override;
+ virtual void stop(ErrorString*) override;
+ virtual void canMonitorMainThread(ErrorString*, bool*) override;
+ virtual void supportsFrameInstrumentation(ErrorString*, bool*) override;
</ins><span class="cx">
</span><span class="cx"> int id() const { return m_id; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorWorkerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // WorkerGlobalScopeProxy::PageInspector implementation
</span><del>- virtual void dispatchMessageFromWorker(const String& message)
</del><ins>+ virtual void dispatchMessageFromWorker(const String& message) override
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InspectorValue> value = InspectorValue::parseJSON(message);
</span><span class="cx"> if (!value)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorWorkerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorWorkerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -62,13 +62,13 @@
</span><span class="cx"> void workerGlobalScopeTerminated(WorkerGlobalScopeProxy*);
</span><span class="cx">
</span><span class="cx"> // Called from InspectorBackendDispatcher
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void canInspectWorkers(ErrorString*, bool*);
- virtual void connectToWorker(ErrorString*, int workerId);
- virtual void disconnectFromWorker(ErrorString*, int workerId);
- virtual void sendMessageToWorker(ErrorString*, int workerId, const RefPtr<Inspector::InspectorObject>& message);
- virtual void setAutoconnectToWorkers(ErrorString*, bool value);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void canInspectWorkers(ErrorString*, bool*) override;
+ virtual void connectToWorker(ErrorString*, int workerId) override;
+ virtual void disconnectFromWorker(ErrorString*, int workerId) override;
+ virtual void sendMessageToWorker(ErrorString*, int workerId, const RefPtr<Inspector::InspectorObject>& message) override;
+ virtual void setAutoconnectToWorkers(ErrorString*, bool value) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void createWorkerFrontendChannelsForExistingWorkers();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageConsoleAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -49,8 +49,8 @@
</span><span class="cx"> virtual bool isWorkerAgent() override { return false; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void clearMessages(ErrorString*);
- virtual void addInspectedNode(ErrorString*, int nodeId);
</del><ins>+ virtual void clearMessages(ErrorString*) override;
+ virtual void addInspectedNode(ErrorString*, int nodeId) override;
</ins><span class="cx">
</span><span class="cx"> InspectorDOMAgent* m_inspectorDOMAgent;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageDebuggerAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageDebuggerAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/PageDebuggerAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -53,18 +53,18 @@
</span><span class="cx"> void didClearMainFrameWindowObject();
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void enable();
- virtual void disable();
</del><ins>+ virtual void enable() override;
+ virtual void disable() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void startListeningScriptDebugServer();
- virtual void stopListeningScriptDebugServer();
- virtual PageScriptDebugServer& scriptDebugServer();
- virtual void muteConsole();
- virtual void unmuteConsole();
</del><ins>+ virtual void startListeningScriptDebugServer() override;
+ virtual void stopListeningScriptDebugServer() override;
+ virtual PageScriptDebugServer& scriptDebugServer() override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
</ins><span class="cx">
</span><del>- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void setOverlayMessage(ErrorString*, const String*);
</del><ins>+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void setOverlayMessage(ErrorString*, const String*) override;
</ins><span class="cx">
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx"> InspectorOverlay* m_overlay;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageRuntimeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageRuntimeAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageRuntimeAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/PageRuntimeAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -55,16 +55,16 @@
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><del>- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
</del><ins>+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
</ins><span class="cx">
</span><span class="cx"> void didCreateMainWorldContext(Frame*);
</span><span class="cx"> void didCreateIsolatedContext(Frame*, JSC::ExecState*, SecurityOrigin*);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void muteConsole();
- virtual void unmuteConsole();
</del><ins>+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
</ins><span class="cx"> void reportExecutionContextCreation();
</span><span class="cx"> void notifyContextCreated(const String& frameId, JSC::ExecState*, SecurityOrigin*, bool isPageContext);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerConsoleAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerConsoleAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/WorkerConsoleAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> virtual bool isWorkerAgent() override { return true; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void addInspectedNode(ErrorString*, int nodeId);
</del><ins>+ virtual void addInspectedNode(ErrorString*, int nodeId) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerDebuggerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> : m_thread(thread)
</span><span class="cx"> , m_workerGlobalScope(workerGlobalScope) { }
</span><span class="cx"> virtual ~RunInspectorCommandsTask() { }
</span><del>- virtual void run()
</del><ins>+ virtual void run() override
</ins><span class="cx"> {
</span><span class="cx"> // Process all queued debugger commands. It is safe to use m_workerGlobalScope here
</span><span class="cx"> // because it is alive if RunWorkerLoop is not terminated, otherwise it will
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.cpp (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> : m_workerGlobalScope(workerGlobalScope) { }
</span><span class="cx"> virtual ~PageInspectorProxy() { }
</span><span class="cx"> private:
</span><del>- virtual bool sendMessageToFrontend(const String& message)
</del><ins>+ virtual bool sendMessageToFrontend(const String& message) override
</ins><span class="cx"> {
</span><span class="cx"> m_workerGlobalScope.thread()->workerReportingProxy().postMessageToPageInspector(message);
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerRuntimeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h (162368 => 162369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h 2014-01-20 20:36:11 UTC (rev 162368)
+++ trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h 2014-01-20 21:15:39 UTC (rev 162369)
</span><span class="lines">@@ -49,16 +49,16 @@
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() override;
</span><span class="cx">
</span><span class="cx"> // Protocol commands.
</span><del>- virtual void run(ErrorString*);
</del><ins>+ virtual void run(ErrorString*) override;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(JAVASCRIPT_DEBUGGER)
</span><span class="cx"> void pauseWorkerGlobalScope(WorkerGlobalScope*);
</span><span class="cx"> #endif // ENABLE(JAVASCRIPT_DEBUGGER)
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void muteConsole();
- virtual void unmuteConsole();
</del><ins>+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
</ins><span class="cx"> WorkerGlobalScope* m_workerGlobalScope;
</span><span class="cx"> RefPtr<Inspector::InspectorRuntimeBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> bool m_paused;
</span></span></pre>
</div>
</div>
</body>
</html>