<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162249] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162249">162249</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2014-01-18 00:22:23 -0800 (Sat, 18 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Bump the minimum required Clang version to 3.3
https://bugs.webkit.org/show_bug.cgi?id=127178
Reviewed by Martin Robinson.
* Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to
build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceautotoolsCheckSystemAndBasicDependenciesm4">trunk/Source/autotools/CheckSystemAndBasicDependencies.m4</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (162248 => 162249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-01-18 07:26:58 UTC (rev 162248)
+++ trunk/ChangeLog 2014-01-18 08:22:23 UTC (rev 162249)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-01-18 Zan Dobersek <zdobersek@igalia.com>
+
+ [GTK] Bump the minimum required Clang version to 3.3
+ https://bugs.webkit.org/show_bug.cgi?id=127178
+
+ Reviewed by Martin Robinson.
+
+ * Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to
+ build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
+ support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).
+
</ins><span class="cx"> 2014-01-14 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Only use color in make output when it’s going to a terminal.
</span></span></pre></div>
<a id="trunkSourceautotoolsCheckSystemAndBasicDependenciesm4"></a>
<div class="modfile"><h4>Modified: trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 (162248 => 162249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 2014-01-18 07:26:58 UTC (rev 162248)
+++ trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 2014-01-18 08:22:23 UTC (rev 162249)
</span><span class="lines">@@ -92,14 +92,14 @@
</span><span class="cx"> #endif
</span><span class="cx"> ])], [c_compiler="gcc"], [])
</span><span class="cx"> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
</span><del>-#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 2)
</del><ins>+#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 3)
</ins><span class="cx"> #error Not a supported Clang compiler
</span><span class="cx"> #endif
</span><span class="cx"> ])], [c_compiler="clang"], [])
</span><span class="cx"> AC_LANG_POP([C])
</span><span class="cx">
</span><span class="cx"> if test "$c_compiler" = "unknown"; then
</span><del>- AC_MSG_ERROR([Compiler GCC >= 4.7 or Clang >= 3.2 is required for C compilation])
</del><ins>+ AC_MSG_ERROR([Compiler GCC >= 4.7 or Clang >= 3.3 is required for C compilation])
</ins><span class="cx"> fi
</span><span class="cx">
</span><span class="cx"> # Check that an appropriate C++ compiler is available.
</span><span class="lines">@@ -111,14 +111,14 @@
</span><span class="cx"> #endif
</span><span class="cx"> ])], [cxx_compiler="g++"], [])
</span><span class="cx"> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
</span><del>-#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 2)
</del><ins>+#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 3)
</ins><span class="cx"> #error Not a supported Clang++ compiler
</span><span class="cx"> #endif
</span><span class="cx"> ])], [cxx_compiler="clang++"], [])
</span><span class="cx"> AC_LANG_POP([C++])
</span><span class="cx">
</span><span class="cx"> if test "$cxx_compiler" = "unknown"; then
</span><del>- AC_MSG_ERROR([Compiler GCC >= 4.7 or Clang >= 3.2 is required for C++ compilation])
</del><ins>+ AC_MSG_ERROR([Compiler GCC >= 4.7 or Clang >= 3.3 is required for C++ compilation])
</ins><span class="cx"> fi
</span><span class="cx">
</span><span class="cx"> # C/C++ Headers
</span></span></pre>
</div>
</div>
</body>
</html>