<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162130] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162130">162130</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-01-16 09:03:15 -0800 (Thu, 16 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: WebKit is not firing AXMenuItemSelectedNotification
https://bugs.webkit.org/show_bug.cgi?id=127081
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Monitor for when a menu item either gains focus() or has aria-selected set,
in which case, we need to fire a specific notification.
Test: platform/mac/accessibility/aria-menu-item-selected-notification.html
* accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
This method was declared in the header, but never implemented, leading to compilation issues.
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Allow the core class to handle focus changes first, then pass off to platform
(WebCore::AXObjectCache::selectedChildrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
Allow menu items to expose a description attribute.
LayoutTests:
* platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt: Added.
* platform/mac/accessibility/aria-menu-item-selected-notification.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCachecpp">trunk/Source/WebCore/accessibility/AXObjectCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCacheh">trunk/Source/WebCore/accessibility/AXObjectCache.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp">trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm">trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm">trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitywinAXObjectCacheWincpp">trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityariamenuitemselectednotificationexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityariamenuitemselectednotificationhtml">trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/LayoutTests/ChangeLog 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WebKit is not firing AXMenuItemSelectedNotification
+ https://bugs.webkit.org/show_bug.cgi?id=127081
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt: Added.
+ * platform/mac/accessibility/aria-menu-item-selected-notification.html: Added.
+
</ins><span class="cx"> 2014-01-16 Michał Pakuła vel Rutka <m.pakula@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL gardening
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityariamenuitemselectednotificationexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt (0 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+Menu item 1
+Menu item 2
+Menu item 3
+This tests that a AXMenuItemSelected notification gets fired when a menuitem is focused.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS addedNotification is true
+Received menu item selected notification: AXMenuItemSelected
+Menu item selected element: AXRole: AXMenuItem
+Menu item selected element description: AXDescription: item1
+
+Received menu item selected notification: AXMenuItemSelected
+Menu item selected element: AXRole: AXMenuItem
+Menu item selected element description: AXDescription: item2
+
+Received menu item selected notification: AXMenuItemSelected
+Menu item selected element: AXRole: AXMenuItem
+Menu item selected element description: AXDescription: item3
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityariamenuitemselectednotificationhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html (0 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -0,0 +1,63 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="menu" role="menu">
+ <div role="menuitem" id="item1" aria-label="item1" tabindex="0">Menu item 1</div>
+ <div role="menuitemradio" id="item2" aria-label="item2" tabindex="0">Menu item 2</div>
+ <div role="menuitemcheckbox" id="item3" aria-label="item3" tabindex="0">Menu item 3</div>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that a AXMenuItemSelected notification gets fired when a menuitem is focused.");
+
+ var element = 0;
+ var notification = 0;
+ var notificationCount = 0;
+ function ariaCallback(element, notification) {
+ if (notification == "AXMenuItemSelected") {
+ notificationCount++;
+
+ debug("Received menu item selected notification: " + notification);
+ debug("Menu item selected element: " + element.role);
+ debug("Menu item selected element description: " + element.description + "\n");
+ if (notificationCount == 3) {
+ accessibilityController.removeNotificationListener();
+ finishJSTest();
+ }
+ }
+ }
+
+ if (window.accessibilityController) {
+ window.jsTestIsAsync = true;
+
+ var addedNotification = accessibilityController.addNotificationListener(ariaCallback);
+ accessibilityController.rootElement;
+
+ shouldBe("addedNotification", "true");
+
+ // Trigger notification through focus.
+ document.getElementById("item1").focus();
+
+ // Trigger notification through aria-selected.
+ document.getElementById("item2").setAttribute("aria-selected", "true");
+
+ // Ensure we don't get a notification when aria-selected is false.
+ document.getElementById("item2").setAttribute("aria-selected", "false");
+
+ // Trigger another notification through focus to ensure we don't
+ document.getElementById("item3").focus();
+ }
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/ChangeLog 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2014-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WebKit is not firing AXMenuItemSelectedNotification
+ https://bugs.webkit.org/show_bug.cgi?id=127081
+
+ Reviewed by Mario Sanchez Prada.
+
+ Monitor for when a menu item either gains focus() or has aria-selected set,
+ in which case, we need to fire a specific notification.
+
+ Test: platform/mac/accessibility/aria-menu-item-selected-notification.html
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::nodeHasRole):
+ This method was declared in the header, but never implemented, leading to compilation issues.
+ (WebCore::AXObjectCache::handleMenuItemSelected):
+ (WebCore::AXObjectCache::handleFocusedUIElementChanged):
+ Allow the core class to handle focus changes first, then pass off to platform
+ (WebCore::AXObjectCache::selectedChildrenChanged):
+ * accessibility/AXObjectCache.h:
+ * accessibility/ios/AXObjectCacheIOS.mm:
+ (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+ Allow menu items to expose a description attribute.
+
</ins><span class="cx"> 2014-01-16 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Fix build issues with exported headers
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -239,7 +239,7 @@
</span><span class="cx"> if (!node || !node->isElementNode())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- return equalIgnoringCase(toElement(node)->getAttribute(roleAttr), role);
</del><ins>+ return equalIgnoringCase(toElement(node)->fastGetAttribute(roleAttr), role);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static PassRefPtr<AccessibilityObject> createFromRenderer(RenderObject* renderer)
</span><span class="lines">@@ -737,8 +737,30 @@
</span><span class="cx"> postNotification(node, AXObjectCache::AXCheckedStateChanged);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void AXObjectCache::handleMenuItemSelected(Node* node)
+{
+ if (!node)
+ return;
+
+ if (!nodeHasRole(node, "menuitem") && !nodeHasRole(node, "menuitemradio") && !nodeHasRole(node, "menuitemcheckbox"))
+ return;
+
+ if (!toElement(node)->focused() && !equalIgnoringCase(toElement(node)->fastGetAttribute(aria_selectedAttr), "true"))
+ return;
+
+ postNotification(getOrCreate(node), &document(), AXMenuListItemSelected);
+}
+
+void AXObjectCache::handleFocusedUIElementChanged(Node* oldNode, Node* newNode)
+{
+ handleMenuItemSelected(newNode);
+ platformHandleFocusedUIElementChanged(oldNode, newNode);
+}
+
</ins><span class="cx"> void AXObjectCache::selectedChildrenChanged(Node* node)
</span><span class="cx"> {
</span><ins>+ handleMenuItemSelected(node);
+
</ins><span class="cx"> // postTarget is TargetObservableParent so that you can pass in any child of an element and it will go up the parent tree
</span><span class="cx"> // to find the container which should send out the notification.
</span><span class="cx"> postNotification(node, AXSelectedChildrenChanged, TargetObservableParent);
</span><span class="lines">@@ -746,6 +768,9 @@
</span><span class="cx">
</span><span class="cx"> void AXObjectCache::selectedChildrenChanged(RenderObject* renderer)
</span><span class="cx"> {
</span><ins>+ if (renderer)
+ handleMenuItemSelected(renderer->node());
+
</ins><span class="cx"> // postTarget is TargetObservableParent so that you can pass in any child of an element and it will go up the parent tree
</span><span class="cx"> // to find the container which should send out the notification.
</span><span class="cx"> postNotification(renderer, AXSelectedChildrenChanged, TargetObservableParent);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -199,7 +199,6 @@
</span><span class="cx">
</span><span class="cx"> void frameLoadingEventNotification(Frame*, AXLoadingEvent);
</span><span class="cx">
</span><del>- bool nodeHasRole(Node*, const AtomicString& role);
</del><span class="cx"> void clearTextMarkerNodesInUse(Document*);
</span><span class="cx">
</span><span class="cx"> void startCachingComputedObjectAttributesUntilTreeMutates();
</span><span class="lines">@@ -211,6 +210,8 @@
</span><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> void postPlatformNotification(AccessibilityObject*, AXNotification);
</span><ins>+ void platformHandleFocusedUIElementChanged(Node* oldFocusedNode, Node* newFocusedNode);
+
</ins><span class="cx"> void nodeTextChangePlatformNotification(AccessibilityObject*, AXTextChange, unsigned offset, const String&);
</span><span class="cx"> void frameLoadingEventPlatformNotification(AccessibilityObject*, AXLoadingEvent);
</span><span class="cx"> void textChanged(AccessibilityObject*);
</span><span class="lines">@@ -237,6 +238,7 @@
</span><span class="cx"> Timer<AXObjectCache> m_notificationPostTimer;
</span><span class="cx"> Vector<std::pair<RefPtr<AccessibilityObject>, AXNotification>> m_notificationsToPost;
</span><span class="cx"> void notificationPostTimerFired(Timer<AXObjectCache>&);
</span><ins>+ void handleMenuItemSelected(Node*);
</ins><span class="cx">
</span><span class="cx"> static AccessibilityObject* focusedImageMapUIElement(HTMLAreaElement*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -302,7 +302,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::handleFocusedUIElementChanged(Node* oldFocusedNode, Node* newFocusedNode)
</del><ins>+void AXObjectCache::platformHandleFocusedUIElementChanged(Node* oldFocusedNode, Node* newFocusedNode)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<AccessibilityObject> oldObject = getOrCreate(oldFocusedNode);
</span><span class="cx"> if (oldObject) {
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::handleFocusedUIElementChanged(Node*, Node* newNode)
</del><ins>+void AXObjectCache::platformHandleFocusedUIElementChanged(Node*, Node* newNode)
</ins><span class="cx"> {
</span><span class="cx"> postNotification(newNode, AXFocusedUIElementChanged, TargetElement, PostAsynchronously);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -121,6 +121,9 @@
</span><span class="cx"> case AXMenuClosed:
</span><span class="cx"> macNotification = (id)kAXMenuClosedNotification;
</span><span class="cx"> break;
</span><ins>+ case AXMenuListItemSelected:
+ macNotification = (id)kAXMenuItemSelectedNotification;
+ break;
</ins><span class="cx"> case AXCheckedStateChanged:
</span><span class="cx"> // Does not exist on Mac.
</span><span class="cx"> default:
</span><span class="lines">@@ -145,7 +148,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::handleFocusedUIElementChanged(Node*, Node*)
</del><ins>+void AXObjectCache::platformHandleFocusedUIElementChanged(Node*, Node*)
</ins><span class="cx"> {
</span><span class="cx"> wkAccessibilityHandleFocusChanged();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -1289,6 +1289,7 @@
</span><span class="cx"> if (menuItemAttrs == nil) {
</span><span class="cx"> tempArray = [[NSMutableArray alloc] initWithArray:commonMenuAttrs];
</span><span class="cx"> [tempArray addObject:NSAccessibilityTitleAttribute];
</span><ins>+ [tempArray addObject:NSAccessibilityDescriptionAttribute];
</ins><span class="cx"> [tempArray addObject:NSAccessibilityHelpAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilitySelectedAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilityValueAttribute];
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitywinAXObjectCacheWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp (162129 => 162130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp 2014-01-16 16:14:06 UTC (rev 162129)
+++ trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp 2014-01-16 17:03:15 UTC (rev 162130)
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> return objID;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::handleFocusedUIElementChanged(Node*, Node* newFocusedNode)
</del><ins>+void AXObjectCache::platformHandleFocusedUIElementChanged(Node*, Node* newFocusedNode)
</ins><span class="cx"> {
</span><span class="cx"> if (!newFocusedNode)
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>