<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162159] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162159">162159</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-16 15:15:07 -0800 (Thu, 16 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>EWS shouldn't comment on Bugzilla for failing builds or style errors
https://bugs.webkit.org/show_bug.cgi?id=127079
Reviewed by Anders Carlsson.
Since patch authors and reviewers could retrieve this information from bubbles,
we shouldn't spam the Bugzilla with useless comments.
We still post style errors but not python paths we used since it's a pure noise.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem._post_reject_message_on_bug):
* Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue.review_patch):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsearlywarningsystempy">trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsqueuespy">trunk/Tools/Scripts/webkitpy/tool/commands/queues.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (162158 => 162159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-16 23:08:24 UTC (rev 162158)
+++ trunk/Tools/ChangeLog 2014-01-16 23:15:07 UTC (rev 162159)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
+
+ EWS shouldn't comment on Bugzilla for failing builds or style errors
+ https://bugs.webkit.org/show_bug.cgi?id=127079
+
+ Reviewed by Anders Carlsson.
+
+ Since patch authors and reviewers could retrieve this information from bubbles,
+ we shouldn't spam the Bugzilla with useless comments.
+
+ We still post style errors but not python paths we used since it's a pure noise.
+
+ * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+ (AbstractEarlyWarningSystem._post_reject_message_on_bug):
+ * Scripts/webkitpy/tool/commands/queues.py:
+ (StyleQueue.review_patch):
+
</ins><span class="cx"> 2014-01-15 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Add support for handling WebGL load policies.
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsearlywarningsystempy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (162158 => 162159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2014-01-16 23:08:24 UTC (rev 162158)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2014-01-16 23:15:07 UTC (rev 162159)
</span><span class="lines">@@ -66,6 +66,9 @@
</span><span class="cx"> return "New failing tests:\n%s" % "\n".join(unexpected_failures)
</span><span class="cx">
</span><span class="cx"> def _post_reject_message_on_bug(self, tool, patch, status_id, extra_message_text=None):
</span><ins>+ if not extra_message_text:
+ return # Don't comment on Bugzilla if we don't have failing tests.
+
</ins><span class="cx"> results_link = tool.status_server.results_url_for_status(status_id)
</span><span class="cx"> message = "Attachment %s did not pass %s (%s):\nOutput: %s" % (patch.id(), self.name, self.port_name, results_link)
</span><span class="cx"> if extra_message_text:
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsqueuespy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (162158 => 162159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2014-01-16 23:08:24 UTC (rev 162158)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2014-01-16 23:15:07 UTC (rev 162159)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> import codecs
</span><span class="cx"> import logging
</span><span class="cx"> import os
</span><ins>+import re
</ins><span class="cx"> import sys
</span><span class="cx"> import time
</span><span class="cx"> import traceback
</span><span class="lines">@@ -465,7 +466,8 @@
</span><span class="cx"> self._did_error(patch, "%s unable to apply patch." % self.name)
</span><span class="cx"> return False
</span><span class="cx"> except ScriptError, e:
</span><del>- message = "Attachment %s did not pass %s:\n\n%s\n\nIf any of these errors are false positives, please file a bug against check-webkit-style." % (patch.id(), self.name, e.output)
</del><ins>+ output = re.sub(r'Failed to run .+ exit_code: 1', '', e.output)
+ message = "Attachment %s did not pass %s:\n\n%s\n\nIf any of these errors are false positives, please file a bug against check-webkit-style." % (patch.id(), self.name, output)
</ins><span class="cx"> self._tool.bugs.post_comment_to_bug(patch.bug_id(), message, cc=self.watchers)
</span><span class="cx"> self._did_fail(patch)
</span><span class="cx"> return False
</span></span></pre>
</div>
</div>
</body>
</html>