<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[162006] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/162006">162006</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-01-14 14:11:43 -0800 (Tue, 14 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
https://bugs.webkit.org/show_bug.cgi?id=126990.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseConstDeclarationList):
- We were missing an error check after attempting to parse an initializer
expression. This is now fixed.
LayoutTests:
* js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
* js/dom/parse-syntax-error-in-initializer.html: Added.
* js/resources/parse-syntax-error-in-initializer.js: Added.
- Added bug test case as a regression test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParsercpp">trunk/Source/JavaScriptCore/parser/Parser.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsdomparsesyntaxerrorininitializerexpectedtxt">trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomparsesyntaxerrorininitializerhtml">trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer.html</a></li>
<li><a href="#trunkLayoutTestsjsresourcesparsesyntaxerrorininitializerjs">trunk/LayoutTests/js/resources/parse-syntax-error-in-initializer.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (162005 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-14 22:10:40 UTC (rev 162005)
+++ trunk/LayoutTests/ChangeLog 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-14 Mark Lam <mark.lam@apple.com>
+
+ ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
+ https://bugs.webkit.org/show_bug.cgi?id=126990.
+
+ Reviewed by Geoffrey Garen.
+
+ * js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
+ * js/dom/parse-syntax-error-in-initializer.html: Added.
+ * js/resources/parse-syntax-error-in-initializer.js: Added.
+ - Added bug test case as a regression test.
+
</ins><span class="cx"> 2014-01-14 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Skip some tests that now fail after r162000.
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomparsesyntaxerrorininitializerexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer-expected.txt (0 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer-expected.txt (rev 0)
+++ trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer-expected.txt 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+CONSOLE MESSAGE: line 3: SyntaxError: Unexpected token ')'
+This tests that a line number and error message is printed for a parse error in a separate source file.
</ins></span></pre></div>
<a id="trunkLayoutTestsjsdomparsesyntaxerrorininitializerhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer.html (0 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer.html (rev 0)
+++ trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer.html 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<html>
+<head>
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+</script>
+<script src="../resources/parse-syntax-error-in-initializer.js"></script>
+<script>
+if (window.testRunner) {
+ testRunner.notifyDone();
+}
+</script>
+</head>
+<body>
+This tests that a line number and error message is printed for a parse error in a separate source file.
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsjsresourcesparsesyntaxerrorininitializerjs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/resources/parse-syntax-error-in-initializer.js (0 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/resources/parse-syntax-error-in-initializer.js (rev 0)
+++ trunk/LayoutTests/js/resources/parse-syntax-error-in-initializer.js 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+// This test case was contributed by Renata Hodovan <reni@webkit.org>
+// for https://bugs.webkit.org/show_bug.cgi?id=126990.
+const var_0 = (null < !), var_0 = 1 + { };
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (162005 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-01-14 22:10:40 UTC (rev 162005)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-14 Mark Lam <mark.lam@apple.com>
+
+ ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
+ https://bugs.webkit.org/show_bug.cgi?id=126990.
+
+ Reviewed by Geoffrey Garen.
+
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::parseConstDeclarationList):
+ - We were missing an error check after attempting to parse an initializer
+ expression. This is now fixed.
+
</ins><span class="cx"> 2014-01-14 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.cpp (162005 => 162006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.cpp 2014-01-14 22:10:40 UTC (rev 162005)
+++ trunk/Source/JavaScriptCore/parser/Parser.cpp 2014-01-14 22:11:43 UTC (rev 162006)
</span><span class="lines">@@ -660,6 +660,7 @@
</span><span class="cx"> if (hasInitializer) {
</span><span class="cx"> next(TreeBuilder::DontBuildStrings); // consume '='
</span><span class="cx"> initializer = parseAssignmentExpression(context);
</span><ins>+ failIfFalse(!!initializer, "Unable to parse initializer");
</ins><span class="cx"> }
</span><span class="cx"> tail = context.appendConstDecl(location, tail, name, initializer);
</span><span class="cx"> if (!constDecls)
</span></span></pre>
</div>
</div>
</body>
</html>