<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161966] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161966">161966</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2014-01-14 07:45:32 -0800 (Tue, 14 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ATK] AXChildrenChanged notification handling is a performance black hole
https://bugs.webkit.org/show_bug.cgi?id=126970
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Remove code that is causing a huge performance problem when
loading big pages, just to be able to emit the children-changed:add
signal at the exact time a child is added.
This removal does not imply that the signal won't be ever emitted,
just that it will be emitted a bit later (when the new child is
asynchronously added to the tree), which should be good enough
anyway for Accessible Technologies, without impacting perfformance
in such a negative way.
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Removed
extremely expensive referring loop when AXChildrenChanged is received.
LayoutTests:
Because of the removal of the referring test when
AXChildrenChanged is received, the children-changed:add signal is
now emitted later, so we need to reorder the expectations.
* accessibility/children-changed-sends-notification-expected.txt: Updated.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationexpectedtxt">trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp">trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (161965 => 161966)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-14 15:41:32 UTC (rev 161965)
+++ trunk/LayoutTests/ChangeLog 2014-01-14 15:45:32 UTC (rev 161966)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-01-14 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] AXChildrenChanged notification handling is a performance black hole
+ https://bugs.webkit.org/show_bug.cgi?id=126970
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Because of the removal of the referring test when
+ AXChildrenChanged is received, the children-changed:add signal is
+ now emitted later, so we need to reorder the expectations.
+
+ * accessibility/children-changed-sends-notification-expected.txt: Updated.
+
</ins><span class="cx"> 2014-01-14 Mihai Tica <mitica@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (161965 => 161966)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-01-14 15:41:32 UTC (rev 161965)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-01-14 15:45:32 UTC (rev 161966)
</span><span class="lines">@@ -6,10 +6,10 @@
</span><span class="cx"> Plain text paragraph
</span><span class="cx">
</span><span class="cx"> End of test
</span><ins>+PARAGRAPH notification: AXChildrenRemoved
+GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
</ins><span class="cx"> PARAGRAPH notification: AXChildrenAdded
</span><span class="cx"> GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
</span><del>-PARAGRAPH notification: AXChildrenRemoved
-GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
</del><span class="cx"> PASS paragraphNotificationCount is globalNotificationCount
</span><span class="cx"> PASS globalNotificationCount is 2
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161965 => 161966)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-14 15:41:32 UTC (rev 161965)
+++ trunk/Source/WebCore/ChangeLog 2014-01-14 15:45:32 UTC (rev 161966)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-01-14 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] AXChildrenChanged notification handling is a performance black hole
+ https://bugs.webkit.org/show_bug.cgi?id=126970
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Remove code that is causing a huge performance problem when
+ loading big pages, just to be able to emit the children-changed:add
+ signal at the exact time a child is added.
+
+ This removal does not imply that the signal won't be ever emitted,
+ just that it will be emitted a bit later (when the new child is
+ asynchronously added to the tree), which should be good enough
+ anyway for Accessible Technologies, without impacting perfformance
+ in such a negative way.
+
+ * accessibility/atk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification): Removed
+ extremely expensive referring loop when AXChildrenChanged is received.
+
</ins><span class="cx"> 2014-01-14 Mihai Tica <mitica@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (161965 => 161966)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-14 15:41:32 UTC (rev 161965)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-14 15:45:32 UTC (rev 161966)
</span><span class="lines">@@ -193,16 +193,6 @@
</span><span class="cx"> atk_object_notify_state_change(axObject, ATK_STATE_CHECKED, coreObject->isChecked());
</span><span class="cx"> break;
</span><span class="cx">
</span><del>- case AXChildrenChanged:
- // We need to make sure that the children AtkObjects are created at this moment,
- // so the children-changed::add signal gets properly emitted in attachWrapper().
- {
- int numOfChildren = atk_object_get_n_accessible_children(axObject);
- for (int i = 0; i < numOfChildren; ++i)
- GRefPtr<AtkObject> child(atk_object_ref_accessible_child(axObject, i));
- }
- break;
-
</del><span class="cx"> case AXSelectedChildrenChanged:
</span><span class="cx"> case AXMenuListValueChanged:
</span><span class="cx"> if (notification == AXMenuListValueChanged && coreObject->isMenuList()) {
</span></span></pre>
</div>
</div>
</body>
</html>