<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161873] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161873">161873</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2014-01-13 03:19:38 -0800 (Mon, 13 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid unnecessary copies of AccessibilityObject::AccessibilityChildrenVector
https://bugs.webkit.org/show_bug.cgi?id=126876
Reviewed by Andreas Kling.
AccessibilityObject::children() returns a reference to the Vector of that AccessibilityObject's children.
The majority of callsites stores the return value in a temporary value instead of a reference, causing
a copy each time. A reference to the return value should be used instead.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::headerObject):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::setSelectedChildren):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
* accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::getListObject):
(WebCore::notifyChildrenSelectionChange):
* accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
* accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(listObjectForSelection):
(optionFromList):
(webkitAccessibleSelectionSelectAllSelection):
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getNChildrenForTable):
(getChildForTable):
(webkitAccessibleRefChild):
(getIndexInParentForCellInRow):
(getInterfaceMaskFromObject):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCachecpp">trunk/Source/WebCore/accessibility/AXObjectCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridcpp">trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridCellcpp">trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridRowcpp">trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListBoxcpp">trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListBoxh">trunk/Source/WebCore/accessibility/AccessibilityListBox.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTablecpp">trunk/Source/WebCore/accessibility/AccessibilityTable.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableColumncpp">trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableRowcpp">trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp">trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleInterfaceHypertextcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleInterfaceSelectioncpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/ChangeLog 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -1,3 +1,80 @@
</span><ins>+2014-01-13 Zan Dobersek <zdobersek@igalia.com>
+
+ Avoid unnecessary copies of AccessibilityObject::AccessibilityChildrenVector
+ https://bugs.webkit.org/show_bug.cgi?id=126876
+
+ Reviewed by Andreas Kling.
+
+ AccessibilityObject::children() returns a reference to the Vector of that AccessibilityObject's children.
+ The majority of callsites stores the return value in a temporary value instead of a reference, causing
+ a copy each time. A reference to the return value should be used instead.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::focusedImageMapUIElement):
+ * accessibility/AccessibilityARIAGrid.cpp:
+ (WebCore::AccessibilityARIAGrid::addRowDescendant):
+ * accessibility/AccessibilityARIAGridCell.cpp:
+ (WebCore::AccessibilityARIAGridCell::rowIndexRange):
+ (WebCore::AccessibilityARIAGridCell::columnIndexRange):
+ * accessibility/AccessibilityARIAGridRow.cpp:
+ (WebCore::AccessibilityARIAGridRow::headerObject):
+ * accessibility/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::setSelectedChildren):
+ * accessibility/AccessibilityListBox.h:
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::insertChild):
+ (WebCore::AccessibilityNodeObject::selectedRadioButton):
+ (WebCore::AccessibilityNodeObject::selectedTabItem):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::appendChildrenToArray):
+ (WebCore::AccessibilityObject::ariaTreeRows):
+ (WebCore::AccessibilityObject::ariaTreeItemContent):
+ (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
+ (WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
+ (WebCore::AccessibilityRenderObject::addHiddenChildren):
+ (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
+ (WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
+ (WebCore::AccessibilityRenderObject::tabChildren):
+ (WebCore::AccessibilityRenderObject::mathRadicandObject):
+ (WebCore::AccessibilityRenderObject::mathRootIndexObject):
+ (WebCore::AccessibilityRenderObject::mathNumeratorObject):
+ (WebCore::AccessibilityRenderObject::mathDenominatorObject):
+ (WebCore::AccessibilityRenderObject::mathUnderObject):
+ (WebCore::AccessibilityRenderObject::mathOverObject):
+ (WebCore::AccessibilityRenderObject::mathBaseObject):
+ (WebCore::AccessibilityRenderObject::mathSubscriptObject):
+ (WebCore::AccessibilityRenderObject::mathSuperscriptObject):
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::cellForColumnAndRow):
+ * accessibility/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::headerObject):
+ * accessibility/AccessibilityTableRow.cpp:
+ (WebCore::AccessibilityTableRow::headerObject):
+ * accessibility/atk/AXObjectCacheAtk.cpp:
+ (WebCore::getListObject):
+ (WebCore::notifyChildrenSelectionChange):
+ * accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
+ (webkitAccessibleHypertextGetLink):
+ (webkitAccessibleHypertextGetNLinks):
+ * accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
+ (listObjectForSelection):
+ (optionFromList):
+ (webkitAccessibleSelectionSelectAllSelection):
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (getNChildrenForTable):
+ (getChildForTable):
+ (webkitAccessibleRefChild):
+ (getIndexInParentForCellInRow):
+ (getInterfaceMaskFromObject):
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
+ (-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
+ (-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
</ins><span class="cx"> 2014-01-13 László Langó <llango.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Comment should be consructable.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -142,7 +142,7 @@
</span><span class="cx"> if (!axRenderImage)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector imageChildren = axRenderImage->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& imageChildren = axRenderImage->children();
</ins><span class="cx"> unsigned count = imageChildren.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="cx"> AccessibilityObject* child = imageChildren[k].get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> if (!rowChild->isTableRow()) {
</span><span class="cx"> // Although a "grid" should have rows as its direct descendants, if this is not a table row,
</span><span class="cx"> // dive deeper into the descendants to try to find a valid row.
</span><del>- AccessibilityChildrenVector children = rowChild->children();
</del><ins>+ const AccessibilityChildrenVector& children = rowChild->children();
</ins><span class="cx"> size_t length = children.size();
</span><span class="cx"> for (size_t i = 0; i < length; ++i)
</span><span class="cx"> addRowDescendant(children[i].get(), appendedRows, columnCount);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridCellcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> if (!columnCount)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector siblings = parent->children();
</del><ins>+ const AccessibilityChildrenVector& siblings = parent->children();
</ins><span class="cx"> unsigned childrenSize = siblings.size();
</span><span class="cx"> for (unsigned k = 0; k < childrenSize; ++k) {
</span><span class="cx"> if (siblings[k].get() == this) {
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> if (!parent->isTableRow() && !parent->isAccessibilityTable())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector siblings = parent->children();
</del><ins>+ const AccessibilityChildrenVector& siblings = parent->children();
</ins><span class="cx"> unsigned childrenSize = siblings.size();
</span><span class="cx"> for (unsigned k = 0; k < childrenSize; ++k) {
</span><span class="cx"> if (siblings[k].get() == this) {
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridRowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx">
</span><span class="cx"> AccessibilityObject* AccessibilityARIAGridRow::headerObject()
</span><span class="cx"> {
</span><del>- AccessibilityChildrenVector rowChildren = children();
</del><ins>+ const AccessibilityChildrenVector& rowChildren = children();
</ins><span class="cx"> unsigned childrenCount = rowChildren.size();
</span><span class="cx"> for (unsigned i = 0; i < childrenCount; ++i) {
</span><span class="cx"> AccessibilityObject* cell = rowChildren[i].get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AccessibilityListBox::setSelectedChildren(AccessibilityChildrenVector& children)
</del><ins>+void AccessibilityListBox::setSelectedChildren(const AccessibilityChildrenVector& children)
</ins><span class="cx"> {
</span><span class="cx"> if (!canSetSelectedChildrenAttribute())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityListBox.h (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityListBox.h 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBox.h 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> virtual bool isListBox() const OVERRIDE { return true; }
</span><span class="cx">
</span><span class="cx"> virtual bool canSetSelectedChildrenAttribute() const OVERRIDE;
</span><del>- void setSelectedChildren(AccessibilityChildrenVector&);
</del><ins>+ void setSelectedChildren(const AccessibilityChildrenVector&);
</ins><span class="cx"> virtual AccessibilityRole roleValue() const OVERRIDE { return ListBoxRole; }
</span><span class="cx">
</span><span class="cx"> virtual void selectedChildren(AccessibilityChildrenVector&) OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -335,7 +335,7 @@
</span><span class="cx"> child->clearChildren();
</span><span class="cx">
</span><span class="cx"> if (child->accessibilityIsIgnored()) {
</span><del>- AccessibilityChildrenVector children = child->children();
</del><ins>+ const AccessibilityChildrenVector& children = child->children();
</ins><span class="cx"> size_t length = children.size();
</span><span class="cx"> for (size_t i = 0; i < length; ++i)
</span><span class="cx"> m_children.insert(index + i, children[i]);
</span><span class="lines">@@ -911,7 +911,7 @@
</span><span class="cx"> if (!isRadioGroup())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx">
</span><span class="cx"> // Find the child radio button that is selected (ie. the intValue == 1).
</span><span class="cx"> size_t size = children.size();
</span><span class="lines">@@ -932,7 +932,7 @@
</span><span class="cx"> AccessibilityObject::AccessibilityChildrenVector tabs;
</span><span class="cx"> tabChildren(tabs);
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> size_t size = tabs.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i) {
</span><span class="cx"> AccessibilityObject* object = children[i].get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -415,13 +415,9 @@
</span><span class="cx">
</span><span class="cx"> static void appendChildrenToArray(AccessibilityObject* object, bool isForward, AccessibilityObject* startObject, AccessibilityObject::AccessibilityChildrenVector& results)
</span><span class="cx"> {
</span><del>- AccessibilityObject::AccessibilityChildrenVector searchChildren;
</del><span class="cx"> // A table's children includes elements whose own children are also the table's children (due to the way the Mac exposes tables).
</span><span class="cx"> // The rows from the table should be queried, since those are direct descendants of the table, and they contain content.
</span><del>- if (object->isAccessibilityTable())
- searchChildren = toAccessibilityTable(object)->rows();
- else
- searchChildren = object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& searchChildren = object->isAccessibilityTable() ? toAccessibilityTable(object)->rows() : object->children();
</ins><span class="cx">
</span><span class="cx"> size_t childrenSize = searchChildren.size();
</span><span class="cx">
</span><span class="lines">@@ -1324,7 +1320,7 @@
</span><span class="cx">
</span><span class="cx"> void AccessibilityObject::ariaTreeRows(AccessibilityChildrenVector& result)
</span><span class="cx"> {
</span><del>- AccessibilityChildrenVector axChildren = children();
</del><ins>+ const AccessibilityChildrenVector& axChildren = children();
</ins><span class="cx"> unsigned count = axChildren.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="cx"> AccessibilityObject* obj = axChildren[k].get();
</span><span class="lines">@@ -1341,7 +1337,7 @@
</span><span class="cx"> void AccessibilityObject::ariaTreeItemContent(AccessibilityChildrenVector& result)
</span><span class="cx"> {
</span><span class="cx"> // The ARIA tree item content are the item that are not other tree items or their containing groups.
</span><del>- AccessibilityChildrenVector axChildren = children();
</del><ins>+ const AccessibilityChildrenVector& axChildren = children();
</ins><span class="cx"> unsigned count = axChildren.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="cx"> AccessibilityObject* obj = axChildren[k].get();
</span><span class="lines">@@ -1355,7 +1351,7 @@
</span><span class="cx">
</span><span class="cx"> void AccessibilityObject::ariaTreeItemDisclosedRows(AccessibilityChildrenVector& result)
</span><span class="cx"> {
</span><del>- AccessibilityChildrenVector axChildren = children();
</del><ins>+ const AccessibilityChildrenVector& axChildren = children();
</ins><span class="cx"> unsigned count = axChildren.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="cx"> AccessibilityObject* obj = axChildren[k].get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -2155,7 +2155,7 @@
</span><span class="cx"> if (!parent)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = parent->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = parent->children();
</ins><span class="cx">
</span><span class="cx"> unsigned count = children.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="lines">@@ -2859,7 +2859,7 @@
</span><span class="cx"> root->setParent(this);
</span><span class="cx">
</span><span class="cx"> if (root->accessibilityIsIgnored()) {
</span><del>- AccessibilityChildrenVector children = root->children();
</del><ins>+ const AccessibilityChildrenVector& children = root->children();
</ins><span class="cx"> unsigned length = children.size();
</span><span class="cx"> for (unsigned i = 0; i < length; ++i)
</span><span class="cx"> m_children.append(children[i]);
</span><span class="lines">@@ -2941,7 +2941,7 @@
</span><span class="cx"> // Find out where the last render sibling is located within m_children.
</span><span class="cx"> AccessibilityObject* childObject = axObjectCache()->get(child->renderer());
</span><span class="cx"> if (childObject && childObject->accessibilityIsIgnored()) {
</span><del>- AccessibilityChildrenVector children = childObject->children();
</del><ins>+ const AccessibilityChildrenVector& children = childObject->children();
</ins><span class="cx"> if (children.size())
</span><span class="cx"> childObject = children.last().get();
</span><span class="cx"> else
</span><span class="lines">@@ -3082,7 +3082,7 @@
</span><span class="cx"> {
</span><span class="cx"> bool isMulti = isMultiSelectable();
</span><span class="cx">
</span><del>- AccessibilityChildrenVector childObjects = children();
</del><ins>+ const AccessibilityChildrenVector& childObjects = children();
</ins><span class="cx"> unsigned childrenSize = childObjects.size();
</span><span class="cx"> for (unsigned k = 0; k < childrenSize; ++k) {
</span><span class="cx"> // Every child should have aria-role option, and if so, check for selected attribute/state.
</span><span class="lines">@@ -3112,7 +3112,7 @@
</span><span class="cx"> if (!hasChildren())
</span><span class="cx"> addChildren();
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; i++) {
</span><span class="cx"> if (!children[i]->isOffScreen())
</span><span class="lines">@@ -3136,7 +3136,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(roleValue() == TabListRole);
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i) {
</span><span class="cx"> if (children[i]->isTabItem())
</span><span class="lines">@@ -3571,7 +3571,7 @@
</span><span class="cx"> if (!isMathRoot())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() < 1)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3584,7 +3584,7 @@
</span><span class="cx"> if (!isMathRoot())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() != 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3598,7 +3598,7 @@
</span><span class="cx"> if (!isMathFraction())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() != 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3610,7 +3610,7 @@
</span><span class="cx"> if (!isMathFraction())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() != 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3622,7 +3622,7 @@
</span><span class="cx"> if (!isMathUnderOver() || !node())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() < 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3637,7 +3637,7 @@
</span><span class="cx"> if (!isMathUnderOver() || !node())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() < 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3654,7 +3654,7 @@
</span><span class="cx"> if (!isMathSubscriptSuperscript() && !isMathUnderOver() && !isMathMultiscript())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> // The base object in question is always the first child.
</span><span class="cx"> if (children.size() > 0)
</span><span class="cx"> return children[0].get();
</span><span class="lines">@@ -3667,7 +3667,7 @@
</span><span class="cx"> if (!isMathSubscriptSuperscript() || !node())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> if (children.size() < 2)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -3682,7 +3682,7 @@
</span><span class="cx"> if (!isMathSubscriptSuperscript() || !node())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector children = this->children();
</del><ins>+ const AccessibilityChildrenVector& children = this->children();
</ins><span class="cx"> unsigned count = children.size();
</span><span class="cx">
</span><span class="cx"> if (count >= 2 && node()->hasTagName(MathMLNames::msupTag))
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -509,7 +509,7 @@
</span><span class="cx"> // Iterate backwards through the rows in case the desired cell has a rowspan and exists in a previous row.
</span><span class="cx"> for (unsigned rowIndexCounter = row + 1; rowIndexCounter > 0; --rowIndexCounter) {
</span><span class="cx"> unsigned rowIndex = rowIndexCounter - 1;
</span><del>- AccessibilityChildrenVector children = m_rows[rowIndex]->children();
</del><ins>+ const AccessibilityChildrenVector& children = m_rows[rowIndex]->children();
</ins><span class="cx"> // Since some cells may have colspans, we have to check the actual range of each
</span><span class="cx"> // cell to determine which is the right one.
</span><span class="cx"> for (unsigned colIndexCounter = std::min(static_cast<unsigned>(children.size()), column + 1); colIndexCounter > 0; --colIndexCounter) {
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableColumncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx">
</span><span class="cx"> AccessibilityTable* parentTable = toAccessibilityTable(m_parent);
</span><span class="cx"> if (parentTable->isAriaTable()) {
</span><del>- AccessibilityChildrenVector rowChildren = children();
</del><ins>+ const AccessibilityChildrenVector& rowChildren = children();
</ins><span class="cx"> unsigned childrenCount = rowChildren.size();
</span><span class="cx"> for (unsigned i = 0; i < childrenCount; ++i) {
</span><span class="cx"> AccessibilityObject* cell = rowChildren[i].get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableRowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> if (!m_renderer || !m_renderer->isTableRow())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityChildrenVector rowChildren = children();
</del><ins>+ const AccessibilityChildrenVector& rowChildren = children();
</ins><span class="cx"> if (!rowChildren.size())
</span><span class="cx"> return 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx"> // For menu lists we need to return the first accessible child,
</span><span class="cx"> // with role MenuListPopupRole, since that's the one holding the list
</span><span class="cx"> // of items with role MenuListOptionRole.
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = object->children();
</ins><span class="cx"> if (!children.size())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector items = listObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& items = listObject->children();
</ins><span class="cx"> if (changedItemIndex < 0 || changedItemIndex >= static_cast<int>(items.size()))
</span><span class="cx"> return;
</span><span class="cx"> AccessibilityObject* item = items.at(changedItemIndex).get();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleInterfaceHypertextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> g_return_val_if_fail(ATK_HYPERTEXT(hypertext), 0);
</span><span class="cx"> returnValIfWebKitAccessibleIsInvalid(WEBKIT_ACCESSIBLE(hypertext), 0);
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = core(hypertext)->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = core(hypertext)->children();
</ins><span class="cx"> if (index < 0 || static_cast<unsigned>(index) >= children.size())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> g_return_val_if_fail(ATK_HYPERTEXT(hypertext), 0);
</span><span class="cx"> returnValIfWebKitAccessibleIsInvalid(WEBKIT_ACCESSIBLE(hypertext), 0);
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = core(hypertext)->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = core(hypertext)->children();
</ins><span class="cx"> if (!children.size())
</span><span class="cx"> return 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleInterfaceSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> // For menu lists we need to return the first accessible child,
</span><span class="cx"> // with role MenuListPopupRole, since that's the one holding the list
</span><span class="cx"> // of items with role MenuListOptionRole.
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = coreSelection->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = coreSelection->children();
</ins><span class="cx"> if (!children.size())
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> if (!listObject)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector options = listObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& options = listObject->children();
</ins><span class="cx"> if (index < static_cast<gint>(options.size()))
</span><span class="cx"> return options.at(index).get();
</span><span class="cx">
</span><span class="lines">@@ -250,8 +250,8 @@
</span><span class="cx"> if (!coreSelection || !coreSelection->isMultiSelectable())
</span><span class="cx"> return FALSE;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = coreSelection->children();
</del><span class="cx"> if (coreSelection->isListBox()) {
</span><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = coreSelection->children();
</ins><span class="cx"> AccessibilityListBox* listBox = toAccessibilityListBox(coreSelection);
</span><span class="cx"> listBox->setSelectedChildren(children);
</span><span class="cx"> AccessibilityObject::AccessibilityChildrenVector selectedItems;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -320,14 +320,14 @@
</span><span class="cx">
</span><span class="cx"> static gint getNChildrenForTable(AccessibilityObject* coreObject)
</span><span class="cx"> {
</span><del>- AccessibilityObject::AccessibilityChildrenVector tableChildren = coreObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& tableChildren = coreObject->children();
</ins><span class="cx"> size_t tableChildrenCount = tableChildren.size();
</span><span class="cx"> size_t cellsCount = 0;
</span><span class="cx">
</span><span class="cx"> // Look for the actual index of the cell inside the table.
</span><span class="cx"> for (unsigned i = 0; i < tableChildrenCount; ++i) {
</span><span class="cx"> if (tableChildren[i]->isTableRow()) {
</span><del>- AccessibilityObject::AccessibilityChildrenVector rowChildren = tableChildren[i]->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& rowChildren = tableChildren[i]->children();
</ins><span class="cx"> cellsCount += rowChildren.size();
</span><span class="cx"> } else
</span><span class="cx"> cellsCount++;
</span><span class="lines">@@ -353,7 +353,7 @@
</span><span class="cx">
</span><span class="cx"> static AccessibilityObject* getChildForTable(AccessibilityObject* coreObject, gint index)
</span><span class="cx"> {
</span><del>- AccessibilityObject::AccessibilityChildrenVector tableChildren = coreObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& tableChildren = coreObject->children();
</ins><span class="cx"> size_t tableChildrenCount = tableChildren.size();
</span><span class="cx"> size_t cellsCount = 0;
</span><span class="cx">
</span><span class="lines">@@ -361,7 +361,7 @@
</span><span class="cx"> size_t current = static_cast<size_t>(index);
</span><span class="cx"> for (unsigned i = 0; i < tableChildrenCount; ++i) {
</span><span class="cx"> if (tableChildren[i]->isTableRow()) {
</span><del>- AccessibilityObject::AccessibilityChildrenVector rowChildren = tableChildren[i]->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& rowChildren = tableChildren[i]->children();
</ins><span class="cx"> size_t rowChildrenCount = rowChildren.size();
</span><span class="cx"> if (current < cellsCount + rowChildrenCount)
</span><span class="cx"> return rowChildren.at(current - cellsCount).get();
</span><span class="lines">@@ -392,7 +392,7 @@
</span><span class="cx"> if (coreObject->isAccessibilityTable())
</span><span class="cx"> coreChild = getChildForTable(coreObject, index);
</span><span class="cx"> else {
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = coreObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = coreObject->children();
</ins><span class="cx"> if (static_cast<unsigned>(index) >= children.size())
</span><span class="cx"> return 0;
</span><span class="cx"> coreChild = children.at(index).get();
</span><span class="lines">@@ -418,7 +418,7 @@
</span><span class="cx"> if (!grandParent)
</span><span class="cx"> return -1;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector rows = grandParent->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& rows = grandParent->children();
</ins><span class="cx"> size_t rowsCount = rows.size();
</span><span class="cx"> size_t previousCellsCount = 0;
</span><span class="cx">
</span><span class="lines">@@ -427,7 +427,7 @@
</span><span class="cx"> if (!rows[i]->isTableRow())
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector cells = rows[i]->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& cells = rows[i]->children();
</ins><span class="cx"> size_t cellsCount = cells.size();
</span><span class="cx">
</span><span class="cx"> if (rows[i] == parent) {
</span><span class="lines">@@ -1133,7 +1133,7 @@
</span><span class="cx"> // Add the TEXT interface for list items whose
</span><span class="cx"> // first accessible child has a text renderer
</span><span class="cx"> if (role == ListItemRole) {
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = coreObject->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = coreObject->children();
</ins><span class="cx"> if (children.size()) {
</span><span class="cx"> AccessibilityObject* axRenderChild = children.at(0).get();
</span><span class="cx"> interfaceMask |= getInterfaceMaskFromObject(axRenderChild);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx"> if ([self isAttachment])
</span><span class="cx"> return [[self attachmentView] accessibilityElementAtIndex:index];
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = m_object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = m_object->children();
</ins><span class="cx"> if (static_cast<unsigned>(index) >= children.size())
</span><span class="cx"> return nil;
</span><span class="cx">
</span><span class="lines">@@ -367,7 +367,7 @@
</span><span class="cx"> if ([self isAttachment])
</span><span class="cx"> return [[self attachmentView] indexOfAccessibilityElement:element];
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = m_object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = m_object->children();
</ins><span class="cx"> unsigned count = children.size();
</span><span class="cx"> for (unsigned k = 0; k < count; ++k) {
</span><span class="cx"> AccessibilityObjectWrapper* wrapper = children[k]->wrapper();
</span><span class="lines">@@ -1073,7 +1073,7 @@
</span><span class="cx"> if (role != LinkRole && role != WebCoreLinkRole)
</span><span class="cx"> return NO;
</span><span class="cx">
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = m_object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = m_object->children();
</ins><span class="cx"> unsigned childrenSize = children.size();
</span><span class="cx">
</span><span class="cx"> // If there's only one child, then it doesn't have segmented children.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (161872 => 161873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-13 10:45:01 UTC (rev 161872)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-13 11:19:38 UTC (rev 161873)
</span><span class="lines">@@ -2377,7 +2377,7 @@
</span><span class="cx"> if ([attributeName isEqualToString:NSAccessibilityContentsAttribute]) {
</span><span class="cx"> // The contents of a tab list are all the children except the tabs.
</span><span class="cx"> if (m_object->isTabList()) {
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = m_object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = m_object->children();
</ins><span class="cx"> AccessibilityObject::AccessibilityChildrenVector tabsChildren;
</span><span class="cx"> m_object->tabChildren(tabsChildren);
</span><span class="cx">
</span><span class="lines">@@ -2389,7 +2389,7 @@
</span><span class="cx"> }
</span><span class="cx"> return convertToNSArray(contents);
</span><span class="cx"> } else if (m_object->isScrollView()) {
</span><del>- AccessibilityObject::AccessibilityChildrenVector children = m_object->children();
</del><ins>+ const AccessibilityObject::AccessibilityChildrenVector& children = m_object->children();
</ins><span class="cx">
</span><span class="cx"> // A scrollView's contents are everything except the scroll bars.
</span><span class="cx"> AccessibilityObject::AccessibilityChildrenVector contents;
</span></span></pre>
</div>
</div>
</body>
</html>