<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161938] branches/jsCStack/Source/JavaScriptCore/ChangeLog</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161938">161938</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-01-13 18:43:01 -0800 (Mon, 13 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Updated ChangeLog review status for patches which have been reviewed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (161937 => 161938)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog 2014-01-14 02:41:08 UTC (rev 161937)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog 2014-01-14 02:43:01 UTC (rev 161938)
</span><span class="lines">@@ -149,7 +149,7 @@
</span><span class="cx"> internal-js-tests.yaml/Octane/mandreel.js.default-ftl fails about 1/30 times with "TypeError: undefined is not an object"
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126797
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Michael Saboff.
</ins><span class="cx">
</span><span class="cx"> This bug was a hilarious combination of concurrent JIT (making it a flake),
</span><span class="cx"> LLInt->JIT OSR, and the FTL's register preservation wrapper.
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx"> FTL tier-up should behave the same with CountExecution's as it does without
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126822
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Sam Weinig.
</ins><span class="cx">
</span><span class="cx"> CountExecution nodes are inserted by the profiler. Prior to this change, their
</span><span class="cx"> presence would change how we inserted CheckTierUp nodes, since a CountExecution
</span><span class="lines">@@ -683,7 +683,7 @@
</span><span class="cx"> FTL should be able to be parallel
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126679
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Oliver Hunt.
</ins><span class="cx">
</span><span class="cx"> Fix some bugs that got in the way of saying JSC_numberOfCompilerThreads=7 or some
</span><span class="cx"> such.
</span><span class="lines">@@ -700,7 +700,7 @@
</span><span class="cx"> FTL should not use the inputs of an add or sub as the live-at-exit values in an overflow check, if the values aren't live after
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126545
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Oliver Hunt.
</ins><span class="cx">
</span><span class="cx"> Introduces the notion of an ExitValue that is computed by doing some math on two
</span><span class="cx"> exit arguments. This gets used by LowerDFGToLLVM by tracking the
</span><span class="lines">@@ -815,7 +815,7 @@
</span><span class="cx"> CStack: Call linking should log call linking for DFG and FTL code blocks if --showDFGDisassembly=true
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126617
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Rreviewed by Oliver Hunt.
</ins><span class="cx">
</span><span class="cx"> * jit/Repatch.cpp:
</span><span class="cx"> (JSC::linkFor):
</span><span class="lines">@@ -835,7 +835,7 @@
</span><span class="cx"> --showDFGDisassembly=true shouldn't show baseline JIT stubs
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126593
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Oliver Hunt.
</ins><span class="cx">
</span><span class="cx"> * assembler/LinkBuffer.cpp:
</span><span class="cx"> (JSC::shouldShowDisassemblyFor):
</span><span class="lines">@@ -1677,7 +1677,6 @@
</span><span class="cx"> CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame().
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126191.
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><span class="cx"> Update: This is supplanted by https://bugs.webkit.org/show_bug.cgi?id=126790.
</span><span class="cx">
</span><span class="cx"> 1. JSStack::disableErrorStackReserve() was wrongly comparing m_end with m_useableTop.
</span><span class="lines">@@ -1897,7 +1896,7 @@
</span><span class="cx"> It should be possible to run the full version of V8v7/crypto with the FTL and call IC's
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126116
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Sam Weinig.
</ins><span class="cx">
</span><span class="cx"> This involved a number of minor fixes:
</span><span class="cx">
</span><span class="lines">@@ -2807,7 +2806,7 @@
</span><span class="cx"> CStack Branch: Fix callee frame access in virtualForThunkGenerator when we don't emit prologue code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125828
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Geoffrey Garen.
</ins><span class="cx">
</span><span class="cx"> Added helpers to access the callee frame using the stack pointer taking into account that
</span><span class="cx"> the caller frame hasn't been pushed onto the stack.
</span><span class="lines">@@ -2950,7 +2949,7 @@
</span><span class="cx"> FTL should *really* know when things are flushed
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125747
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed bu Sam Weinig.
</ins><span class="cx">
</span><span class="cx"> Fix more codegen badness. This makes V8v7's crypto am3() function run faster in the FTL
</span><span class="cx"> than in DFG. This means that even if we just compile those functions in V8v7 that don't
</span><span class="lines">@@ -2979,7 +2978,7 @@
</span><span class="cx"> cStack: Calling into FTL-generated code should be fast
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125649
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Geoffrey Garen.
</ins><span class="cx">
</span><span class="cx"> * assembler/AbstractMacroAssembler.h:
</span><span class="cx"> * bytecode/StructureStubInfo.h:
</span><span class="lines">@@ -3212,7 +3211,7 @@
</span><span class="cx"> CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125666
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Geoffrey Garen.
</ins><span class="cx">
</span><span class="cx"> Eliminated "extraStack" arguments and related stack pointer manipulation for 64 bit platforms.
</span><span class="cx"> Both ARM64 and X86_64 already have aligned stacks. Eliminated some related commented out
</span><span class="lines">@@ -3331,7 +3330,7 @@
</span><span class="cx"> CStack Branch: Set stack pointer in OSR exit handler
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125617
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Oliver Hunt.
</ins><span class="cx">
</span><span class="cx"> Set the stack pointer off of the callFrameRegister just like at the top of the function.
</span><span class="cx">
</span><span class="lines">@@ -3355,7 +3354,7 @@
</span><span class="cx"> CStack Branch: enable use of DFG for simple JavaScript
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125599
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Filip Pizlo.
</ins><span class="cx">
</span><span class="cx"> Added code to set up the stack pointer on entry and for call for the DFG. Changed the
</span><span class="cx"> SpeculativeJIT::calleeFrame*() helpers to use the stack pointer instead of the call frame
</span><span class="lines">@@ -3412,7 +3411,7 @@
</span><span class="cx"> CStack Branch: ctiNativeCallFallback and friends should renamed ...NativeTailCall
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125485
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Geoffrey Garen.
</ins><span class="cx">
</span><span class="cx"> Changed ctiNativeCallFallback to ctiNativeTailCall and nativeCallFallbackGenerator
</span><span class="cx"> to nativeTailCallGenerator to be more descriptive of what is happening.
</span><span class="lines">@@ -3518,7 +3517,7 @@
</span><span class="cx"> CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125381
</span><span class="cx">
</span><del>- Not yet reviewed.
</del><ins>+ Reviewed by Geoffrey Garen.
</ins><span class="cx">
</span><span class="cx"> Changed the entry / exit sequences to use emitFunctionPrologue() and
</span><span class="cx"> functionEpilogue().
</span></span></pre>
</div>
</div>
</body>
</html>