<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161900] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161900">161900</a></dd>
<dt>Author</dt> <dd>bburg@apple.com</dd>
<dt>Date</dt> <dd>2014-01-13 12:10:22 -0800 (Mon, 13 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: protocol generator should support integer-typed declarations
https://bugs.webkit.org/show_bug.cgi?id=126828
Reviewed by Joseph Pecoraro.
Add new binding classes for parameter/ad-hoc and normal integer type declarations.
* inspector/scripts/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainInteger):
(TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):
(TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):
(TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainInteger.get_type_model):
(TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefInteger):
(TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):
(TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptsCodeGeneratorInspectorpy">trunk/Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (161899 => 161900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-01-13 19:42:27 UTC (rev 161899)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-01-13 20:10:22 UTC (rev 161900)
</span><span class="lines">@@ -1,3 +1,40 @@
</span><ins>+2014-01-13 Brian Burg <bburg@apple.com>
+
+ Web Inspector: protocol generator should support integer-typed declarations
+ https://bugs.webkit.org/show_bug.cgi?id=126828
+
+ Reviewed by Joseph Pecoraro.
+
+ Add new binding classes for parameter/ad-hoc and normal integer type declarations.
+
+ * inspector/scripts/CodeGeneratorInspector.py:
+ (TypeBindings.create_type_declaration_):
+ (TypeBindings.create_type_declaration_.PlainInteger):
+ (TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):
+ (TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):
+ (TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):
+ (TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):
+ (TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):
+ (TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):
+ (TypeBindings.create_type_declaration_.PlainInteger.get_type_model):
+ (TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):
+ (TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):
+ (TypeBindings.create_type_declaration_.TypedefInteger):
+ (TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):
+ (TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):
+ (TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):
+ (TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):
+ (TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):
+
</ins><span class="cx"> 2014-01-13 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable SUBPIXEL_LAYOUT on Mac
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptsCodeGeneratorInspectorpy"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py (161899 => 161900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py 2014-01-13 19:42:27 UTC (rev 161899)
+++ trunk/Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py 2014-01-13 20:10:22 UTC (rev 161900)
</span><span class="lines">@@ -1112,6 +1112,106 @@
</span><span class="cx">
</span><span class="cx"> return TypedefString
</span><span class="cx">
</span><ins>+ elif json_typable["type"] == "integer":
+ if helper.is_ad_hoc:
+
+ class PlainInteger:
+ @classmethod
+ def resolve_inner(cls, resolve_context):
+ pass
+
+ @staticmethod
+ def request_user_runtime_cast(request):
+ raise Exception("Unsupported")
+
+ @staticmethod
+ def request_internal_runtime_cast():
+ pass
+
+ @staticmethod
+ def get_code_generator():
+ return None
+
+ @classmethod
+ def get_validator_call_text(cls):
+ return RawTypes.Int.get_raw_validator_call_text()
+
+ @staticmethod
+ def reduce_to_raw_type():
+ return RawTypes.Int
+
+ @staticmethod
+ def get_type_model():
+ return TypeModel.Int
+
+ @staticmethod
+ def get_setter_value_expression_pattern():
+ return None
+
+ @classmethod
+ def get_array_item_c_type_text(cls):
+ return cls.reduce_to_raw_type().get_array_item_raw_c_type_text()
+
+ return PlainInteger
+
+ else:
+
+ class TypedefInteger:
+ @classmethod
+ def resolve_inner(cls, resolve_context):
+ pass
+
+ @staticmethod
+ def request_user_runtime_cast(request):
+ raise Exception("Unsupported")
+
+ @staticmethod
+ def request_internal_runtime_cast():
+ RawTypes.Int.request_raw_internal_runtime_cast()
+
+ @staticmethod
+ def get_code_generator():
+ class CodeGenerator:
+ @staticmethod
+ def generate_type_builder(writer, generate_context):
+ helper.write_doc(writer)
+ fixed_type_name.output_comment(writer)
+ writer.newline("typedef int ")
+ writer.append(fixed_type_name.class_name)
+ writer.append(";\n\n")
+
+ @staticmethod
+ def register_use(forward_listener):
+ pass
+
+ @staticmethod
+ def get_generate_pass_id():
+ return TypeBuilderPass.TYPEDEF
+
+ return CodeGenerator
+
+ @classmethod
+ def get_validator_call_text(cls):
+ return RawTypes.Int.get_raw_validator_call_text()
+
+ @staticmethod
+ def reduce_to_raw_type():
+ return RawTypes.Int
+
+ @staticmethod
+ def get_type_model():
+ return TypeModel.Int
+
+ @staticmethod
+ def get_setter_value_expression_pattern():
+ return None
+
+ @classmethod
+ def get_array_item_c_type_text(cls):
+ return helper.full_name_prefix_for_use + fixed_type_name.class_name
+
+ return TypedefInteger
+
</ins><span class="cx"> elif json_typable["type"] == "object":
</span><span class="cx"> if "properties" in json_typable:
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>