<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161808] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161808">161808</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-12 08:15:48 -0800 (Sun, 12 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
* GNUmakefile.am: Added new target DerivedSources/ANGLE which is a directory to be created
* bindings/gobject/GNUmakefile.am: Added new target DerivedSources/webkitdom which is a directory to be created
Source/WebKit/gtk: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
* GNUmakefile.am: Added a new target of the directory in which files are meant to be stored ($(GENSOURCES_WEBKIT)).
Tools: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
* WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreGNUmakefileam">trunk/Source/WebCore/GNUmakefile.am</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectGNUmakefileam">trunk/Source/WebCore/bindings/gobject/GNUmakefile.am</a></li>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkGNUmakefileam">trunk/Source/WebKit/gtk/GNUmakefile.am</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerGNUmakefileam">trunk/Tools/WebKitTestRunner/GNUmakefile.am</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-01-12 Tobias Mueller <tobiasmue@gnome.org>
+
+ --disable-dependency-tracking causes build failure due to missing directories
+ https://bugs.webkit.org/show_bug.cgi?id=94488
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Ensure output directory existing
+ before generating DerivedSources. This allows for
+ --disable-dependency-tracking to be run.
+
+ * GNUmakefile.am: Added new target DerivedSources/ANGLE which is a directory to be created
+ * bindings/gobject/GNUmakefile.am: Added new target DerivedSources/webkitdom which is a directory to be created
+
</ins><span class="cx"> 2014-01-12 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] WebFontCache is Mac-only
</span></span></pre></div>
<a id="trunkSourceWebCoreGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/GNUmakefile.am (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/GNUmakefile.am 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Source/WebCore/GNUmakefile.am 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -387,11 +387,14 @@
</span><span class="cx"> dist_audio_DATA = $(audio_DATA)
</span><span class="cx"> endif # END ENABLE_WEB_AUDIO
</span><span class="cx">
</span><ins>+DerivedSources/ANGLE:
+ $(AM_V_at)mkdir -p $@
+
</ins><span class="cx"> # ANGLE tokenizer & parser
</span><del>-DerivedSources/ANGLE/glslang.cpp: Source/ThirdParty/ANGLE/src/compiler/glslang.l DerivedSources/ANGLE/glslang_tab.cpp
</del><ins>+DerivedSources/ANGLE/glslang.cpp: Source/ThirdParty/ANGLE/src/compiler/glslang.l DerivedSources/ANGLE/glslang_tab.cpp DerivedSources/ANGLE
</ins><span class="cx"> $(AM_V_GEN)$(FLEX) --noline --nounistd --outfile="$@" "$<"
</span><span class="cx">
</span><del>-DerivedSources/ANGLE/glslang_tab.cpp: Source/ThirdParty/ANGLE/src/compiler/glslang.y
</del><ins>+DerivedSources/ANGLE/glslang_tab.cpp: Source/ThirdParty/ANGLE/src/compiler/glslang.y DerivedSources/ANGLE
</ins><span class="cx"> $(AM_V_GEN)$(BISON) --no-lines --defines="DerivedSources/ANGLE/glslang_tab.h" --skeleton=yacc.c --output="$@" $<
</span><span class="cx"> DerivedSources/ANGLE/glslang_tab.h: DerivedSources/ANGLE/glslang_tab.cpp
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -474,10 +474,12 @@
</span><span class="cx">
</span><span class="cx"> gdom_class_list := $(subst WebKitDOM,, $(filter-out %Private, $(basename $(notdir $(webkitgtk_gdom_built_sources)))))
</span><span class="cx"> gdom_class_list += Custom EventTarget Object Deprecated
</span><del>-DerivedSources/webkitdom/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am
</del><ins>+DerivedSources/webkitdom:
+ $(AM_V_at)mkdir -p $@
+DerivedSources/webkitdom/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)echo $(gdom_class_list) | $(PERL) $< gdom > $@
</span><span class="cx">
</span><del>-DerivedSources/webkitdom/webkitdomdefines.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am
</del><ins>+DerivedSources/webkitdom/webkitdomdefines.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)echo $(gdom_class_list) | $(PERL) $< defines > $@
</span><span class="cx">
</span><span class="cx"> noinst_DATA += DerivedSources/webkitdom/webkitdom.symbols
</span><span class="lines">@@ -518,16 +520,16 @@
</span><span class="cx"> # DerivedSources/webkitdom directory. The reason is that we want all header files distributed in the
</span><span class="cx"> # include/webkit-x.y/webkitdom directory, but do not want to name the WebCore/bindings/gobject directory
</span><span class="cx"> # "webkitdom", as that's a bit presumptuous for a GTK binding.
</span><del>-$(top_builddir)/DerivedSources/webkitdom/WebKitDOMObject.h: $(WebCore)/bindings/gobject/WebKitDOMObject.h
</del><ins>+$(top_builddir)/DerivedSources/webkitdom/WebKitDOMObject.h: $(WebCore)/bindings/gobject/WebKitDOMObject.h $(top_builddir)/DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)cp -f $< $@
</span><span class="cx">
</span><del>-$(top_builddir)/DerivedSources/webkitdom/WebKitDOMEventTarget.h: $(WebCore)/bindings/gobject/WebKitDOMEventTarget.h
</del><ins>+$(top_builddir)/DerivedSources/webkitdom/WebKitDOMEventTarget.h: $(WebCore)/bindings/gobject/WebKitDOMEventTarget.h $(top_builddir)/DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)cp -f $< $@
</span><span class="cx">
</span><del>-$(top_builddir)/DerivedSources/webkitdom/WebKitDOMEventTargetPrivate.h: $(WebCore)/bindings/gobject/WebKitDOMEventTargetPrivate.h
</del><ins>+$(top_builddir)/DerivedSources/webkitdom/WebKitDOMEventTargetPrivate.h: $(WebCore)/bindings/gobject/WebKitDOMEventTargetPrivate.h $(top_builddir)/DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)cp -f $< $@
</span><span class="cx">
</span><del>-$(top_builddir)/DerivedSources/webkitdom/WebKitDOMCustom.h: $(WebCore)/bindings/gobject/WebKitDOMCustom.h
</del><ins>+$(top_builddir)/DerivedSources/webkitdom/WebKitDOMCustom.h: $(WebCore)/bindings/gobject/WebKitDOMCustom.h $(top_builddir)/DerivedSources/webkitdom
</ins><span class="cx"> $(AM_V_GEN)cp -f $< $@
</span><span class="cx">
</span><span class="cx"> $(top_builddir)/DerivedSources/webkitdom/WebKitDOMDeprecated.h: $(WebCore)/bindings/gobject/WebKitDOMDeprecated.h
</span></span></pre></div>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-01-12 Tobias Mueller <tobiasmue@gnome.org>
+
+ --disable-dependency-tracking causes build failure due to missing directories
+ https://bugs.webkit.org/show_bug.cgi?id=94488
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Autotools build fix: Ensure output directory existing
+ before generating DerivedSources. This allows for
+ --disable-dependency-tracking to be run.
+
+ * GNUmakefile.am: Added a new target of the directory in which files are meant to be stored ($(GENSOURCES_WEBKIT)).
+
</ins><span class="cx"> 2014-01-10 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Tweak ProgressTrackerClient functions
</span></span></pre></div>
<a id="trunkSourceWebKitgtkGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/GNUmakefile.am (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/GNUmakefile.am 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Source/WebKit/gtk/GNUmakefile.am 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -349,13 +349,16 @@
</span><span class="cx"> $(GENSOURCES_WEBKIT)/webkitmarshal.h: stamp-webkitmarshal.h
</span><span class="cx"> @true
</span><span class="cx">
</span><del>-stamp-webkitmarshal.cpp: $(WEBKIT_MARSHAL_LIST)
</del><ins>+$(GENSOURCES_WEBKIT):
+ $(AM_V_at)mkdir -p $@
+
+stamp-webkitmarshal.cpp: $(WEBKIT_MARSHAL_LIST) $(GENSOURCES_WEBKIT)
</ins><span class="cx"> $(AM_V_GEN) echo "extern \"C\" {" > $(GENSOURCES_WEBKIT)/webkitmarshal.cpp && \
</span><span class="cx"> $(GLIB_GENMARSHAL) --prefix=webkit_marshal $(WEBKIT_MARSHAL_LIST) --body >> $(GENSOURCES_WEBKIT)/webkitmarshal.cpp && \
</span><span class="cx"> echo '}' >> $(GENSOURCES_WEBKIT)/webkitmarshal.cpp && \
</span><span class="cx"> echo timestamp > $(@F)
</span><span class="cx">
</span><del>-stamp-webkitmarshal.h: $(WEBKIT_MARSHAL_LIST)
</del><ins>+stamp-webkitmarshal.h: $(WEBKIT_MARSHAL_LIST) $(GENSOURCES_WEBKIT)
</ins><span class="cx"> $(AM_V_GEN)$(GLIB_GENMARSHAL) --prefix=webkit_marshal $(WEBKIT_MARSHAL_LIST) --header > $(GENSOURCES_WEBKIT)/webkitmarshal.h && \
</span><span class="cx"> echo timestamp > $(@F)
</span><span class="cx">
</span><span class="lines">@@ -370,7 +373,7 @@
</span><span class="cx"> && rm -f xgen-gth \
</span><span class="cx"> && echo timestamp > $(@F)
</span><span class="cx">
</span><del>-$(GENSOURCES_WEBKIT)/webkitenumtypes.cpp: $(webkitgtk_h_api) $(WebKit)/GNUmakefile.am
</del><ins>+$(GENSOURCES_WEBKIT)/webkitenumtypes.cpp: $(webkitgtk_h_api) $(WebKit)/GNUmakefile.am $(GENSOURCES_WEBKIT)
</ins><span class="cx"> $(AM_V_GEN)glib-mkenums --template $(srcdir)/Source/WebKit/gtk/webkit/webkitenumtypes.cpp.template $(webkitgtk_h_api) | \
</span><span class="cx"> sed 's,web_kit,webkit,' \
</span><span class="cx"> > xgen-gtc \
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Tools/ChangeLog 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-01-12 Tobias Mueller <tobiasmue@gnome.org>
+
+ --disable-dependency-tracking causes build failure due to missing directories
+ https://bugs.webkit.org/show_bug.cgi?id=94488
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Autotools build fix: Ensure output directory existing
+ before generating DerivedSources. This allows for
+ --disable-dependency-tracking to be run.
+
+
+ * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
+
</ins><span class="cx"> 2014-01-12 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Fix return value of WebKitDownload::created-destination
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/GNUmakefile.am (161807 => 161808)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/GNUmakefile.am 2014-01-12 16:09:51 UTC (rev 161807)
+++ trunk/Tools/WebKitTestRunner/GNUmakefile.am 2014-01-12 16:15:48 UTC (rev 161808)
</span><span class="lines">@@ -156,7 +156,10 @@
</span><span class="cx"> Source/WebCore/bindings/scripts/InFilesParser.pm \
</span><span class="cx"> Source/WebCore/bindings/scripts/generate-bindings.pl
</span><span class="cx">
</span><del>-DerivedSources/InjectedBundle/JS%.cpp: Tools/WebKitTestRunner/InjectedBundle/Bindings/%.idl $(code_generation_dependencies)
</del><ins>+$(top_builddir)/DerivedSources/InjectedBundle:
+ $(AM_V_at)mkdir -p $@
+
+DerivedSources/InjectedBundle/JS%.cpp: Tools/WebKitTestRunner/InjectedBundle/Bindings/%.idl $(code_generation_dependencies) $(top_builddir)/DerivedSources/InjectedBundle
</ins><span class="cx"> $(AM_V_GEN)$(PERL) \
</span><span class="cx"> -I $(srcdir)/Source/WebCore/bindings/scripts \
</span><span class="cx"> -I $(srcdir)/Tools/WebKitTestRunner/InjectedBundle/Bindings \
</span></span></pre>
</div>
</div>
</body>
</html>