<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161781] branches/jsCStack/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161781">161781</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-01-11 13:03:15 -0800 (Sat, 11 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, add a test for InvalidationPoint in the FTL.
Probably there are other tests that cover this in various ways and it's possible
that we're just not running those tests in the FTL, yet. But anyway I think it's
good to have an FTL-specific test for this.
* tests/stress/invalidation-point.js: Added.
(foo):
(Thingy):
(Thingy.prototype.f):
(possiblyDoBadThings.Thingy.prototype.f):
(possiblyDoBadThings):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoretestsstressinvalidationpointjs">branches/jsCStack/Source/JavaScriptCore/tests/stress/invalidation-point.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (161780 => 161781)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog 2014-01-11 20:59:15 UTC (rev 161780)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog 2014-01-11 21:03:15 UTC (rev 161781)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2014-01-11 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ Unreviewed, add a test for InvalidationPoint in the FTL.
+
+ Probably there are other tests that cover this in various ways and it's possible
+ that we're just not running those tests in the FTL, yet. But anyway I think it's
+ good to have an FTL-specific test for this.
+
+ * tests/stress/invalidation-point.js: Added.
+ (foo):
+ (Thingy):
+ (Thingy.prototype.f):
+ (possiblyDoBadThings.Thingy.prototype.f):
+ (possiblyDoBadThings):
+
+2014-01-11 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> FTL tier-up should behave the same with CountExecution's as it does without
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126822
</span><span class="cx">
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoretestsstressinvalidationpointjs"></a>
<div class="addfile"><h4>Added: branches/jsCStack/Source/JavaScriptCore/tests/stress/invalidation-point.js (0 => 161781)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/tests/stress/invalidation-point.js (rev 0)
+++ branches/jsCStack/Source/JavaScriptCore/tests/stress/invalidation-point.js 2014-01-11 21:03:15 UTC (rev 161781)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+function foo(o, p) {
+ possiblyDoBadThings(p);
+ return o.f();
+}
+noInline(foo);
+
+function Thingy() { }
+Thingy.prototype.f = function() { return 42; }
+
+function possiblyDoBadThings(p) {
+ if (p)
+ Thingy.prototype.f = function() { return 24; }
+}
+noInline(possiblyDoBadThings);
+
+for (var i = 0; i < 100000; ++i) {
+ var result = foo(new Thingy(), false);
+ if (result != 42)
+ throw "Error: bad result: " + result;
+}
+
+var result = foo(new Thingy(), true);
+if (result != 24)
+ throw "Error: bad result: " + result;
</ins></span></pre>
</div>
</div>
</body>
</html>