<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161784] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161784">161784</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-01-11 16:54:27 -0800 (Sat, 11 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>InspectorAgentRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=126826
Reviewed by Sam Weinig.
Source/JavaScriptCore:
* inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::append):
* inspector/InspectorAgentRegistry.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
* inspector/agents/InspectorAgent.h:
Source/WebCore:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.cpp:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorHeapProfilerAgent.cpp:
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/PageDebuggerAgent.cpp:
* inspector/PageDebuggerAgent.h:
* inspector/PageRuntimeAgent.h:
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerDebuggerAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
* inspector/WorkerRuntimeAgent.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInspectorAgentRegistrycpp">trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInspectorAgentRegistryh">trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorJSGlobalObjectInspectorControllercpp">trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectoragentsInspectorAgenth">trunk/Source/JavaScriptCore/inspector/agents/InspectorAgent.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgenth">trunk/Source/WebCore/inspector/InspectorCSSAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCanvasAgenth">trunk/Source/WebCore/inspector/InspectorCanvasAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllercpp">trunk/Source/WebCore/inspector/InspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgenth">trunk/Source/WebCore/inspector/InspectorDOMAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMDebuggerAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth">trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMStorageAgenth">trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDatabaseAgenth">trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHeapProfilerAgentcpp">trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHeapProfilerAgenth">trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgenth">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInputAgenth">trunk/Source/WebCore/inspector/InspectorInputAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorLayerTreeAgenth">trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorMemoryAgentcpp">trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorMemoryAgenth">trunk/Source/WebCore/inspector/InspectorMemoryAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgentcpp">trunk/Source/WebCore/inspector/InspectorPageAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorProfilerAgentcpp">trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorProfilerAgenth">trunk/Source/WebCore/inspector/InspectorProfilerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorResourceAgenth">trunk/Source/WebCore/inspector/InspectorResourceAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgenth">trunk/Source/WebCore/inspector/InspectorTimelineAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorWorkerAgentcpp">trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorWorkerAgenth">trunk/Source/WebCore/inspector/InspectorWorkerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageConsoleAgenth">trunk/Source/WebCore/inspector/PageConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageDebuggerAgentcpp">trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageDebuggerAgenth">trunk/Source/WebCore/inspector/PageDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageRuntimeAgenth">trunk/Source/WebCore/inspector/PageRuntimeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerConsoleAgenth">trunk/Source/WebCore/inspector/WorkerConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerDebuggerAgentcpp">trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerDebuggerAgenth">trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerInspectorControllercpp">trunk/Source/WebCore/inspector/WorkerInspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerRuntimeAgenth">trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-01-11 Anders Carlsson <andersca@apple.com>
+
+ InspectorAgentRegistry should use std::unique_ptr
+ https://bugs.webkit.org/show_bug.cgi?id=126826
+
+ Reviewed by Sam Weinig.
+
+ * inspector/InspectorAgentRegistry.cpp:
+ (Inspector::InspectorAgentRegistry::append):
+ * inspector/InspectorAgentRegistry.h:
+ * inspector/JSGlobalObjectInspectorController.cpp:
+ (Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
+ * inspector/agents/InspectorAgent.h:
+
</ins><span class="cx"> 2014-01-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInspectorAgentRegistrycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -31,9 +31,9 @@
</span><span class="cx">
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><del>-void InspectorAgentRegistry::append(PassOwnPtr<InspectorAgentBase> agent)
</del><ins>+void InspectorAgentRegistry::append(std::unique_ptr<InspectorAgentBase> agent)
</ins><span class="cx"> {
</span><del>- m_agents.append(agent);
</del><ins>+ m_agents.append(std::move(agent));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorAgentRegistry::didCreateFrontendAndBackend(InspectorFrontendChannel* frontendChannel, InspectorBackendDispatcher* backendDispatcher)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInspectorAgentRegistryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/JavaScriptCore/inspector/InspectorAgentRegistry.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #define InspectorAgentRegistry_h
</span><span class="cx">
</span><span class="cx"> #include "InspectorAgentBase.h"
</span><del>-#include <wtf/PassOwnPtr.h>
</del><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="cx"> namespace Inspector {
</span><span class="lines">@@ -38,14 +37,22 @@
</span><span class="cx">
</span><span class="cx"> class JS_EXPORT_PRIVATE InspectorAgentRegistry {
</span><span class="cx"> public:
</span><del>- void append(PassOwnPtr<InspectorAgentBase>);
</del><ins>+ template<typename T, typename... Args>
+ T& createAndAppend(Args&&... args)
+ {
+ m_agents.append(std::make_unique<T>(std::forward<Args...>(args)...));
</ins><span class="cx">
</span><ins>+ return static_cast<T&>(*m_agents.last());
+ }
+
+ void append(std::unique_ptr<InspectorAgentBase>);
+
</ins><span class="cx"> void didCreateFrontendAndBackend(InspectorFrontendChannel*, InspectorBackendDispatcher*);
</span><span class="cx"> void willDestroyFrontendAndBackend();
</span><span class="cx"> void discardAgents();
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- Vector<OwnPtr<InspectorAgentBase>> m_agents;
</del><ins>+ Vector<std::unique_ptr<InspectorAgentBase>> m_agents;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace Inspector
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorJSGlobalObjectInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -45,8 +45,7 @@
</span><span class="cx"> , m_injectedScriptManager(std::make_unique<InjectedScriptManager>(*this, InjectedScriptHost::create()))
</span><span class="cx"> , m_inspectorFrontendChannel(nullptr)
</span><span class="cx"> {
</span><del>- OwnPtr<InspectorAgent> inspectorAgent(InspectorAgent::create());
- m_agents.append(inspectorAgent.release());
</del><ins>+ m_agents.append(std::make_unique<InspectorAgent>());
</ins><span class="cx">
</span><span class="cx"> // FIXME: Create RuntimeAgent.
</span><span class="cx"> // FIXME: Create DebuggerAgent.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectoragentsInspectorAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/agents/InspectorAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/agents/InspectorAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/JavaScriptCore/inspector/agents/InspectorAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> class JS_EXPORT_PRIVATE InspectorAgent FINAL : public InspectorAgentBase, public InspectorInspectorBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorAgent> create() { return adoptPtr(new InspectorAgent); }
</del><ins>+ InspectorAgent();
</ins><span class="cx"> virtual ~InspectorAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(InspectorFrontendChannel*, InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -60,8 +60,6 @@
</span><span class="cx"> void evaluateForTestInFrontend(long testCallId, const String& script);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorAgent();
-
</del><span class="cx"> std::unique_ptr<InspectorInspectorFrontendDispatcher> m_frontendDispatcher;
</span><span class="cx"> RefPtr<InspectorInspectorBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> Vector<std::pair<long, String>> m_pendingEvaluateTestCommands;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2014-01-11 Anders Carlsson <andersca@apple.com>
+
+ InspectorAgentRegistry should use std::unique_ptr
+ https://bugs.webkit.org/show_bug.cgi?id=126826
+
+ Reviewed by Sam Weinig.
+
+ * inspector/InspectorApplicationCacheAgent.h:
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorCanvasAgent.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ * inspector/InspectorDOMAgent.h:
+ * inspector/InspectorDOMDebuggerAgent.cpp:
+ * inspector/InspectorDOMDebuggerAgent.h:
+ * inspector/InspectorDOMStorageAgent.h:
+ * inspector/InspectorDatabaseAgent.h:
+ * inspector/InspectorHeapProfilerAgent.cpp:
+ * inspector/InspectorHeapProfilerAgent.h:
+ * inspector/InspectorIndexedDBAgent.h:
+ * inspector/InspectorInputAgent.h:
+ * inspector/InspectorLayerTreeAgent.h:
+ * inspector/InspectorMemoryAgent.cpp:
+ * inspector/InspectorMemoryAgent.h:
+ * inspector/InspectorPageAgent.cpp:
+ * inspector/InspectorPageAgent.h:
+ * inspector/InspectorProfilerAgent.cpp:
+ (WebCore::InspectorProfilerAgent::create):
+ * inspector/InspectorProfilerAgent.h:
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/InspectorWorkerAgent.cpp:
+ * inspector/InspectorWorkerAgent.h:
+ * inspector/PageConsoleAgent.h:
+ * inspector/PageDebuggerAgent.cpp:
+ * inspector/PageDebuggerAgent.h:
+ * inspector/PageRuntimeAgent.h:
+ * inspector/WorkerConsoleAgent.h:
+ * inspector/WorkerDebuggerAgent.cpp:
+ * inspector/WorkerDebuggerAgent.h:
+ * inspector/WorkerInspectorController.cpp:
+ (WebCore::WorkerInspectorController::WorkerInspectorController):
+ * inspector/WorkerRuntimeAgent.h:
+
</ins><span class="cx"> 2014-01-11 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -53,10 +53,7 @@
</span><span class="cx"> class InspectorApplicationCacheAgent : public InspectorAgentBase, public Inspector::InspectorApplicationCacheBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorApplicationCacheAgent); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorApplicationCacheAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent)
- {
- return adoptPtr(new InspectorApplicationCacheAgent(instrumentingAgents, pageAgent));
- }
</del><ins>+ InspectorApplicationCacheAgent(InstrumentingAgents*, InspectorPageAgent*);
</ins><span class="cx"> ~InspectorApplicationCacheAgent() { }
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -71,7 +68,6 @@
</span><span class="cx"> virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorApplicationCacheAgent(InstrumentingAgents*, InspectorPageAgent*);
</del><span class="cx"> PassRefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);
</span><span class="cx"> PassRefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::ApplicationCacheResource>> buildArrayForApplicationCacheResources(const ApplicationCacheHost::ResourceInfoList&);
</span><span class="cx"> PassRefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCacheResource> buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -90,14 +90,11 @@
</span><span class="cx"> ContentSecurityPolicy* m_contentSecurityPolicy;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static CSSStyleRule* asCSSStyleRule(CSSRule*);
-
- static PassOwnPtr<InspectorCSSAgent> create(InstrumentingAgents* instrumentingAgents, InspectorDOMAgent* domAgent)
- {
- return adoptPtr(new InspectorCSSAgent(instrumentingAgents, domAgent));
- }
</del><ins>+ InspectorCSSAgent(InstrumentingAgents*, InspectorDOMAgent*);
</ins><span class="cx"> ~InspectorCSSAgent();
</span><span class="cx">
</span><ins>+ static CSSStyleRule* asCSSStyleRule(CSSRule*);
+
</ins><span class="cx"> bool forcePseudoState(Element*, CSSSelector::PseudoType);
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() OVERRIDE;
</span><span class="lines">@@ -149,8 +146,6 @@
</span><span class="cx"> class SetRuleSelectorAction;
</span><span class="cx"> class AddRuleAction;
</span><span class="cx">
</span><del>- InspectorCSSAgent(InstrumentingAgents*, InspectorDOMAgent*);
-
</del><span class="cx"> typedef HashMap<String, RefPtr<InspectorStyleSheet>> IdToInspectorStyleSheet;
</span><span class="cx"> typedef HashMap<CSSStyleSheet*, RefPtr<InspectorStyleSheet>> CSSStyleSheetToInspectorStyleSheet;
</span><span class="cx"> typedef HashMap<Node*, RefPtr<InspectorStyleSheetForInlineStyle>> NodeToInspectorStyleSheet; // bogus "stylesheets" with elements' inline styles
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCanvasAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCanvasAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCanvasAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorCanvasAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -62,10 +62,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorCanvasAgent : public InspectorAgentBase, public Inspector::InspectorCanvasBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorCanvasAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, Inspector::InjectedScriptManager* injectedScriptManager)
- {
- return adoptPtr(new InspectorCanvasAgent(instrumentingAgents, pageAgent, injectedScriptManager));
- }
</del><ins>+ InspectorCanvasAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*);
</ins><span class="cx"> ~InspectorCanvasAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -95,8 +92,6 @@
</span><span class="cx"> virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorCanvasAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*);
-
</del><span class="cx"> InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, JSC::ExecState*);
</span><span class="cx"> InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, const Deprecated::ScriptObject&);
</span><span class="cx"> InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, const String&);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -96,80 +96,79 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT_ARG(inspectorClient, inspectorClient);
</span><span class="cx">
</span><del>- OwnPtr<InspectorAgent> inspectorAgentPtr(InspectorAgent::create());
</del><ins>+ auto inspectorAgentPtr = std::make_unique<InspectorAgent>();
</ins><span class="cx"> m_inspectorAgent = inspectorAgentPtr.get();
</span><span class="cx"> m_instrumentingAgents->setInspectorAgent(m_inspectorAgent);
</span><del>- m_agents.append(inspectorAgentPtr.release());
</del><ins>+ m_agents.append(std::move(inspectorAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::create(m_instrumentingAgents.get(), page, inspectorClient, m_overlay.get()));
</del><ins>+ auto pageAgentPtr = std::make_unique<InspectorPageAgent>(m_instrumentingAgents.get(), page, inspectorClient, m_overlay.get());
</ins><span class="cx"> InspectorPageAgent* pageAgent = pageAgentPtr.get();
</span><span class="cx"> m_pageAgent = pageAgentPtr.get();
</span><del>- m_agents.append(pageAgentPtr.release());
</del><ins>+ m_agents.append(std::move(pageAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get()));
</del><ins>+ auto domAgentPtr = std::make_unique<InspectorDOMAgent>(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get());
</ins><span class="cx"> m_domAgent = domAgentPtr.get();
</span><del>- m_agents.append(domAgentPtr.release());
</del><ins>+ m_agents.append(std::move(domAgentPtr));
</ins><span class="cx">
</span><del>- m_agents.append(InspectorCSSAgent::create(m_instrumentingAgents.get(), m_domAgent));
</del><ins>+ m_agents.append(std::make_unique<InspectorCSSAgent>(m_instrumentingAgents.get(), m_domAgent));
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(SQL_DATABASE)
</span><del>- OwnPtr<InspectorDatabaseAgent> databaseAgentPtr(InspectorDatabaseAgent::create(m_instrumentingAgents.get()));
</del><ins>+ auto databaseAgentPtr = std::make_unique<InspectorDatabaseAgent>(m_instrumentingAgents.get());
</ins><span class="cx"> InspectorDatabaseAgent* databaseAgent = databaseAgentPtr.get();
</span><del>- m_agents.append(databaseAgentPtr.release());
</del><ins>+ m_agents.append(std::move(databaseAgentPtr));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>- m_agents.append(InspectorIndexedDBAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get(), pageAgent));
</del><ins>+ m_agents.append(std::make_unique<InspectorIndexedDBAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get(), pageAgent));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><del>- OwnPtr<InspectorDOMStorageAgent> domStorageAgentPtr(InspectorDOMStorageAgent::create(m_instrumentingAgents.get(), m_pageAgent));
</del><ins>+ auto domStorageAgentPtr = std::make_unique<InspectorDOMStorageAgent>(m_instrumentingAgents.get(), m_pageAgent);
</ins><span class="cx"> InspectorDOMStorageAgent* domStorageAgent = domStorageAgentPtr.get();
</span><del>- m_agents.append(domStorageAgentPtr.release());
</del><ins>+ m_agents.append(std::move(domStorageAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorMemoryAgent> memoryAgentPtr(InspectorMemoryAgent::create(m_instrumentingAgents.get()));
</del><ins>+ auto memoryAgentPtr = std::make_unique<InspectorMemoryAgent>(m_instrumentingAgents.get());
</ins><span class="cx"> m_memoryAgent = memoryAgentPtr.get();
</span><del>- m_agents.append(memoryAgentPtr.release());
</del><ins>+ m_agents.append(std::move(memoryAgentPtr));
</ins><span class="cx">
</span><del>- m_agents.append(InspectorTimelineAgent::create(m_instrumentingAgents.get(), pageAgent, m_memoryAgent, InspectorTimelineAgent::PageInspector,
- inspectorClient));
- m_agents.append(InspectorApplicationCacheAgent::create(m_instrumentingAgents.get(), pageAgent));
</del><ins>+ m_agents.append(std::make_unique<InspectorTimelineAgent>(m_instrumentingAgents.get(), pageAgent, m_memoryAgent, InspectorTimelineAgent::PageInspector, inspectorClient));
+ m_agents.append(std::make_unique<InspectorApplicationCacheAgent>(m_instrumentingAgents.get(), pageAgent));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourceAgent::create(m_instrumentingAgents.get(), pageAgent, inspectorClient));
</del><ins>+ auto resourceAgentPtr = std::make_unique<InspectorResourceAgent>(m_instrumentingAgents.get(), pageAgent, inspectorClient);
</ins><span class="cx"> m_resourceAgent = resourceAgentPtr.get();
</span><del>- m_agents.append(resourceAgentPtr.release());
</del><ins>+ m_agents.append(std::move(resourceAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorRuntimeAgent> runtimeAgentPtr(PageRuntimeAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get(), page, pageAgent));
</del><ins>+ auto runtimeAgentPtr = std::make_unique<PageRuntimeAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get(), page, pageAgent);
</ins><span class="cx"> InspectorRuntimeAgent* runtimeAgent = runtimeAgentPtr.get();
</span><del>- m_agents.append(runtimeAgentPtr.release());
</del><ins>+ m_agents.append(std::move(runtimeAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorConsoleAgent> consoleAgentPtr(PageConsoleAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get(), m_domAgent));
</del><ins>+ auto consoleAgentPtr = std::make_unique<PageConsoleAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get(), m_domAgent);
</ins><span class="cx"> InspectorConsoleAgent* consoleAgent = consoleAgentPtr.get();
</span><del>- m_agents.append(consoleAgentPtr.release());
</del><ins>+ m_agents.append(std::move(consoleAgentPtr));
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(JAVASCRIPT_DEBUGGER)
</span><del>- OwnPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgent::create(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get()));
</del><ins>+ auto debuggerAgentPtr = std::make_unique<PageDebuggerAgent>(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get());
</ins><span class="cx"> m_debuggerAgent = debuggerAgentPtr.get();
</span><del>- m_agents.append(debuggerAgentPtr.release());
</del><ins>+ m_agents.append(std::move(debuggerAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorDOMDebuggerAgent> domDebuggerAgentPtr(InspectorDOMDebuggerAgent::create(m_instrumentingAgents.get(), m_domAgent, m_debuggerAgent));
</del><ins>+ auto domDebuggerAgentPtr = std::make_unique<InspectorDOMDebuggerAgent>(m_instrumentingAgents.get(), m_domAgent, m_debuggerAgent);
</ins><span class="cx"> m_domDebuggerAgent = domDebuggerAgentPtr.get();
</span><del>- m_agents.append(domDebuggerAgentPtr.release());
</del><ins>+ m_agents.append(std::move(domDebuggerAgentPtr));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorProfilerAgent> profilerAgentPtr(InspectorProfilerAgent::create(m_instrumentingAgents.get(), consoleAgent, page, m_injectedScriptManager.get()));
</del><ins>+ auto profilerAgentPtr = InspectorProfilerAgent::create(m_instrumentingAgents.get(), consoleAgent, page, m_injectedScriptManager.get());
</ins><span class="cx"> m_profilerAgent = profilerAgentPtr.get();
</span><del>- m_agents.append(profilerAgentPtr.release());
</del><ins>+ m_agents.append(std::move(profilerAgentPtr));
</ins><span class="cx">
</span><del>- m_agents.append(InspectorHeapProfilerAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get()));
</del><ins>+ m_agents.append(std::make_unique<InspectorHeapProfilerAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get()));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><del>- m_agents.append(InspectorWorkerAgent::create(m_instrumentingAgents.get()));
</del><ins>+ m_agents.append(std::make_unique<InspectorWorkerAgent>(m_instrumentingAgents.get()));
</ins><span class="cx">
</span><del>- m_agents.append(InspectorCanvasAgent::create(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get()));
</del><ins>+ m_agents.append(std::make_unique<InspectorCanvasAgent>(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get()));
</ins><span class="cx">
</span><del>- m_agents.append(InspectorInputAgent::create(m_instrumentingAgents.get(), page));
</del><ins>+ m_agents.append(std::make_unique<InspectorInputAgent>(m_instrumentingAgents.get(), page));
</ins><span class="cx">
</span><span class="cx"> #if USE(ACCELERATED_COMPOSITING)
</span><del>- m_agents.append(InspectorLayerTreeAgent::create(m_instrumentingAgents.get()));
</del><ins>+ m_agents.append(std::make_unique<InspectorLayerTreeAgent>(m_instrumentingAgents.get()));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> ASSERT(m_injectedScriptManager->commandLineAPIHost());
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -106,15 +106,11 @@
</span><span class="cx"> virtual void didModifyDOMAttr(Element*) = 0;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassOwnPtr<InspectorDOMAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, Inspector::InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
- {
- return adoptPtr(new InspectorDOMAgent(instrumentingAgents, pageAgent, injectedScriptManager, overlay));
- }
</del><ins>+ InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
+ ~InspectorDOMAgent();
</ins><span class="cx">
</span><span class="cx"> static String toErrorString(const ExceptionCode&);
</span><span class="cx">
</span><del>- ~InspectorDOMAgent();
-
</del><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() OVERRIDE;
</span><span class="cx">
</span><span class="lines">@@ -215,8 +211,6 @@
</span><span class="cx"> InspectorPageAgent* pageAgent() { return m_pageAgent; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
-
</del><span class="cx"> void setSearchingForNode(ErrorString*, bool enabled, Inspector::InspectorObject* highlightConfig);
</span><span class="cx"> PassOwnPtr<HighlightConfig> highlightConfigFromInspectorObject(ErrorString*, Inspector::InspectorObject* highlightInspectorObject);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMDebuggerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -64,11 +64,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorDOMDebuggerAgent> InspectorDOMDebuggerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent)
-{
- return adoptPtr(new InspectorDOMDebuggerAgent(instrumentingAgents, domAgent, debuggerAgent));
-}
-
</del><span class="cx"> InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent)
</span><span class="cx"> : InspectorAgentBase(ASCIILiteral("DOMDebugger"), instrumentingAgents)
</span><span class="cx"> , m_domAgent(domAgent)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -58,8 +58,7 @@
</span><span class="cx"> class InspectorDOMDebuggerAgent : public InspectorAgentBase, public InspectorDebuggerAgent::Listener, public Inspector::InspectorDOMDebuggerBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorDOMDebuggerAgent> create(InstrumentingAgents*, InspectorDOMAgent*, InspectorDebuggerAgent*);
-
</del><ins>+ InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorDOMAgent*, InspectorDebuggerAgent*);
</ins><span class="cx"> virtual ~InspectorDOMDebuggerAgent();
</span><span class="cx">
</span><span class="cx"> // DOMDebugger API
</span><span class="lines">@@ -87,8 +86,6 @@
</span><span class="cx"> virtual void discardAgent();
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorDOMAgent*, InspectorDebuggerAgent*);
-
</del><span class="cx"> // InspectorDebuggerAgent::Listener implementation.
</span><span class="cx"> virtual void debuggerWasEnabled();
</span><span class="cx"> virtual void debuggerWasDisabled();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMStorageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -54,10 +54,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorDOMStorageAgent : public InspectorAgentBase, public Inspector::InspectorDOMStorageBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorDOMStorageAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent)
- {
- return adoptPtr(new InspectorDOMStorageAgent(instrumentingAgents, pageAgent));
- }
</del><ins>+ InspectorDOMStorageAgent(InstrumentingAgents*, InspectorPageAgent*);
</ins><span class="cx"> ~InspectorDOMStorageAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -78,9 +75,6 @@
</span><span class="cx"> void didDispatchDOMStorageEvent(const String& key, const String& oldValue, const String& newValue, StorageType, SecurityOrigin*, Page*);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>-
- InspectorDOMStorageAgent(InstrumentingAgents*, InspectorPageAgent*);
-
</del><span class="cx"> PassRefPtr<StorageArea> findStorageArea(ErrorString*, const RefPtr<Inspector::InspectorObject>&, Frame*&);
</span><span class="cx">
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDatabaseAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -52,10 +52,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorDatabaseAgent : public InspectorAgentBase, public Inspector::InspectorDatabaseBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorDatabaseAgent> create(InstrumentingAgents* instrumentingAgents)
- {
- return adoptPtr(new InspectorDatabaseAgent(instrumentingAgents));
- }
</del><ins>+ explicit InspectorDatabaseAgent(InstrumentingAgents*);
</ins><span class="cx"> ~InspectorDatabaseAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -74,8 +71,6 @@
</span><span class="cx">
</span><span class="cx"> void didOpenDatabase(PassRefPtr<Database>, const String& domain, const String& name, const String& version);
</span><span class="cx"> private:
</span><del>- explicit InspectorDatabaseAgent(InstrumentingAgents*);
-
</del><span class="cx"> Database* databaseForId(const String& databaseId);
</span><span class="cx"> InspectorDatabaseResource* findByFileName(const String& fileName);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHeapProfilerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -45,11 +45,6 @@
</span><span class="cx">
</span><span class="cx"> static const char* const UserInitiatedProfileNameHeap = "org.webkit.profiles.user-initiated";
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorHeapProfilerAgent> InspectorHeapProfilerAgent::create(InstrumentingAgents* instrumentingAgents, PageInjectedScriptManager* injectedScriptManager)
-{
- return adoptPtr(new InspectorHeapProfilerAgent(instrumentingAgents, injectedScriptManager));
-}
-
</del><span class="cx"> InspectorHeapProfilerAgent::InspectorHeapProfilerAgent(InstrumentingAgents* instrumentingAgents, PageInjectedScriptManager* injectedScriptManager)
</span><span class="cx"> : InspectorAgentBase(ASCIILiteral("HeapProfiler"), instrumentingAgents)
</span><span class="cx"> , m_injectedScriptManager(injectedScriptManager)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHeapProfilerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorHeapProfilerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> class InspectorHeapProfilerAgent : public InspectorAgentBase, public Inspector::InspectorHeapProfilerBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorHeapProfilerAgent); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorHeapProfilerAgent> create(InstrumentingAgents*, PageInjectedScriptManager*);
</del><ins>+ InspectorHeapProfilerAgent(InstrumentingAgents*, PageInjectedScriptManager*);
</ins><span class="cx"> virtual ~InspectorHeapProfilerAgent();
</span><span class="cx">
</span><span class="cx"> virtual void collectGarbage(ErrorString*);
</span><span class="lines">@@ -75,8 +75,6 @@
</span><span class="cx"> virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorHeapProfilerAgent(InstrumentingAgents*, PageInjectedScriptManager*);
-
</del><span class="cx"> typedef HashMap<unsigned, RefPtr<ScriptHeapSnapshot>> IdToHeapSnapshotMap;
</span><span class="cx">
</span><span class="cx"> void resetFrontendProfiles();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -50,10 +50,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorIndexedDBAgent : public InspectorAgentBase, public Inspector::InspectorIndexedDBBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorIndexedDBAgent> create(InstrumentingAgents* instrumentingAgents, Inspector::InjectedScriptManager* injectedScriptManager, InspectorPageAgent* pageAgent)
- {
- return adoptPtr(new InspectorIndexedDBAgent(instrumentingAgents, injectedScriptManager, pageAgent));
- }
</del><ins>+ InspectorIndexedDBAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, InspectorPageAgent*);
</ins><span class="cx"> ~InspectorIndexedDBAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -68,8 +65,6 @@
</span><span class="cx"> virtual void clearObjectStore(ErrorString*, const String& in_securityOrigin, const String& in_databaseName, const String& in_objectStoreName, PassRefPtr<ClearObjectStoreCallback>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorIndexedDBAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, InspectorPageAgent*);
-
</del><span class="cx"> Inspector::InjectedScriptManager* m_injectedScriptManager;
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx"> RefPtr<Inspector::InspectorIndexedDBBackendDispatcher> m_backendDispatcher;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInputAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInputAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInputAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorInputAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -47,11 +47,7 @@
</span><span class="cx"> class InspectorInputAgent : public InspectorAgentBase, public Inspector::InspectorInputBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorInputAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorInputAgent> create(InstrumentingAgents* instrumentingAgents, Page* page)
- {
- return adoptPtr(new InspectorInputAgent(instrumentingAgents, page));
- }
-
</del><ins>+ InspectorInputAgent(InstrumentingAgents*, Page*);
</ins><span class="cx"> ~InspectorInputAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -62,8 +58,6 @@
</span><span class="cx"> virtual void dispatchMouseEvent(ErrorString*, const String& type, int x, int y, const int* modifiers, const double* timestamp, const String* button, const int* clickCount);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorInputAgent(InstrumentingAgents*, Page*);
-
</del><span class="cx"> Page* m_page;
</span><span class="cx"> RefPtr<Inspector::InspectorInputBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorLayerTreeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -49,10 +49,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorLayerTreeAgent : public InspectorAgentBase, public Inspector::InspectorLayerTreeBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorLayerTreeAgent> create(InstrumentingAgents* instrumentingAgents)
- {
- return adoptPtr(new InspectorLayerTreeAgent(instrumentingAgents));
- }
</del><ins>+ explicit InspectorLayerTreeAgent(InstrumentingAgents*);
</ins><span class="cx"> ~InspectorLayerTreeAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -70,8 +67,6 @@
</span><span class="cx"> virtual void reasonsForCompositingLayer(ErrorString*, const String& layerId, RefPtr<Inspector::TypeBuilder::LayerTree::CompositingReasons>&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorLayerTreeAgent(InstrumentingAgents*);
-
</del><span class="cx"> // RenderLayer-related methods.
</span><span class="cx"> String bind(const RenderLayer*);
</span><span class="cx"> void unbind(const RenderLayer*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorMemoryAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -90,11 +90,6 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorMemoryAgent> InspectorMemoryAgent::create(InstrumentingAgents* instrumentingAgents)
-{
- return adoptPtr(new InspectorMemoryAgent(instrumentingAgents));
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(INSPECTOR)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorMemoryAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> class InspectorMemoryAgent : public InspectorAgentBase, public Inspector::InspectorMemoryBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorMemoryAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorMemoryAgent> create(InstrumentingAgents* instrumentingAgents);
</del><ins>+ explicit InspectorMemoryAgent(InstrumentingAgents*);
</ins><span class="cx"> virtual ~InspectorMemoryAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -57,8 +57,6 @@
</span><span class="cx"> virtual void getDOMCounters(ErrorString*, int* documents, int* nodes, int* jsEventListeners);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorMemoryAgent(InstrumentingAgents*);
-
</del><span class="cx"> RefPtr<Inspector::InspectorMemoryBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -225,11 +225,6 @@
</span><span class="cx"> return decodeBuffer(data, size, textEncodingName, result);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorPageAgent> InspectorPageAgent::create(InstrumentingAgents* instrumentingAgents, Page* page, InspectorClient* client, InspectorOverlay* overlay)
-{
- return adoptPtr(new InspectorPageAgent(instrumentingAgents, page, client, overlay));
-}
-
</del><span class="cx"> // static
</span><span class="cx"> void InspectorPageAgent::resourceContent(ErrorString* errorString, Frame* frame, const URL& url, String* result, bool* base64Encoded)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -70,6 +70,8 @@
</span><span class="cx"> class InspectorPageAgent : public InspectorAgentBase, public Inspector::InspectorPageBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorPageAgent);
</span><span class="cx"> public:
</span><ins>+ InspectorPageAgent(InstrumentingAgents*, Page*, InspectorClient*, InspectorOverlay*);
+
</ins><span class="cx"> enum ResourceType {
</span><span class="cx"> DocumentResource,
</span><span class="cx"> StylesheetResource,
</span><span class="lines">@@ -81,8 +83,6 @@
</span><span class="cx"> OtherResource
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassOwnPtr<InspectorPageAgent> create(InstrumentingAgents*, Page*, InspectorClient*, InspectorOverlay*);
-
</del><span class="cx"> static bool cachedResourceContent(CachedResource*, String* result, bool* base64Encoded);
</span><span class="cx"> static bool sharedBufferContent(PassRefPtr<SharedBuffer>, const String& textEncodingName, bool withBase64Encode, String* result);
</span><span class="cx"> static void resourceContent(ErrorString*, Frame*, const URL&, String* result, bool* base64Encoded);
</span><span class="lines">@@ -163,7 +163,6 @@
</span><span class="cx"> static DocumentLoader* assertDocumentLoader(ErrorString*, Frame*);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorPageAgent(InstrumentingAgents*, Page*, InspectorClient*, InspectorOverlay*);
</del><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> void updateTouchEventEmulationInPage(bool);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorProfilerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -89,9 +89,9 @@
</span><span class="cx"> Page* m_inspectedPage;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorProfilerAgent> InspectorProfilerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorConsoleAgent* consoleAgent, Page* inspectedPage, PageInjectedScriptManager* injectedScriptManager)
</del><ins>+std::unique_ptr<InspectorProfilerAgent> InspectorProfilerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorConsoleAgent* consoleAgent, Page* inspectedPage, PageInjectedScriptManager* injectedScriptManager)
</ins><span class="cx"> {
</span><del>- return adoptPtr(new PageProfilerAgent(instrumentingAgents, consoleAgent, inspectedPage, injectedScriptManager));
</del><ins>+ return std::make_unique<PageProfilerAgent>(instrumentingAgents, consoleAgent, inspectedPage, injectedScriptManager);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> class WorkerProfilerAgent : public InspectorProfilerAgent {
</span><span class="lines">@@ -116,9 +116,9 @@
</span><span class="cx"> WorkerGlobalScope* m_workerGlobalScope;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorProfilerAgent> InspectorProfilerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorConsoleAgent* consoleAgent, WorkerGlobalScope* workerGlobalScope, PageInjectedScriptManager* injectedScriptManager)
</del><ins>+std::unique_ptr<InspectorProfilerAgent> InspectorProfilerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorConsoleAgent* consoleAgent, WorkerGlobalScope* workerGlobalScope, PageInjectedScriptManager* injectedScriptManager)
</ins><span class="cx"> {
</span><del>- return adoptPtr(new WorkerProfilerAgent(instrumentingAgents, consoleAgent, workerGlobalScope, injectedScriptManager));
</del><ins>+ return std::make_unique<WorkerProfilerAgent>(instrumentingAgents, consoleAgent, workerGlobalScope, injectedScriptManager);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProfilerAgent::InspectorProfilerAgent(InstrumentingAgents* instrumentingAgents, InspectorConsoleAgent* consoleAgent, PageInjectedScriptManager* injectedScriptManager)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorProfilerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -61,8 +61,8 @@
</span><span class="cx"> class InspectorProfilerAgent : public InspectorAgentBase, public Inspector::InspectorProfilerBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorProfilerAgent); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorProfilerAgent> create(InstrumentingAgents*, InspectorConsoleAgent*, Page*, PageInjectedScriptManager*);
- static PassOwnPtr<InspectorProfilerAgent> create(InstrumentingAgents*, InspectorConsoleAgent*, WorkerGlobalScope*, PageInjectedScriptManager*);
</del><ins>+ static std::unique_ptr<InspectorProfilerAgent> create(InstrumentingAgents*, InspectorConsoleAgent*, Page*, PageInjectedScriptManager*);
+ static std::unique_ptr<InspectorProfilerAgent> create(InstrumentingAgents*, InspectorConsoleAgent*, WorkerGlobalScope*, PageInjectedScriptManager*);
</ins><span class="cx">
</span><span class="cx"> virtual ~InspectorProfilerAgent();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorResourceAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -77,11 +77,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorResourceAgent : public InspectorAgentBase, public Inspector::InspectorNetworkBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorResourceAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorClient* client)
- {
- return adoptPtr(new InspectorResourceAgent(instrumentingAgents, pageAgent, client));
- }
-
</del><ins>+ InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*);
</ins><span class="cx"> ~InspectorResourceAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -143,8 +139,6 @@
</span><span class="cx"> virtual void setCacheDisabled(ErrorString*, bool cacheDisabled);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*);
-
</del><span class="cx"> void enable();
</span><span class="cx">
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -128,11 +128,7 @@
</span><span class="cx"> public:
</span><span class="cx"> enum InspectorType { PageInspector, WorkerInspector };
</span><span class="cx">
</span><del>- static PassOwnPtr<InspectorTimelineAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorMemoryAgent* memoryAgent, InspectorType type, InspectorClient* client)
- {
- return adoptPtr(new InspectorTimelineAgent(instrumentingAgents, pageAgent, memoryAgent, type, client));
- }
-
</del><ins>+ InspectorTimelineAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorMemoryAgent*, InspectorType, InspectorClient*);
</ins><span class="cx"> ~InspectorTimelineAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -232,8 +228,6 @@
</span><span class="cx"> size_t usedHeapSizeAtStart;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- InspectorTimelineAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorMemoryAgent*, InspectorType, InspectorClient*);
-
</del><span class="cx"> void sendEvent(PassRefPtr<Inspector::InspectorObject>);
</span><span class="cx"> void appendRecord(PassRefPtr<Inspector::InspectorObject> data, TimelineRecordType, bool captureCallStack, Frame*);
</span><span class="cx"> void pushCurrentRecord(PassRefPtr<Inspector::InspectorObject>, TimelineRecordType, bool captureCallStack, Frame*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorWorkerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -103,11 +103,6 @@
</span><span class="cx">
</span><span class="cx"> int InspectorWorkerAgent::WorkerFrontendChannel::s_nextId = 1;
</span><span class="cx">
</span><del>-PassOwnPtr<InspectorWorkerAgent> InspectorWorkerAgent::create(InstrumentingAgents* instrumentingAgents)
-{
- return adoptPtr(new InspectorWorkerAgent(instrumentingAgents));
-}
-
</del><span class="cx"> InspectorWorkerAgent::InspectorWorkerAgent(InstrumentingAgents* instrumentingAgents)
</span><span class="cx"> : InspectorAgentBase(ASCIILiteral("Worker"), instrumentingAgents)
</span><span class="cx"> , m_enabled(false)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorWorkerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorWorkerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorWorkerAgent : public InspectorAgentBase, public Inspector::InspectorWorkerBackendDispatcherHandler {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<InspectorWorkerAgent> create(InstrumentingAgents*);
</del><ins>+ explicit InspectorWorkerAgent(InstrumentingAgents*);
</ins><span class="cx"> ~InspectorWorkerAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -71,7 +71,6 @@
</span><span class="cx"> virtual void setAutoconnectToWorkers(ErrorString*, bool value);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorWorkerAgent(InstrumentingAgents*);
</del><span class="cx"> void createWorkerFrontendChannelsForExistingWorkers();
</span><span class="cx"> void createWorkerFrontendChannel(WorkerGlobalScopeProxy*, const String& url);
</span><span class="cx"> void destroyWorkerFrontendChannels();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageConsoleAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -43,16 +43,12 @@
</span><span class="cx"> class PageConsoleAgent : public InspectorConsoleAgent {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<PageConsoleAgent> create(InstrumentingAgents* instrumentingAgents, PageInjectedScriptManager* injectedScriptManager, InspectorDOMAgent* domAgent)
- {
- return adoptPtr(new PageConsoleAgent(instrumentingAgents, injectedScriptManager, domAgent));
- }
</del><ins>+ PageConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*, InspectorDOMAgent*);
</ins><span class="cx"> virtual ~PageConsoleAgent();
</span><span class="cx">
</span><span class="cx"> virtual bool isWorkerAgent() OVERRIDE { return false; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- PageConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*, InspectorDOMAgent*);
</del><span class="cx"> virtual void clearMessages(ErrorString*);
</span><span class="cx"> virtual void addInspectedNode(ErrorString*, int nodeId);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageDebuggerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -48,11 +48,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-PassOwnPtr<PageDebuggerAgent> PageDebuggerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
-{
- return adoptPtr(new PageDebuggerAgent(instrumentingAgents, pageAgent, injectedScriptManager, overlay));
-}
-
</del><span class="cx"> PageDebuggerAgent::PageDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
</span><span class="cx"> : InspectorDebuggerAgent(instrumentingAgents, injectedScriptManager)
</span><span class="cx"> , m_pageAgent(pageAgent)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageDebuggerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageDebuggerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/PageDebuggerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(PageDebuggerAgent);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<PageDebuggerAgent> create(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
</del><ins>+ PageDebuggerAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
</ins><span class="cx"> virtual ~PageDebuggerAgent();
</span><span class="cx">
</span><span class="cx"> void didClearMainFrameWindowObject();
</span><span class="lines">@@ -66,7 +66,6 @@
</span><span class="cx"> virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
</span><span class="cx"> virtual void setOverlayMessage(ErrorString*, const String*);
</span><span class="cx">
</span><del>- PageDebuggerAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
</del><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx"> InspectorOverlay* m_overlay;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageRuntimeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageRuntimeAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageRuntimeAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/PageRuntimeAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -50,11 +50,9 @@
</span><span class="cx">
</span><span class="cx"> class PageRuntimeAgent : public InspectorRuntimeAgent {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<PageRuntimeAgent> create(InstrumentingAgents* instrumentingAgents, Inspector::InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)
- {
- return adoptPtr(new PageRuntimeAgent(instrumentingAgents, injectedScriptManager, page, pageAgent));
- }
</del><ins>+ PageRuntimeAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, Page*, InspectorPageAgent*);
</ins><span class="cx"> virtual ~PageRuntimeAgent();
</span><ins>+
</ins><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() OVERRIDE;
</span><span class="cx"> virtual void enable(ErrorString*);
</span><span class="lines">@@ -64,8 +62,6 @@
</span><span class="cx"> void didCreateIsolatedContext(Frame*, JSC::ExecState*, SecurityOrigin*);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- PageRuntimeAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, Page*, InspectorPageAgent*);
-
</del><span class="cx"> virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
</span><span class="cx"> virtual void muteConsole();
</span><span class="cx"> virtual void unmuteConsole();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerConsoleAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerConsoleAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/WorkerConsoleAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -41,16 +41,12 @@
</span><span class="cx"> class WorkerConsoleAgent : public InspectorConsoleAgent {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(WorkerConsoleAgent);
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<WorkerConsoleAgent> create(InstrumentingAgents* instrumentingAgents, PageInjectedScriptManager* injectedScriptManager)
- {
- return adoptPtr(new WorkerConsoleAgent(instrumentingAgents, injectedScriptManager));
- }
</del><ins>+ WorkerConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*);
</ins><span class="cx"> virtual ~WorkerConsoleAgent();
</span><span class="cx">
</span><span class="cx"> virtual bool isWorkerAgent() OVERRIDE { return true; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- WorkerConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*);
</del><span class="cx"> virtual void addInspectedNode(ErrorString*, int nodeId);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerDebuggerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -84,11 +84,6 @@
</span><span class="cx">
</span><span class="cx"> const char* WorkerDebuggerAgent::debuggerTaskMode = "debugger";
</span><span class="cx">
</span><del>-PassOwnPtr<WorkerDebuggerAgent> WorkerDebuggerAgent::create(InstrumentingAgents* instrumentingAgents, WorkerGlobalScope* inspectedWorkerGlobalScope, InjectedScriptManager* injectedScriptManager)
-{
- return adoptPtr(new WorkerDebuggerAgent(instrumentingAgents, inspectedWorkerGlobalScope, injectedScriptManager));
-}
-
</del><span class="cx"> WorkerDebuggerAgent::WorkerDebuggerAgent(InstrumentingAgents* instrumentingAgents, WorkerGlobalScope* inspectedWorkerGlobalScope, InjectedScriptManager* injectedScriptManager)
</span><span class="cx"> : InspectorDebuggerAgent(instrumentingAgents, injectedScriptManager)
</span><span class="cx"> , m_scriptDebugServer(inspectedWorkerGlobalScope, WorkerDebuggerAgent::debuggerTaskMode)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -44,22 +44,20 @@
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(WorkerDebuggerAgent);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<WorkerDebuggerAgent> create(InstrumentingAgents*, WorkerGlobalScope*, Inspector::InjectedScriptManager*);
</del><ins>+ WorkerDebuggerAgent(InstrumentingAgents*, WorkerGlobalScope*, Inspector::InjectedScriptManager*);
</ins><span class="cx"> virtual ~WorkerDebuggerAgent();
</span><span class="cx">
</span><span class="cx"> static const char* debuggerTaskMode;
</span><span class="cx"> static void interruptAndDispatchInspectorCommands(WorkerThread*);
</span><span class="cx">
</span><del>-private:
- WorkerDebuggerAgent(InstrumentingAgents*, WorkerGlobalScope*, Inspector::InjectedScriptManager*);
</del><ins>+ virtual void startListeningScriptDebugServer() OVERRIDE;
+ virtual void stopListeningScriptDebugServer() OVERRIDE;
+ virtual WorkerScriptDebugServer& scriptDebugServer() OVERRIDE;
+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) OVERRIDE;
+ virtual void muteConsole() OVERRIDE;
+ virtual void unmuteConsole() OVERRIDE;
</ins><span class="cx">
</span><del>- virtual void startListeningScriptDebugServer();
- virtual void stopListeningScriptDebugServer();
- virtual WorkerScriptDebugServer& scriptDebugServer();
- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void muteConsole();
- virtual void unmuteConsole();
-
</del><ins>+private:
</ins><span class="cx"> WorkerScriptDebugServer m_scriptDebugServer;
</span><span class="cx"> WorkerGlobalScope* m_inspectedWorkerGlobalScope;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.cpp (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -85,21 +85,21 @@
</span><span class="cx"> , m_injectedScriptManager(std::make_unique<PageInjectedScriptManager>(*this, PageInjectedScriptHost::create()))
</span><span class="cx"> , m_runtimeAgent(0)
</span><span class="cx"> {
</span><del>- OwnPtr<InspectorRuntimeAgent> runtimeAgent = WorkerRuntimeAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get(), workerGlobalScope);
</del><ins>+ auto runtimeAgent = std::make_unique<WorkerRuntimeAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get(), workerGlobalScope);
</ins><span class="cx"> m_runtimeAgent = runtimeAgent.get();
</span><del>- m_agents.append(runtimeAgent.release());
</del><ins>+ m_agents.append(std::move(runtimeAgent));
</ins><span class="cx">
</span><del>- OwnPtr<InspectorConsoleAgent> consoleAgent = WorkerConsoleAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get());
</del><ins>+ auto consoleAgent = std::make_unique<WorkerConsoleAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get());
</ins><span class="cx"> #if ENABLE(JAVASCRIPT_DEBUGGER)
</span><del>- OwnPtr<InspectorDebuggerAgent> debuggerAgent = WorkerDebuggerAgent::create(m_instrumentingAgents.get(), workerGlobalScope, m_injectedScriptManager.get());
</del><ins>+ auto debuggerAgent = std::make_unique<WorkerDebuggerAgent>(m_instrumentingAgents.get(), workerGlobalScope, m_injectedScriptManager.get());
</ins><span class="cx"> m_runtimeAgent->setScriptDebugServer(&debuggerAgent->scriptDebugServer());
</span><del>- m_agents.append(debuggerAgent.release());
</del><ins>+ m_agents.append(std::move(debuggerAgent));
</ins><span class="cx">
</span><span class="cx"> m_agents.append(InspectorProfilerAgent::create(m_instrumentingAgents.get(), consoleAgent.get(), workerGlobalScope, m_injectedScriptManager.get()));
</span><del>- m_agents.append(InspectorHeapProfilerAgent::create(m_instrumentingAgents.get(), m_injectedScriptManager.get()));
</del><ins>+ m_agents.append(std::make_unique<InspectorHeapProfilerAgent>(m_instrumentingAgents.get(), m_injectedScriptManager.get()));
</ins><span class="cx"> #endif
</span><del>- m_agents.append(InspectorTimelineAgent::create(m_instrumentingAgents.get(), 0, 0, InspectorTimelineAgent::WorkerInspector, 0));
- m_agents.append(consoleAgent.release());
</del><ins>+ m_agents.append(std::make_unique<InspectorTimelineAgent>(m_instrumentingAgents.get(), nullptr, nullptr, InspectorTimelineAgent::WorkerInspector, nullptr));
+ m_agents.append(std::move(consoleAgent));
</ins><span class="cx">
</span><span class="cx"> if (CommandLineAPIHost* commandLineAPIHost = m_injectedScriptManager->commandLineAPIHost()) {
</span><span class="cx"> commandLineAPIHost->init(nullptr
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerRuntimeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h (161783 => 161784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h 2014-01-11 22:56:40 UTC (rev 161783)
+++ trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h 2014-01-12 00:54:27 UTC (rev 161784)
</span><span class="lines">@@ -42,10 +42,7 @@
</span><span class="cx">
</span><span class="cx"> class WorkerRuntimeAgent : public InspectorRuntimeAgent {
</span><span class="cx"> public:
</span><del>- static PassOwnPtr<WorkerRuntimeAgent> create(InstrumentingAgents* instrumentingAgents, Inspector::InjectedScriptManager* injectedScriptManager, WorkerGlobalScope* context)
- {
- return adoptPtr(new WorkerRuntimeAgent(instrumentingAgents, injectedScriptManager, context));
- }
</del><ins>+ WorkerRuntimeAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, WorkerGlobalScope*);
</ins><span class="cx"> virtual ~WorkerRuntimeAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) OVERRIDE;
</span><span class="lines">@@ -59,7 +56,6 @@
</span><span class="cx"> #endif // ENABLE(JAVASCRIPT_DEBUGGER)
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- WorkerRuntimeAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, WorkerGlobalScope*);
</del><span class="cx"> virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
</span><span class="cx"> virtual void muteConsole();
</span><span class="cx"> virtual void unmuteConsole();
</span></span></pre>
</div>
</div>
</body>
</html>