<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161653] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161653">161653</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-10 10:59:28 -0800 (Fri, 10 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/161629">r161629</a>.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762
Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).
Source/WebCore:
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGTests.cpp:
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):
LayoutTests:
* svg/custom/conditional-processing-1-expected.txt: Removed.
* svg/custom/conditional-processing-1.svg: Removed.
* svg/custom/conditional-processing-2-expected.txt: Removed.
* svg/custom/conditional-processing-2.html: Removed.
* svg/dom/SVGTests-expected.txt: Removed.
* svg/dom/SVGTests.html: Removed.
* svg/dom/script-tests/SVGTests.js: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGSwitchElementcpp">trunk/Source/WebCore/svg/SVGSwitchElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTestscpp">trunk/Source/WebCore/svg/SVGTests.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgcustomconditionalprocessing1expectedtxt">trunk/LayoutTests/svg/custom/conditional-processing-1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgcustomconditionalprocessing1svg">trunk/LayoutTests/svg/custom/conditional-processing-1.svg</a></li>
<li><a href="#trunkLayoutTestssvgcustomconditionalprocessing2expectedtxt">trunk/LayoutTests/svg/custom/conditional-processing-2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgcustomconditionalprocessing2html">trunk/LayoutTests/svg/custom/conditional-processing-2.html</a></li>
<li><a href="#trunkLayoutTestssvgdomSVGTestsexpectedtxt">trunk/LayoutTests/svg/dom/SVGTests-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomSVGTestshtml">trunk/LayoutTests/svg/dom/SVGTests.html</a></li>
<li><a href="#trunkLayoutTestssvgdomscripttestsSVGTestsjs">trunk/LayoutTests/svg/dom/script-tests/SVGTests.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/ChangeLog 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-01-10 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r161629.
+ http://trac.webkit.org/changeset/161629
+ https://bugs.webkit.org/show_bug.cgi?id=126762
+
+ Fails svg/custom/conditional-processing-2.html (Requested by
+ ap on #webkit).
+
+ * svg/custom/conditional-processing-1-expected.txt: Removed.
+ * svg/custom/conditional-processing-1.svg: Removed.
+ * svg/custom/conditional-processing-2-expected.txt: Removed.
+ * svg/custom/conditional-processing-2.html: Removed.
+ * svg/dom/SVGTests-expected.txt: Removed.
+ * svg/dom/SVGTests.html: Removed.
+ * svg/dom/script-tests/SVGTests.js: Removed.
+
</ins><span class="cx"> 2014-01-10 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed test correction after r161605.
</span></span></pre></div>
<a id="trunkLayoutTestssvgcustomconditionalprocessing1expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/custom/conditional-processing-1-expected.txt (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/conditional-processing-1-expected.txt 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/custom/conditional-processing-1-expected.txt 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderSVGRoot {svg} at (0,0) size 100x100
- RenderSVGContainer {switch} at (0,0) size 100x100
- RenderSVGRect {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
</del></span></pre></div>
<a id="trunkLayoutTestssvgcustomconditionalprocessing1svg"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/custom/conditional-processing-1.svg (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/conditional-processing-1.svg 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/custom/conditional-processing-1.svg 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,16 +0,0 @@
</span><del>-<?xml version="1.0"?>
-<svg xmlns="http://www.w3.org/2000/svg" width="100%" height="100%">
- <switch>
- <!-- This test passes if a renderer is only created for the first valid SVG child. -->
- <span xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; width: 100px; height: 100px; background: red"/>
- <mspace xmlns="http://www.w3.org/1998/Math/MathML" width="100px" height="100px" mathbackground="red"/>
- <foreignObject requiredExtensions="unknownExtension" height="100" width="100">
- <span xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; width: 100px; height: 100px; background: red"/>
- </foreignObject>
- <rect width="100" height="100" fill="green"/>
- <rect width="100" height="100" fill="red"/>
- <rect width="100" height="100" fill="red"/>
- <rect width="100" height="100" fill="red"/>
- <rect width="100" height="100" fill="red"/>
- </switch>
-</svg>
</del></span></pre></div>
<a id="trunkLayoutTestssvgcustomconditionalprocessing2expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/custom/conditional-processing-2-expected.txt (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/conditional-processing-2-expected.txt 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/custom/conditional-processing-2-expected.txt 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,41 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x160
- RenderBlock {HTML} at (0,0) size 800x160
- RenderBody {BODY} at (8,16) size 784x136
- RenderBlock {P} at (0,0) size 784x17
- RenderText {#text} at (0,0) size 321x17
- text run at (0,0) width 321: "This test passes if four green squares are displayed:"
- RenderBlock (anonymous) at (0,33) size 784x103
- RenderSVGRoot {svg} at (8,49) size 100x100
- RenderSVGContainer {switch} at (8,49) size 100x100
- RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
- RenderBlock {SPAN} at (0,0) size 100x100 [bgcolor=#008000]
- RenderText {#text} at (0,0) size 0x0
- RenderText {#text} at (100,86) size 4x17
- text run at (100,86) width 4: " "
- RenderText {#text} at (0,0) size 0x0
- RenderSVGRoot {svg} at (112,49) size 100x100
- RenderSVGContainer {switch} at (112,49) size 100x100
- RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
- RenderMathMLMath {math} at (0,0) size 102x100 [padding: 0 1 0 1]
- RenderMathMLSpace {mspace} at (1,0) size 100x100 [bgcolor=#008000]
- RenderText {#text} at (0,0) size 0x0
- RenderText {#text} at (204,86) size 4x17
- text run at (204,86) width 4: " "
- RenderText {#text} at (0,0) size 0x0
- RenderSVGRoot {svg} at (216,49) size 100x100
- RenderSVGContainer {switch} at (216,49) size 100x100
- RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
- RenderBlock {SPAN} at (0,0) size 100x100
- RenderMathMLMath {math} at (0,0) size 102x100 [padding: 0 1 0 1]
- RenderMathMLSpace {mspace} at (1,0) size 100x100 [bgcolor=#008000]
- RenderText {#text} at (0,0) size 0x0
- RenderText {#text} at (0,0) size 0x0
- RenderText {#text} at (308,86) size 4x17
- text run at (308,86) width 4: " "
- RenderText {#text} at (0,0) size 0x0
- RenderSVGRoot {svg} at (320,49) size 100x100
- RenderSVGContainer {switch} at (320,49) size 100x100
- RenderSVGRect {rect} at (320,49) size 100x100 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
- RenderText {#text} at (0,0) size 0x0
</del></span></pre></div>
<a id="trunkLayoutTestssvgcustomconditionalprocessing2html"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/custom/conditional-processing-2.html (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/conditional-processing-2.html 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/custom/conditional-processing-2.html 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,60 +0,0 @@
</span><del>-<!doctype html>
-<html>
- <head>
- <title>requiredExtensions</title>
- <meta charset="utf-8"/>
- </head>
- <body>
-
- <!-- The following elements contain foreignObject with a list of required extensions. We should only display it when the list contains MathML or XHTML namespaces. -->
-
- <p>This test passes if four green squares are displayed:</p>
-
- <!-- This tests a required XHTML extension. -->
- <svg width="100px" height="100px">
- <switch>
- <foreignObject requiredExtensions="http://www.w3.org/1999/xhtml" height="100" width="100">
- <span style="display: inline-block; width: 100px; height: 100px; background: green"></span>
- </foreignObject>
- <rect width="100" height="100" fill="red"/>
- </switch>
- </svg>
-
- <!-- This tests a required MathML extension. -->
- <svg width="100px" height="100px">
- <switch>
- <foreignObject requiredExtensions="http://www.w3.org/1998/Math/MathML" height="100" width="100">
- <math>
- <mspace width="100px" height="100px" mathbackground="green"/>
- </math>
- </foreignObject>
- <rect width="100" height="100" fill="red"/>
- </switch>
- </svg>
-
- <!-- This tests required XHTML and MathML extensions. -->
- <svg width="100px" height="100px">
- <switch>
- <foreignObject requiredExtensions="http://www.w3.org/1998/Math/MathML http://www.w3.org/1999/xhtml" height="100" width="100">
- <span style="display: inline-block; width: 100px; height: 100px;">
- <math>
- <mspace width="100px" height="100px" mathbackground="green"/>
- </math>
- </span>
- </foreignObject>
- <rect width="100" height="100" fill="red"/>
- </switch>
- </svg>
-
- <!-- This tests an unknown required extension. -->
- <svg width="100px" height="100px">
- <switch>
- <foreignObject requiredExtensions="http://www.w3.org/1998/Math/MathML http://www.w3.org/1999/xhtml unknownExtension" height="100" width="100">
- <span style="display: inline-block; width: 100px; height: 100px; background: red"></span>
- </foreignObject>
- <rect width="100" height="100" fill="green"/>
- </switch>
- </svg>
-
- </body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGTestsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/dom/SVGTests-expected.txt (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGTests-expected.txt 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/dom/SVGTests-expected.txt 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,22 +0,0 @@
</span><del>-This test checks the SVGTests API
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-Check the requiredFeatures, requiredExtensions and systemLanguage attributes
-PASS foreignObject.requiredFeatures instanceof SVGStringList is true
-PASS foreignObject.requiredExtensions instanceof SVGStringList is true
-PASS foreignObject.systemLanguage instanceof SVGStringList is true
-
-Check the hasExtension function
-PASS foreignObject.hasExtension('http://www.w3.org/1998/Math/MathML') is true
-PASS foreignObject.hasExtension('http://www.w3.org/1999/xhtml') is true
-PASS foreignObject.hasExtension('') is false
-PASS foreignObject.hasExtension('unknownExtension') is false
-PASS foreignObject.hasExtension('HTTP://WWW.W3.ORG/1999/XHTML') is false
-PASS foreignObject.hasExtension('http://www.w3.org/1998/Math/MathML http://www.w3.org/1999/xhtml') is false
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGTestshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/dom/SVGTests.html (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGTests.html 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/dom/SVGTests.html 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,12 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script src="script-tests/SVGTests.js"></script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestssvgdomscripttestsSVGTestsjs"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/dom/script-tests/SVGTests.js (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/script-tests/SVGTests.js 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/LayoutTests/svg/dom/script-tests/SVGTests.js 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,21 +0,0 @@
</span><del>-description("This test checks the SVGTests API");
-
-var svgElement = document.createElementNS("http://www.w3.org/2000/svg", "svg");
-var foreignObject = document.createElementNS("http://www.w3.org/2000/svg", "foreignObject");
-
-debug("");
-debug("Check the requiredFeatures, requiredExtensions and systemLanguage attributes");
-shouldBeTrue("foreignObject.requiredFeatures instanceof SVGStringList");
-shouldBeTrue("foreignObject.requiredExtensions instanceof SVGStringList");
-shouldBeTrue("foreignObject.systemLanguage instanceof SVGStringList");
-
-debug("");
-debug("Check the hasExtension function");
-shouldBeTrue("foreignObject.hasExtension('http://www.w3.org/1998/Math/MathML')");
-shouldBeTrue("foreignObject.hasExtension('http://www.w3.org/1999/xhtml')");
-shouldBeFalse("foreignObject.hasExtension('')");
-shouldBeFalse("foreignObject.hasExtension('unknownExtension')");
-shouldBeFalse("foreignObject.hasExtension('HTTP://WWW.W3.ORG/1999/XHTML')");
-shouldBeFalse("foreignObject.hasExtension('http://www.w3.org/1998/Math/MathML http://www.w3.org/1999/xhtml')");
-
-successfullyParsed = true;
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/Source/WebCore/ChangeLog 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-10 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r161629.
+ http://trac.webkit.org/changeset/161629
+ https://bugs.webkit.org/show_bug.cgi?id=126762
+
+ Fails svg/custom/conditional-processing-2.html (Requested by
+ ap on #webkit).
+
+ * svg/SVGSwitchElement.cpp:
+ (WebCore::SVGSwitchElement::childShouldCreateRenderer):
+ * svg/SVGTests.cpp:
+ (WebCore::SVGTests::hasExtension):
+ (WebCore::SVGTests::isValid):
+
</ins><span class="cx"> 2014-01-10 ChangSeok Oh <changseok.oh@collabora.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix since r161589.
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGSwitchElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSwitchElement.cpp (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGSwitchElement.cpp 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/Source/WebCore/svg/SVGSwitchElement.cpp 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -51,8 +51,8 @@
</span><span class="cx">
</span><span class="cx"> bool SVGSwitchElement::childShouldCreateRenderer(const Node& child) const
</span><span class="cx"> {
</span><del>- // We create a renderer for the first valid SVG element child.
- // FIXME: The renderer must be updated after dynamic change of the requiredFeatures, requiredExtensions and systemLanguage attributes (http://wkb.ug/74749).
</del><ins>+ // FIXME: This function does not do what the comment below implies it does.
+ // It will create a renderer for any valid SVG element children, not just the first one.
</ins><span class="cx"> for (auto& element : childrenOfType<SVGElement>(*this)) {
</span><span class="cx"> if (!element.isValid())
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTestscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTests.cpp (161652 => 161653)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTests.cpp 2014-01-10 18:53:12 UTC (rev 161652)
+++ trunk/Source/WebCore/svg/SVGTests.cpp 2014-01-10 18:59:28 UTC (rev 161653)
</span><span class="lines">@@ -25,11 +25,7 @@
</span><span class="cx">
</span><span class="cx"> #include "Attribute.h"
</span><span class="cx"> #include "DOMImplementation.h"
</span><del>-#include "HTMLNames.h"
</del><span class="cx"> #include "Language.h"
</span><del>-#if ENABLE(MATHML)
-#include "MathMLNames.h"
-#endif
</del><span class="cx"> #include "SVGElement.h"
</span><span class="cx"> #include "SVGNames.h"
</span><span class="cx"> #include "SVGStringList.h"
</span><span class="lines">@@ -99,14 +95,10 @@
</span><span class="cx"> return map;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool SVGTests::hasExtension(const String& extension) const
</del><ins>+bool SVGTests::hasExtension(const String&) const
</ins><span class="cx"> {
</span><del>- // We recognize XHTML and MathML, as implemented in Gecko and suggested in the SVG Tiny recommendation (http://www.w3.org/TR/SVG11/struct.html#RequiredExtensionsAttribute).
-#if ENABLE(MATHML)
- return extension == HTMLNames::xhtmlNamespaceURI || extension == MathMLNames::mathmlNamespaceURI;
-#else
- return extension == HTMLNames::xhtmlNamespaceURI;
-#endif
</del><ins>+ // FIXME: Implement me!
+ return false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool SVGTests::isValid() const
</span><span class="lines">@@ -125,12 +117,8 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- unsigned extensionsSize = m_requiredExtensions.value.size();
- for (unsigned i = 0; i < extensionsSize; ++i) {
- String value = m_requiredExtensions.value.at(i);
- if (!hasExtension(value))
- return false;
- }
</del><ins>+ if (!m_requiredExtensions.value.isEmpty())
+ return false;
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>