<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161722] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161722">161722</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-10 20:06:17 -0800 (Fri, 10 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/161702">r161702</a>.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803
Broke multiple tests (Requested by ap on #webkit).
Source/JavaScriptCore:
* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
* js/script-tests/typedarray-constructors.js: Removed.
* js/typedarray-constructors-expected.txt: Removed.
* js/typedarray-constructors.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGenericTypedArrayViewConstructorInlinesh">trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsscriptteststypedarrayconstructorsjs">trunk/LayoutTests/js/script-tests/typedarray-constructors.js</a></li>
<li><a href="#trunkLayoutTestsjstypedarrayconstructorsexpectedtxt">trunk/LayoutTests/js/typedarray-constructors-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjstypedarrayconstructorshtml">trunk/LayoutTests/js/typedarray-constructors.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/ChangeLog 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-01-10 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r161702.
+ http://trac.webkit.org/changeset/161702
+ https://bugs.webkit.org/show_bug.cgi?id=126803
+
+ Broke multiple tests (Requested by ap on #webkit).
+
+ * js/script-tests/typedarray-constructors.js: Removed.
+ * js/typedarray-constructors-expected.txt: Removed.
+ * js/typedarray-constructors.html: Removed.
+
</ins><span class="cx"> 2014-01-10 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
</span></span></pre></div>
<a id="trunkLayoutTestsjsscriptteststypedarrayconstructorsjs"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/js/script-tests/typedarray-constructors.js (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/typedarray-constructors.js 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/script-tests/typedarray-constructors.js 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -1,35 +0,0 @@
</span><del>-description(
-'This test case tests the various typed array and related constructors. ' +
-'In particular, makes sure that you use the "new" keyword when using the constructors.'
-);
-
-shouldThrow("Int8Array()");
-shouldNotThrow("new Int8Array()");
-
-shouldThrow("Int16Array()");
-shouldNotThrow("new Int16Array()");
-
-shouldThrow("Int32Array()");
-shouldNotThrow("new Int32Array()");
-
-shouldThrow("Uint8Array()");
-shouldNotThrow("new Uint8Array()");
-
-shouldThrow("Uint16Array()");
-shouldNotThrow("new Uint16Array()");
-
-shouldThrow("Uint32Array()");
-shouldNotThrow("new Uint32Array()");
-
-shouldThrow("Uint8ClampedArray()");
-shouldNotThrow("new Uint8ClampedArray()");
-
-shouldThrow("Float32Array()");
-shouldNotThrow("new Float32Array()");
-
-shouldThrow("Float64Array()");
-shouldNotThrow("new Float64Array()");
-
-shouldThrow("DataView(new ArrayBuffer())");
-shouldNotThrow("new DataView(new ArrayBuffer())");
-
</del></span></pre></div>
<a id="trunkLayoutTestsjstypedarrayconstructorsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/js/typedarray-constructors-expected.txt (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/typedarray-constructors-expected.txt 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/typedarray-constructors-expected.txt 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -1,29 +0,0 @@
</span><del>-This test case tests the various typed array and related constructors. In particular, makes sure that you use the "new" keyword when using the constructors.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Int8Array() threw exception TypeError: Function is not a function (evaluating 'Int8Array()').
-PASS new Int8Array() did not throw exception.
-PASS Int16Array() threw exception TypeError: Function is not a function (evaluating 'Int16Array()').
-PASS new Int16Array() did not throw exception.
-PASS Int32Array() threw exception TypeError: Function is not a function (evaluating 'Int32Array()').
-PASS new Int32Array() did not throw exception.
-PASS Uint8Array() threw exception TypeError: Function is not a function (evaluating 'Uint8Array()').
-PASS new Uint8Array() did not throw exception.
-PASS Uint16Array() threw exception TypeError: Function is not a function (evaluating 'Uint16Array()').
-PASS new Uint16Array() did not throw exception.
-PASS Uint32Array() threw exception TypeError: Function is not a function (evaluating 'Uint32Array()').
-PASS new Uint32Array() did not throw exception.
-PASS Uint8ClampedArray() threw exception TypeError: Function is not a function (evaluating 'Uint8ClampedArray()').
-PASS new Uint8ClampedArray() did not throw exception.
-PASS Float32Array() threw exception TypeError: Function is not a function (evaluating 'Float32Array()').
-PASS new Float32Array() did not throw exception.
-PASS Float64Array() threw exception TypeError: Function is not a function (evaluating 'Float64Array()').
-PASS new Float64Array() did not throw exception.
-PASS DataView(new ArrayBuffer()) threw exception TypeError: Function is not a function (evaluating 'DataView(new ArrayBuffer())').
-PASS new DataView(new ArrayBuffer()) did not throw exception.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsjstypedarrayconstructorshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/js/typedarray-constructors.html (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/typedarray-constructors.html 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/LayoutTests/js/typedarray-constructors.html 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="script-tests/typedarray-constructors.js"></script>
-<script src="../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-01-10 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r161702.
+ http://trac.webkit.org/changeset/161702
+ https://bugs.webkit.org/show_bug.cgi?id=126803
+
+ Broke multiple tests (Requested by ap on #webkit).
+
+ * runtime/JSGenericTypedArrayViewConstructorInlines.h:
+ (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
+
</ins><span class="cx"> 2014-01-10 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Clean up architectures in xcconfig files
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGenericTypedArrayViewConstructorInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h (161721 => 161722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h 2014-01-11 04:05:19 UTC (rev 161721)
+++ trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h 2014-01-11 04:06:17 UTC (rev 161722)
</span><span class="lines">@@ -157,7 +157,7 @@
</span><span class="cx"> CallType JSGenericTypedArrayViewConstructor<ViewClass>::getCallData(JSCell*, CallData& callData)
</span><span class="cx"> {
</span><span class="cx"> callData.native.function = constructGenericTypedArrayView<ViewClass>;
</span><del>- return CallTypeNone;
</del><ins>+ return CallTypeHost;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre>
</div>
</div>
</body>
</html>