<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161441] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161441">161441</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-01-07 11:36:11 -0800 (Tue, 07 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126472
Reviewed by Timothy Hatcher.
Added a delay when quickly switching to a different popover, making it easier to
move mouse pointer from active element to its popover without accidentally opening
a different popover.
Used this code to add a delay before creating a popover. This doesn't change UI
behavior, as there was alerady a delay before it became visible, but it avoids
flooding buildbot server with http requests when quickly moving the mouse over
dashboard page.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
Fixed a case where popover could get stuck. If content was updated while fade-out
transition was already in place, the transition was removed for no good reason.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
(.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
popover delay from 1s to 800ms.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesPopovercss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js (161440 => 161441)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js 2014-01-07 19:36:11 UTC (rev 161441)
</span><span class="lines">@@ -208,12 +208,9 @@
</span><span class="cx"> var targetFrame = this._targetFrame;
</span><span class="cx"> var preferredEdges = this._preferredEdges;
</span><span class="cx">
</span><del>- // Ensure our element is on display so that its metrics can be resolved
- // or interrupt any pending transition to remove it from display.
</del><ins>+ // Ensure our element is on display so that its metrics can be resolved.
</ins><span class="cx"> if (this._element.parentNode !== document.body)
</span><span class="cx"> document.body.appendChild(this._element);
</span><del>- else
- this._element.classList.remove(Dashboard.Popover.FadeOutClassName);
</del><span class="cx">
</span><span class="cx"> if (this._contentNeedsUpdate) {
</span><span class="cx"> // Reset CSS properties on element so that the element may be sized to fit its content.
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js (161440 => 161441)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-07 19:36:11 UTC (rev 161441)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> BaseObject.call(this);
</span><span class="cx">
</span><span class="cx"> console.assert(element);
</span><del>- console.assert(presentPopoverCallback && typeof presentPopoverCallback == "function");
</del><ins>+ console.assert(presentPopoverCallback && typeof presentPopoverCallback === "function");
</ins><span class="cx">
</span><span class="cx"> this._element = element;
</span><span class="cx"> this._presentPopover = presentPopoverCallback;
</span><span class="lines">@@ -40,46 +40,116 @@
</span><span class="cx"> element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PopoverTracker._popover = null; // Only one popover may be active at any time.
</del><ins>+// Only one popover may be active at any time. An active popover is not necessarily visible already.
+PopoverTracker._popover = null;
</ins><span class="cx">
</span><ins>+// A candidate timer may be active whether we have an active popover or not.
+PopoverTracker._candidateTracker = null;
+PopoverTracker._candidateTimer = null;
+PopoverTracker.CandidateSwitchDelay = 200;
+
</ins><span class="cx"> BaseObject.addConstructorFunctions(PopoverTracker);
</span><span class="cx">
</span><ins>+PopoverTracker._setCandidatePopoverTracker = function(popoverTracker)
+{
+ console.assert(!popoverTracker || !popoverTracker._active);
+
+ if (PopoverTracker._candidateTracker) {
+ clearTimeout(PopoverTracker._candidateTimer);
+ PopoverTracker._candidateTimer = null;
+ }
+
+ console.assert(!PopoverTracker._candidateTimer);
+
+ PopoverTracker._candidateTracker = popoverTracker;
+
+ if (popoverTracker)
+ PopoverTracker._candidateTimer = setTimeout(PopoverTracker._candidatePopoverTrackerTimerFired, PopoverTracker.CandidateSwitchDelay);
+}
+
+PopoverTracker._candidatePopoverTrackerTimerFired = function()
+{
+ var hadPopover = !!PopoverTracker._popover;
+ if (hadPopover) {
+ console.assert(PopoverTracker._popover.visible);
+ PopoverTracker._popover.dismissImmediately();
+ }
+ console.assert(!PopoverTracker._popover);
+
+ var tracker = PopoverTracker._candidateTracker;
+
+ PopoverTracker._setCandidatePopoverTracker(null);
+ tracker._showPopover();
+
+ if (PopoverTracker._popover && hadPopover)
+ PopoverTracker._popover.makeVisibleImmediately();
+}
+
+PopoverTracker._onblur = function()
+{
+ if (PopoverTracker._popover)
+ PopoverTracker._popover.dismissImmediately();
+
+ PopoverTracker._setCandidatePopoverTracker(null);
+}
+
+window.addEventListener("blur", PopoverTracker._onblur, true);
+
</ins><span class="cx"> PopoverTracker.prototype = {
</span><span class="cx"> constructor: PopoverTracker,
</span><span class="cx"> __proto__: BaseObject.prototype,
</span><span class="cx">
</span><ins>+ _showPopover: function()
+ {
+ var popover = new Dashboard.Popover(this);
+ if (!this._presentPopover(this._element, popover, this._context))
+ return;
+
+ this._active = true;
+ PopoverTracker._popover = popover;
+ popover.element.addEventListener("mouseenter", this._mouseEnteredPopoverOrElement.bind(this), true);
+ popover.element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
+ },
+
</ins><span class="cx"> _mouseEnteredPopoverOrElement: function(event)
</span><span class="cx"> {
</span><span class="cx"> var popover = PopoverTracker._popover;
</span><del>- var popoverWasVisible = popover && popover.visible;
</del><ins>+
</ins><span class="cx"> if (popover) {
</span><span class="cx"> // Abort fade-out when re-entering the same element or an existing popover.
</span><span class="cx"> if ((this._active && this._element.isSelfOrAncestor(event.toElement))
</span><span class="cx"> || popover.element.isSelfOrAncestor(event.toElement)) {
</span><span class="cx"> popover.makeVisibleImmediately();
</span><ins>+ PopoverTracker._setCandidatePopoverTracker(null);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // We entered a different element, dismiss the old popover.
</del><ins>+ // We entered a different element.
+ if (popover.visible) {
+ PopoverTracker._setCandidatePopoverTracker(this);
+ return;
+ }
+
+ // The popover wasn't visible yet, so it was effectively non-existent.
</ins><span class="cx"> popover.dismissImmediately();
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> console.assert(!PopoverTracker._popover);
</span><ins>+ console.assert(!PopoverTracker._candidateTracker);
+ console.assert(!PopoverTracker._candidateTimer);
</ins><span class="cx">
</span><del>- var popover = new Dashboard.Popover(this);
- if (!this._presentPopover(event.target, popover, this._context))
- return;
-
- if (popoverWasVisible)
- popover.makeVisibleImmediately();
-
- this._active = true;
- PopoverTracker._popover = popover;
- popover.element.addEventListener("mouseenter", this._mouseEnteredPopoverOrElement.bind(this), true);
- popover.element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
</del><ins>+ PopoverTracker._setCandidatePopoverTracker(this);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _mouseExitedPopoverOrElement: function(event)
</span><span class="cx"> {
</span><ins>+ if (this === PopoverTracker._candidateTracker) {
+ if (this._element.isSelfOrAncestor(event.toElement))
+ return;
+ PopoverTracker._setCandidatePopoverTracker(null);
+ return;
+ }
+
</ins><span class="cx"> var popover = PopoverTracker._popover;
</span><span class="cx">
</span><span class="cx"> if (!popover)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesPopovercss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css (161440 => 161441)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css 2014-01-07 19:36:11 UTC (rev 161441)
</span><span class="lines">@@ -55,7 +55,9 @@
</span><span class="cx">
</span><span class="cx"> .popover.step-in {
</span><span class="cx"> transition: opacity 0ms;
</span><del>- transition-delay: 1s;
</del><ins>+ /* This is a delay after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */
+ /* It is useful to separate the delays because popover creation can be costly, e.g. it can lazily load data from network during the transition. */
+ transition-delay: 800ms;
</ins><span class="cx"> opacity: 1;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161440 => 161441)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/ChangeLog 2014-01-07 19:36:11 UTC (rev 161441)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2014-01-07 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><ins>+ There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=126472
+
+ Reviewed by Timothy Hatcher.
+
+ Added a delay when quickly switching to a different popover, making it easier to
+ move mouse pointer from active element to its popover without accidentally opening
+ a different popover.
+
+ Used this code to add a delay before creating a popover. This doesn't change UI
+ behavior, as there was alerady a delay before it became visible, but it avoids
+ flooding buildbot server with http requests when quickly moving the mouse over
+ dashboard page.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
+ Fixed a case where popover could get stuck. If content was updated while fade-out
+ transition was already in place, the transition was removed for no good reason.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
+ (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
+ (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
+ popover delay from 1s to 800ms.
+
+2014-01-07 Alexey Proskuryakov <ap@apple.com>
+
</ins><span class="cx"> Improve display of failed builds at build.webkit.org/dashboard
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126542
</span><span class="cx"> <rdar://problem/15753550>
</span></span></pre>
</div>
</div>
</body>
</html>