<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161380] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161380">161380</a></dd>
<dt>Author</dt> <dd>seokju@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-06 15:35:52 -0800 (Mon, 06 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
https://bugs.webkit.org/show_bug.cgi?id=126312
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
It is a dead code as all ports in WebKit don't support it.
And this patch removes all things related to DOM.setFileInputFiles in Frontend.
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/protocol/DOM.json:
Source/WebInspectorUI:
Update InspectorWebBackendCommands.js after removing DOM.setFileInputFiles.
* UserInterface/InspectorWebBackendCommands.js:
LayoutTests:
* inspector-protocol/dom/setFileInputFiles-expected.txt: Removed.
* inspector-protocol/dom/setFileInputFiles.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClienth">trunk/Source/WebCore/inspector/InspectorClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllercpp">trunk/Source/WebCore/inspector/InspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgenth">trunk/Source/WebCore/inspector/InspectorDOMAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolDOMjson">trunk/Source/WebCore/inspector/protocol/DOM.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectorprotocoldomsetFileInputFilesexpectedtxt">trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomsetFileInputFileshtml">trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/LayoutTests/ChangeLog 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126312
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector-protocol/dom/setFileInputFiles-expected.txt: Removed.
+ * inspector-protocol/dom/setFileInputFiles.html: Removed.
+
</ins><span class="cx"> 2014-01-06 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed test update after r161375.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomsetFileInputFilesexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles-expected.txt (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles-expected.txt 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles-expected.txt 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -1,4 +0,0 @@
</span><del>-
-Received error: Cannot set file input files
-Received error: Cannot set file input files
-
</del></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomsetFileInputFileshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles.html (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles.html 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/LayoutTests/inspector-protocol/dom/setFileInputFiles.html 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -1,69 +0,0 @@
</span><del>-<html>
-<head>
-<script type="text/javascript" src="../../http/tests/inspector-protocol/resources/protocol-test.js"></script>
-<script>
-
-function onLoad()
-{
- document.querySelector("input").addEventListener("change", onChange);
-
- function onChange(event)
- {
- var files = event.target.files;
- log("File count: " + files.length);
- for (var i = 0; i < files.length; i++) {
- log("Name: " + files[i].name);
- }
- }
-
- runTest();
-}
-
-function test()
-{
- function abortOnError(message)
- {
- if (message.error) {
- InspectorTest.log(message.error.message);
- InspectorTest.completeTest();
- }
- }
-
- InspectorTest.sendCommand("DOM.getDocument", {}, onGotDocument);
-
- function onGotDocument(message)
- {
- abortOnError(message);
- var node = message.result.root;
- InspectorTest.sendCommand("DOM.querySelectorAll", { "nodeId": node.nodeId, "selector": "input" }, onQuerySelectorAll);
- }
-
- function onQuerySelectorAll(message)
- {
- abortOnError(message);
- var ids = message.result.nodeIds;
- InspectorTest.sendCommand("DOM.setFileInputFiles", { "nodeId": ids[0], "files": ["file1", "file2"] }, onSetFiles);
- InspectorTest.sendCommand("DOM.setFileInputFiles", { "nodeId": ids[1], "files": ["file1", "file2"] }, onBadSetFiles);
- }
-
- function onSetFiles(message)
- {
- if (message.error) {
- InspectorTest.log("Received error: " + message.error.message);
- }
- }
-
- function onBadSetFiles(message)
- {
- InspectorTest.log("Received error: " + message.error.message);
- InspectorTest.completeTest();
- }
-}
-
-</script>
-</head>
-<body onload="onLoad()">
-<input type="file"></input>
-<input type="text"></input>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/ChangeLog 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126312
+
+ Reviewed by Joseph Pecoraro.
+
+ No new tests, No changes in behavior.
+
+ It is a dead code as all ports in WebKit don't support it.
+ And this patch removes all things related to DOM.setFileInputFiles in Frontend.
+
+ * inspector/InspectorClient.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::InspectorDOMAgent):
+ * inspector/InspectorDOMAgent.h:
+ (WebCore::InspectorDOMAgent::create):
+ * inspector/protocol/DOM.json:
+
</ins><span class="cx"> 2014-01-06 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [WebGL] Revise String Concatenation (Follow-up to r161247)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.h (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.h 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -95,8 +95,6 @@
</span><span class="cx">
</span><span class="cx"> virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
</span><span class="cx">
</span><del>- virtual bool canSetFileInputFiles() { return false; }
-
</del><span class="cx"> static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.cpp 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> m_pageAgent = pageAgentPtr.get();
</span><span class="cx"> m_agents.append(pageAgentPtr.release());
</span><span class="cx">
</span><del>- OwnPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get(), inspectorClient));
</del><ins>+ OwnPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create(m_instrumentingAgents.get(), pageAgent, m_injectedScriptManager.get(), m_overlay.get()));
</ins><span class="cx"> m_domAgent = domAgentPtr.get();
</span><span class="cx"> m_agents.append(domAgentPtr.release());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -57,18 +57,14 @@
</span><span class="cx"> #include "EventListener.h"
</span><span class="cx"> #include "EventNames.h"
</span><span class="cx"> #include "EventTarget.h"
</span><del>-#include "File.h"
-#include "FileList.h"
</del><span class="cx"> #include "FrameTree.h"
</span><span class="cx"> #include "HTMLElement.h"
</span><span class="cx"> #include "HTMLFrameOwnerElement.h"
</span><del>-#include "HTMLInputElement.h"
</del><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLTemplateElement.h"
</span><span class="cx"> #include "HitTestResult.h"
</span><span class="cx"> #include "IdentifiersFactory.h"
</span><span class="cx"> #include "InjectedScriptManager.h"
</span><del>-#include "InspectorClient.h"
</del><span class="cx"> #include "InspectorHistory.h"
</span><span class="cx"> #include "InspectorNodeFinder.h"
</span><span class="cx"> #include "InspectorOverlay.h"
</span><span class="lines">@@ -213,12 +209,11 @@
</span><span class="cx"> return "";
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorDOMAgent::InspectorDOMAgent(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, InspectorClient* client)
</del><ins>+InspectorDOMAgent::InspectorDOMAgent(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
</ins><span class="cx"> : InspectorAgentBase(ASCIILiteral("DOM"), instrumentingAgents)
</span><span class="cx"> , m_pageAgent(pageAgent)
</span><span class="cx"> , m_injectedScriptManager(injectedScriptManager)
</span><span class="cx"> , m_overlay(overlay)
</span><del>- , m_client(client)
</del><span class="cx"> , m_domListener(0)
</span><span class="cx"> , m_lastNodeId(1)
</span><span class="cx"> , m_lastBackendNodeId(-1)
</span><span class="lines">@@ -1188,34 +1183,6 @@
</span><span class="cx"> element->focus();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorDOMAgent::setFileInputFiles(ErrorString* errorString, int nodeId, const RefPtr<InspectorArray>& files)
-{
- if (!m_client->canSetFileInputFiles()) {
- *errorString = "Cannot set file input files";
- return;
- }
-
- Node* node = assertNode(errorString, nodeId);
- if (!node)
- return;
- HTMLInputElement* element = node->toInputElement();
- if (!element || !element->isFileUpload()) {
- *errorString = "Node is not a file input element";
- return;
- }
-
- RefPtr<FileList> fileList = FileList::create();
- for (InspectorArray::const_iterator iter = files->begin(); iter != files->end(); ++iter) {
- String path;
- if (!(*iter)->asString(&path)) {
- *errorString = "Files must be strings";
- return;
- }
- fileList->append(File::create(path));
- }
- element->setFiles(fileList);
-}
-
</del><span class="cx"> void InspectorDOMAgent::resolveNode(ErrorString* errorString, int nodeId, const String* const objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result)
</span><span class="cx"> {
</span><span class="cx"> String objectGroupName = objectGroup ? *objectGroup : "";
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -61,7 +61,6 @@
</span><span class="cx"> class Document;
</span><span class="cx"> class Element;
</span><span class="cx"> class Event;
</span><del>-class InspectorClient;
</del><span class="cx"> class InspectorHistory;
</span><span class="cx"> class InspectorOverlay;
</span><span class="cx"> class InspectorPageAgent;
</span><span class="lines">@@ -105,9 +104,9 @@
</span><span class="cx"> virtual void didModifyDOMAttr(Element*) = 0;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassOwnPtr<InspectorDOMAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, InspectorClient* client)
</del><ins>+ static PassOwnPtr<InspectorDOMAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
</ins><span class="cx"> {
</span><del>- return adoptPtr(new InspectorDOMAgent(instrumentingAgents, pageAgent, injectedScriptManager, overlay, client));
</del><ins>+ return adoptPtr(new InspectorDOMAgent(instrumentingAgents, pageAgent, injectedScriptManager, overlay));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static String toErrorString(const ExceptionCode&);
</span><span class="lines">@@ -155,7 +154,6 @@
</span><span class="cx"> virtual void redo(ErrorString*);
</span><span class="cx"> virtual void markUndoableState(ErrorString*);
</span><span class="cx"> virtual void focus(ErrorString*, int nodeId);
</span><del>- virtual void setFileInputFiles(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& files);
</del><span class="cx">
</span><span class="cx"> void getEventListeners(Node*, Vector<EventListenerInfo>& listenersArray, bool includeAncestors);
</span><span class="cx">
</span><span class="lines">@@ -215,7 +213,7 @@
</span><span class="cx"> InspectorPageAgent* pageAgent() { return m_pageAgent; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*, InspectorClient*);
</del><ins>+ InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*);
</ins><span class="cx">
</span><span class="cx"> void setSearchingForNode(ErrorString*, bool enabled, Inspector::InspectorObject* highlightConfig);
</span><span class="cx"> PassOwnPtr<HighlightConfig> highlightConfigFromInspectorObject(ErrorString*, Inspector::InspectorObject* highlightInspectorObject);
</span><span class="lines">@@ -250,7 +248,6 @@
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx"> InjectedScriptManager* m_injectedScriptManager;
</span><span class="cx"> InspectorOverlay* m_overlay;
</span><del>- InspectorClient* m_client;
</del><span class="cx"> std::unique_ptr<Inspector::InspectorDOMFrontendDispatcher> m_frontendDispatcher;
</span><span class="cx"> RefPtr<Inspector::InspectorDOMBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> DOMListener* m_domListener;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolDOMjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/DOM.json (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/DOM.json 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebCore/inspector/protocol/DOM.json 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -377,14 +377,6 @@
</span><span class="cx"> { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to focus." }
</span><span class="cx"> ],
</span><span class="cx"> "description": "Focuses the given element."
</span><del>- },
- {
- "name": "setFileInputFiles",
- "parameters": [
- { "name": "nodeId", "$ref": "NodeId", "description": "Id of the file input node to set files for." },
- { "name": "files", "type": "array", "items": { "type": "string" }, "description": "Array of file paths to set." }
- ],
- "description": "Sets files for the given file input element."
</del><span class="cx"> }
</span><span class="cx"> ],
</span><span class="cx"> "events": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126312
+
+ Reviewed by Joseph Pecoraro.
+
+ Update InspectorWebBackendCommands.js after removing DOM.setFileInputFiles.
+
+ * UserInterface/InspectorWebBackendCommands.js:
+
</ins><span class="cx"> 2013-12-22 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK][CMake] Integrate GResource for inspector files (and others?)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js (161379 => 161380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-06 23:28:15 UTC (rev 161379)
+++ trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-06 23:35:52 UTC (rev 161380)
</span><span class="lines">@@ -126,7 +126,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("DOM.redo", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("DOM.markUndoableState", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("DOM.focus", [{"name": "nodeId", "type": "number", "optional": false}], []);
</span><del>-InspectorBackend.registerCommand("DOM.setFileInputFiles", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "files", "type": "object", "optional": false}], []);
</del><span class="cx">
</span><span class="cx"> // DOMDebugger.
</span><span class="cx"> InspectorBackend.registerEnum("DOMDebugger.DOMBreakpointType", {SubtreeModified: "subtree-modified", AttributeModified: "attribute-modified", NodeRemoved: "node-removed"});
</span></span></pre>
</div>
</div>
</body>
</html>